From nobody Thu Jun 11 00:36:04 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD8D13EDAC5 for ; Fri, 27 Feb 2026 16:27:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772209679; cv=none; b=D7kHMY1/Jv6n7UXIhmJuoTUBlApPY3QYZROgZxk3mu5HmBnJvAY6FAKsU/8nRZ3PdeaqbR+SRgLqE1RnWMDmaGUXCRjNDx7W5PFiEgEYU5e56T2V4/2cDAXxZ3i1L4N9VRIp4D8SnIbJF1Tm3Mr7PUH5y3wBUlTBOe0QRsVmG5o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772209679; c=relaxed/simple; bh=tkupGVLWosd9h5O9WTeJtLj7xFFWbEgR/Q3ECU1nYnQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TbyncWiSED8R870gogqf6j8BcNYHqjaBQqEm4BMBoQiGj9dHVUDmv6RkcnSaZS2eHpTDXAfOgyPvKFjJtMal6xipKOerxHb3zAsAKD50NVaOuG/NNYdG/9sfPhIOqzx05XpNyLsc5b+0Tmr/cFT2ieW9pcOct4dKNcHNd/DP2tU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=p2p.industries; spf=pass smtp.mailfrom=p2p.industries; dkim=pass (2048-bit key) header.d=p2p.industries header.i=@p2p.industries header.b=Xagl5VsF; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=p2p.industries Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=p2p.industries Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=p2p.industries header.i=@p2p.industries header.b="Xagl5VsF" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-483a233819aso22505215e9.3 for ; Fri, 27 Feb 2026 08:27:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=p2p.industries; s=google; t=1772209675; x=1772814475; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aLOUNewpxFrSWUmNtLjrQOnmr3Uj3bvJ8Kyt6EDWtos=; b=Xagl5VsFQxbItkRnLRmXofUJp6a15z4/GMeQRcc5K2aSD7ZuvtoblLpbEE98e4OV3D YbPqf7gdGuo0N2uOcTtq/1zKcxumxG8w7BkctwTcDgGDgmYvaGtu1noNipPWVEAjfojt rORacTAWI3DrF7sGQ/zoAUmIj4WFl4re+6YTi7XXoCNqY9T2mCtD2y2zcASiJEkPRCuq hz4ZDJcAtOe5zU4Fs3VXb9HXcK3gYx49//8KhjkGeXNE6m5Cg92dYxYadPsjgpcR0iyS OqvA8KJxYMBZ1xl/39uAlABE1nXyIC5IIfKALtN2NJjMts3Pyu0Op2taMY+7SZPzhbzT v5TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772209675; x=1772814475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aLOUNewpxFrSWUmNtLjrQOnmr3Uj3bvJ8Kyt6EDWtos=; b=ugBryxyxEqBpOWNCZAHYr5f9m99RSAWfiBIrGA4nA07MKCXkuQ4VWHzDOCWNtXhVi/ RTtDQhoYKnD1Ian8PyIhTLrr16Qw9W48JVCK9ZjefaetXhhSnzUULqXko0lawivte4rE jcnRdse2d+AKQYMgsM8Pw5h/qMrRJDcFl2aHsAsdtr6IteUYJh9JgmpEJ+q13+lLqaV7 R0AopL7oW/LXdL6/HaYmbL/Vo1RztlpP8oUIJDd+AzrKc+lPkcyLRHpupDSVtGY0D1YR e2u5xrf9izlOvTG8egKladJe5GwgCTSXxm0vMYTGy9bj5ZGN07NHjsRNe3dQtpSygrd6 JXxQ== X-Forwarded-Encrypted: i=1; AJvYcCWJjDBTc1c9vFQyLWNruJPrAX8/93l9HvkeZ8U6BJs/GaO8/6ZWdjacQK7Lj8SOXIpUqyX+82XhEbzAoDQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwDLVuWPu9mJYVAZPQSwpEJWeIy/E8WTR+5iLyWmJWqwMODwxJb BG+lWI4ZN26mV136ncjNPaE/+9uaTH3XUZak7Ce5uJdXgHWkGrI+x5jWMnjDKLzuDCc= X-Gm-Gg: ATEYQzxpEYoZY/WlSELDAOZHM2SHXT9KAU+rm8I7VH5kkRt0zuoSGIDgnJS1w0UKmKL ogHI8H74x7LoNvFgX0v65INVkj0QGY3hC11lI+1s6F8rh7i/JvdZueYhtsbNa+pFSY/bz7oMiCX AFI9MV8yXl+MKSgiXAqXx4ExqCKkLAbPUYfIfvxkhwicMrTGQzPUDT2ItnAZFYbwhmsGX1olJIF wSAQ7jbbv1iFy/03Y7xmZBf3ISYxmAZDEbpnN4zpiqO/NnqKB09/YTmTmiyVgUizFSwrChIn+sL IYzn4xE2fr0886WhygmNfTMoHGMc4NWLpwlEDpm1F4xUf/XUH7O5JK15yK3GQ6k/ccw+LvCr0fj vh/uQC9c6mautUoV6ocg4JG0pBRbNE0vT3tg4z7ok4CKfRhEPJkVIUsYDl36Z5cJaO9TJUtWO6p w3LQT9pnoUzAtcPA== X-Received: by 2002:a05:600c:350d:b0:483:a8e9:201b with SMTP id 5b1f17b1804b1-483c9b81265mr61099385e9.0.1772209674956; Fri, 27 Feb 2026 08:27:54 -0800 (PST) Received: from nixos ([2a02:168:646f:0:b9df:9962:a75a:7bad]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfcd0b14sm62116515e9.27.2026.02.27.08.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 08:27:54 -0800 (PST) From: Hannes Furmans X-Google-Original-From: Hannes Furmans To: Jens Axboe Cc: Stefan Metzmacher , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hannes Furmans Subject: [PATCH v2] io_uring/net: don't check MSG_CTRUNC for IORING_OP_RECV Date: Fri, 27 Feb 2026 17:27:30 +0100 Message-ID: <20260227162730.79355-1-hannes@stillwind.ai> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260226220310.758404-1-hannes@stillwind.ai> References: <20260226220310.758404-1-hannes@stillwind.ai> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable IORING_OP_RECV sets up the msghdr with msg_control=3DNULL and msg_controllen=3D0, as it has no cmsg support. Any socket layer that calls put_cmsg() will find no buffer space and set MSG_CTRUNC in msg_flags. This is expected =E2=80=94 the caller didn't ask for control dat= a. However, io_recv checks: if ((flags & MSG_WAITALL) && (msg_flags & (MSG_TRUNC | MSG_CTRUNC))) req_set_fail(req); This sets REQ_F_FAIL on a fully successful recv (ret >=3D min_ret) when MSG_CTRUNC is set, which causes io_disarm_next() to cancel all linked operations with -ECANCELED. The recv CQE shows the full requested byte count, yet linked operations are cancelled. This is triggered by kTLS, which calls put_cmsg(SOL_TLS, TLS_GET_RECORD_TYPE) for every record in tls_record_content_type() (tls_sw.c), but it affects any protocol that delivers cmsg data on the kernel side. The MSG_CTRUNC check was introduced by commit 0031275d119e ("io_uring: call req_set_fail_links() on short send[msg]()/recv[msg]() with MSG_WAITALL") whose commit message states "For IORING_OP_RECVMSG we also check for the MSG_TRUNC and MSG_CTRUNC flags", but the code applied the check to IORING_OP_RECV as well. MSG_CTRUNC is meaningful for IORING_OP_RECVMSG where the user provides a cmsg buffer =E2=80=94 truncation there means lost metadata. It is meaningless for IORING_OP_RECV which never provides a cmsg buffer. Remove MSG_CTRUNC from the io_recv check. The io_recvmsg check is left unchanged as MSG_CTRUNC is meaningful there. Fixes: 0031275d119e ("io_uring: call req_set_fail_links() on short send[msg= ]()/recv[msg]() with MSG_WAITALL") Cc: stable@vger.kernel.org Signed-off-by: Hannes Furmans --- v2: v1 incorrectly guarded req_set_fail() for all done_io > 0 cases. Stefan Metzmacher correctly pointed out that short MSG_WAITALL reads should still sever the link chain. Root-caused via ftrace + msg_flags inspection on a real kTLS connection (TLS 1.3, AES-128-GCM, S3 download): ftrace shows io_uring_fail_link firing immediately after io_uring_complete with result=3D67108864 (full 64MB), from io-wq: iou-wrk-52242 io_uring_complete: req ..., result 67108864 iou-wrk-52242 io_uring_fail_link: opcode RECV, link ... A debug recvmsg on the same kTLS socket shows: recvmsg: ret=3D67108864 msg_flags=3D0x88 (MSG_EOR | MSG_CTRUNC) MSG_CTRUNC is always set because kTLS calls put_cmsg() but IORING_OP_RECV provides no cmsg buffer. io_uring/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/io_uring/net.c b/io_uring/net.c index 8576c6cb2236..8baaf74e8f8d 100644 --- a/io_uring/net.c +++ b/io_uring/net.c @@ -1221,7 +1221,7 @@ int io_recv(struct io_kiocb *req, unsigned int issue_= flags) if (ret =3D=3D -ERESTARTSYS) ret =3D -EINTR; req_set_fail(req); - } else if ((flags & MSG_WAITALL) && (kmsg->msg.msg_flags & (MSG_TRUNC | M= SG_CTRUNC))) { + } else if ((flags & MSG_WAITALL) && (kmsg->msg.msg_flags & MSG_TRUNC)) { out_free: req_set_fail(req); } --=20 2.53.0