From nobody Thu Mar 5 08:10:33 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57A8B41B361 for ; Fri, 27 Feb 2026 15:26:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772206017; cv=none; b=RT6qJSVyIyvCCtHkKA8dLrQpkl5iKxc/Rr10782ou2RbJM8aVGy2DverFGFKEJbArTGCJXY3H0vcA+DbTd+OI1e7A9QkAb1EC1MWCgPbrqoXNTpWMDQWbKLfmngjVhp+L9c/wg40X4TTEr2o95URTIU06F4kIsyE9ConTO3IWWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772206017; c=relaxed/simple; bh=KH38vAbUG91j18z6rOjdMD2fAX3Mmj2nRTot2I1wbL0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lpQIi9jw8KxjH2vH3llJbv2bZDvhw+AcF/JZAKrretN5+X08/OpbV7mbM+qYeDRGpoFDyCsv1Vz4RM73DzMNumpeB/tSehvLW6GvpcVTPgyaksDypiWS3fn7pYiVydYfLjVnJ1WmuoNHnEtLnBzWmjlL8hufVHT7PSLkfMp8elQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZBoadKQC; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZBoadKQC" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c6e1dc5c5edso903731a12.1 for ; Fri, 27 Feb 2026 07:26:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772206016; x=1772810816; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z0tbDXBeKezMjzIv1CEH1zzav2roQ8v1QT6xHrnaf4M=; b=ZBoadKQCHwlbLAEiJjqxPNtgQKLj8iczlHlVZ/Hiadfpe5qW3/VranHjhAW7b+MvSA dHaD0XgIBxekREJqlDmgCws08oh2zala6YmnKs+3pfsC607sBtIskXoXTUenv3b9TrRO WCWSahn2Yenj5GkrUCY62jkk+hU/sUSXEBKufNvfBll5RBMUm4wZPnd5GsBtorO3N4Xl cyCca3Sc79YkRtMCcv63o6epF9VEs/dASl96m+zg7Rn2L/Tp9VZ2qECRis30YBO8tQHA jv4J5YL1oDayDq8izT2M+hYmDN21HrG/3q79P3Qfe+rb7rFu4GSb98wDCtT8fIH2Zgv+ rqZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772206016; x=1772810816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z0tbDXBeKezMjzIv1CEH1zzav2roQ8v1QT6xHrnaf4M=; b=PqIrerD5KhOY9/gRmUVX4TgkY1ylCgzLUFarpApkMVmNoB+n3fdBcfQBQxRXLuK3qF 7HKDOedGZTBWQV+J9S6W0V3khGjLvHSWQvvA4rzeHGctswVep0zneK/NiBseCvMXpurs 3k2hfbEskUiPEcm5Xwmr8v2I7QWRbkJang3MCrxjcLoFnk3ysMdXAWHg63fhnbZlE096 Yz3R6eWnsJTJNPiQr0Apr58ht3qGcKiYye1VyKjti3inG9d86qSX78UITI5UrDAhJ8Zo NZle94FtfDSWwTThozwrSfyszzyaurWUhpsoFT66z1kia6zRh/iN2r4aPU7tXMiqNkFb Iw5g== X-Forwarded-Encrypted: i=1; AJvYcCXex3Lovc8ve+z6emJv/cIdxQK4U5btrJ2Tr8a3YD6qpk2h+qOSjikrymTBb7XbHQmku2gwoHIYuZjHvW8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzex3FRP/JLxmWo4oIktGMpl3jDU3azxFuKGvqPP0ApJsgcsoKc 1QQeU9DIC5GkJHqujhnQmFepVbLtIQ9Fc3tGiHZRnww9PinvqXzWYsq7 X-Gm-Gg: ATEYQzxVri2Jb0duOGuqsnqzQhsAdMd2UGDEESG2ZM5sJndTpZPw6Cqjmnkd6g/d1xY wU3ptVZ8J/FJiMQwH8G0rmmBccAy4tbu2cS752bAe2mVgiPMDSunISW14tF9WxIQCUlGsZPeKNj 40Cye7SBcbqNu93CFWDeVSplm+d1wkL72+UgMgFFo0sWQAc0dZSi1SO2QZJnF2BzMUKBbPl1c4V VmRCWpHnKu1u1yA1zInG1kIi9DSidsPhbUr3GXb9t0iE4NSAxM0++FP8yZjXBOBB7BXwg8pn8Ac xAakYq3S8IydDf/SgW1lH8fv7BsOz/xS8ryeKYrRJUk6Np1fgfACO1r62PeGfMyAsJJ1Ve4kMIB qpmu3RTFfeGUqE98MPoGXLv5yJeatlj8sVJek6UkSdHcBcLEwP7SrW/Vrp7GEFFJBLrGjB7zkIP TMUTion7eMabzaG6EuDLvACKA75ZSuW2wwDuo0a+/trVgIPDiTY1fg+2oNiCa9mxyQvU7m X-Received: by 2002:a17:90b:4b8f:b0:34c:fe57:2793 with SMTP id 98e67ed59e1d1-35965ccf181mr2879013a91.20.1772206015655; Fri, 27 Feb 2026 07:26:55 -0800 (PST) Received: from sean-All-Series.. (1-160-203-78.dynamic-ip.hinet.net. [1.160.203.78]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35900700e69sm9053211a91.0.2026.02.27.07.26.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 07:26:55 -0800 (PST) From: Sean Chang To: Andrew Lunn , nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev, trond.myklebust@hammerspace.com, anna@kernel.org Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v4 1/2] sunrpc: fix unused variable warnings by using no_printk Date: Fri, 27 Feb 2026 23:26:23 +0800 Message-Id: <20260227152624.164964-2-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260227152624.164964-1-seanwascoding@gmail.com> References: <20260227152624.164964-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When CONFIG_SUNRPC_DEBUG is disabled, the dfprintk() macros currently expand to empty do-while loops. This causes variables used solely within these calls to appear unused, triggering -Wunused-variable warnings. Instead of marking every affected variable with __maybe_unused, update the dfprintk and dfprintk_rcu stubs to use no_printk(). This allows the compiler to see the variables and perform type checking without emitting any code, thus silencing the warnings globally for these macros. Suggested-by: Andrew Lunn Signed-off-by: Sean Chang Reviewed-by: Andrew Lunn Reviewed-by: Chuck Lever --- include/linux/sunrpc/debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/sunrpc/debug.h b/include/linux/sunrpc/debug.h index eb4bd62df319..55c54df8bc7d 100644 --- a/include/linux/sunrpc/debug.h +++ b/include/linux/sunrpc/debug.h @@ -52,8 +52,8 @@ do { \ # define RPC_IFDEBUG(x) x #else # define ifdebug(fac) if (0) -# define dfprintk(fac, fmt, ...) do {} while (0) -# define dfprintk_rcu(fac, fmt, ...) do {} while (0) +# define dfprintk(fac, fmt, ...) no_printk(fmt, ##__VA_ARGS__) +# define dfprintk_rcu(fac, fmt, ...) no_printk(fmt, ##__VA_ARGS__) # define RPC_IFDEBUG(x) #endif =20 --=20 2.34.1 From nobody Thu Mar 5 08:10:33 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC92443C056 for ; Fri, 27 Feb 2026 15:27:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772206023; cv=none; b=SJrdRZf5kni8zJb0Mr50Sa7Ncytu3T5rxRQ2dx8EuV++UITw82VA2yGBnAeuqJRMlvzMCxYzxNO/B2qV1Y3Ynf+Iz8Uashqn4xjp8tzq3f49aTPAUeiEDh1RyfoTWH4YMablpVJfocqYe46mewiCG1yL+BuuclvOpQm4BcX8hwY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772206023; c=relaxed/simple; bh=DsCvTnRonbBjO2JlO28mIxQ6YAbIlpWMICrRxDHCp3I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=u54nH7qYGqnAcwss02JiVUAMk9AJGthpkx0mK9Die4HlVWJ1j+X5uhMYJgVmUM2IzBeIvJ/tQZaTZqM81EAEzkjc6/d3+xVtwAnbQmux9HrW8tLCogVGc0VICHZvgOQB/Ok0c/aT4nz1+WsXnT7uybpJc2/Zwd7FHk9Yl6x00H0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iEwLk5w+; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iEwLk5w+" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-82746ed8cdcso1038162b3a.3 for ; Fri, 27 Feb 2026 07:27:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772206020; x=1772810820; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rX9CCCw8zu4UXrbXJRhFhr2cp9sA+7MdybCVq3xcDCE=; b=iEwLk5w+Kf3q5yOK6GSPqVYzOPjfJrhuLsFuv4x+oEbMbDj/kQd72GoJS2yLzpy+ai SBLsrY7CkHs8AAZwSX0dT5VgVNGMvGGualCq+wcHNoJqM9hQ9fGXp5or+1nixgq/8PVu 2R6EAixSFyqh6ih6/jcDaqoqdDNaY7Zr6D8zY9+jaAu8fqHAMrt3AkPxEEYoVhCIcLmf dPNIIlqhRJFNp7jlhHdd03491thNzNlFNhtYYK7BdLnxW49w1PnhW75/UACsnJbXjY6r +/YYoSmXhNMBbH8OMOe4Kt4hIrotYrwffgtMDo3EpOfRnxKphNa+DvKZdk84oFQGW0GZ ElOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772206020; x=1772810820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rX9CCCw8zu4UXrbXJRhFhr2cp9sA+7MdybCVq3xcDCE=; b=BGtnPhCDQ+z/Cv9Wm05qj8GwaSum0hFWSYP02Zrel5pfwGDbN+G3Ob7bfzTB5vCdcl V8RmnAIWoHFOpRIjhptL3C9XsP4Lr7tdwM34cZip7RMYIr65jTTMXIZOdh+pH0hRsIYp 12ujQmAlhgSEa9em7w6wTUMW5xpwVdW9Ceang9aAyFhELUAASTQCardf0xBMZK2qhBIq ErNv9XBo6P4QY8P7ICVnjKQmlG/I79A5yd+ZQpt6NRvlVahwZaIXMZss4VMkv42caUkm KZzHU/1lj5mF2SyJWopUT8B+UXUvPwS7sINhto0BVA8MUhPUXqal6OIhKNtuk0o44k6j ndDQ== X-Forwarded-Encrypted: i=1; AJvYcCXB5hTNvCpWqq9Oc7qMh1hmpdP/gTeZuBvz/UPUKKFWdISEelLpvpSr5BtM/BRkjYZq7HgzqpHWm5B9cp8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2k4cfZj0wDlR9vl3VTWFnKSkwYicECTRHGdsvka1Kdo8iPc0I Csmjj1dHCKTnDDpW0QQKJFrU5OO19uqZUEIHC/2qSUgb5PDStSvWVHxf X-Gm-Gg: ATEYQzwwyKxhKpM9KR18fSiblnTFIHND3YkUzfYqFIDxvtvicjNi0URaGdGm7sLQZFn TPiv0zKjsLeGy8W+KnsiiPr9xYDqYI0/ftepuaoWQVUu1WVMLo30q0fD3fk4P+8nLuTyEEpX6Jd Va8nzcMc3wFsnP0/ntdm2UY7MMZjFmgTBkTC9veWEbsWT5i7txjB04OUTi8uqn+h/p6UsozUWG1 ObKzBDPZA4oCvFkB2umOtu/8hhf+3qOVWCJwNotjvpAt/7kP3t6lIVEgNdTLZ20QEbY2eiDlO05 PtezvZnWFMdQUfHVUAyrUT5ElVwjkW6tl9uLQF3i/AICEfMpYruf0ifj/XiKs7wepKr/We/W/Ie IfLNj4vi54QWdHlvqT304ksCK4CO4/+ljlJtHGajVMvjQ1M6w/eNgDkCzN2MbFwOIOMEC3r+r+2 XegB3j7Sg93dI1sPQ+nhqSBnOg3lMOXMlFsPPF5UnHLGiuSZDtmvqP8XAtmCKVuQ9yHMGaxksZR 3ECuvc= X-Received: by 2002:a17:90b:1ccc:b0:340:b912:536 with SMTP id 98e67ed59e1d1-35965cec355mr2681607a91.31.1772206020190; Fri, 27 Feb 2026 07:27:00 -0800 (PST) Received: from sean-All-Series.. (1-160-203-78.dynamic-ip.hinet.net. [1.160.203.78]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35900700e69sm9053211a91.0.2026.02.27.07.26.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 07:26:59 -0800 (PST) From: Sean Chang To: Andrew Lunn , nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev, trond.myklebust@hammerspace.com, anna@kernel.org Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v4 2/2] net: macb: use ethtool_sprintf to fill ethtool stats strings Date: Fri, 27 Feb 2026 23:26:24 +0800 Message-Id: <20260227152624.164964-3-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260227152624.164964-1-seanwascoding@gmail.com> References: <20260227152624.164964-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The RISC-V toolchain triggers a stringop-truncation warning when using snprintf() with a fixed ETH_GSTRING_LEN (32 bytes) buffer. Convert the driver to use the modern ethtool_sprintf() API from linux/ethtool.h. This removes the need for manual snprintf() and memcpy() calls, handles the 32-byte padding automatically, and simplifies the logic by removing manual pointer arithmetic. Suggested-by: Andrew Lunn Reviewed-by: Andrew Lunn Signed-off-by: Sean Chang --- drivers/net/ethernet/cadence/macb_main.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/etherne= t/cadence/macb_main.c index 5bc35f651ebd..79ca19097b2d 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -3145,7 +3145,6 @@ static int gem_get_sset_count(struct net_device *dev,= int sset) =20 static void gem_get_ethtool_strings(struct net_device *dev, u32 sset, u8 *= p) { - char stat_string[ETH_GSTRING_LEN]; struct macb *bp =3D netdev_priv(dev); struct macb_queue *queue; unsigned int i; @@ -3158,10 +3157,8 @@ static void gem_get_ethtool_strings(struct net_devic= e *dev, u32 sset, u8 *p) ETH_GSTRING_LEN); =20 for (q =3D 0, queue =3D bp->queues; q < bp->num_queues; ++q, ++queue) { - for (i =3D 0; i < QUEUE_STATS_LEN; i++, p +=3D ETH_GSTRING_LEN) { - snprintf(stat_string, ETH_GSTRING_LEN, "q%d_%s", - q, queue_statistics[i].stat_string); - memcpy(p, stat_string, ETH_GSTRING_LEN); + for (i =3D 0; i < QUEUE_STATS_LEN; i++) { + ethtool_sprintf(&p, "q%u_%s", q, queue_statistics[i].stat_string); } } break; --=20 2.34.1