From nobody Tue Apr 7 18:45:33 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 125B63F0767 for ; Fri, 27 Feb 2026 15:07:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772204875; cv=none; b=iAFwPCRzLAEl2paXJ/QcX0+PmSgav+941noEgiWrrZFsx/d+HJa205RBxKFrmPhrVvnoTayP+obg/SLg8Rfq1IFr2987r49odpVNbkJGNXKuWBPCJoZ4ekRuQs9sHMGM/2ck2/xezcGUcCdxFjAcxMGDRKSz/ilD+A0mFERHoyA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772204875; c=relaxed/simple; bh=n5by/7VydHZBlyVXmejs+RldCK/liqhGy2KeoVOUm+E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EVSqniYHXcGqRhc7QWpRKq6kJy8duQcjp+HDxW2MVW0JK9L+i5Hy0kijwY3dBSlPetwDALsO4EMJacMUqkDb7CnaaBGRahbOT7rouSzZNazlg5P+mD2a85K2Z8Ob+SH27quTGRc++IZOVgdCuwvIQZZL6rrxiFrdeS2tTjFXRz0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SbIeZiKU; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SbIeZiKU" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-8274843810cso898537b3a.3 for ; Fri, 27 Feb 2026 07:07:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772204872; x=1772809672; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6LDCMDc2QskBV2WyhBMjp2GzitMWV4MKLPEd5YXyGQM=; b=SbIeZiKUsa7IiJt9C4qy+BqadZocb7b74pTNOyuUPrwhcKoB+W+tJ5UWraLjJIRgQL ysfU5fTQ2LMEAtqmhwX1eQW3YzTFYG7AyfjNHQQ/19+0LVNfHaOfclnDgzMXaLyfeHzW EbyDE3qJPQ+1/4oNe04ltuwlIpn3Ptpk8eGUa/GKFOXSiHCRZkddjuUobmDMOb2HBrKq NcYnY5XaGU3Fd0Y82SqW1VfTHCx7xHJZVNpcc/u7eMtMQ1aex4BDD07OFVdRRZmDa3kC rGjR69rxM/ZqxX5m/2E+2A9HIJbrGSQY/gsw1WAaNDMhUTs37GO5hFtJEIKWJu7MAZt8 520g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772204872; x=1772809672; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6LDCMDc2QskBV2WyhBMjp2GzitMWV4MKLPEd5YXyGQM=; b=DRK/YZ92XV8bQt2eMokNmEhtb2lJCF43kEBnwrHdDR1yEBU4BN0r5grZL0a2CzjfRJ lsPDAtBVl0u+iQUAsSvVun0hIDHBToewQfZj26L6Vcm3F0MvxPBm/JMMvI0RkdY9lUIO cdErB4b8iLHjOiusf2RsdeYzYwxXrvbmQabyQKU7RfkSSwaW5Rz+RaKd4iZHe3qbVfUl ROosZ3s1d/2ZlkwDJCHRUtkdslZe/zlNLfLpFcOPST1iA/iGJbzJ11UU+0YvxIgHp73s amrzZ/k2rJ26FBEoWWtDSmuXrmYFUheo3NmiVA7IFKBbK5/FYtTxQlYc2xoQQT6e9AIv Rbpw== X-Forwarded-Encrypted: i=1; AJvYcCXXYrXgz6CSDFAJH0f1EjooAoHb2ib87tS9fBHfzbniTxhlfbuhxnrnS7+EhYSB7l1nYwuWK4ejKaPpbVc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxqvah4usDp2AU9L7xx1a5ESpYc9qnOOlwowY/YLj7DEwYQ8Gfv /WwyiKHb5Lz7YFIkkkYVtDz7LhzHydqvWAJ+avLd1uIgjE/z7EPpAYT8 X-Gm-Gg: ATEYQzzFwKT1ztXzTqgWitkbXPMl7Vh0/4HFaFWmRoWPKo5X1fS30NBv1iqYisSTq1W dI6cl1VbKIkfwK5f7eZMgLkY/tIAWEPLiBNSZO78Ck8g0ZEIq5Hl/9TnLb3li/gP9qi6fLGPNAR G+JwPNDArycdhAR5BmfsnDBMPYCSt1fcKsrK41Lbz8iOzIg25CSSWqGR1vUcf9U2k6WV//1ZO2X i2dDSgCUzRKL0gsAlPFHt2v6Q1Y70orl1z96tIDk9bxuD1ZAykb9i3Xr5bTtov+7bX+/uJX+btl Fwa4jmO5oIkkUUTFuRdFUF2QftI/DlbyN4byWhfhRFXlfSyOY9BVzLX7N3mxfsb42VdlAse4WOT K2LME6s8VryAejxGt5usZOeWHJ/ni23UZQ38TL2+ERFfYOsi6ciM69jyKd2kQvmF5PlSHaiRB26 KWax7VQAW9XO3fEenQw/ybbZG/EJE60YU7cA== X-Received: by 2002:a05:6a21:4d89:b0:35e:c55b:9203 with SMTP id adf61e73a8af0-395c3ac9858mr3240110637.33.1772204872340; Fri, 27 Feb 2026 07:07:52 -0800 (PST) Received: from Alone ([2404:7c00:52:ab73:3d93:3341:c649:9374]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70fa806295sm4997307a12.16.2026.02.27.07.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 07:07:51 -0800 (PST) From: Alone Dangal To: axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Alone Dangal Subject: [PATCH] block: cleanup various NULL pointer comparisons Date: Fri, 27 Feb 2026 20:51:41 +0545 Message-ID: <20260227150641.28735-1-yogeshdangal66@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove open-coded NULL comparisons to follow kernel coding style guidelines. While at it, remove a trailing whitespace in blk-core.c. Signed-off-by: Alone Dangal --- block/badblocks.c | 2 +- block/bio.c | 2 +- block/blk-core.c | 4 ++-- block/blk-iolatency.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block/badblocks.c b/block/badblocks.c index ece64e76f..d409e6b6e 100644 --- a/block/badblocks.c +++ b/block/badblocks.c @@ -1374,7 +1374,7 @@ EXPORT_SYMBOL_GPL(badblocks_clear); */ void ack_all_badblocks(struct badblocks *bb) { - if (bb->page =3D=3D NULL || bb->changed) + if (!bb->page || bb->changed) /* no point even trying */ return; write_seqlock_irq(&bb->lock); diff --git a/block/bio.c b/block/bio.c index d80d5d268..e15f30a5c 100644 --- a/block/bio.c +++ b/block/bio.c @@ -762,7 +762,7 @@ static int __bio_alloc_cache_prune(struct bio_alloc_cac= he *cache, unsigned int i =3D 0; struct bio *bio; =20 - while ((bio =3D cache->free_list) !=3D NULL) { + while ((bio =3D cache->free_list)) { cache->free_list =3D bio->bi_next; cache->nr--; bio_free(bio); diff --git a/block/blk-core.c b/block/blk-core.c index 474700ffa..ae075a95b 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -635,7 +635,7 @@ static void __submit_bio(struct bio *bio) blk_mq_submit_bio(bio); } else if (likely(bio_queue_enter(bio) =3D=3D 0)) { struct gendisk *disk =3D bio->bi_bdev->bd_disk; -=09 + if ((bio->bi_opf & REQ_POLLED) && !(disk->queue->limits.features & BLK_FEAT_POLL)) { bio->bi_status =3D BLK_STS_NOTSUPP; @@ -695,7 +695,7 @@ static void __submit_bio_noacct(struct bio *bio) */ bio_list_init(&lower); bio_list_init(&same); - while ((bio =3D bio_list_pop(&bio_list_on_stack[0])) !=3D NULL) + while ((bio =3D bio_list_pop(&bio_list_on_stack[0]))) if (q =3D=3D bdev_get_queue(bio->bi_bdev)) bio_list_add(&same, bio); else diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c index 53e8dd2df..dbd951e8c 100644 --- a/block/blk-iolatency.c +++ b/block/blk-iolatency.c @@ -689,7 +689,7 @@ static void blkiolatency_timer_fn(struct timer_list *t) * We scaled down but don't have a scale_grp, scale up and carry * on. */ - if (lat_info->scale_grp =3D=3D NULL) { + if (!lat_info->scale_grp) { scale_cookie_change(iolat->blkiolat, lat_info, true); goto next_lock; } --=20 2.53.0