From nobody Tue Apr 7 20:28:49 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A316330334; Fri, 27 Feb 2026 13:41:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772199673; cv=none; b=sIsYv/I4GsfaNpJRODIeQ49UpxzouQ3Bs5ainrvK7cutf/KgyP8byVwLCmm3k2qLaT1Rp/TUoNEdL7qqUdUxBGqbMe4idrWlnVtvO2vY4uD0zuowW4xJHv69WDPQe2qtzPSci69sn9o5ccsoqLQweeek5IqvLBep7J58xQUCD/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772199673; c=relaxed/simple; bh=I8IxnmVCk+FGLLSievLa0IM2y7OaqIwWWg+UEICANBY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NqN2zKMWvKRp61D9sQp6oxXeIz4OiA64Al2MI17Kik5kKhIBLOtabSuEBy7p4pIdvNZ6M7dALWlt0GX5HQoug7f225kPF2DO/3BuPnBRZWY4jJqs2+1feUnKrDOKN75mNs3L5Wfmi2nVSqZmTn06staXFrvhwdTdnJ65USCxg3Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZJS/Zk2v; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZJS/Zk2v" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772199672; x=1803735672; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=I8IxnmVCk+FGLLSievLa0IM2y7OaqIwWWg+UEICANBY=; b=ZJS/Zk2vN78iZo5WRASU+mLsigkUdNPAFWEcbkgtwdb30FUW9bz9YbFJ JsR2Di1m6fDY3Wrd+J+bfjk5RmBzHXdf+2Rs2RCCBiHRJs8upQNhQeSif iJLu5mj6Pp1QRu9EO7EwgtMiZCi0dHSw8h61fxOqZQo+Nt0KWMSUH/m1Y 9WuwKUQmeQEt5nh1d2zZS2QUmbBefY0tCRHJbte5O71IFJSEBV55spnTt 0vSvwajSj02KO5NOE1gMEX5xZVM/ktjCM2mzXOXR+8kjOMp+KYARrANZG 9x02Z+0mVNrbCsQ38OB7upV7GeCPr4UEkdZ7dSR7HoLX6MB0LpQKIDOss Q==; X-CSE-ConnectionGUID: N74t7QPURZq+qXJ7zqg4PA== X-CSE-MsgGUID: pIgNvQYSSOeUO/xje3qO4g== X-IronPort-AV: E=McAfee;i="6800,10657,11714"; a="77121497" X-IronPort-AV: E=Sophos;i="6.21,314,1763452800"; d="scan'208";a="77121497" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2026 05:41:12 -0800 X-CSE-ConnectionGUID: Posd17YRR9OBT1D9uWs/ew== X-CSE-MsgGUID: o1Aklm2ZT3ShOFCFO+wZtQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,314,1763452800"; d="scan'208";a="244281875" Received: from intel-nuc8i7beh.iind.intel.com ([10.223.163.35]) by fmviesa001.fm.intel.com with ESMTP; 27 Feb 2026 05:41:10 -0800 From: Arun T To: arun.t@intel.com Cc: mehdi.djait@linux.intel.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] media: i2c: ov13b10: Support tps68470 regulator and gpio Date: Fri, 27 Feb 2026 19:05:42 +0530 Message-ID: <20260227133542.970820-3-arun.t@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260227133542.970820-1-arun.t@intel.com> References: <20260130092431.2335363-2-arun.t@intel.com> <20260227133542.970820-1-arun.t@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Ov13b10 sensor get clock and regulator from TPS68470 PMIC. Added tps68470 regulator/gpio names in power_on Signed-off-by: Arun T --- drivers/media/i2c/ov13b10.c | 47 ++++++++++++++++++++----------------- 1 file changed, 26 insertions(+), 21 deletions(-) diff --git a/drivers/media/i2c/ov13b10.c b/drivers/media/i2c/ov13b10.c index 5421874732bc..228ffe5ada70 100644 --- a/drivers/media/i2c/ov13b10.c +++ b/drivers/media/i2c/ov13b10.c @@ -11,6 +11,7 @@ #include #include #include +#include =20 #define OV13B10_REG_VALUE_08BIT 1 #define OV13B10_REG_VALUE_16BIT 2 @@ -699,6 +700,13 @@ static const struct ov13b10_mode supported_2_lanes_mod= es[] =3D { }, }; =20 +static const char * const ov13b10_supply_names[] =3D { + "dovdd", /* Digital I/O power */ + "avdd", /* Analog power */ + "dvdd", /* Digital core power */ +}; + + struct ov13b10 { struct device *dev; =20 @@ -708,7 +716,7 @@ struct ov13b10 { struct v4l2_ctrl_handler ctrl_handler; =20 struct clk *img_clk; - struct regulator *avdd; + struct regulator_bulk_data supplies[ARRAY_SIZE(ov13b10_supply_names)]; struct gpio_desc *reset; =20 /* V4L2 Controls */ @@ -1194,9 +1202,8 @@ static int ov13b10_power_off(struct device *dev) struct ov13b10 *ov13b10 =3D to_ov13b10(sd); =20 gpiod_set_value_cansleep(ov13b10->reset, 1); - - if (ov13b10->avdd) - regulator_disable(ov13b10->avdd); + regulator_bulk_disable(ARRAY_SIZE(ov13b10_supply_names), + ov13b10->supplies); =20 clk_disable_unprepare(ov13b10->img_clk); =20 @@ -1214,14 +1221,12 @@ static int ov13b10_power_on(struct device *dev) dev_err(dev, "failed to enable imaging clock: %d", ret); return ret; } - - if (ov13b10->avdd) { - ret =3D regulator_enable(ov13b10->avdd); - if (ret < 0) { - dev_err(dev, "failed to enable avdd: %d", ret); - clk_disable_unprepare(ov13b10->img_clk); - return ret; - } + ret =3D regulator_bulk_enable(ARRAY_SIZE(ov13b10_supply_names), + ov13b10->supplies); + if (ret < 0) { + dev_err(dev, "failed to enable regulators\n"); + clk_disable_unprepare(ov13b10->img_clk); + return ret; } =20 gpiod_set_value_cansleep(ov13b10->reset, 0); @@ -1473,7 +1478,7 @@ static void ov13b10_free_controls(struct ov13b10 *ov1= 3b) static int ov13b10_get_pm_resources(struct ov13b10 *ov13b) { unsigned long freq; - int ret; + int ret, i; =20 ov13b->reset =3D devm_gpiod_get_optional(ov13b->dev, "reset", GPIOD_OUT_L= OW); if (IS_ERR(ov13b->reset)) @@ -1481,6 +1486,7 @@ static int ov13b10_get_pm_resources(struct ov13b10 *o= v13b) "failed to get reset gpio\n"); =20 ov13b->img_clk =3D devm_v4l2_sensor_clk_get(ov13b->dev, NULL); + if (IS_ERR(ov13b->img_clk)) return dev_err_probe(ov13b->dev, PTR_ERR(ov13b->img_clk), "failed to get imaging clock\n"); @@ -1491,15 +1497,14 @@ static int ov13b10_get_pm_resources(struct ov13b10 = *ov13b) "external clock %lu is not supported\n", freq); =20 - ov13b->avdd =3D devm_regulator_get_optional(ov13b->dev, "avdd"); - if (IS_ERR(ov13b->avdd)) { - ret =3D PTR_ERR(ov13b->avdd); - ov13b->avdd =3D NULL; - if (ret !=3D -ENODEV) - return dev_err_probe(ov13b->dev, ret, - "failed to get avdd regulator\n"); - } + for (i =3D 0; i < ARRAY_SIZE(ov13b10_supply_names); i++) + ov13b->supplies[i].supply =3D ov13b10_supply_names[i]; =20 + ret =3D devm_regulator_bulk_get(ov13b->dev, ARRAY_SIZE(ov13b10_supply_nam= es), + ov13b->supplies); + if (ret) + return dev_err_probe(ov13b->dev, ret, + "failed to get regulators\n"); return 0; } =20 --=20 2.43.0