From nobody Tue Apr 7 18:46:40 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 018E732AADC for ; Fri, 27 Feb 2026 12:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772195116; cv=none; b=svsDDDPU1Fo0QVnGbwrkUbukMs705wjeUJ1C5UqUnsSs3D4a6AVKnj1d0qsqQEWCtCmpCAMUxNJzuAKGM+y7kR0D+Ces87T3Z4ywHm23pSJIv+KcjMrESc+iXUbYHGm91E6wtc8wupgeo7K9U0nfa4y1dAUot+DJbeBhab8HsyA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772195116; c=relaxed/simple; bh=P+qkb+46r1pOhfXqbnnaPkQ6Y0J/SoJAGu2MyiHuEv0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gyJ2V0I//lp3DeE0JcmJeMHFZdBAraJYrR3N0xqqo/etNd9sjrAxoFQ1P+3z3DXHV17Vj/jmkTSBLPMjFh7qTT6bzhdv64JKSZH1ujDayhihhPVOSgHQS23lCxJx/ehEKpiEqcsFk67IaHi4DZcLWrWCOD9eQGlyVz/80MIHJP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=thingy.jp; spf=pass smtp.mailfrom=0x0f.com; dkim=pass (1024-bit key) header.d=thingy.jp header.i=@thingy.jp header.b=fAXeXlni; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=thingy.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=0x0f.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=thingy.jp header.i=@thingy.jp header.b="fAXeXlni" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c06cb8004e8so782773a12.0 for ; Fri, 27 Feb 2026 04:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thingy.jp; s=google; t=1772195112; x=1772799912; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4DTCycSkXD9AMNo6HpXSEpzM+j7SRgkLeP93XH/2s3c=; b=fAXeXlni5g8rv+SeT8kVGc6LC9C3tGPG9A5kSHq6bQBmwQKIJJ2UwpRkaijV/rtHpq 3KBvC4in5BzjGeQJLa93lm6R8f/kQAiR71kwzTCxBnNtdpTdjaZR0DCE8/6mELSdvEru wLRBY64VtVlNzXIEi1m+p+IE6P06kZI2apWJ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772195112; x=1772799912; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4DTCycSkXD9AMNo6HpXSEpzM+j7SRgkLeP93XH/2s3c=; b=DdXbGMQTEBxqhgS8vETM+H4uid1tYFE9a73CxHJRuvYodJ6ZNMqxDhMoIeDawYcw+R jMcIIh8A+fY0aBxid/TWfsY+Fg+YppVa+Nc1r0fXbQb+pTPEX9OBsDfJHnYK5K+9CjV0 pUVeeCrbUzj/ovExwCVNRy4CRn77IUkBTi6udyl/Nd8i3R/lkIdo3m8d9aDka3j97Q/y suoFnO+vIvcUWgHD8EUTF98tskUDz2a+UPzA9w58ihNkGK8DzP6NRs5k6NEaZaGKuBQy iw1Zi20P0vBGXLVJwIFu+LYtPeTeSOeafOPK3JTYJdBfaueqMbYXTv99K0RPiZ8qfscx HE5g== X-Forwarded-Encrypted: i=1; AJvYcCWIp1lLOy4VB4dXws63lZ1/ZMs7QIwkM3rWaI75Vxd1nHl/GfmDq/3SbtE1LjVycKn1gzl0CKWUneEEfC8=@vger.kernel.org X-Gm-Message-State: AOJu0YxHVqzw2CUJE5Qxx2hB/qThJxNDoiuhWGM9HxeVzxQhrqlRtDQc mE+y+F2sd6UiIiyibHM0Ev/UQmIeHjqZurLjn+Aeegy/W1WDnE0zmfSYeCogLWDyECE= X-Gm-Gg: ATEYQzyDRy+cjjfU23rNg+4YKi2GzjodI2e1KXwpe4woULtYPVHXy3w3RPQBx8vHZYa QPGRaIVfYmze+mP6g9c+GQszaIptA0AyG3ei6E/pvZgXmG8hXfmuY9gsvLU5HxebGoo3aoFgVuL R2+wOiQ8yJJnO8N0Zk6esyFAzG8iRwssbH9yBFLxWq/a3+sDUJAh6ifldNQgcq+r43VXQlNaCRm AmhJl1pr72id2T5yObDUjoCQ0Y9lfVm4D8F7bfNRpmMWOvMV8u6kPkQAg7WcEtqxGIuF/9nV9Qz 5yKOmMCizu5rWihj+J/mwkW6LiO8cY3Np6OulJm6TGRJZee8RQyAISudXlBEEnY1RJqxtOBjKui VauNxR2Eqjss0WmRSKvC8a0iv35JIEkV8rfMZIXLx2DwKALwR+1HKUfLYl/O+NqkZaYSiEdf5HU f0xq624Xx9L2Ig84veobfeubuICu2ThNH/JWxcLurEBobpSsne8AJ3V/Hpu6yLaUA1kETTLAF1N xxuJkdtGgYA+y4= X-Received: by 2002:a17:90b:5111:b0:343:eb40:8dca with SMTP id 98e67ed59e1d1-35965cad678mr2014537a91.19.1772195112207; Fri, 27 Feb 2026 04:25:12 -0800 (PST) Received: from kinako.work.home.arpa (p1590226-ipxg00c01sizuokaden.shizuoka.ocn.ne.jp. [153.227.10.226]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-3591342f19fsm3612094a91.10.2026.02.27.04.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 04:25:11 -0800 (PST) From: Daniel Palmer To: deller@gmx.de, linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Palmer Subject: [PATCH] fbdev/tdfxfb: Make the VGA register initialisation a bit more obvious Date: Fri, 27 Feb 2026 21:25:00 +0900 Message-ID: <20260227122500.3885069-1-daniel@thingy.jp> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For a while I was trying to get this working on m68k, for some reason the card doesn't display anything if it's own video BIOS didn't run.. Anyhow, I spent a long time looking up what each of these offsets were to work out what the code is configuring and eventually replaced them with the human readable defines in video/vga.h. Functionally there is no change but maybe it makes it a bit easier to look at for the next person that finds themselves in here. Tested on a real voodoo 3 on x86_64. Signed-off-by: Daniel Palmer --- drivers/video/fbdev/tdfxfb.c | 109 ++++++++++++++++++----------------- 1 file changed, 55 insertions(+), 54 deletions(-) diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index 51ebe78359ec..7606e024fa3f 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -77,6 +77,7 @@ #include =20 #include