From nobody Thu Apr 9 12:07:39 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12C25389E04 for ; Fri, 27 Feb 2026 06:52:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772175159; cv=none; b=Ptz/0HIRnm2MzuKJI7bg5x3A4jJhCuvtXdBkF1JOhEB+Y4Ik9r6UvX6wwLAGZ9L/7pQTkrTJXAHdN1/QmeqKt+PrpC2t1zxm8bm6FiCQI6+ozBrx6NyWhjN6kuuGdUGqSUZCIpRQQWtP1VyiADwqMabGh8b+hGVGVgGJ3CVfHSg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772175159; c=relaxed/simple; bh=VGybc11sxwvWF0HDuBPbq3JhrmA6GyT3MfIsT7PkMeY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kk0KokHO63T2ysC32F8R/jcxSXfsQ2Vzej3CkqHp01DjakCOfWIi8A1FCT68mNc5ih8X2A2wjSQcos7hEiAcljmeZu+x62WhmFOimEecl85IVbwMKS5nWcIG+eK5Ly+mPwVUKJ9Bgkmmn3ymo9RRILwnYhTxCnHIUPE391V/BoI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j8h1OLyN; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j8h1OLyN" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-35621da1a7dso1302990a91.0 for ; Thu, 26 Feb 2026 22:52:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772175157; x=1772779957; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/me4FJ+d1aVpAIXm0mJoiSYOgYUY6c5yW2UB1Oq5vLw=; b=j8h1OLyN/k1nehMFpkrDIU64y5fQ1zUACbcSVNN1XQIWa6YEz7kNgvwIPjy3MjW0i7 vzjac8PqnN9KaSHjAuwDcno0/TY1FEfrJ1VwzIzCRXmZi9CYhU2+509EYrhNw8Z+BoBC 1gRfdB0sVY+zb4U1hUX22zzz2jRLNmInQZd0sY5EpqdGiXOMOF8aF1etONfWFpu8/PxC opWZgUtN7mO0zO7EkOuXKBdzE5Tva6OxhXQ+SUhsHNv19Tnm2HzNpvkbeCeubn/IDEyG csuWkbSDh/y15lCknoUT12CeeJgVamywtMjvU1qS7apcIL8yWFvEIT+BuDtulTmwYJOJ BC2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772175157; x=1772779957; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/me4FJ+d1aVpAIXm0mJoiSYOgYUY6c5yW2UB1Oq5vLw=; b=TrloERQTNLO+exC9E8czG8w2XX5DENeXOm7dYwo8J9hB2FG24zS2Fc/4Rvk8q89exE uvL/9QxPuGo6Lh+Sdg9rosbY18H7CAXF8jVXtHxs9u2aw3eF9nB7uS/H2B7WIUu++u2j tSpjXUs1vAIUI/xftqWE3jyieBLn2ZfDgO0Ppds/1HHNd6IUHBBQZFAwHkMddoZlhbLy wrN1hrKcSE7DoP92ohs8J12ZBAlorI8Sph2SvIBL+sqlcJ2bSUZHKO7z26+oBaq2UOhx wxtT9tL/c7AkZFIFTs41CyVHV+xKA2EXc09140lZmdHdPT9z8YjFbJ/4n5wdTVmoDvFN xofQ== X-Forwarded-Encrypted: i=1; AJvYcCWnDF7+aEW/8oC1vJGelWujtzzN2DzR+6NepVkQzVWhPPlyQdEDhhiCWo1hOJS5qqBrYzBUTZXI8ngzIBI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/cyf75Yi2Gd/H0rOVWToV+/PdKPxuIIAiTbMHtTJE0hPu/P2d FWbEcMqeyaEvznVWetN3Y2unngKVlE7dENTxoPcd6VcDN0EubpjgqnwM X-Gm-Gg: ATEYQzycIyoaxkTmivPUVSMZNVslwBHLMu+zZifSGRMl30xgJZo6TWNkRQfKkmZ/Qol 5W8i+BSNW42iA3WuA/HpnPnOwwOebywMUGOJbj5NrJCP1GRNS4C3FH4T9On9wEZnk5r98h2Nd/I YfjQVJSG50o07RuYsVrpYFkTUuKAPF3wheukKXEVMsjgMuNqhxMywAayDuUtGClDJC8RxLk70g7 LXGlMvMtniasADrzG1CrRSAicObNvHHthziICFVdhRa9uXKwE46NWOwUMAaqai8x2Qoa8k1vcj5 COpgHwutvqYrjtzjazR/P/0TqgY2eieCpoHyxfzvpVL6/bPT5YkT/diiRukoVflCrkW3mI6yL/2 2AUWPxWULw3os6AU4IctfJ8heeJqeA/2WEDkQh4M6j48wOuNYYJNykPKqvViP8gzqCuPEw8C89F 6bOBrWvXWVns+hkR6D7W77QWCPbYvsjty4bvJZvFkDt75Dsw== X-Received: by 2002:a17:90b:4b49:b0:359:7eb:d91d with SMTP id 98e67ed59e1d1-35965ceb5d7mr1683755a91.26.1772175157281; Thu, 26 Feb 2026 22:52:37 -0800 (PST) Received: from fedora ([2409:40e5:11f9:3821:4f9f:ee0b:d955:3519]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3593dcad6ddsm4149788a91.1.2026.02.26.22.52.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 22:52:36 -0800 (PST) From: Shubham Chakraborty To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, dtwlin@gmail.com, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Shubham Chakraborty Subject: [PATCH v2] staging: greybus: uart: add descriptive lock comments Date: Fri, 27 Feb 2026 12:22:20 +0530 Message-ID: <20260227065220.8039-1-chakrabortyshubham66@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace vague lock comments with specific descriptions of what data each lock protects: - read_lock: protects iocount and oldcount - write_lock: protects write_fifo and credits - mutex: protects disconnected state Signed-off-by: Shubham Chakraborty --- drivers/staging/greybus/uart.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index fe554eba555a..1e51818e34a8 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -50,12 +50,12 @@ struct gb_tty { unsigned int minor; unsigned char clocal; bool disconnected; - spinlock_t read_lock; /* protects read operations */ - spinlock_t write_lock; /* protects write operations */ + spinlock_t read_lock; /* protects iocount and oldcount */ + spinlock_t write_lock; /* protects write_fifo and credits */ struct async_icount iocount; struct async_icount oldcount; wait_queue_head_t wioctl; - struct mutex mutex; /* serializes port operations */ + struct mutex mutex; /* protects disconnected state */ u8 ctrlin; /* input control lines */ u8 ctrlout; /* output control lines */ struct gb_uart_set_line_coding_request line_coding; --=20 2.53.0