From nobody Thu Apr 2 09:30:24 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 417CF387378 for ; Fri, 27 Feb 2026 06:16:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772172985; cv=none; b=UY+D4xd3Zd+wIN+GoSBIf3hcsvdwikT+1zWrhpiKD2ya3FNTnshlGu0DbrAty/2dOgv35hgy/UosddAd1lG8G5mIes7Wh8UFxnVpWAAHmhoCJUeEOXhSs898p998t6gMJVOzR3XKyvSd9CNf5LjfgBjhVXkUw352JbDQaX/nrpY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772172985; c=relaxed/simple; bh=vinpJK3AdlE6QuECVjsA4xyKYusB2fCdpA1B0h1Sv7E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=X95OncwjE1JvZETf1x8yNfdwwmnQf0n2bnDSdDBfIsMUVMbo78+2ZSY96jm4mfzRQ25FCK/W6DkyAe6fTvhWTuYMu8r1uetM8XUIvw1NHrSut6BSsz+fN/3JLrkDvwUlW46BEvG4hqWaJwFffz7VEJQEewC9IgjSdq2hPtkooBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TKVwr3PR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OVq81ErH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TKVwr3PR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OVq81ErH" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61R2K8fN2403273 for ; Fri, 27 Feb 2026 06:16:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=iEGuO6CekKn dAjKBDhzD10xpNyXSXQXlYftFADS5L1E=; b=TKVwr3PR+4rYKrj9N375Qqj5Fvl 7XFiw9n8j8lj+CsfA1NchYFEInJ+Ji5zUG3zp5rqyyYmKWLUOUEu96WP3H9yusyO p3lTQtUEeyHrPvJePux75XDNOO/Jzp911ymEPdWoVp9G6wIqMsFk7v39xPriraxD +OgJOHLxq+NqRt68Qfwok2VlyG46e5FPOyTkZWsbrUip/4mqUIeT2X83TGMNoEbS kwUZQj/iNQ/0IMU6tDQaz3Ap0Ce7WbM5eLxP+LYD/6p5068R3hprCXqiBEMXIxiI j79DY/cqhMCsVgt1ySy0PznwMJ901tnoAm+qB9AS/miDe8K1bS4I+AHT5Lg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cjw239kkp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Feb 2026 06:16:23 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-358e425c261so1364640a91.3 for ; Thu, 26 Feb 2026 22:16:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772172982; x=1772777782; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iEGuO6CekKndAjKBDhzD10xpNyXSXQXlYftFADS5L1E=; b=OVq81ErH+rZSSv7Lr/CDZE7Bz0XHHJ+Q4y4uVBa0CnXOexTb2/OX53Vt35dkVZBWX0 SAUiEzvGvdBKEh1RoNR8JsHURuJNHDDmHxXJNMC04gf7BXmAP5eG9lDp9ox6fCYeXAfA WK6gxlodGkQTBwyKM1+ruEh8gTdAYgBueROZLcQ3WbIjpvLfZFRBHpUXFmURyXPUT3Yg excwo+xouqVuAnBFBXuRDKIWykb4ildsWHtBLCE53+hd2Xr8tjjW9D/N6Y7SZ0oT4mKO hWncXdaO1i4el/WYVHlPobfoWJtQ7FbpeEvH4THDwZ1SMat5/1+MdhPBAENiKm3/nAR5 IMoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772172982; x=1772777782; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iEGuO6CekKndAjKBDhzD10xpNyXSXQXlYftFADS5L1E=; b=GyimVvFnufcl9CcdTDv+OZ1Aa5NvbfPIr9rPmBvUM2jn9TvPuTYhyqCGBGWHt0HkLm 4OT+t+H4Hmz6bDt9nqxwjbHx4+/qdvEkOcC3KYNF0ISBkc9Ny1r2JSWRp4MR1DN/P1r3 md96Sg9m+72h4VNVgofS9rEij2+CTQt4ryjtAYck2xjoWDaTHelugct1bv57TdWQ/w9M XpG2azHlByohEGarRnCKOTxdqlg3ci6T78buYlWKyKwFpAoWvDrvo701RXj/kxzv5zZ+ o/LLoDDM2P9f7BZu++ojF84kPsNNnEH5+Io2wA99/I4rKeQv5ueyaTnGbdcWLnpcRf2v 9sHw== X-Forwarded-Encrypted: i=1; AJvYcCUZQtQWOwTKL1OSfuXrpiBmDV89QmMp9au6V140EQORopqKQFlUh4QbCk2F/p5IXcdLTazXn5Hk3nKmdxo=@vger.kernel.org X-Gm-Message-State: AOJu0YzOzS112DUuhjwPUqJZRNtwq5vB4F3b7fswuDYztpKpNxNQwDGA FF09UY92bCrUIMm6SU2y6i4CTUNtahy253g4kc6DoHwl8DWkICyxjFqPTUcffPNEyUhQ7Vra4Bc FCehAMv0AvSJAMwRTu10URNQHCRUT1fWCCdi/H/4SObiAJZnMMJ2RDc88UUjsK+g0lcI= X-Gm-Gg: ATEYQzyxpjCT8jMSgFDGawsH+Ripqsc5Ufkc+4zAyLFbrnbv1tliCdk9hzbipK3XUCK gOSOvS0mlqf+g6xpgOeMjTAQNIDRVug1RiQQF2e9qnR83rZa2GhcG4OWuXQndDTiw5KvUwEI1TM QpGASvN0kyIQ4SP7myJNjOfdbhpsYcpxwqjW6f2TXdhX3IOjdK2cYSyc6jUX/320vbGcoCxpfD7 UJluu+JJ6Fzi6zFkXX6WzEWwGbqSu19rYQtsMK+VPD0J5vC26u6rTrnQjrktCZ9/QQnCytqtK+e Rbuh4lU/aMysjsak9ZslJGUiTh9F10JjrK8z4rVqxXk8nKca26Nue9lRK4oIWJWWHW8yHwrCycn rf2rAeh8Pb+4Q24btmcic6P76pWB2V69zZw1yhrF4t0MNs2tRbEbWbmM= X-Received: by 2002:a17:902:db04:b0:29e:76b8:41e5 with SMTP id d9443c01a7336-2ae2e496c4dmr14976485ad.30.1772172982142; Thu, 26 Feb 2026 22:16:22 -0800 (PST) X-Received: by 2002:a17:902:db04:b0:29e:76b8:41e5 with SMTP id d9443c01a7336-2ae2e496c4dmr14976225ad.30.1772172981546; Thu, 26 Feb 2026 22:16:21 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb6a043dsm64813025ad.54.2026.02.26.22.16.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 22:16:21 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, chiluka.harish@oss.qualcomm.com Subject: [PATCH v6 04/13] soc: qcom: geni-se: Handle core clk in geni_se_clks_off() and geni_se_clks_on() Date: Fri, 27 Feb 2026 11:45:35 +0530 Message-Id: <20260227061544.1785978-5-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260227061544.1785978-1-praveen.talari@oss.qualcomm.com> References: <20260227061544.1785978-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 6L32iMw0wlYu_KK42pgcQUyqWEpTY2bF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDA1MCBTYWx0ZWRfX+R6Hoj3Kc0Bd fcIGKsZnO+xtdlzS/cUKYKm6J26gG77QQbQMdR0zw0EzyNCCKP2ka0RP691B1SxUFHwZwuFRBi/ tL8q9thidMd+fVrQb5PNO7FyyfehJrYV4zKEHmU/+ICYrL1CyIcMlio28hV7R4P5M8f/gvFt6Gs 5fobZpcjtSnS8RoFeyM2hwWWAAQk296BIgJFQl6vqnrWZQiCWbm0llBgzupAcJSxSbsCSI9/Qv7 m8tOh+xhmNS6sfFlgaWTGLIw8IcI12Q9bNLIBC7jeWP6i+rZ4OyP4ZK7ht6OFwYzLNCrb+V/MMH 4jjq5fU39iF9VwKPKdJlbPhLRzR21ZUyQdtU8ILY/gj1GUPsybW8Rbv7pV+EkywQcUmRrgjr8X0 p7owakFBtpOYkHkblnGK6UTMURH0ps5odCLL9Ne9cJLTH0Jwnlxx7uitzygNt3HI1IGvG83iq+3 JVe1jOZe/SnnmNfwUkg== X-Authority-Analysis: v=2.4 cv=cJHtc1eN c=1 sm=1 tr=0 ts=69a136b7 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=fzsqq50RfsZR9heXkngA:9 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: 6L32iMw0wlYu_KK42pgcQUyqWEpTY2bF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_01,2026-02-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 spamscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270050 Content-Type: text/plain; charset="utf-8" Currently, core clk is handled individually in protocol drivers like the I2C driver. Move this clock management to the common clock APIs (geni_se_clks_on/off) that are already present in the common GENI SE driver to maintain consistency across all protocol drivers. Core clk is now properly managed alongside the other clocks (se->clk and wrapper clocks) in the fundamental clock control functions, eliminating the need for individual protocol drivers to handle this clock separately. Reviewed-by: Konrad Dybcio Signed-off-by: Praveen Talari --- v4->v5 - Added a Reviewed-by tag --- drivers/soc/qcom/qcom-geni-se.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-s= e.c index 75e722cd1a94..2e41595ff912 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -583,6 +583,7 @@ static void geni_se_clks_off(struct geni_se *se) =20 clk_disable_unprepare(se->clk); clk_bulk_disable_unprepare(wrapper->num_clks, wrapper->clks); + clk_disable_unprepare(se->core_clk); } =20 /** @@ -619,7 +620,18 @@ static int geni_se_clks_on(struct geni_se *se) =20 ret =3D clk_prepare_enable(se->clk); if (ret) - clk_bulk_disable_unprepare(wrapper->num_clks, wrapper->clks); + goto err_bulk_clks; + + ret =3D clk_prepare_enable(se->core_clk); + if (ret) + goto err_se_clk; + + return 0; + +err_se_clk: + clk_disable_unprepare(se->clk); +err_bulk_clks: + clk_bulk_disable_unprepare(wrapper->num_clks, wrapper->clks); return ret; } =20 --=20 2.34.1