From nobody Thu Apr 9 13:32:18 2026 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF27B3E95A9 for ; Fri, 27 Feb 2026 06:14:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772172888; cv=none; b=QCiVvPhLIIATrgO7OlORJkoerGtbxSmW6dPj8Qt9CNFPJEow2bjYG9+F5ayilisXT3CddmhHIGOm20PnTtL0BY6YyCZY7DIvCfE2r2sJot6S/3oVLcFZdr3VyL6OhaNvIdIBeK0+Z9Cw3msedSw3t2AJOrhYmK8Z8ln+ykZQPrk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772172888; c=relaxed/simple; bh=L4Ide4otMmuh82D/YTpixyERsDg5wcHyrdGjG5XeZHY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=msCBnlljKEbjlZtoGqhXRO6mnviYQ4bhOnnPglFu5d0GeJsl0LJmZiLSrBNLdLO7IoI1+bth7xT1mURrKtw9ol9se38WDZmbUMRtdyzacPDpcpdbkbvDqbA5DNjskIz88mREqdWb2d6k3aKvg5Qoz5Tm9RakC88OkofE1G0HjOY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VewKcL7Z; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VewKcL7Z" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-7987531082aso16366757b3.3 for ; Thu, 26 Feb 2026 22:14:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772172886; x=1772777686; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=12VAYoqja87LYfXA9N2irRdh/f4qGYYdkwkwGsNdZYg=; b=VewKcL7ZSWDAeeIturpEvu7AlHhsx94s2VvIim3L+W7GLIzTjtYBJjqRRXRVm92rwC 62ri20EbbTIj92KJa9eNyGbGb01bFlQPnrBtdy5493TBvI0U/wrau2pDsxwF66rLYRHi znhDrPr7juWz7rAR1cW//j7IOOsWNEMQ951SA+/x2K2SDADuiQ4tmHDUF7dhJ0EVqVI/ ZQUbwGIS062/txXs4jMZYm89rrN7vU1NymFbB+yL76o3VzqxCmjyFiRgh/WlnwZrqvEB TIpLU+5PrnLj3WNP7I9HoJoGiF9IJ2EffS3OIyUovifh9Yz1HMwPM5TEjgfAyZirqw2y vrjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772172886; x=1772777686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=12VAYoqja87LYfXA9N2irRdh/f4qGYYdkwkwGsNdZYg=; b=Ww4u32gqgort9A+DSkP4xNNtIU854hbJVy/p/ZMSB8VldmgOUdIg6r38jzGki3DDQ1 mQUxqNSqCjh5SEDd8afHfZA1Mxd5oLBrkpCAEHssOB5cT651yz10udLAK6qDSL4Wt2kQ Li9XRCZjihftXSU8xMpUEKptuCfuR+f9+1k8iW74BX3NmJZagNM4vLP1lcztXSI66hqr KFz+2rhQFtoG6yN6rk4arv8d45xrBEbMO+HMpg/FPnSpR8eil1t8GIfzHY0B18h/6B+6 KZyHQZoOYMFpBAX6ZSdY0u8vk1cy901IY54BqEvyNMO+Hcpb1/EJiINnrK9Ce1IwHmxr Mofw== X-Forwarded-Encrypted: i=1; AJvYcCUY/5cugVLQI49Iet4mWQQpoNXKQVAgcHiJKko8/ODTP/Mfd5vU9Cd2Vvo2suCE84gCbyTokCQo1SsdSjU=@vger.kernel.org X-Gm-Message-State: AOJu0YyWnDlbUQJODmm1nuVYFib0p5X8HiTkcJUXMpPPAuS0MGeatNUI QekMDD5/uRN8Pz7W1CLGrk3FA8m/+3EJSNl+z7Ge5IYvA3gp1KttzxTD X-Gm-Gg: ATEYQzzsDVzvy44C9u+VBshns6K6iJu2OE+mfzW1oONmxOV4Cu9JnXgYJFE1OYBW746 ufvKVFR5xk8JUwP939ibhBQKGAukmTIMhQgJGdMNJ0lnAJ71GYGr4SlALuKKajW3skulTMxvqf0 1OYcNFvvv8xng/VJL8/mLlA1DEEuefDlfpmFQA+Pq40+psw6JPJ2y7IXMsx9rjbMYzOKQkdyD8r yKpuGQKPT5ORW2XECncPNIKWkgw4lAXeKZwPiNtNKCZLPsdKHiKMT9fiN6jNtALRpyY76rifybz TaqndbZELW973aMFAfX3Av5syzTH9KBgYmengte7MeBljrDw/OrlgwSHnMLO38IoSxdMpoSz4ob xWmG7D7VCZp6izUpoOmReUfm0OVP1+RqlhuLnxxKxDAZK8Ujo7ga8b1fQSJe2Te8UO7VKonizpa tJ05Us6WleeImX9Ul4PwhppqbGzmmPHxBfOyP9FNtgBaTwFFJKMr6IAg/q3TluKASiB8oN8WNMX 4t3QqWntSQj160yNMO8/DZh X-Received: by 2002:a05:690c:2605:b0:798:7309:a427 with SMTP id 00721157ae682-798855c617fmr16288607b3.36.1772172885860; Thu, 26 Feb 2026 22:14:45 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876ad0de6sm18149527b3.15.2026.02.26.22.14.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 22:14:45 -0800 (PST) From: Ethan Tidmore To: Antoniu Miclaus , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 1/3] iio: filter: admv8818: Add missing error code Date: Fri, 27 Feb 2026 00:14:22 -0600 Message-ID: <20260227061424.1135505-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260227061424.1135505-1-ethantidmore06@gmail.com> References: <20260227061424.1135505-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If the macro FIELD_GET() returns an error code the function returns with 0 because ret was just confirmed to be 0 a few lines above. Add error code. Detected by Smatch: drivers/iio/filter/admv8818.c:335 __admv8818_read_hpf_freq() warn: missing error code? 'ret' drivers/iio/filter/admv8818.c:376 __admv8818_read_lpf_freq() warn: missing error code? 'ret' Fixes: f34fe888ad054 ("iio:filter:admv8818: add support for ADMV8818") Signed-off-by: Ethan Tidmore --- drivers/iio/filter/admv8818.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c index e494fd33911b..4d5e7a9d806a 100644 --- a/drivers/iio/filter/admv8818.c +++ b/drivers/iio/filter/admv8818.c @@ -332,7 +332,7 @@ static int __admv8818_read_hpf_freq(struct admv8818_sta= te *st, u64 *hpf_freq) hpf_band =3D FIELD_GET(ADMV8818_SW_IN_WR0_MSK, data); if (!hpf_band || hpf_band > 4) { *hpf_freq =3D 0; - return ret; + return -EINVAL; } =20 ret =3D regmap_read(st->regmap, ADMV8818_REG_WR0_FILTER, &data); @@ -373,7 +373,7 @@ static int __admv8818_read_lpf_freq(struct admv8818_sta= te *st, u64 *lpf_freq) lpf_band =3D FIELD_GET(ADMV8818_SW_OUT_WR0_MSK, data); if (!lpf_band || lpf_band > 4) { *lpf_freq =3D 0; - return ret; + return -EINVAL; } =20 ret =3D regmap_read(st->regmap, ADMV8818_REG_WR0_FILTER, &data); --=20 2.53.0