From nobody Thu Apr 9 12:06:46 2026 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF27B3E95A9 for ; Fri, 27 Feb 2026 06:14:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772172888; cv=none; b=QCiVvPhLIIATrgO7OlORJkoerGtbxSmW6dPj8Qt9CNFPJEow2bjYG9+F5ayilisXT3CddmhHIGOm20PnTtL0BY6YyCZY7DIvCfE2r2sJot6S/3oVLcFZdr3VyL6OhaNvIdIBeK0+Z9Cw3msedSw3t2AJOrhYmK8Z8ln+ykZQPrk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772172888; c=relaxed/simple; bh=L4Ide4otMmuh82D/YTpixyERsDg5wcHyrdGjG5XeZHY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=msCBnlljKEbjlZtoGqhXRO6mnviYQ4bhOnnPglFu5d0GeJsl0LJmZiLSrBNLdLO7IoI1+bth7xT1mURrKtw9ol9se38WDZmbUMRtdyzacPDpcpdbkbvDqbA5DNjskIz88mREqdWb2d6k3aKvg5Qoz5Tm9RakC88OkofE1G0HjOY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VewKcL7Z; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VewKcL7Z" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-7987531082aso16366757b3.3 for ; Thu, 26 Feb 2026 22:14:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772172886; x=1772777686; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=12VAYoqja87LYfXA9N2irRdh/f4qGYYdkwkwGsNdZYg=; b=VewKcL7ZSWDAeeIturpEvu7AlHhsx94s2VvIim3L+W7GLIzTjtYBJjqRRXRVm92rwC 62ri20EbbTIj92KJa9eNyGbGb01bFlQPnrBtdy5493TBvI0U/wrau2pDsxwF66rLYRHi znhDrPr7juWz7rAR1cW//j7IOOsWNEMQ951SA+/x2K2SDADuiQ4tmHDUF7dhJ0EVqVI/ ZQUbwGIS062/txXs4jMZYm89rrN7vU1NymFbB+yL76o3VzqxCmjyFiRgh/WlnwZrqvEB TIpLU+5PrnLj3WNP7I9HoJoGiF9IJ2EffS3OIyUovifh9Yz1HMwPM5TEjgfAyZirqw2y vrjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772172886; x=1772777686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=12VAYoqja87LYfXA9N2irRdh/f4qGYYdkwkwGsNdZYg=; b=Ww4u32gqgort9A+DSkP4xNNtIU854hbJVy/p/ZMSB8VldmgOUdIg6r38jzGki3DDQ1 mQUxqNSqCjh5SEDd8afHfZA1Mxd5oLBrkpCAEHssOB5cT651yz10udLAK6qDSL4Wt2kQ Li9XRCZjihftXSU8xMpUEKptuCfuR+f9+1k8iW74BX3NmJZagNM4vLP1lcztXSI66hqr KFz+2rhQFtoG6yN6rk4arv8d45xrBEbMO+HMpg/FPnSpR8eil1t8GIfzHY0B18h/6B+6 KZyHQZoOYMFpBAX6ZSdY0u8vk1cy901IY54BqEvyNMO+Hcpb1/EJiINnrK9Ce1IwHmxr Mofw== X-Forwarded-Encrypted: i=1; AJvYcCUY/5cugVLQI49Iet4mWQQpoNXKQVAgcHiJKko8/ODTP/Mfd5vU9Cd2Vvo2suCE84gCbyTokCQo1SsdSjU=@vger.kernel.org X-Gm-Message-State: AOJu0YyWnDlbUQJODmm1nuVYFib0p5X8HiTkcJUXMpPPAuS0MGeatNUI QekMDD5/uRN8Pz7W1CLGrk3FA8m/+3EJSNl+z7Ge5IYvA3gp1KttzxTD X-Gm-Gg: ATEYQzzsDVzvy44C9u+VBshns6K6iJu2OE+mfzW1oONmxOV4Cu9JnXgYJFE1OYBW746 ufvKVFR5xk8JUwP939ibhBQKGAukmTIMhQgJGdMNJ0lnAJ71GYGr4SlALuKKajW3skulTMxvqf0 1OYcNFvvv8xng/VJL8/mLlA1DEEuefDlfpmFQA+Pq40+psw6JPJ2y7IXMsx9rjbMYzOKQkdyD8r yKpuGQKPT5ORW2XECncPNIKWkgw4lAXeKZwPiNtNKCZLPsdKHiKMT9fiN6jNtALRpyY76rifybz TaqndbZELW973aMFAfX3Av5syzTH9KBgYmengte7MeBljrDw/OrlgwSHnMLO38IoSxdMpoSz4ob xWmG7D7VCZp6izUpoOmReUfm0OVP1+RqlhuLnxxKxDAZK8Ujo7ga8b1fQSJe2Te8UO7VKonizpa tJ05Us6WleeImX9Ul4PwhppqbGzmmPHxBfOyP9FNtgBaTwFFJKMr6IAg/q3TluKASiB8oN8WNMX 4t3QqWntSQj160yNMO8/DZh X-Received: by 2002:a05:690c:2605:b0:798:7309:a427 with SMTP id 00721157ae682-798855c617fmr16288607b3.36.1772172885860; Thu, 26 Feb 2026 22:14:45 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876ad0de6sm18149527b3.15.2026.02.26.22.14.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 22:14:45 -0800 (PST) From: Ethan Tidmore To: Antoniu Miclaus , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 1/3] iio: filter: admv8818: Add missing error code Date: Fri, 27 Feb 2026 00:14:22 -0600 Message-ID: <20260227061424.1135505-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260227061424.1135505-1-ethantidmore06@gmail.com> References: <20260227061424.1135505-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If the macro FIELD_GET() returns an error code the function returns with 0 because ret was just confirmed to be 0 a few lines above. Add error code. Detected by Smatch: drivers/iio/filter/admv8818.c:335 __admv8818_read_hpf_freq() warn: missing error code? 'ret' drivers/iio/filter/admv8818.c:376 __admv8818_read_lpf_freq() warn: missing error code? 'ret' Fixes: f34fe888ad054 ("iio:filter:admv8818: add support for ADMV8818") Signed-off-by: Ethan Tidmore --- drivers/iio/filter/admv8818.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c index e494fd33911b..4d5e7a9d806a 100644 --- a/drivers/iio/filter/admv8818.c +++ b/drivers/iio/filter/admv8818.c @@ -332,7 +332,7 @@ static int __admv8818_read_hpf_freq(struct admv8818_sta= te *st, u64 *hpf_freq) hpf_band =3D FIELD_GET(ADMV8818_SW_IN_WR0_MSK, data); if (!hpf_band || hpf_band > 4) { *hpf_freq =3D 0; - return ret; + return -EINVAL; } =20 ret =3D regmap_read(st->regmap, ADMV8818_REG_WR0_FILTER, &data); @@ -373,7 +373,7 @@ static int __admv8818_read_lpf_freq(struct admv8818_sta= te *st, u64 *lpf_freq) lpf_band =3D FIELD_GET(ADMV8818_SW_OUT_WR0_MSK, data); if (!lpf_band || lpf_band > 4) { *lpf_freq =3D 0; - return ret; + return -EINVAL; } =20 ret =3D regmap_read(st->regmap, ADMV8818_REG_WR0_FILTER, &data); --=20 2.53.0 From nobody Thu Apr 9 12:06:46 2026 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF20A3E9F72 for ; Fri, 27 Feb 2026 06:14:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772172889; cv=none; b=KzDuV23oodKFMb4YTNDj9keC9vV5yqL/UGFRo86K/GRbE85a89Toa33YB2KqQB3I3x2TXnIRWVgRbpaO2LDsSb7Q/eX3YLNAS9xqjVpzOHGZTslCM1y4mmR7Bgy8+V/bpAvFEHfG+pNDjp0vgu3LkKIuMMk4AQejlvJw0aEE2Gg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772172889; c=relaxed/simple; bh=E/ZD1dgTfN9GELfDVgcd77soj3hxro0RxUDwR0iNADI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MPpsKtVXtiO6pNU1VLm4tRx8fkodcCySkMhvcCRp24vkhuwv+E+MKtJYcykaNwriSALbhuEc3wMrMO6R5Q31KZuk6KwUqLmLelgQZfCy8nw9KCbNu+dDOOUE4H1pM0jEpGqVmwsvnAaCAZ1F3GRgWmI8ZB1J5gbXSF0xr3s2zVU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aTFP8Hd2; arc=none smtp.client-ip=209.85.128.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aTFP8Hd2" Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-7982c3b7da9so19568187b3.1 for ; Thu, 26 Feb 2026 22:14:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772172887; x=1772777687; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zzfxima+2vAKmrCI20smUZW6Vmlg524ON+pU5T6MXTM=; b=aTFP8Hd2wOlTad6IG4+Fd/OTcANokpq4F62gMlF2UHef6qa80hQTpZkHTGjEHQkxEb io1PgrtKbF2M6sbVcOL83IyGFQJ3g9kSiJ0mo5d3q5MutaXXDcTSE6qlFw6bQVVcv4Dj tgMzvrrOY7LyUyTBjKF2PAx6pjyftFVBtK3mPW1ahLNz2zrK9JbvE5YzvnjFvE2FM6M0 Wx5NLWBto2H97/2oO/uOV3BeuKDEl/s666+zoitEDWExXF4xjqTZaOezgUm9rrpi4WKi xacOUgchzoy0qya/BiCfjiiWd+YiSW9+EGh+g09AZm5yXTJHsQgAxzteUDjXTGprvyQG uptA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772172887; x=1772777687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Zzfxima+2vAKmrCI20smUZW6Vmlg524ON+pU5T6MXTM=; b=FrbToZopzuMnpbD8Ktdk0Mwt2yPkQGdqZqELNL37Hi/avLsA0UM3cr7bN2m8+6R6Y0 sOC0hAJ5cdAX3+7kI6zHwnqW5Z8ul61+bSeFBoWiYMU2nnPfpfPxPosVK6NE+xaAOr+J Ys7o9MqHoojhN6qxMMJm4FiCJHr0Lu8TzKbqJnjeBnhtbEtameCn98xxEs5PwVh6clCc KY2cmwqTeIWprHWrZZg2nC/RPVv22uLChr1MqX2hXn+hynZ/qRyP6OXDCmL5Lino3MBQ UDe0252C+oz5TFMBJKwIAT9i3msSKg3LOhNzVci5d1dsz6O5p32v8lfRXDP6YVGJJ0YY m79A== X-Forwarded-Encrypted: i=1; AJvYcCV87BGuape1uTovf8tNtxHuLMhv/PA9AfefU9LjlHkngi1aSPPx9yyp7/TKeV2mP6lJzDjOx9Lw5zOVLWE=@vger.kernel.org X-Gm-Message-State: AOJu0YzrKWmn0Z3c/9gAFNqAGJ/x01q38HACZAjl+xYDi+fUQ9N/rtfQ zXC3Ts9FfY3J4ZMEQTGKGQ/alwe9fsSfYyVSzTC+WrC4flRhHYvedWn1 X-Gm-Gg: ATEYQzzbWgXH8cOspPVFHQvPmEHPL7UkM22KtAPao2NZiIF6jIBbznVe15aA93/D/rT pBvnisp3OlwRnb9E81jWYdF7keT3ca35SOqRYBDo4uvPlFO7PFm3/zUFrH9SkMppN8d8uGWWaHI V3Y8f39Cvt4VVjxRwx5oZiSwndRAXXLagKsPstjLifoE8+QcrDyYieYoTX3+lYZzDoexPO6yPgW BZxJWY9DfolSxp864ebrFqSX5JV5Fg3eu7LBD6EMxQ2KEy/i/ndmpQG/nnKHjca/o/Z4EWzjGAj jRdNbQ3HFCj2eNWsTYtE6j8Is6lPBmNv9EJ4nvP8MtDsQ7jOTS425jVeaCs8fR5/DG14oLCBDQc rEuxBCbm6/QA99idk1gb08GGxKkA5rL0cU9kh5nYnZQ5E3ZgxcbuhMf1FmeQ+zzRd/SuC5+olhS TL87kzu3eaEznMddpb7r0slXWbb1gYlrmM9nZg31aWk8R6c+JbsphyFwDQwGJ+SmcLt2s/F/rak EXVzXsExn/lKwlvWupgH4b9 X-Received: by 2002:a05:690c:c4e8:b0:798:244:1b07 with SMTP id 00721157ae682-7988549ee94mr17049017b3.11.1772172886888; Thu, 26 Feb 2026 22:14:46 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876ad0de6sm18149527b3.15.2026.02.26.22.14.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 22:14:46 -0800 (PST) From: Ethan Tidmore To: Antoniu Miclaus , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 2/3] iio: filter: admv8818: Simplify locking with guard() Date: Fri, 27 Feb 2026 00:14:23 -0600 Message-ID: <20260227061424.1135505-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260227061424.1135505-1-ethantidmore06@gmail.com> References: <20260227061424.1135505-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use guard() instead of manual locking to simplify code. Signed-off-by: Ethan Tidmore --- drivers/iio/filter/admv8818.c | 59 ++++++++++++----------------------- 1 file changed, 20 insertions(+), 39 deletions(-) diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c index 4d5e7a9d806a..2d12700d717f 100644 --- a/drivers/iio/filter/admv8818.c +++ b/drivers/iio/filter/admv8818.c @@ -7,6 +7,7 @@ =20 #include #include +#include #include #include #include @@ -205,13 +206,8 @@ static int __admv8818_hpf_select(struct admv8818_state= *st, u64 freq) =20 static int admv8818_hpf_select(struct admv8818_state *st, u64 freq) { - int ret; - - mutex_lock(&st->lock); - ret =3D __admv8818_hpf_select(st, freq); - mutex_unlock(&st->lock); - - return ret; + guard(mutex)(&st->lock); + return __admv8818_hpf_select(st, freq); } =20 static int __admv8818_lpf_select(struct admv8818_state *st, u64 freq) @@ -281,13 +277,8 @@ static int __admv8818_lpf_select(struct admv8818_state= *st, u64 freq) =20 static int admv8818_lpf_select(struct admv8818_state *st, u64 freq) { - int ret; - - mutex_lock(&st->lock); - ret =3D __admv8818_lpf_select(st, freq); - mutex_unlock(&st->lock); - - return ret; + guard(mutex)(&st->lock); + return __admv8818_lpf_select(st, freq); } =20 static int admv8818_rfin_band_select(struct admv8818_state *st) @@ -308,16 +299,17 @@ static int admv8818_rfin_band_select(struct admv8818_= state *st) if (lpf_corner_target < st->cf_hz) lpf_corner_target =3D U64_MAX; =20 - mutex_lock(&st->lock); + guard(mutex)(&st->lock); =20 ret =3D __admv8818_hpf_select(st, hpf_corner_target); if (ret) - goto exit; + return ret; =20 ret =3D __admv8818_lpf_select(st, lpf_corner_target); -exit: - mutex_unlock(&st->lock); - return ret; + if (ret) + return ret; + + return 0; } =20 static int __admv8818_read_hpf_freq(struct admv8818_state *st, u64 *hpf_fr= eq) @@ -352,13 +344,8 @@ static int __admv8818_read_hpf_freq(struct admv8818_st= ate *st, u64 *hpf_freq) =20 static int admv8818_read_hpf_freq(struct admv8818_state *st, u64 *hpf_freq) { - int ret; - - mutex_lock(&st->lock); - ret =3D __admv8818_read_hpf_freq(st, hpf_freq); - mutex_unlock(&st->lock); - - return ret; + guard(mutex)(&st->lock); + return __admv8818_read_hpf_freq(st, hpf_freq); } =20 static int __admv8818_read_lpf_freq(struct admv8818_state *st, u64 *lpf_fr= eq) @@ -393,13 +380,8 @@ static int __admv8818_read_lpf_freq(struct admv8818_st= ate *st, u64 *lpf_freq) =20 static int admv8818_read_lpf_freq(struct admv8818_state *st, u64 *lpf_freq) { - int ret; - - mutex_lock(&st->lock); - ret =3D __admv8818_read_lpf_freq(st, lpf_freq); - mutex_unlock(&st->lock); - - return ret; + guard(mutex)(&st->lock); + return __admv8818_read_lpf_freq(st, lpf_freq); } =20 static int admv8818_write_raw_get_fmt(struct iio_dev *indio_dev, @@ -485,7 +467,7 @@ static int admv8818_filter_bypass(struct admv8818_state= *st) { int ret; =20 - mutex_lock(&st->lock); + guard(mutex)(&st->lock); =20 ret =3D regmap_update_bits(st->regmap, ADMV8818_REG_WR0_SW, ADMV8818_SW_IN_SET_WR0_MSK | @@ -497,18 +479,17 @@ static int admv8818_filter_bypass(struct admv8818_sta= te *st) FIELD_PREP(ADMV8818_SW_OUT_SET_WR0_MSK, 1) | FIELD_PREP(ADMV8818_SW_OUT_WR0_MSK, 0)); if (ret) - goto exit; + return ret; =20 ret =3D regmap_update_bits(st->regmap, ADMV8818_REG_WR0_FILTER, ADMV8818_HPF_WR0_MSK | ADMV8818_LPF_WR0_MSK, FIELD_PREP(ADMV8818_HPF_WR0_MSK, 0) | FIELD_PREP(ADMV8818_LPF_WR0_MSK, 0)); + if (ret) + return ret; =20 -exit: - mutex_unlock(&st->lock); - - return ret; + return 0; } =20 static int admv8818_get_mode(struct iio_dev *indio_dev, --=20 2.53.0 From nobody Thu Apr 9 12:06:46 2026 Received: from mail-yx1-f48.google.com (mail-yx1-f48.google.com [74.125.224.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAF973E9F9A for ; Fri, 27 Feb 2026 06:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772172890; cv=none; b=a0SL+sbNDdQpmmqFXpCxOQKzeCPoH4Dml7d1AQjc2DWbo2yK17a7jZJM3syGvgeGuZJvS9VPrMJb5hRMURWA3wsdg/WxTS6qe8H7HwZ1CpgmaDEfUU+F8faJ7YYi5ENHz3K11m40zbnC57DCvTt65mXhgSFXufRdKsdwGqnK/PY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772172890; c=relaxed/simple; bh=m0A1LYSAug8YgjqXyIGlPGL4DtTehQPQM7D2gvX5ko8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W3fQrzXRlhuiw6vMhUW/iUQtvw2Ckr13YkBfokSXJpLw6VN11xXf6r90hvOmGY7PBJleofzn7UK8zNd69FD8iUKiEC0oKaUPZTLyJGhNOUMiQAgP9PKrdlleK7+kx3Cai2IU1LtYEnL+uSRsSeOotz8VbcJhcp6mdjBQXsOk9dY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AEQwXNF9; arc=none smtp.client-ip=74.125.224.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AEQwXNF9" Received: by mail-yx1-f48.google.com with SMTP id 956f58d0204a3-64ca09f2170so1632338d50.1 for ; Thu, 26 Feb 2026 22:14:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772172888; x=1772777688; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J0eQA0+mqLsPCYgC0M5tS08RbplxdERLESEbNrqUaNE=; b=AEQwXNF9ng2hAb7tbX9QmheTgnmsv/8b82SVouL3icSHLayPa4fq5dkJ6ta3p3JbPx Kh2HHY2iAjJclF5VKyh8yBoBZesUehOKeYut1iMG++tl8HI0ybzpe8VeJSYhkVyoXGIk ton4AkUfwzaW3w+M6ihYWj2cG7NJdBPS/OAQrnHoLdQ9NAw/tuEdbtyBO/FWeZimOPXc Aln8Fie1VFz20/zfX2IvCXJPvsce11AknHx38soTnzJiuaqKzwwKuD71djiNaCMx6Ori JcJJ57rLs6RBDlWWWw7LJTqhxNEEraIxcNTz5nph9J24IBdtEXPULGXOU09ltVnI0ofR WHFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772172888; x=1772777688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=J0eQA0+mqLsPCYgC0M5tS08RbplxdERLESEbNrqUaNE=; b=QQ26oJNd+mnkBwtphQp8n6xcXfzC44aFDlVfVXwVBLQhuHMYBwWrWJPUZFrexy/Q0d AT+dMNzz6TfmZSsgaVhS7cG5AP0tm+Rv5wHeWgXl44hfgo+vh7xkAzTbmqQcqF2rzasy MeqPQx8K4Ew7mqzDaBiTGkkQCWAfpp71MAw6hqO4Bx11nvbAyjLPJtOFCDtYObA+1RQR EaJIZok4mVmkIWjZGKJYnrF6axYuxyA+Q3TH3Rky0qQAI0APETZxq8fXENGKP686U8u1 9G7rzgSidj+byVwgC1h0iNyKLjr4Zw+Lp7gphBq47uERfEePJ7TxCQ4OYmrm2DZ6jNMr uOMA== X-Forwarded-Encrypted: i=1; AJvYcCXAXDNsNxDIqXDWoFX6wBwM43HCjBxWuZnoSutFDbjatte95bhhSAZfhkfYTHOgKLPlLximRiEu5TeX34w=@vger.kernel.org X-Gm-Message-State: AOJu0Yws/1NVYYOOK0VQnk2Lt3qkqEs4MTjGce+DSMgDKMtfc4QxH40T LvWP7lzMKocTC2nLS1tp56uWFYuPCaCDWrsXRsW1Hb1P4qOX+ILW1HHi X-Gm-Gg: ATEYQzymT0OoprhimtQoYhKQlSRRBUVBtZirq2rS80qBn6o78F5x6yMrWLhYtei6p4C sOKugnjChEX5Y2BK+v9jsj6pHEEDrYu/BAdV/uAJfWCjQHTiFxuLVmsM5FjoFawpIzmjFGNTWBZ kuLTTa0sdXfxmaso4xpHCg25/b6BVq6YV80yDOSqXbV2eB9lIcIHH30ye14CKgZPbWaqNczUNBW nC7BzDSvHV6JkrAr06lAdR2DPhSzzabsqZLUwXtzB90pCWbwGLE3+wljoTj+pohMHz8pN65dPqh Ku6UhtWTQE2RXwMt5xOzRUgMdboZDDTO6gTtIsbdkUeGtRq3pymM2ocOcJY6Lo/InuYjmM68FRP RACx3QZXFt87mT9Un7uJtr9g0d57bjWSKiOpQTKEa2WOjzN5AEuwGpJAd9KnNb2Vhuyl1tf7olu ifvSknrJunsUofE6J8/7Soq/NstCEoFg/hrILa+RoIkT5WhN82LObKlfvGkoa30uYuq0aYN8wdd WiLVeP9lQtSOPjNel/2Qxmh X-Received: by 2002:a05:690c:c24c:b0:798:509c:f79a with SMTP id 00721157ae682-7988559abd7mr16851457b3.36.1772172887631; Thu, 26 Feb 2026 22:14:47 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876ad0de6sm18149527b3.15.2026.02.26.22.14.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 22:14:47 -0800 (PST) From: Ethan Tidmore To: Antoniu Miclaus , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 3/3] iio: filter: admv8818: Minor cleanups Date: Fri, 27 Feb 2026 00:14:24 -0600 Message-ID: <20260227061424.1135505-4-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260227061424.1135505-1-ethantidmore06@gmail.com> References: <20260227061424.1135505-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Resolve every checkpatch error in the driver. Signed-off-by: Ethan Tidmore --- drivers/iio/filter/admv8818.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c index 2d12700d717f..1af263007322 100644 --- a/drivers/iio/filter/admv8818.c +++ b/drivers/iio/filter/admv8818.c @@ -240,7 +240,6 @@ static int __admv8818_lpf_select(struct admv8818_state = *st, u64 freq) freq_step =3D div_u64(freq_step, ADMV8818_NUM_STATES - 1); =20 for (state =3D ADMV8818_STATE_MAX; state >=3D ADMV8818_STATE_MIN; --stat= e) { - freq_corner =3D freq_range_lpf[band][ADMV8818_BAND_CORNER_LOW] + state * freq_step; =20 @@ -385,8 +384,8 @@ static int admv8818_read_lpf_freq(struct admv8818_state= *st, u64 *lpf_freq) } =20 static int admv8818_write_raw_get_fmt(struct iio_dev *indio_dev, - struct iio_chan_spec const *chan, - long mask) + struct iio_chan_spec const *chan, + long mask) { switch (mask) { case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY: @@ -722,7 +721,6 @@ static int admv8818_read_properties(struct admv8818_sta= te *st) else return ret; =20 - ret =3D device_property_read_u32(&spi->dev, "adi,hpf-margin-mhz", &mhz); if (ret =3D=3D 0) st->hpf_margin_hz =3D (u64)mhz * HZ_PER_MHZ; --=20 2.53.0