From nobody Tue Apr 7 17:12:32 2026 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D7E33AEF3D for ; Fri, 27 Feb 2026 05:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772170928; cv=none; b=dKdwWNop+5uV0ZFoe7N/oRRAsCoNNkACAOT85sF6yTIrKrvgwNdt4b7ZHjbYf9SCZmLl1DpPNefjTgMDsndrMIFtqqN1O/JBrFaLV5lHH813tf+lZK69V+zvFGhXFHWnWTSApdbfhob7xqfG4271FZ16B7Ujd7woYV4/be6MND4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772170928; c=relaxed/simple; bh=zmsupM9VegvhsjdSykGaYxxnPjKeCboE0a5qziv32gs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YEtur9b8ZEta12R+iV0VARn6+RP9WdUGIpcAOsoOXcS+cvNyUuP60AMx3V7WOT+7czd3x5v7VrsgEh5T9wfNGtFmyruWe7wjVccYsZQyO7ukNI2dSa4fzv9qzAP2DHHznZg7eE3WrylNreI6BdrjEnsdSAw8AhBsCOYRAHuLA7I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NakF4s/7; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NakF4s/7" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-506aa68065eso18212411cf.1 for ; Thu, 26 Feb 2026 21:42:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772170926; x=1772775726; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ssq9TpzF8ZsuA3Ephf3zMm3UiGyLwWJ1+YlM8IprLC8=; b=NakF4s/7x/FQEbdrJiONTbvzdb6zlktBDCtm8zivK/z+uN2Zp+xaw6wCftCPlpRZdm T1lSvF63CtdKhZw+VthjNxDZXupMFN5eGK49U02SkInrNaTWikwJpsmXKUbvnrsg2M7l VQPN8xdVgPqDp/HJewj6P9nsux0XAZLNvEUlBtBEDHoo2/FMT4zC1CURcg9DG20z743a Z3sbCKdl5vKWl3XMsOyDcYvTAolOcSMJISz3US3A/rk+yc2kvu+eWCZFoP9b30DYP9qB 6CUfZXwN7XDCWQT3EAVlxt1/cZQmXoSkJ/mYTOR2ptqbMS/0HeSsH1yhqiEh1zWbKDh0 oPeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772170926; x=1772775726; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ssq9TpzF8ZsuA3Ephf3zMm3UiGyLwWJ1+YlM8IprLC8=; b=SKmcsFweKDYD0bDmckqahh2ZocBubnqFt+WXQf25J/H8cFQ6AaP61p8jokZqCnBjQi 5kBOW+ed2nz5lAC6fRScjS/ur5nWCe7wVax+VHrly09gllYLBlM8tu9cTsymScOMyDdD AC2LODbOpOv5TYgUbAlIv+1BlUnWmc53Vzu/+l3guyDXbw/t6e4Os4cffMIDJrM+xAyU baTZNl/7sXIDHpb7NfhiLMCSUN3gKkSwfNCcqkU+Vru0STicX+mvgFQ10/uR1xppvRng STuiTZOPziap41AjsdGBuR2KbdRF+cHeH6Ta6VdtTOX89CaOC4GzR3BSfF86n9wcgQV5 MBNA== X-Forwarded-Encrypted: i=1; AJvYcCWtMbsONvRyqSz3NllarRlmlieIOYBS5OcgTzJax+eYAEC/jupmjLELjbXMSANFFMK5AEHkKVQuIjEyhVE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/OIzMqa8OBZ19YkiCA/d8wQSiSm9cD3wB+Cywg0gbBQZaFCA/ PWYASTqVz56Y79X7W232o/arXSavXMd/wP8cNj2576gOM868eOGSqgR1 X-Gm-Gg: ATEYQzyHFJqtF1zQRT/DSc312AAMocnwJU9KyKS9eVtlGDxQJ5AY2SguBMk4MbutAKL H9KqKr/LVdnPAqBy8opxGlkg1XDVkGdvBpmek1MO446SUOpjLH+p5ZqrfvHi/88gnZOa2RWOgcV oNM4O2jrfmYVRsXUgogpLALYSB/zFOz407C1FVSs2lcouhyQxTG+9a5m6Gpkk7BD5TmQaVO22Gi 03yrxGpd8SG5VrAkTYsNf1oIAVsJIEW2571/o80fPmLrhCoyBf//+rNWcUHttbO9kT50nn0uDl/ OK5Q3hUeaByvdIANIpCIFceMwz3m09sDE1yYX6JyVKjMDDNu9YL4v4p3GI9P9TEe03CZKt7UCRZ ylF0juaSMsSKnvMrk03nffag79ETQLcUTiFCPLgxgMOlMVjXF8cZ0p2Hdkzb9o45Cf62uHvtULu 5UagXFkGp5Tznmkctkr83r7ZfEBXyPHSRrIlTljN6jTYlxM5GM+PhP6QeIR8vttsNutLby3n09k FNW X-Received: by 2002:a05:622a:1445:b0:506:9a89:5f49 with SMTP id d75a77b69052e-507529b830fmr16212931cf.50.1772170925996; Thu, 26 Feb 2026 21:42:05 -0800 (PST) Received: from NIKUNJ.localdomain (pool-96-240-15-29.nwrknj.fios.verizon.net. [96.240.15.29]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50744ab3d88sm40345961cf.21.2026.02.26.21.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 21:42:05 -0800 (PST) From: techy-Nik To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, techy-Nik Subject: [PATCH] staging: rtl8723bs: remove RTL8188E references Date: Fri, 27 Feb 2026 00:41:45 -0500 Message-ID: <20260227054145.2261768-1-niktechgig@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove all references to RTL8188E chip from the driver code. This includes renaming variables, deleting unused macros and struct members, and updating comments to reflect that this driver is specifically for RTL8723BS. This addresses the TODO item to remove leftover code for other chips. Signed-off-by: techy-Nik --- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 16 ++++++++-------- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h | 2 +- drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c | 2 +- drivers/staging/rtl8723bs/hal/odm.h | 3 --- drivers/staging/rtl8723bs/include/hal_com_reg.h | 4 ++-- drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 4 +++- 6 files changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.c index 9df3274c1..f2e19e044 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -23,14 +23,14 @@ =20 /*---------------------------Define Local Constant------------------------= ---*/ =20 -/* In the case that we fail to read TxPowerTrack.txt, we use the table for - * 88E as the default table. +/* In the case that we fail to read TxPowerTrack.txt, we use the default + * delta swing table. */ -static u8 DeltaSwingTableIdx_2GA_N_8188E[] =3D { +static u8 DeltaSwingTableIdx_2GA_N_8723B[] =3D { 0, 0, 0, 2, 2, 3, 3, 4, 4, 4, 4, 5, 5, 6, 6, 7, 7, 7, 7, 8, 8, 9, 9, 10, 10, 10, 11, 11, 11, 11 }; -static u8 DeltaSwingTableIdx_2GA_P_8188E[] =3D { +static u8 DeltaSwingTableIdx_2GA_P_8723B[] =3D { 0, 0, 0, 0, 1, 1, 2, 2, 3, 3, 4, 4, 4, 4, 4, 4, 4, 4, 5, 5, 7, 7, 8, 8, 8, 9, 9, 9, 9, 9 }; @@ -326,10 +326,10 @@ static void GetDeltaSwingTable_8723B( *TemperatureDOWN_B =3D pRFCalibrateInfo->DeltaSwingTableIdx_2GB_N; } } else { - *TemperatureUP_A =3D (u8 *)DeltaSwingTableIdx_2GA_P_8188E; - *TemperatureDOWN_A =3D (u8 *)DeltaSwingTableIdx_2GA_N_8188E; - *TemperatureUP_B =3D (u8 *)DeltaSwingTableIdx_2GA_P_8188E; - *TemperatureDOWN_B =3D (u8 *)DeltaSwingTableIdx_2GA_N_8188E; + *TemperatureUP_A =3D (u8 *)DeltaSwingTableIdx_2GA_P_8723B; + *TemperatureDOWN_A =3D (u8 *)DeltaSwingTableIdx_2GA_N_8723B; + *TemperatureUP_B =3D (u8 *)DeltaSwingTableIdx_2GA_P_8723B; + *TemperatureDOWN_B =3D (u8 *)DeltaSwingTableIdx_2GA_N_8723B; } } =20 diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.h index c83442917..a21764adb 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h @@ -65,4 +65,4 @@ void _PHY_MACSettingCalibration_8723B( struct adapter *padapter, u32 *MACReg, u32 *MACBackup ); =20 -#endif /* #ifndef __HAL_PHY_RF_8188E_H__ */ +#endif /* #ifndef __HAL_PHY_RF_8723B_H__ */ diff --git a/drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c b/drivers/staging= /rtl8723bs/hal/HalPwrSeqCmd.c index 86404b5e6..7f57ae017 100644 --- a/drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c +++ b/drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c @@ -26,7 +26,7 @@ Major Change History: =20 /* */ /* Description: */ -/* This routine deal with the Power Configuration CMDs parsing for RTL872= 3/RTL8188E Series IC. */ +/* This routine deals with the Power Configuration CMDs parsing for RTL87= 23 Series IC. */ /* */ /* Assumption: */ /* We should follow specific format which was released from HW SD. */ diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723b= s/hal/odm.h index 1c929d88e..c4fce230c 100644 --- a/drivers/staging/rtl8723bs/hal/odm.h +++ b/drivers/staging/rtl8723bs/hal/odm.h @@ -203,7 +203,6 @@ struct odm_rate_adaptive { /* Declare for common info */ /* */ #define MAX_PATH_NUM_92CS 2 -#define MAX_PATH_NUM_8188E 1 #define MAX_PATH_NUM_8192E 2 #define MAX_PATH_NUM_8723B 1 #define MAX_PATH_NUM_8812A 2 @@ -538,8 +537,6 @@ struct odm_rf_cal_t { /* ODM_RF_Calibration_Structure */ u8 DeltaSwingTableIdx_2GA_N[DELTA_SWINGIDX_SIZE]; u8 DeltaSwingTableIdx_2GB_P[DELTA_SWINGIDX_SIZE]; u8 DeltaSwingTableIdx_2GB_N[DELTA_SWINGIDX_SIZE]; - u8 DeltaSwingTableIdx_2GA_P_8188E[DELTA_SWINGIDX_SIZE]; - u8 DeltaSwingTableIdx_2GA_N_8188E[DELTA_SWINGIDX_SIZE]; =20 /* */ =20 diff --git a/drivers/staging/rtl8723bs/include/hal_com_reg.h b/drivers/stag= ing/rtl8723bs/include/hal_com_reg.h index cf5c15dc2..a1cfe2f7d 100644 --- a/drivers/staging/rtl8723bs/include/hal_com_reg.h +++ b/drivers/staging/rtl8723bs/include/hal_com_reg.h @@ -202,7 +202,7 @@ #define WCAMI REG_CAMWRITE /* Software write CAM input content */ =20 /* */ -/* 8723/8188E Host System Interrupt Status Register (offset 0x5C, 3= 2 byte) */ +/* 8723 Host System Interrupt Status Register (offset 0x5C, 32 byte= ) */ /* */ #define HSISR_GPIO12_0_INT BIT0 #define HSISR_SPS_OCP_INT BIT5 @@ -539,7 +539,7 @@ =20 #define SDIO_HIMR_DISABLED 0 =20 -/* RTL8723/RTL8188E SDIO Host Interrupt Mask Register */ +/* RTL8723 SDIO Host Interrupt Mask Register */ #define SDIO_HIMR_RX_REQUEST_MSK BIT0 #define SDIO_HIMR_AVAL_MSK BIT1 =20 diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/sta= ging/rtl8723bs/include/rtw_mlme_ext.h index afa5631a4..a8ebcb314 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h @@ -10,7 +10,9 @@ =20 /* Commented by Albert 20101105 */ /* Increase the SURVEY_TO value from 100 to 150 (100ms to 150ms) */ -/* The Realtek 8188CE SoftAP will spend around 100ms to send the probe re= sponse after receiving the probe request. */ +/* The Realtek SoftAP will spend around 100ms to send the probe response + * after receiving the probe request. + */ /* So, this driver tried to extend the dwell time for each scanning chann= el. */ /* This will increase the chance to receive the probe response from SoftA= P. */ =20 --=20 2.43.0