From nobody Tue Apr 7 19:02:35 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A0443DA7D7 for ; Fri, 27 Feb 2026 05:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772170411; cv=none; b=Lgvs3qvH0rHZnc4v/JvJ/5ys29aSP9qQK7V0QWo1IrO3J1taZ29X5zhg2IiPRU0el2nSMfv88w58TwrGfi0sEtO8qsT55M3HyJ2DH6f+7GQoQQ4fcitpkKYEFl870dB047Q6tfK4o/cEkAU4DhFAlPvENdpsT5njYiKUD9zOCJI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772170411; c=relaxed/simple; bh=sBdF7+0u19ZP3gybl8MNQCA85kIrnAKsI6e62lko7KQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lvK0cQG07oze9wHPeLiuXGmm7C5V9MAwNitZQGPWgeVZegoheGDSkJyBY+iiu0WneEHxouf1+JfUBBF/HOSVmp2PyGpg1skfkuOHgZthb5e93WQpFWXMnTeYUD/huqT5YmcjPo+YTxYA2N0EFXYGxqmUgpBc2jcVJm2Iv5B97f4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eu3G09PD; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eu3G09PD" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-82748095963so492013b3a.2 for ; Thu, 26 Feb 2026 21:33:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772170410; x=1772775210; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=feZZgyhgnxd2MB3vtB7LaA+CWft2WYSV7ZFSVYTIeiU=; b=eu3G09PDfZM/CBVYSo37kRoGQWlPRsP2wJQ+2n77iIRIKoaIRqCdEfrSsbKZ5GFR7q 188fJYw6BU4xOHz+C6a8jHt7EIKyQD4Oe6Z3Iu2GL+y1yko5dv/dFgojljI6IlwJsHqU 8VJHvMTB1+vGu6E32DOhqkSs+SuUL2H30AkBYEhI8PzuCdKzeNNCEBulnJweM7VzQg9U bjkKQ9MA2lXhSFbM1SM1hcPuWE3Na+a9VAyqNMpjYU0WT7ryKNSc36C7IkFPAXNje3sh Xrjpwuwn7AHfqBsUc59XgVdy90vHEHxJpmOTmiSqBHWyA6iyum2enJOWImoVKvUQ/A7E skmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772170410; x=1772775210; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=feZZgyhgnxd2MB3vtB7LaA+CWft2WYSV7ZFSVYTIeiU=; b=WPUggnTXld7SyIFMdFzRkzU5wzBmU7JFTKWADiGuxDfZ6uEnNvlBsnwjtHnV3eQ9hp mTZkgT1jdUEwGNeCYjZZsOXq/T749d9MNconvN4gUL6iQ0BE0n564Lv7SpmBRdcOvkey h3Y6enzEqP4Y4Xh6wW/fYR5mbPRN0dkbtaoofpa017rcvzeUXfwO+hxhOBZNXrDnqlQ9 na7JYmyC7QiUzN5ZvCH6ArMMl+EI5xoO/IFDuMyPhOoa+O5N3+lHWGO5LksxnleMZiZ3 sMKXUsHqZGF89/Jq7gFeF94eQsjEkf0u2A739v4Ht29sKL36cBvSsDe3gcJyNa0tztjQ RHPw== X-Forwarded-Encrypted: i=1; AJvYcCXoP5WReDGcEHxHDFYTPWcXexSY1bq+6slXRx+fzpM2d1Wd9H8+iScxfeL3dovohe5ACPY58BQkxnmScjw=@vger.kernel.org X-Gm-Message-State: AOJu0YwKQX+1o2fW3MYGjz0rGLw5heNYyE8rkD19swEcCbGbCpcjmBzh yq1SMqa9uAevQEYTEouGJJaeKR8JuNBnQbqiPFWI4d2WZsZ1MTBjpVRU X-Gm-Gg: ATEYQzw7OOLlZXtXzVZn0MNa9c8o9h3c41gpoEc4L6E9dJCNEdP6NwZCNWdIX2XzA67 qd7Ntvugg5gVeWUGrbhywBHjmMtf8mStMnRfNFEDdfL1FQvApcKMy9RmsEAPCsIFuDmCG6Bmv5e mSg0KmwMrRzNGn0Aw/ymaG4DZRMTuUnWCrTEITZKhtfijkbi8V8ZqPoY6pRPhr8YwnPB6rZqml+ jGHu1nlMV405950HHLQNQgQMvuMNoZlFJbZKJTDqlkQ42tHLMbUAMUSUdfJbB1Yp36ZN63IqiL+ 67CTeC91PyHnLyM8bPbQHSoiBLs9WufiG9rI3CG0nsyyM9IYwn9SmdbfOLgl/81Tvbp9JKXg4Uo 6WOg8V1WaJzxXVV4wHggGvifpjGG8hYAgIPaL20o88A/BTxeCmuqEEytWePBVjShMnpLlOYwpOo SRdmNoAk58TzGIQ0/f9KsHcf9yBqOr477tRVBperUUB6fbhK/4Gw== X-Received: by 2002:a05:6a00:4c84:b0:824:9451:c1e2 with SMTP id d2e1a72fcca58-8274da275b4mr1328637b3a.59.1772170409864; Thu, 26 Feb 2026 21:33:29 -0800 (PST) Received: from name2965-Precision-7820-Tower.. ([175.201.112.127]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a048615sm3815828b3a.52.2026.02.26.21.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 21:33:29 -0800 (PST) From: Jeongjun Park To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Alim Akhtar , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Jeongjun Park Subject: [PATCH 6.1.y 5.15.y 5.10.y 3/3] drm/exynos: vidi: use ctx->lock to protect struct vidi_context member variables related to memory alloc/free Date: Fri, 27 Feb 2026 14:33:17 +0900 Message-Id: <20260227053317.426000-4-aha310510@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260227053317.426000-1-aha310510@gmail.com> References: <20260227053317.426000-1-aha310510@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" [ Upstream commit 52b330799e2d6f825ae2bb74662ec1b10eb954bb ] Exynos Virtual Display driver performs memory alloc/free operations without lock protection, which easily causes concurrency problem. For example, use-after-free can occur in race scenario like this: ``` CPU0 CPU1 CPU2 ---- ---- ---- vidi_connection_ioctl() if (vidi->connection) // true drm_edid =3D drm_edid_alloc(); // alloc drm_edid ... ctx->raw_edid =3D drm_edid; ... drm_mode_getconnector() drm_helper_probe_single_connector_modes() vidi_get_modes() if (ctx->raw_edid) // true drm_edid_dup(ctx->raw_edid); if (!drm_edid) // false ... vidi_connection_ioctl() if (vidi->connection) // false drm_edid_free(ctx->raw_edid); // free drm_edid ... drm_edid_alloc(drm_edid->edid) kmemdup(edid); // UAF!! ... ``` To prevent these vulns, at least in vidi_context, member variables related to memory alloc/free should be protected with ctx->lock. Cc: Signed-off-by: Jeongjun Park --- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 43 +++++++++++++++++++----- 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exy= nos/exynos_drm_vidi.c index 576d79ebe9a8..b7eae2469b31 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -186,15 +186,17 @@ static ssize_t vidi_store_connection(struct device *d= ev, const char *buf, size_t len) { struct vidi_context *ctx =3D dev_get_drvdata(dev); - int ret; + int ret, new_connected; =20 - ret =3D kstrtoint(buf, 0, &ctx->connected); + ret =3D kstrtoint(buf, 0, &new_connected); if (ret) return ret; =20 - if (ctx->connected > 1) + if (new_connected > 1) return -EINVAL; =20 + mutex_lock(&ctx->lock); + /* use fake edid data for test. */ if (!ctx->raw_edid) ctx->raw_edid =3D (struct edid *)fake_edid_info; @@ -202,14 +204,21 @@ static ssize_t vidi_store_connection(struct device *d= ev, /* if raw_edid isn't same as fake data then it can't be tested. */ if (ctx->raw_edid !=3D (struct edid *)fake_edid_info) { DRM_DEV_DEBUG_KMS(dev, "edid data is not fake data.\n"); - return -EINVAL; + ret =3D -EINVAL; + goto fail; } =20 + ctx->connected =3D new_connected; + mutex_unlock(&ctx->lock); + DRM_DEV_DEBUG_KMS(dev, "requested connection.\n"); =20 drm_helper_hpd_irq_event(ctx->drm_dev); =20 return len; +fail: + mutex_unlock(&ctx->lock); + return ret; } =20 static DEVICE_ATTR(connection, 0644, vidi_show_connection, @@ -244,11 +253,14 @@ int vidi_connection_ioctl(struct drm_device *drm_dev,= void *data, return -EINVAL; } =20 + mutex_lock(&ctx->lock); if (ctx->connected =3D=3D vidi->connection) { + mutex_unlock(&ctx->lock); DRM_DEV_DEBUG_KMS(ctx->dev, "same connection request.\n"); return -EINVAL; } + mutex_unlock(&ctx->lock); =20 if (vidi->connection) { struct edid *raw_edid; @@ -271,20 +283,27 @@ int vidi_connection_ioctl(struct drm_device *drm_dev,= void *data, "failed to allocate raw_edid.\n"); return -ENOMEM; } + mutex_lock(&ctx->lock); ctx->raw_edid =3D raw_edid; + mutex_unlock(&ctx->lock); } else { /* * with connection =3D 0, free raw_edid * only if raw edid data isn't same as fake data. */ + mutex_lock(&ctx->lock); if (ctx->raw_edid && ctx->raw_edid !=3D (struct edid *)fake_edid_info) { kfree(ctx->raw_edid); ctx->raw_edid =3D NULL; } + mutex_unlock(&ctx->lock); } =20 + mutex_lock(&ctx->lock); ctx->connected =3D vidi->connection; + mutex_unlock(&ctx->lock); + drm_helper_hpd_irq_event(ctx->drm_dev); =20 return 0; @@ -299,7 +318,7 @@ static enum drm_connector_status vidi_detect(struct drm= _connector *connector, * connection request would come from user side * to do hotplug through specific ioctl. */ - return ctx->connected ? connector_status_connected : + return READ_ONCE(ctx->connected) ? connector_status_connected : connector_status_disconnected; } =20 @@ -321,22 +340,24 @@ static int vidi_get_modes(struct drm_connector *conne= ctor) struct vidi_context *ctx =3D ctx_from_connector(connector); struct edid *edid; int edid_len; - int count; + int count =3D 0; =20 /* * the edid data comes from user side and it would be set * to ctx->raw_edid through specific ioctl. */ + + mutex_lock(&ctx->lock); if (!ctx->raw_edid) { DRM_DEV_DEBUG_KMS(ctx->dev, "raw_edid is null.\n"); - return 0; + goto fail; } =20 edid_len =3D (1 + ctx->raw_edid->extensions) * EDID_LENGTH; edid =3D kmemdup(ctx->raw_edid, edid_len, GFP_KERNEL); if (!edid) { DRM_DEV_DEBUG_KMS(ctx->dev, "failed to allocate edid\n"); - return 0; + goto fail; } =20 drm_connector_update_edid_property(connector, edid); @@ -345,6 +366,8 @@ static int vidi_get_modes(struct drm_connector *connect= or) =20 kfree(edid); =20 +fail: + mutex_unlock(&ctx->lock); return count; } =20 @@ -490,11 +513,15 @@ static int vidi_remove(struct platform_device *pdev) { struct vidi_context *ctx =3D platform_get_drvdata(pdev); =20 + mutex_lock(&ctx->lock); + if (ctx->raw_edid !=3D (struct edid *)fake_edid_info) { kfree(ctx->raw_edid); ctx->raw_edid =3D NULL; } =20 + mutex_unlock(&ctx->lock); + component_del(&pdev->dev, &vidi_component_ops); =20 return 0; --