From nobody Tue Apr 7 18:51:41 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 370CF3D9047 for ; Fri, 27 Feb 2026 05:33:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772170406; cv=none; b=pbxmmACZWRGFv1AdnPXbCLMkwyGpxWNBAkC+ItXJX5jQ225pWlaLyuy2cXaCzruxHL2Max8MBnZpsiNQkcnhm9wec9+yDE0022r0AfXU6FsqBGshUUbCutYZe0ri/cuR9loWeQOYWSZolIJhIzlVzxvLbNhp5M4fsFDnnWGhiDw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772170406; c=relaxed/simple; bh=b9b22Ozhvo19VJujzVT1horPbr1WA97i8oWgfeEATgg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KBGrxis+uEWQAUjVKNcORd5QG1LScxRM36v6bMbzigcQynkDUa+afZ/NDQy2hbEQWlG+Io63K0xCBa5cFxnvq3KWj+mUzat+4+nx/3vEiiZbdiZI4rfORchbElGr/b1NfgjvH/mGTYwVc/MPxD0fJ9CNiTdf5XA9jLvUA5CYT5c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jo3uANIK; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jo3uANIK" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-82735a41920so674127b3a.2 for ; Thu, 26 Feb 2026 21:33:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772170404; x=1772775204; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kWzBer8K/lUNOlKz33ehPBmEnMKwxXodb/hUWZrwOGc=; b=jo3uANIKQqy4fRyqLKWxjo/tW4WyzQo0WjSg5vfDfuQrKOOnUJzS4cSv0cAgh2/oRr O/5yed+Gwt8Vto3PJfHuCYd0lkHR1eqFVRYt2nG8VC+YHaqV0SVRkR3UVKIDa7fDWDF7 7vcxah+vuuuji5ENOl2H6O9Yf7ZBuomshJkuxj1aUX0CU1vMUEcoQ1J5jaP4hEXQt+uK eSJefHQS6LBQ7GhRu0McxTAblNFnJM+afRqssQqrSUdpHd03++0m1rgu32qbhxRLEcs8 n6BopYEfse4+Nuw71VVrJgksuoeDZ1kGBDcK3RXPRp/oSiQHr4KVgfnSWLOGoz6MpYLJ 7CBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772170404; x=1772775204; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kWzBer8K/lUNOlKz33ehPBmEnMKwxXodb/hUWZrwOGc=; b=DgP4NS9gDvjkjvWSn6T1devSnG0fo1RHqGeeJgZYxD6DfNhP4nS0du36NQZ0HzcQDu mLFU77abpHB/ICM8GV56uaOEPKK9J+JOIeZ3YHd+EkKAMAL5PoMPkOe+mueSIaGXChwW pCoZNiPgp0sfGb0mX3p6dD8gIQmjvI4Gv6KNiHS/edsQyjNb06wtcrp5oXgQyq2wnEvv jDD1dSOZlrdXDsTkRkm4OEhhtLymC7NkAqx0bzJONbr7BuSXdDn/BziS77Th9Q+GW6VM C2UXLV+zNz/5eRs7RoQ1y8vOsDaZLQMb6/6y4HMlzCvDrd64G/VXwtwFd+SZaw7LjwtF Kudw== X-Forwarded-Encrypted: i=1; AJvYcCUzQ6s/PhvKCIiDa7B019N/8m1DVIyLOcPds1KwNrXgn0Un4iW3kJVTLv7+yBqxfuM4XISwccPwT99aoDo=@vger.kernel.org X-Gm-Message-State: AOJu0YxUfMXJUiVkVBis0HH+RK0OJUIFC41edixTLqGCu648FCxD0ALV NC5FdTpUuayLZ6lUNvDbytGjYAsYRpQAEeFCA9LJ6tLoFGZBN8mJIilI X-Gm-Gg: ATEYQzwCqPj6TE2gP3c3pUFVAUXWqdllJo1gbFsjU35dOL1JaitvROeIJltWw4h+D/C b52jZgHNesyTvgrW5XCIPVwdEOKrkam/x9KQhQIpLWTJOny/TmVt3LNmFfx7nNIBFFb6arB4vRx cuYDCXgw1jvRFLwQF8PFpvijNMeVTZiecGYubGuIl52j45JYA/9WHtNAY5FFK40WEXzpTYUpnB0 c+6odTvK7FDYofzAs8xnpcWs+q6RBYztV7X3IddSt97ddef5Rkr4Hgb8RYOjIQQ1qtNPmgLvkRH 5zQ7efPvtEWnIp60LsB9uBKcgeczng+wlVhHUGG6iyBOnCZMxm6lcwI3d3pClQaCAwrFgAZyDpP x+cZQ7UatsbzJkgGSEROKgXlGJqhvYuPctorFJ8EzSs7r/vzxwYPb5AKro8tb5RHw0EfSO0KejQ 0oibSnXdDYYMlJ5c4BalalZnw8FJB0+GZb8RXSYqsWJb7g6DBwlQ== X-Received: by 2002:a05:6a00:2d11:b0:824:16ae:9ec4 with SMTP id d2e1a72fcca58-8274da248famr1742089b3a.63.1772170404587; Thu, 26 Feb 2026 21:33:24 -0800 (PST) Received: from name2965-Precision-7820-Tower.. ([175.201.112.127]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a048615sm3815828b3a.52.2026.02.26.21.33.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 21:33:24 -0800 (PST) From: Jeongjun Park To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Alim Akhtar , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Jeongjun Park Subject: [PATCH 6.1.y 5.15.y 5.10.y 1/3] drm/exynos: vidi: use priv->vidi_dev for ctx lookup in vidi_connection_ioctl() Date: Fri, 27 Feb 2026 14:33:15 +0900 Message-Id: <20260227053317.426000-2-aha310510@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260227053317.426000-1-aha310510@gmail.com> References: <20260227053317.426000-1-aha310510@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" [ Upstream commit d3968a0d85b211e197f2f4f06268a7031079e0d0 ] vidi_connection_ioctl() retrieves the driver_data from drm_dev->dev to obtain a struct vidi_context pointer. However, drm_dev->dev is the exynos-drm master device, and the driver_data contained therein is not the vidi component device, but a completely different device. This can lead to various bugs, ranging from null pointer dereferences and garbage value accesses to, in unlucky cases, out-of-bounds errors, use-after-free errors, and more. To resolve this issue, we need to store/delete the vidi device pointer in exynos_drm_private->vidi_dev during bind/unbind, and then read this exynos_drm_private->vidi_dev within ioctl() to obtain the correct struct vidi_context pointer. Cc: Signed-off-by: Jeongjun Park Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 1 + drivers/gpu/drm/exynos/exynos_drm_vidi.c | 14 +++++++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exyn= os/exynos_drm_drv.h index 23646e55f142..06c29ff2aac0 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h @@ -199,6 +199,7 @@ struct drm_exynos_file_private { struct exynos_drm_private { struct device *g2d_dev; struct device *dma_dev; + struct device *vidi_dev; void *mapping; =20 /* for atomic commit */ diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu/drm/exy= nos/exynos_drm_vidi.c index 6de0cced6c9d..b31eefb3a8b1 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c @@ -223,9 +223,14 @@ ATTRIBUTE_GROUPS(vidi); int vidi_connection_ioctl(struct drm_device *drm_dev, void *data, struct drm_file *file_priv) { - struct vidi_context *ctx =3D dev_get_drvdata(drm_dev->dev); + struct exynos_drm_private *priv =3D drm_dev->dev_private; + struct device *dev =3D priv ? priv->vidi_dev : NULL; + struct vidi_context *ctx =3D dev ? dev_get_drvdata(dev) : NULL; struct drm_exynos_vidi_connection *vidi =3D data; =20 + if (!ctx) + return -ENODEV; + if (!vidi) { DRM_DEV_DEBUG_KMS(ctx->dev, "user data for vidi is null.\n"); @@ -374,6 +379,7 @@ static int vidi_bind(struct device *dev, struct device = *master, void *data) { struct vidi_context *ctx =3D dev_get_drvdata(dev); struct drm_device *drm_dev =3D data; + struct exynos_drm_private *priv =3D drm_dev->dev_private; struct drm_encoder *encoder =3D &ctx->encoder; struct exynos_drm_plane *exynos_plane; struct exynos_drm_plane_config plane_config =3D { 0 }; @@ -381,6 +387,8 @@ static int vidi_bind(struct device *dev, struct device = *master, void *data) int ret; =20 ctx->drm_dev =3D drm_dev; + if (priv) + priv->vidi_dev =3D dev; =20 plane_config.pixel_formats =3D formats; plane_config.num_pixel_formats =3D ARRAY_SIZE(formats); @@ -426,8 +434,12 @@ static int vidi_bind(struct device *dev, struct device= *master, void *data) static void vidi_unbind(struct device *dev, struct device *master, void *d= ata) { struct vidi_context *ctx =3D dev_get_drvdata(dev); + struct drm_device *drm_dev =3D data; + struct exynos_drm_private *priv =3D drm_dev->dev_private; =20 del_timer_sync(&ctx->timer); + if (priv) + priv->vidi_dev =3D NULL; } =20 static const struct component_ops vidi_component_ops =3D { --