From nobody Tue Apr 7 17:15:07 2026 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3D5D25B1CB for ; Fri, 27 Feb 2026 01:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772156672; cv=none; b=jg7+PgyrhGBorhRd7vEusW0pu2xWf+4+9Pi4zj5cqSJ8dFBJkEqrZh8N3RX+rcJSHhFGk4LHXCGFI/+uha+rWGjrXKVmSz+C/npKz+c/nj7P9IBAOim9H24tU9Y8k9M7UgDm6FoyDHsfaSYdORQ9K0TAsj7apQJ/AYM80VIXvUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772156672; c=relaxed/simple; bh=GpDeRFp88gB3TzbvcHymbD1YAVT9F+FtecKEf2Gc/lg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=cveypp7doH5hgyyKV5K0CdPeHq2rjMaenlhmJF5WQ8ffveFUGeo7FJtmc1RGcX8mz/m16hify7Qngm2P1aN8banuyQu8SmD1s79hME7byBLi371R5FAcKwekyTncNTPHLSbVlpDGq4Q6jm/fPYFukPeSvTA30aYegEd2Jb+uyWg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost (unknown [124.16.138.129]) by APP-03 (Coremail) with SMTP id rQCowAD3Ednv9qBpIP9iCQ--.42639S2; Fri, 27 Feb 2026 09:44:15 +0800 (CST) From: Chen Ni To: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Cc: linusw@kernel.org, bbrezillon@kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Chen Ni Subject: [PATCH] mtd: physmap_of_gemini: Fix disabled pinctrl state check Date: Fri, 27 Feb 2026 09:43:36 +0800 Message-Id: <20260227014337.3938091-1-nichen@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowAD3Ednv9qBpIP9iCQ--.42639S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtF48tw1fGFyfJry8Zw43Jrb_yoWkurb_Ca 17ZFs2qr15WFZFvF1Igr40va409ayj9F18ur48X398t34UJrWjqayqv3y3Cr18Xr45KF9x Gw13Xr1Y9wsIyjkaLaAFLSUrUUUUbb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbs8FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26F4UJV W0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY1x0262kKe7AKxVWU tVW8ZwCY02Avz4vE14v_KwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw C20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAF wI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjx v20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2 jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43 ZEXa7VU1xu4UUUUUU== X-CM-SenderInfo: xqlfxv3q6l2u1dvotugofq/ Content-Type: text/plain; charset="utf-8" The condition for checking the disabled pinctrl state incorrectly checks gf->enabled_state instead of gf->disabled_state. This causes misleading error messages and could lead to incorrect behavior when only one of the pinctrl states is defined. Fix the condition to properly check gf->disabled_state. Fixes: 9d3b5086f6d4 ("mtd: physmap_of_gemini: Handle pin control") Signed-off-by: Chen Ni Reviewed-by: Linus Walleij --- drivers/mtd/maps/physmap-gemini.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/maps/physmap-gemini.c b/drivers/mtd/maps/physmap-g= emini.c index 9d3b4bf84a1a..1c34b4ef77ea 100644 --- a/drivers/mtd/maps/physmap-gemini.c +++ b/drivers/mtd/maps/physmap-gemini.c @@ -181,7 +181,7 @@ int of_flash_probe_gemini(struct platform_device *pdev, dev_err(dev, "no enabled pin control state\n"); =20 gf->disabled_state =3D pinctrl_lookup_state(gf->p, "disabled"); - if (IS_ERR(gf->enabled_state)) { + if (IS_ERR(gf->disabled_state)) { dev_err(dev, "no disabled pin control state\n"); } else { ret =3D pinctrl_select_state(gf->p, gf->disabled_state); --=20 2.25.1