From nobody Tue Apr 7 18:46:40 2026 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011070.outbound.protection.outlook.com [52.101.65.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA26F3815E6; Fri, 27 Feb 2026 08:16:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772180221; cv=fail; b=V7Jmf2yjrNMcmbGtpxv+fMZgn/968iO0JiRnCLa0RQfQPx/x/qLI8ABP9LV8B/vwxHo1SuYN+YTVQzsJDx9cMTz/6zboCbi7btTKreHuDg53ePMch8oqEateTq1y5lLaWmSJ3XKLANRKpvXzrICcwSR1MoelLN5onF92P3DybLg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772180221; c=relaxed/simple; bh=Bc8cKQRPp8xNJe4QKR/tlcKnkBCrkYlYrKRfpIsyehI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=GNUkz8PND+JR64Rsw9V5MBEASMuT8HxAJMtDobrVo5AGZf0gP9G6R4j4lQNyAe8svDkIB+YbDqF5kEPktOSxLf1jPH3zRDsRr2se0WCmSznAaoF5cKLPuReeJUq1hGQYNMf5/Uf63vD2lTdC1rVLy3IFOda6dvmcKRyewKTm5o4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=iAqhkAdH; arc=fail smtp.client-ip=52.101.65.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="iAqhkAdH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DlporNT964hqJR4w7j6zBILnP5jvjTiDRUFk7jAs8krAA6ko/5x7aMz858JdBmee1Iy2DWb2H1/lxx8HZizTfCjK0UVusS8kb9hIAI9WtMY+/IOYRL0gbzwwVRpPe/AGxxPbc2utZ8CBv+RcMOK4nZv6YFDcINrRihS3ZXqadt8h3hfrfAZigTgPXLgUnIth8qZRxNBX/kDwFW3fWXBYPqVpFHQaNmEpeyighK4tmIT2YSvPO/ImNj86mD/ZIAaRQy96lCrBxLR0nMkuQH/bC5KlfBcgJzH+T2ZykfLfh9Bwy5NJQ95AuHBCBGAXSlxC1tE186I6PwKR8rdfuHxFMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TDuz+0+fXtiXMhLkQDsLn5ADOOvybDDRWZlQ8c5E0MA=; b=gFHDJgyuIorU2LwZ46qRGGEAYsg/EsZN8HqaH400nAWGeH7HqaV3+igp3a7DCB3sKxkaS85qBDJt98KqPxmfVIRLpf3n86EyiEn/q6ANhgl+Fo4+wH9CCKblJSWLPjYWdu28R8fLmWDkvltEbxcjJicDHAAiLiaNdvVj53XJxgdo6bdHn2yd3aNUgW9jb3iQu/g5xqZVsBlcIc/DNTyMGYuLC8YcsH2hzq+FCSH0aqBI3NitzWw4qeoEGoD7rZQiurcigdQ1wwfIU1y8y4tNOqRsPEkTQIXjnaANk7WXc3XMJlX9/NaGmP7wfD8uUsq2323LBU/+Gbd27rAFiSdSyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TDuz+0+fXtiXMhLkQDsLn5ADOOvybDDRWZlQ8c5E0MA=; b=iAqhkAdHMMRJ69r/q3uS2uE2VRfs9CRoZ/70jw2+Vjk7veyHI9YuSBqkQ2vVSdHUNKQjQAYoWJUVpVjH6zdJFB0GVBKsp5qwxkiw1Ze0KnnvdSW8kOWL4vkVyepokX3v2p30TgKGmQrzFCh95WQZZoSTOU1p0lzz+6zPydsg9/Fddy5hBpwSp9AiUrmSGvRSi9SZc5q4xD8A1Tltor/4OAmef1iLosnNsM6VtC5awnxXNSNijvXPrzepDq2MyoVj9qvuHzXTc/x/bKHsrirUBBWutx9Q+ya+BxnzN9ds/+JEl4F44ZI7tls/3SIVgRWK2U3DMOExnm6en1vTivE0AA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8077.eurprd04.prod.outlook.com (2603:10a6:102:1c3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.13; Fri, 27 Feb 2026 08:16:56 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::4972:7eaa:b9f6:7b5e]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::4972:7eaa:b9f6:7b5e%7]) with mapi id 15.20.9632.017; Fri, 27 Feb 2026 08:16:56 +0000 From: "Peng Fan (OSS)" Date: Fri, 27 Feb 2026 16:18:20 +0800 Subject: [PATCH 1/3] NFS: flexfilelayout: return ERR_PTR from nfs4_ff_alloc_deviceid_node() and fix caller Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260227-nfs-v1-1-2a6ea2ca8528@nxp.com> References: <20260227-nfs-v1-0-2a6ea2ca8528@nxp.com> In-Reply-To: <20260227-nfs-v1-0-2a6ea2ca8528@nxp.com> To: Trond Myklebust , Anna Schumaker Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SG2PR02CA0098.apcprd02.prod.outlook.com (2603:1096:4:92::14) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: ea2baf6e-6f9d-4f36-5556-08de75d89257 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|19092799006|1800799024|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: KVa1VyD+COXTpVKZf0eigX8kI86WfLP7yxSqea0FUWq5foZG+dVsmE9cntOVhIEFNJ3KjqsXgLZ+iLTfEDaHpy+Og+fgEla7RjJc+Fhe9CnsKSyyuS1DG0d+koXO7LNMoF+nYbxpF5i3MYXW+cMepdDrdYOi8TNds2GK5tldCcCyoMzdQxN964j+7Wi/Jb5vb2KKqSJikIBbfqtJ58t8pufa1o7ZDHea8ldxi/fbGBD5ANhWVHg4mNWUZyf4KNlr5PepFeyDFr2moo8+saR4Cw0hFk/b10umVw0t2unmKY55tPRGFeQAypMcuUisZhetSSpa35bufg7VKFUiq0bGh7iIStHNVwOeVvqykRr/810GbcL1X88Lb83I1GOtvoeuWfqBTm7bwavlJQi1hrJe6qmI0GGiR1nLkSr3T6wCi2yvAfyyClHa4KTrZL7dz/epxJrgJ8uO4vhxeOIJz0Q9+ZUwIMwFaqYYKftRc+/cN7UQ58Acr+EGB4Bq3uT3WWX7BKC5FJrYteowSZX96Pm8PR0yzPk01QSbondm7QztJyN83WOs7TQQKHVjhUUI4T1TakStFDuHRXDuz5YzC5N5KKmMLtKMdsth9utkSDoBf0FEUYshGSsFM5fkgstKsQcmJWtHpKI9U4AlTfp7FVl2ziq/75o3qkVJoXoyI4FgdN04JdDfWNW/aTdHrz5fh+UiqGMHsoLhwd0EID37+G31NX5qxy2wwWGB2srjM7B1TuGpZzKWvYSmJjT8503YTJ/NTvDXp7j5IsIvWcrV1Ts5WqlOw07XWXBSK9HRLjnWuD0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(19092799006)(1800799024)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjZRLzM5cmIycmtsU1JDUzl0TWxGcGpONUZDWE1lYkNPZVBoYWxDcnpuclpS?= =?utf-8?B?V21NMVlsMXpJVHhDTVZJZGpGNGRuT1dEZlFvUXVCMEJIRnZZUi8wRTl0TURa?= =?utf-8?B?NUhBbVJhNXBaWE5sUkFPczJCZ200WXVxNVFURFhkcnF1WXdxMDlDaHI5azhU?= =?utf-8?B?UnhnaW4vT0d4d0JweiswWCtQd3BoTTd4VzNHK1RrTzRMU2lzMiszTWk0SWlz?= =?utf-8?B?ZHZOV2owU2V3OFBIVWxmeXhyWGloR1lTUGNxd2JrM21yQVBaOXZmcmRTL3p1?= =?utf-8?B?R1c1dmF5SFIyeFlUZ29mQ0Vyek5DWHVlUUE5SGcwSlB0bkxsYzVkT0NwNmxn?= =?utf-8?B?RDdNQ0VEQUdSc2NjVFI5TWg1UjNGSjFJTUJWNVdiNWJyN1gwZVp3ZlNPWXBx?= =?utf-8?B?YXI3T3dqNUJIdjhqWEF3RlNpcDB3aGRycGhMb04rTm1OWjhxcTF0clduUTVU?= =?utf-8?B?ODhXbEtFUmwxL1M1cDlqa2NteDNjdnJTQlNGcWRRVG9tRmZaUUJCU3BpMExF?= =?utf-8?B?TVplYmNlS0p5dEJGd0RBN2VJaS9jSnhpaTVUUUVzNEs3eUo4bXkvRDRJVFdz?= =?utf-8?B?WHd6bXU0blllMm05RlF5NHRNa0Ztenh6VEV3ZGZEV0pCR2dpMStRRWw0MkVR?= =?utf-8?B?VTk1bUhwV1FTRThSTEtlc0hiSElMcE5YM21Fbm1LNU14VjNIUHpDdCtWZzBW?= =?utf-8?B?MmpCaVF3NGp3UzUyV00zc0xBOTBtdld6b0ZwNm9BNUQ1REd1SGxuR1RBc0xZ?= =?utf-8?B?b21aYXY3WVA3ZVNNa2VrWHE2ODJzZzM5bndudTY0UGZ3VWp2aW9ENWNRVWc5?= =?utf-8?B?SGhhOFQ0eWkzVWxXV0xjWDA3YWpuTTZBQlFIVjVpT044b0lKallFNlUxMUJJ?= =?utf-8?B?Nmo2dHJyS1lid1FDdHFFK3RCUE9PcDFBdkV0OXVxaUc4ZHE3MitjN2VZU0kx?= =?utf-8?B?aVVzemk0ZTNDVEN6TWNTd3RoaS9leEw1OVQ5SzVONFNZZFhEVkFxMXc3MHR4?= =?utf-8?B?NTFqUnI5d01CMFE2Zk5RWXNnTzlQanBoMERIMnFwQUpSckFaZ2wzY3BBM1BO?= =?utf-8?B?TTd4MXB2aXNDWThvcHV6MmhIUWF2ek5ZNndrd3g0b3ZBY1h1N3U1STNiVDRV?= =?utf-8?B?akJtQXVwL05nVEpzLzhtc0RqU3Zvcmg0MS8wZzFhdk1uQUF0S2g2ek8vRnky?= =?utf-8?B?Mi9vby92VjZtS2c3eHNsT3lxQzRNV1V0MkRsQWhIQWRoa0xROFFvSlJjaDVw?= =?utf-8?B?R2p2UHpIQk9GejRteGk3SzZUdVZsT0J6ZWpoYThBZEQxMGFibTVwelFReG1B?= =?utf-8?B?eThzYythYUZpOFVYYUdkZkQ5aFJFVmZtdFhpQkJuY1FhczJNZjAwT3BWSHJ3?= =?utf-8?B?dDgwWFJ0OTlZTFRQZllaUnJ1VlJWQUtXL2g5MVZQTG0yY25HQVNPY3VoU2gw?= =?utf-8?B?WHA5MGVCQ3hsMHhqTDZXRUZlY0hVYTdUUFZUQmdraVpvN05BUXAveVVQL3Uv?= =?utf-8?B?SkN6ZTI4am5qUGJxRkhKRkU5cE9vVDllelNMdkdSbkUyc2cvUU9vOTJFWmM5?= =?utf-8?B?cHlSbkpxaWhuSDAzNXJNUmtnSFlncHAveGIvYjV0QWlZYUhSWnZmdGhEalVk?= =?utf-8?B?YS92bHVKZkpMTGxlYVh5clh4M0FtK2F2djVLanZySEdXMkVQM2Zva0RtcFBN?= =?utf-8?B?KzRNVTh2aCtnOUV6UXZJUW5SZGtIb1V3QVZJWGpwRzVlMzQ4OWJoQmNqQjcy?= =?utf-8?B?VXpDS0hBeW5wL0hveXhMN0R6elpIRW9WQm4zdVp3bWo3Mis0UlZpektlS3RV?= =?utf-8?B?c1YvUmx3TkZKTUM0TWxSQ3VXRUI3VlQzdGxEZmJKTFlYQzhuRnNlbm1EdXhh?= =?utf-8?B?amJSS2hCL3c0YzhaMUl6YS9Dby9KQkU3VkJ4THFJdllIdUJVZU5sVWNXSlJC?= =?utf-8?B?YXdFMy91RG1HbFIrb1hoU0RYME1PUG1NQ3VUZGNHQlRWTmxwZWl6YVlqSlIw?= =?utf-8?B?WHcwVTd0WmQ1dllOZXc4a3Y1U0FqZTZsbzBkdUwyd2RNb1dYRkp6dGhjdExo?= =?utf-8?B?cTZURk5HWUtQSmZGV0VheU9WK1pFS3hwaVpnUG1XeCt4aDBKb1JjUGN6cU1U?= =?utf-8?B?T3I5NEFJTVNlQm9MN0huWlFXRklnVkdldkNmNHhlb2h0cktZVzdvSForclpu?= =?utf-8?B?R211VG44Z1BjZ1JNeTRQL3lkRng1YjdVMnkzUmNVS0FoY08xK1ZBSFVOSWxl?= =?utf-8?B?OWEzMURXNk1qK1BIamtSZU9TUkEyNk9HQytGb1EzWHFiamV4WDNnM2NoRzJW?= =?utf-8?B?dTh3N252Sm5rSUFMMXpRVkljMTZXaS9pS3FrRHJtMVI3WVNXaTNoUT09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea2baf6e-6f9d-4f36-5556-08de75d89257 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2026 08:16:56.3561 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /odyWc8PfmpbgjpZqw0ItKDHPzMi7Hia8ZHsYSTxs5qqlJBux5tOKRjw/8xnjIFpdQqzq6KnqbeMxdjC2QsPWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8077 From: Peng Fan nfs4_ff_alloc_deviceid_node() initialized 'ret' but never returned it, triggering W=3D1: fs/nfs/flexfilelayout/flexfilelayoutdev.c:56:9: error: variable 'ret' set but not used [-Werror=3Dunused-but-set-variable] The function also returned NULL on error, dropping the specific errno stored in 'ret'. Convert it to return ERR_PTR(ret) instead, and update ff_layout_alloc_deviceid_node() to detect errors using IS_ERR(). This preserves the error code for callers and aligns the helper with common ERR_PTR-returning allocation patterns. It also resolves the build warning. No functional change for success paths; improves error reporting. Signed-off-by: Peng Fan --- fs/nfs/flexfilelayout/flexfilelayout.c | 2 +- fs/nfs/flexfilelayout/flexfilelayoutdev.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nfs/flexfilelayout/flexfilelayout.c b/fs/nfs/flexfilelayout= /flexfilelayout.c index f67773d52830d2ab4d12dd04caccc2077d4105e0..cd175204807600ff4e33ff769e0= 3ef7ac700a6dc 100644 --- a/fs/nfs/flexfilelayout/flexfilelayout.c +++ b/fs/nfs/flexfilelayout/flexfilelayout.c @@ -2566,7 +2566,7 @@ ff_layout_alloc_deviceid_node(struct nfs_server *serv= er, struct nfs4_ff_layout_ds *dsaddr; =20 dsaddr =3D nfs4_ff_alloc_deviceid_node(server, pdev, gfp_flags); - if (!dsaddr) + if (IS_ERR(dsaddr)) return NULL; return &dsaddr->id_node; } diff --git a/fs/nfs/flexfilelayout/flexfilelayoutdev.c b/fs/nfs/flexfilelay= out/flexfilelayoutdev.c index c40395ae081429f315ccee6b73eafc742b4f01a4..9e36350b10fa84d5e2a2e6f25fc= e36ed504285ce 100644 --- a/fs/nfs/flexfilelayout/flexfilelayoutdev.c +++ b/fs/nfs/flexfilelayout/flexfilelayoutdev.c @@ -181,7 +181,7 @@ nfs4_ff_alloc_deviceid_node(struct nfs_server *server, = struct pnfs_device *pdev, kfree(new_ds); =20 dprintk("%s ERROR: returning %d\n", __func__, ret); - return NULL; + return ERR_PTR(ret); } =20 static void extend_ds_error(struct nfs4_ff_layout_ds_err *err, --=20 2.37.1 From nobody Tue Apr 7 18:46:40 2026 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011017.outbound.protection.outlook.com [52.101.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F105438A702; Fri, 27 Feb 2026 08:17:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.17 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772180224; cv=fail; b=u35dMR1RBelw+3VURelRURGHUrEhLjv8jfzuEw4VWJal7MynYeVgCe0SrmDEA8HwuRTO9TLxdV5RGX7u5O2GVn2I6kHgxNJ5S1UpVUNXur6u/u2spgUBT52+9XbEowl2nBX0jh4zIiB8WB5nUkpsTh2+lX1RKvJJc1ILgmeL3Pk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772180224; c=relaxed/simple; bh=sTaJdrGelw3lG6J9HML12v/kq63zGeMxOkDG7gg/Mw0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=s4UpXDmnpEOERi70nJKFHVyNPOBnVnFRmoGNQsGOZ9tPuLZE0L2/iVihBS/466IEE7pQRVXPGLljMntEwShJ6vktK45KfMAJPBL12/tn518BBvIwZMdOuPpPCkZFlvqEjEp/mIm7hot0XAlWyNndIDfwF08IdpHrclSoCI25gmg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=jNPDtgUX; arc=fail smtp.client-ip=52.101.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="jNPDtgUX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ixgZyJqfqK5JoVWVkNRSBalapKeh/Qf7AWQFt1XjYSE6SxbjaiksPjL2KajU7BVntaNLSm77UQp7bYCN+Dtdt/tkqp3YneTM93R6q6y8L9J5HTCHB5wXwq5q0BzzYVV+P3z9H757Rt0SRyGer/VnaNXZVPfaOHA1iT/Gs8iOiIoU6dqPXso4zXR5lBRNii6e0QefJmJee7Sv5RjJ1v1oAfEAfNsCynKnjrHxvu8655tlu/nY6gYpuIReXGj9sth+2vSqWkg5BpgEccl6Zq2I5uaYVxSsOcrVuBWYcBjZ1t+VNuWA6XIMDjlq4+ukDcQTUrpHOWLFospQh14btqi1eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=emC8WAoHvIEAhVvf6AdKz1R6mVyEc8B/UFBqxTioe5I=; b=Ps9uQXI3WIaGWxu+y/cVe+stmg20QAx3vPj+CcUOxGGIfgz6zNopGaqC4SIkw8pT/InalDdwEI829kaZR9fmA+XbHQjEFPqIsZkO1CZ/nRGaPMCmaQRx6cE/Yti68oks7zrZZefb1zZisAkedMFwoCTuMldavU8s/SOqjqNIiVUIkasvjh/F54FQdApYrUiT19bAuanvEETQUrky1AJw6oc/oPSqb66+JLekTuUGtVNZ0fTrzMMQKHQugy3vFIeoqNXN4+n6cD6xyPIqetUtO03rFRU9uAaGZtJgk720AACYdZdcnf27p5AKrNPnaRRo61GpFKLVrPWr5nQo/is2mA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=emC8WAoHvIEAhVvf6AdKz1R6mVyEc8B/UFBqxTioe5I=; b=jNPDtgUXLF42GD53UvwelISymr+qT8MX29r/VqCEzw8Zz3RrosuHvhLYrLxLclTIodaYBI8oucWPLUB4CnocT3w5pcNDKWC99w0Qkimmfgui34zxn9OTyRLPWeiRvc17Yt40kHgxebX1azy168xdB+FVnt1L70xePwS/8WEsO+R6XPtRk62iQrXQQ1gSYdah+Ee9PVYlp646GyCfIxETQ+QOfpnyMYXk0sviR4anxIZuKylJg0GgCRvSf+9WCbp2+/OrBXGwKT6hC9G2v22N/S4qVOZVnRnCQRAvgu0pwveR2DaODdcKAofTaD/WGF1CgfnO0wNPfJHaClKW5BnyGA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8077.eurprd04.prod.outlook.com (2603:10a6:102:1c3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.13; Fri, 27 Feb 2026 08:16:59 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::4972:7eaa:b9f6:7b5e]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::4972:7eaa:b9f6:7b5e%7]) with mapi id 15.20.9632.017; Fri, 27 Feb 2026 08:16:58 +0000 From: "Peng Fan (OSS)" Date: Fri, 27 Feb 2026 16:18:21 +0800 Subject: [PATCH 2/3] NFS: flexfilelayout: Mark err as __maybe_unused in ff_layout_io_track_ds_error Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260227-nfs-v1-2-2a6ea2ca8528@nxp.com> References: <20260227-nfs-v1-0-2a6ea2ca8528@nxp.com> In-Reply-To: <20260227-nfs-v1-0-2a6ea2ca8528@nxp.com> To: Trond Myklebust , Anna Schumaker Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SG2PR02CA0098.apcprd02.prod.outlook.com (2603:1096:4:92::14) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: 1580dee8-b702-428d-43fc-08de75d893a1 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|19092799006|1800799024|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: HoYKxWEddC8ComNFqG8MzOgeBmoDrADX9jw0A94+BR5GhI3zw9xG74jJGw65Rr0SWojFqW6+AEl4EwbpZ0RZF1uglJyIoHTstGPrrbLccwIuZGnOIWLK4pEvDbf2C51D0sPkLysSks8RbH/GXZCR10k8PAqkusEE1R5rvzWWLKODIEbCYNVrLduHbDYzfPwUcVhoKzKzphLXyzVavqTx1vnZlIn3jccGpjqOsjMG1d99gme+7XSsOiR/npAxu2UX1ZKI7nf3NioWTuL3DyVXSVTd8cekt4tTdvI6y1b1ntpUVn7wJRiYi6BkAjb6Cv8X4RygqzQvHo7FCZVX+Qs9wp8yz/L841Hy9DSY3rG/Sroy+ik855rXyOPgJDvZEdBtUKMHOOmK2cCqIKFg19JGQOb7R6rEA5/Ux2PG3OkvAYzuC7PH+sQ84PbSIk419gyLLWBVy7oDb7UlrivoI0pUn8McBiWpL9jh0WbBCv62IlWWk2ZcOCqdrRM+m12ydaeVkkCUqQfVJIsFfaHbYPO9AoU0jbGy68oITtiRCWhgyCyKnSlO+EN4vM22iGFKVCG9IwEeEF9rOPXZ+6BVahhFb/IDnbkQlJTXtGVz0C81KZbiP2GMwPXrt5E1DutFZCEE/picHPFFGxJvZm2NH+ZRcRARHbz57W6+AE+9MU+G4lva6RSXcs83T5NbllyOUdB99abeGJ0t9ycF4/wrBW3A8MnGA8mymonnMZdBoKSXYdhXemCKyzoZDur1MOZ56qkUMe3hw8SOCm6z2uYQNVKkpoS5R7Hs9bcvXfm6rA3EUX8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(19092799006)(1800799024)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzZ1YkJvcDZ4YzdYOEYybXhWb3BOTFVYdXRzN1p5Z2hzNVdpVVF3R21ycC9j?= =?utf-8?B?cnhycnhoQjBXSHI1NGlqRmtJa0ErUGlNUGdTckR5MFc0aXBuTVhKQlQ5M3Fh?= =?utf-8?B?ZnltSzE2U2FueEZTaHRWWmxBc0hiTEFIWk5YaFVMMnJNSGJVcU5Fb0lhWGFo?= =?utf-8?B?ZjJXSUZXeHFMRkk2LzVrbnR5VFd3RTY4Q0RiKytjZUgwZ3lZSWI3U0RoeUt0?= =?utf-8?B?UnN1SGRqZ0h3NmRMc0tFcSt6YW5zQkhJdGlvQUlHa0hEeGs3Z3NtT21VcTRi?= =?utf-8?B?ZkwrWTZvUjVkVE9qMjRCMExJbi8xWnNaNzVScHF1Ujl0Z00xWXllMEtWMGpK?= =?utf-8?B?MEtXMUhUekJzclVqemZrdHZhSW4xTU9jMnJoWnBiY0ptRVhuOU5MQ1FtNi8x?= =?utf-8?B?eVRQN0dMRTRjTXRKZ2pKU2prZGtnZ1laMHZ1ZDVhQmQzNGw2dVd6SUhMKzJJ?= =?utf-8?B?SnJsTGpxb1lQbG9GNk0vM1JhdnN0MUtyZDhudFBwM0NCeUZkSTdFd2dZWVN3?= =?utf-8?B?M3RDdG91SEtvc1lHWHNzWGJQckJvTzVuWmhjdG5kZVF3VU5IMThZNWZDWi83?= =?utf-8?B?MytFMjdPTFRTTzhTWDVlREpxOXJXSnB6NmVaRUMycFE5ZTQvekRlUVJPWDM1?= =?utf-8?B?aVVTckZ5SkJpYmpUaWR5ZFFEUDd6dWx0NlJKZllNZjUzQVBHNDU3YS9Ud0NJ?= =?utf-8?B?d0dkd0ZUSUFDTm5aOEtRZmliNHIwUXFPQXhzb2NydEU1YXh1MjRWN05ZSURn?= =?utf-8?B?TDNGbjdlckJjY0V6V01OWEovbGR6d2VjaXQza0M1S2hKeFI5RW5PR1JDTjRu?= =?utf-8?B?eFBQOCtCL2FHYTVabUZHQTdQY3pyL0JmTVU4aW5CL2VmUkY1SVhJMm5HRFJD?= =?utf-8?B?Q2wrRVA1UjEvSGpCd3RSOXdGWjhXNjFQYnZpTm1YcytMYVhZNGNBLzdadHJ6?= =?utf-8?B?NUpwZWQrRmZnQ0VLSysrZDN1ZXFYVStwQVdldGxUU3Aza2ZVTEp0NWg4YXNv?= =?utf-8?B?REQyTnJRNGJzRHhoS0d4YmRUS1VpWUxKaGdKYUsxUHE5SXBDNGFuNThNeXBa?= =?utf-8?B?V2R3bUZwa1hUSEpON05LWlVtRi8ydXVlZTVLU1pXMHlCbG9TSWhVbE5zR1Mz?= =?utf-8?B?VjVmWXVpcG5EK05RV0p5ODc1RnB0U0ZlS0cvTndUZGVxK0tXR3htd0F6SmZZ?= =?utf-8?B?bTJNSnV0a2Jpem5HQmdhWFJwN2dWNzNiUklKVXIrTmx5T1AzREpzZWpPN0Vr?= =?utf-8?B?QWNUR2Z6Vnp2dWw5azRza24vWlpMaEwxRmRsc1Z3eGNoeHdaWGFWSXY2RmJq?= =?utf-8?B?enY3SVNRSTlQQVJkdGJGeTZqWjhaUTFRdUpzR3o3MTRJTk5RZnNUVzlXd0V5?= =?utf-8?B?OHgxNll1ZERudFJJKzdLZndQSkQzTkM2ckYzODZXOTl4Zmp3QW1MeFdJK1Rl?= =?utf-8?B?anFCbGEwRjgrYXRnSGxQR2UxL2hjZlBpZEdzUG9SdTB0VitaL2FqMDBVV2pi?= =?utf-8?B?b0YvMktYK3lFWkxINVJCL2g1NExndEpKNHJIN2hLOE9WZVVzdDQxMldVMFpt?= =?utf-8?B?NW1BQ3FIRGNrenk0azFDTEYxY0xvZ0tDSVVETk1JRXJtaWpZSTZhbEZ6ajFI?= =?utf-8?B?WE9hSkcrNG1SeG9Kd2ZIWkpac3ZPd3BpTGR2R1BsV2RMTVNyRitQSGlIVUI1?= =?utf-8?B?T0FlUnlkQW16Z0U0Yk1YSjVPWHhhL0FBM2FnM0lwVXBiYlRiSEkzT1NTVk05?= =?utf-8?B?WGxVRVFpTTl0NDkxekFOSDV3ZVpHKzNQSjBVbml3L3pIUCtSalpBekdicUhW?= =?utf-8?B?SGgyNnl5bXdpa3dTVUpaQnh4Vk10VDRaQWVKUHptc1JsV1RMOFNUZlJNQkdM?= =?utf-8?B?b2xsb0t3Qi9ncWc0dVp6MFVvRFVLK2hnVHF3SDM4SzV2VC9uMXJ3Q1FqNFdS?= =?utf-8?B?SHhDTFRnYWNBTXNaZ1lpMGpyL2pLQ2xsdUhsMHpQbHVMb2t6T21UZ2hwS1Nv?= =?utf-8?B?cmRQZFdMa1hyaFQzQTNyVzE2Ni9SZXpROWZIRE9hZlFrTWZxT1hsUTJWeG8z?= =?utf-8?B?VElGN0NlaFhOczRvRDRoanhsVjJwWXAwN0x5VllsVVZKV1V5RGwreUVXaE1N?= =?utf-8?B?dVRiZUZ5cUN0U1ZkM2lrSnl6dHhQb09EN0NOTWFtOE42cWFJQ3Rya2lxWnV0?= =?utf-8?B?b0NLQmJlNXNwZjFpSS9Wc3NSbUF6ZUFqNk1zbWMzNWZDS3dVTFQ5cTdSUlpn?= =?utf-8?B?Um5kQndxVWV2VXUrV1NRRldRdmcveklOb1Fhb01CMVp1ZzVsdndaR3F1ZWYv?= =?utf-8?B?bGlieEpsb2UzakorVjhZaHhpb1BYa2FJMytZUHM5RWxjQ2lKRWVPdz09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1580dee8-b702-428d-43fc-08de75d893a1 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2026 08:16:58.5352 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /WmSgdppKPENMe1gy/7CXP28GjOfE0HCqgpE669jDYonr14a7oRG6RCiQvFM0wPRl8xMUQnH76iEMGzMTR78fA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8077 From: Peng Fan Fix the following compiler warning when building with W=3D1: flexfilelayout.c: In function 'ff_layout_io_track_ds_error': flexfilelayout.c:1503:6: error: variable 'err' set but not used [-Werror=3Dunused-but-set-variable] 1503 | int err; | ^~~ Variable 'err' is assigned the return value of ff_layout_track_ds_error() but is only used in the dprintk() debug statement at the end of the function. When debug output is disabled, the variable appears unused to the compiler. Mark it as __maybe_unused to indicate this is intentional. Signed-off-by: Peng Fan --- fs/nfs/flexfilelayout/flexfilelayout.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/flexfilelayout/flexfilelayout.c b/fs/nfs/flexfilelayout= /flexfilelayout.c index cd175204807600ff4e33ff769e03ef7ac700a6dc..1d8099337652a1cdbcaf58d394a= 6e981e8e7e413 100644 --- a/fs/nfs/flexfilelayout/flexfilelayout.c +++ b/fs/nfs/flexfilelayout/flexfilelayout.c @@ -1500,7 +1500,7 @@ static void ff_layout_io_track_ds_error(struct pnfs_l= ayout_segment *lseg, { struct nfs4_ff_layout_mirror *mirror; u32 status =3D *op_status; - int err; + int err __maybe_unused; =20 if (status =3D=3D 0) { switch (error) { --=20 2.37.1 From nobody Tue Apr 7 18:46:40 2026 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011017.outbound.protection.outlook.com [52.101.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 725CA38B7A8; Fri, 27 Feb 2026 08:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.17 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772180225; cv=fail; b=l0hLEWB1xCCe5wd/Kc6I8MiL78dekqy2Pucj8RBjiaRXEVwqo8m3DLDlCzRbz/NPhpy12lOm8Fj3iDIu3ZWe9wrEO5OGchur1InJ+vGVVhWNBBwdK5UUPX6KEXD0PfBnESgkHpgTN88zWazMgt9oDJ6ga8LP+bovjul0Ys4HAgA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772180225; c=relaxed/simple; bh=seupKc5yYORVS+7fxH8bhAQJFlv7Heru6XJFmBChB3g=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=iZ0URxTcYwz3KAOGiFV2xFuD5LNq8ArpY/rzLOsXspvI86xk9QFkXs+M/4auRU6CPHetqSiFfME3Q2w2/xoxnl6FO2HFSpW0rnQ0WW7/S46Delr1DQzHe+0KSXKr4R26rWIyMox/SJTufOWhtCP0qYycZgbTegXCpv1EeGeO8T8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=xvXH3SpK; arc=fail smtp.client-ip=52.101.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="xvXH3SpK" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZZ18qERdE2H5nbtxb1Gd1wytzv1vcWfbJNEfo6Ig9W24MWubd+VYmy28VsIvnUKV6R8uYc9UIeCOsravegoqRyAAmR0geTBAnU31TNR0fEodwfRBLGux0aOpLV4I8bf6OXqpQHcRqkUJVfXjHlbzaBI3JoW+Ex9NnvxOwr9iayABo64LpnojGhXqgcxD+0dBSyX7ZRaVy4luG0+u0uoW/hodGjjdC+mu1I5N55rXUFGlHX+imfJ+GGplhucuoqyZGQPcPmpbteNJhhRcumAJqsfxnVl97lbV1aC7kUgVo442bwYxQk52qbH7DBtcBqiG7+eA/uS3mhPX2Yym+YhP5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1DJ9JFzdAMLMY83YZ2I2J1IOSGBpgnMQGvle6DnbQx4=; b=Gu+1uZ8dQDC16PJdv/q+BRDEsWOqhigR5V+EfcH16I4oAVEB17rVqXsiPuoOc11vF2SGy81HgXohcaCFKt5teP92wT/BmXirox3HWXqPWVxvVHGmUqONGotNl8gKQ1xjrKQ5Nf+ZidGVgSW9wEToFvNui+FM0fld0l6EYZ2tg1sMi3VUq3WotdDNCrByVmB9GfEsZymLRZy+wgpCuhj0xZ+XpvCJNZjdO7OmOWUE7fga0zQD0ZXEOGUq97l9vwBDJsuDba+XJyajjSxld1ih4PG1BwBRFHoG01Y5l/ZxDOvUIKKwYCE2Da5PtFS6huF7jH0fMOY2WK4krZaWParNpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1DJ9JFzdAMLMY83YZ2I2J1IOSGBpgnMQGvle6DnbQx4=; b=xvXH3SpKmImNJbVZRdVMVUOOZ7JKxpVkE7MyVy4O+0H3f/oofwWjaaO86Rfjt44cbDvu9zOufX1b14V71UawbGWwiY4f+HAU0teGaMGtc+Zq6syJbTBJDY+av6gDvMamMetn1Hf4v4Zha6lQnjPEx6moY7MXE8YJmUTurKGyPz4MJnOnHJYjiNJFGXFhU68mwBgk+RxrEML7ppMiwkmPAmTrGcWaxitXakJw0+yFS/4MItXxf/UVT056g59JfNFW6WNX7U1t1BdkwUOwgN4TobnuMbjc8r4+kYSXRkNkdZHJ0IGJqgMzZZK2vYMQE9I5w7u5hPnYsZ1LjB9y9n99vA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PAXPR04MB8077.eurprd04.prod.outlook.com (2603:10a6:102:1c3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.13; Fri, 27 Feb 2026 08:17:00 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::4972:7eaa:b9f6:7b5e]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::4972:7eaa:b9f6:7b5e%7]) with mapi id 15.20.9632.017; Fri, 27 Feb 2026 08:17:00 +0000 From: "Peng Fan (OSS)" Date: Fri, 27 Feb 2026 16:18:22 +0800 Subject: [PATCH 3/3] NFS: nfs4proc: Mark ptr as __maybe_unused in nfs4_proc_create_session Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260227-nfs-v1-3-2a6ea2ca8528@nxp.com> References: <20260227-nfs-v1-0-2a6ea2ca8528@nxp.com> In-Reply-To: <20260227-nfs-v1-0-2a6ea2ca8528@nxp.com> To: Trond Myklebust , Anna Schumaker Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SG2PR02CA0098.apcprd02.prod.outlook.com (2603:1096:4:92::14) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PAXPR04MB8077:EE_ X-MS-Office365-Filtering-Correlation-Id: aed66a83-3fc8-4e8b-17f0-08de75d894f2 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|19092799006|1800799024|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: k5BughwiGcYuflrADrlHh6fUkKlwrGmRldshfRKEP4RgyKfUzNSEx7do3j747YjsdqR0pYAZXja6xTWaAOYTFY47TPZ6KwbbttuF7Vkz9AR8wyOCvV46iFV6UDhFJCsvtrgom4JI5ZlLsfwML+k3vE4q9wtzuw4AslF8f5M6fKPSKvaW98MTnvZ7xRFbMWzME/BZUVxl9gea7QB6RoUlTjHy7+IExYNHWKvx6cQ0mSHzWsiLUCPosp4YrOE14L+BrY2cgDx31wslkwZYr624L+rITbT4x3lBExsOab1C4PSU++zWREhXVYEVNcPI6O8z2iNGF+pAm7Cd1u+3bEXwZUV+f+Z3dpV8XicNoZElt+MGqpJvBcISAUdsUS3QbYgHnY90ku7Sl41KsXCaGUpf3zVFGKl80isXxYvJX3hk+cX1OPdLzUVsuFCsgvO8WRvqtWAlcWx2Vi17kCt+vks3CcvrEh6N/EvyVJCaKhTloZgqtapqBMHo9gQOfTOrWzZUucadL+vHOWgUuyHHBmtz2QEcsvuKVUG+2lj17+eBitYRXe5hKQLxk2gsH2uzDaVe5mznv0lESzyZWnNZUmmnqNUSa2K9hvJFxnN2wXH7U9dHM3Dy2qgL+A24uSMaW3JIQ8LOLr6CEGNYjWuEfE+QqL/PnLToC9HABlRraKvNLjMgY9GuCxxuKyif2X8vZAv8O3tyJqq3Qp2qt4BUZtjgiv+Ea928S5KEfJPr8e3atqe8fY9+RLQSt1Z/TbMX/Q9I7mWzA31617OLw6jGxBJvEuYPUdAAM1yjMOrPTM1EtnE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(19092799006)(1800799024)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVJxdWNWYXV0Q2c4QXdNUDAvRGl1ZEFGam5iRVEveGN5dG9qbytQS3hVNDR1?= =?utf-8?B?QkZuSzVPL0tIYlJMcUdXMVZiUEd2d0hVVFdOMCtsaVY4RW1TZm1JUXpaL0FS?= =?utf-8?B?ZUJBV3FBelJ6cXcxb0plTnlpK3ZnL013enhsMFE4enZZTDY0QmQvNmFMTmNu?= =?utf-8?B?Qm9VTmphME1tY3A1TFVWZk9NLzQ5akRJVEh0Ulk1bUhpdXY0NStvaFJ1SjlT?= =?utf-8?B?NmhJMkorSmppb3BLakZqSDlGZ2lVYmxtaGdTSXorZk1qTWVmWGUxUm9RanVX?= =?utf-8?B?QUQyVis0enhHdkVnL3JvNUhabDlPTjZ5enZPSHRKTU5wNUM3eG9SVUJOT0ZY?= =?utf-8?B?WWl1ekE3TXJEanVVa1VucDVaM09la0RuQ0NJRVVuRUJGUUljL1pWdmtBenJD?= =?utf-8?B?bE5HY3FZUVZqWW1BajRTcU5HOUg1QThpWXpsaU43VEYvbE9oKzE3WWg2RHBq?= =?utf-8?B?dFE0dXRXeEMvYXdiWG43Rkh2Tk0wOG9qWUlwZ212N293VWVZV1c1aXQ5RmFo?= =?utf-8?B?UWFkWEdQQWNIYS9GVFJDb1dTSzduVXFNT05PTkVqYWpWclI4dmhzUlRBUnNX?= =?utf-8?B?UFFadlhzVm9hNElvOFAwWkpZTktjSUp0aUZZRU1QVnYzOGxiQkFlYllmSFZi?= =?utf-8?B?dGFiczM5Zjh2Q1hiWVp6Z2JHYkRHanczYThteEZpMlVBdkc1d1JiUGNDNUcy?= =?utf-8?B?NlhOTnFhYnRHL2x3emwyZXBXRnVkRVJqd2VVZ3pHWDA3QWRPTU8wUFFJS21U?= =?utf-8?B?K1BTcnBsck95OXJ0UnQ0b20zNUoveU9jcnk0OXRxOHdIQnlYd1RmeTBqejc3?= =?utf-8?B?ditDN1lMTzRiVmhNbWNRZGNXUUdwMDJZM3p6dlBlN0NWVWlnZlVYaVp1Y3RW?= =?utf-8?B?K2hjRjB5QTN0NWFPejQxTnlnSEdNSVZGbWx1UXgvM1RWc1B1OVYrbVBoc1o2?= =?utf-8?B?dy9mc3FDM0JqUVVsMm8xSFVLSnIxZy9SVy9USTVKL24vc3Y1NEtWVWhIK3J4?= =?utf-8?B?aXFJYjk4WmlaNzA2eEJTdVk0QnB6OGU4UVBDNjBXaHpKMFlrVExHcDdZYWt0?= =?utf-8?B?MTY1UEUzRU1rdll3NHpVTFpQVTNtZVh0MHhFek51WHVuYXQ3eXRJSDY3WGVr?= =?utf-8?B?VncybWdJMDVqZDdXYnNZTXo3b3FVU3d4dHRnNC9EQXJibXBFZFNUVmRiTlEy?= =?utf-8?B?ZWZCK1VERVZ0K2N6cjZXRVBQS2o4TDlCMmVvOW5wYVpKZkMxTjQrZG5xTTU2?= =?utf-8?B?M2VqdW1tZ3lNalBsNkExQkJUell5UW84aHBVSm56ZTZZNlJRRGpNZXNUUS9L?= =?utf-8?B?Tk1KekFlcXVHenlxbW50SUJOM1JxZ0FVbDUwdTF6SHRiM0UwUmJ5UWxlcnpo?= =?utf-8?B?TUF6NUkrdmwzSlp2MEF0Z056aVVkNFZHcnFtODJ1aGdLSVVDRW1sZXgwRjVp?= =?utf-8?B?dVlRK01LR09LNGx3NnQzcHA3dTcrTS92WDRMQ1VuVWVxWU5DVVdHL0duMElr?= =?utf-8?B?RkNPbmppQUJKSlpDOHFNY3hKUTdqRE5jM1hyeVVlY1JIZGlUVmRPTTlaaUFT?= =?utf-8?B?cS9Ic01YNTNORVg5S3BqN3dXbHhROHpETEkwSnRUY1RKNzRiVXllbGhMaVBy?= =?utf-8?B?cUYwa3dxcndpWCtRUXQ3dEhVQ2lRZTNOUmI0TFIzTVUyaUVEQ2VkZnhiK09S?= =?utf-8?B?dWpaaHpid2cwck41YUV0Y21IcTdCSURQeHc0UGx4UkE0Kzl0LzF1V1o3UVhx?= =?utf-8?B?ZlFuY3FoOUxuRjJ6a1FIR3FqanFUc20zQTd3R1IrRzBVMUFKQzNNQUtMWk1n?= =?utf-8?B?KzRvY0FQd21tblAreGRvd2ZGdFQ5UmZNNndGZW9KUWRtTE40YnpwNDkyQUR3?= =?utf-8?B?eUMvbVpoZS9MMHNMY2VSL2xTRXAwWG8ySTZGVDVac3Q4VDd3MGt3eEZYVEJU?= =?utf-8?B?bWhzL2RNVS94ckhNZFBHZ21oeWdlb2xLaTNLc1lqK01pbUdnNlhHSlhpRHkv?= =?utf-8?B?WEIvc3ltcEppcVRpSDhTaUc3WkttbS9zR3hveWQ5SkhnenlQcTlidHpQZVhU?= =?utf-8?B?eGp1cW9jdDlqKzVsQmdkRzgxK1UrSW5rY2o5TTRqRCt6dm8vNmd2eEdsejli?= =?utf-8?B?VE1Hc3VNRjFQL2ptMGZ2N3IvSSsrRW5SWFpQVXhCcG5FMGtZbVJBQklqelYy?= =?utf-8?B?Qm04dUdlenNLNlBZVW9sNWxnQ1ZHMWk0ZnltdWlaQ0tKSllzVE5zNEhTdmdX?= =?utf-8?B?ZjY2QWMzdkdjRW1nWEZJQWJ1OGtwTnFkODZickFJc2lvUndRKytuYys2N0xu?= =?utf-8?B?RlNHeXcra3ZyU0w2MGM0WUJHTHk2K25mYUZabWxPYTUxY3pjc3I3Zz09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: aed66a83-3fc8-4e8b-17f0-08de75d894f2 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2026 08:17:00.7313 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9krfRaUH+P796dfkfEY1H7ZIuwkwnJF0jH2MggIAXj5HzbtwuJzS2c/hnFQq1piyiafSqFlvn4ObqitPwGE7Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8077 From: Peng Fan Fix the following compiler warning when building with W=3D1: nfs4proc.c: In function 'nfs4_proc_create_session': nfs4proc.c:9244:16: error: variable 'ptr' set but not used [-Werror=3Dunused-but-set-variable] 9244 | unsigned *ptr; | ^~~ The variable 'ptr' is assigned but only used in dprintk() debug statements. When debug output is disabled, the variable appears unused to the compiler. Mark it as __maybe_unused to indicate this is intentional. Signed-off-by: Peng Fan --- fs/nfs/nfs4proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 91bcf67bd743f72a008a9dcde29207bf7a36c407..64e0221c39423dae58a30018a28= d874198de57aa 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -9241,7 +9241,7 @@ static int _nfs4_proc_create_session(struct nfs_clien= t *clp, int nfs4_proc_create_session(struct nfs_client *clp, const struct cred *cr= ed) { int status; - unsigned *ptr; + unsigned *ptr __maybe_unused; struct nfs4_session *session =3D clp->cl_session; struct nfs4_add_xprt_data xprtdata =3D { .clp =3D clp, --=20 2.37.1