From nobody Thu Apr 9 13:31:48 2026 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAF05332625 for ; Fri, 27 Feb 2026 07:15:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772176515; cv=none; b=X4hcwzCLv6tSuPTQhRUOhnO9KISP5HwMLD0mUUrsCJINSUCJp6fmmQ2RsKyzDulz2Z+Bi79kvnM4kSYze5W3Q79PryPT7+96rb8wS26o/nkPXMSIaBz9ovlJEq1wKf3Q590WUAwbNfhWnHQRJawzLmt69FMOjDQBpU1laaDeAw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772176515; c=relaxed/simple; bh=SW0KsH0zfeD8rz2BxR1U12qdNdVFhIs86kUgS/R+a3w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HAGT519gH16bSc8jCRdow84M9SrshJjgLYpIYuQhK3kivaMe8WjHc/RgT8DDHIc91dT8junzJ+N8o+1LmtkEL7iPyXVtEIVY4fB8Ypp8Z2MLdGDO9wyofDnXZDcf2s8vn74/7Z3Af+F8vNAQFX3kkHvFRxbognv49+u99eL7axs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wNOdNsHG; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wNOdNsHG" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b8f8d80faebso457856866b.1 for ; Thu, 26 Feb 2026 23:15:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772176512; x=1772781312; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mSygevmpkuj28iNV7zrww7IIgn1pA3j+kvHDTNdICpE=; b=wNOdNsHG+JkebgsSzY5ZxPl2Q8eJNyeQUXPWY/HXkHYO0ygRjcuvtl/i/fNRe1/gsr 58Q+fXHOdrRoHOuhwD8mXZLPPVQfO+oSOowHEq7VpAw7rHo9Y66KonYbGLBBE/cRMruQ A+mgH/I4WnR4vCGa0N/QKBotGvI1nLVKjKKx98UPpNmNgvmYLOXHfDGszZtZaAOiWmQJ c09cJTExkGD6C8hvfkk0yLRwalgb7in+vvvgLnL6ae/7jsSFsw9ggqew8pQJkkskP7+E FpIjRAD1q/2Gdcqpl+FSOT9t0+d3bTt6yZNrmQj8NGRVW7yALlTAKSzxAhQChfVoPbpx kimg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772176512; x=1772781312; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mSygevmpkuj28iNV7zrww7IIgn1pA3j+kvHDTNdICpE=; b=AQjOapyeBJJY8+6OBiCjWPt0yfaSGaHkWYo8UwQb7sTtkzWcC3NLQHvpxOzyGAFzPH /Lno2f+RqRj1inMVlC0aZOfsMn/GHjB03RICUjBWTMCz5rATee8PmyyIVoDgRLtC4+N2 cBSSZOoZBO+z0IDu0sXLwIQhEKbE0KJi5tq1uAm1ajl17v3yF0l+Uwo8O8C4Ny/7IH9f qg0+CS645ErHkLkOxsgUbyINwK7LC8zbxIEtbuIfppAd7Z1M6Ukl1MKDacNnu3ZziQ86 cLXQitjzH2WynTEob4qaBrR0eAtSLU+QHqLEqrvZVcue9WzA0NhX6GoW0rJ0HOltielB FDOQ== X-Forwarded-Encrypted: i=1; AJvYcCUi9gZmB6QyrmKwq37i5BTYpu5EUUdcPzXvtnBXVvw5QCFbQgjDfKclt/0T10fRenk5pCQTsh4lXXd36eQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7JzVUEusjVrvMzVSonoA9OttCM5NUIPdiOsRVQEpqQxIQOH/e eKdCZVUuZfHqaCbdLUbnbh7oMC6nt2WAZzn/9Y3dsIfLE98QiMImktXC4gshwKPNaAs= X-Gm-Gg: ATEYQzw7nVHiwECkmpJIQkp03UPxi1s9lqwr9uIKKhweiWGK/TZYKlvkJPBjtfNAiCM Fq3jj++rC+QLWGNcjCHUF8c4i+HTlboT5CTORSz9rT/gOsqWzZRof9xV8Tn2IDdQ87Me8QcHz5n 1qqA0yZkUna66e0e9NcqOWFGDUHJpRL/zm3ScgxQBuYbgMcE3e38qx78T1mWqXDwtix2PAiJAe/ KwDtQCSgPoz9vLdj5XYPCWFDOThPUBY5JQEsioZ2TUwgsBnmcnBzku6aSfsb8Fhna6SRS4lICWZ q1F2UewIkQCMdiDREoDcmZWJzY/Q9FO4qjrZaiVjDMeaiGa6rHkMPZE/SAMpRvCeXSgOtayTzC6 W1Tx1EaJSOQ/Q1c3nTppdgC6ouTV8FM5QAI6M8DgxwNZBsUPQpU08+0BlSV9Zw1atlnazVuz8dX xYBFY1MYqu+52YtePOPi/CURaownJAjjL/WAU+4JlnUfaMDncN9QNO1TlpY3LVW8aOHWKm7mdcI j9j/t90efuG2Os9Gg== X-Received: by 2002:a17:907:97ce:b0:b93:56a4:d6d3 with SMTP id a640c23a62f3a-b9356ed6a7amr349717566b.1.1772176512050; Thu, 26 Feb 2026 23:15:12 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935aeee867sm124205066b.66.2026.02.26.23.15.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 23:15:11 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 27 Feb 2026 07:15:10 +0000 Subject: [PATCH v2 05/11] power: supply: max17042: use dev_err_probe() where appropriate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260227-max77759-fg-v2-5-e50be5f191f0@linaro.org> References: <20260227-max77759-fg-v2-0-e50be5f191f0@linaro.org> In-Reply-To: <20260227-max77759-fg-v2-0-e50be5f191f0@linaro.org> To: Hans de Goede , Krzysztof Kozlowski , Marek Szyprowski , Sebastian Krzyszkowiak , Purism Kernel Team , Sebastian Reichel , Rob Herring , Conor Dooley Cc: Peter Griffin , Tudor Ambarus , Juan Yescas , Amit Sunil Dhamne , kernel-team@android.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.3 dev_err_probe() exists to simplify code, harmonise error messages, and set the deferred probe reason if relevant - there's no reason not to use it here. Signed-off-by: Andr=C3=A9 Draszik --- drivers/power/supply/max17042_battery.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply= /max17042_battery.c index 07759d4fdc37..b9277f81a25d 100644 --- a/drivers/power/supply/max17042_battery.c +++ b/drivers/power/supply/max17042_battery.c @@ -1053,16 +1053,14 @@ static int max17042_probe(struct i2c_client *client= , struct device *dev, int irq chip->dev =3D dev; chip->chip_type =3D chip_type; chip->regmap =3D devm_regmap_init_i2c(client, &max17042_regmap_config); - if (IS_ERR(chip->regmap)) { - dev_err(dev, "Failed to initialize regmap\n"); - return -EINVAL; - } + if (IS_ERR(chip->regmap)) + return dev_err_probe(dev, PTR_ERR(chip->regmap), + "Failed to initialize regmap\n"); =20 chip->pdata =3D max17042_get_pdata(chip); - if (!chip->pdata) { - dev_err(dev, "no platform data provided\n"); - return -EINVAL; - } + if (!chip->pdata) + return dev_err_probe(dev, -EINVAL, + "no platform data provided\n"); =20 dev_set_drvdata(dev, chip); psy_cfg.drv_data =3D chip; @@ -1090,10 +1088,9 @@ static int max17042_probe(struct i2c_client *client,= struct device *dev, int irq =20 chip->battery =3D devm_power_supply_register(dev, max17042_desc, &psy_cfg); - if (IS_ERR(chip->battery)) { - dev_err(dev, "failed: power supply register\n"); - return PTR_ERR(chip->battery); - } + if (IS_ERR(chip->battery)) + return dev_err_probe(dev, PTR_ERR(chip->battery), + "failed: power supply register\n"); =20 if (irq) { unsigned int flags =3D IRQF_ONESHOT | IRQF_SHARED | IRQF_PROBE_SHARED; --=20 2.53.0.473.g4a7958ca14-goog