From nobody Thu Apr 9 13:33:29 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D62CD36B060 for ; Fri, 27 Feb 2026 06:51:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772175078; cv=none; b=hU+iv8C5lPEw9XEJQrPflimLkS5FoA9IQqZp4MCQtJwyqfcYM2KTsBZK48mVfhtTAxImEgLMNv4Z4GU8ma7nZ/x2+6PJTMbhUdC8FCDUPT2ivr5+kWuIxAHmKrsk5F3BBS6EDRVGiSdaDYRXKax4NiFhjnseAx+vVAzesm4p42c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772175078; c=relaxed/simple; bh=FZ3ARdYGTQxmH6JaV2ra/jpTuBox548HjHD9kKuTQec=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qMUe2X8waJ/HrIHhq7tkXyCOYEX4T44TXE2uyrKvyiNVm+EUnFWx6+6WzMhbwkuSxNCwk+AhFx8QHV+7zjfCcfpSYBMvLHZjBMMqR7mG/Vnly6JK46+tMsmFFiesgjEZRDpoT1vyz4BnST5E/lhzHrPmdjHiYBTLKLisWtBiTgk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Br2U/9G0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Y2KrLYJE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Br2U/9G0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Y2KrLYJE" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61R2KCAh236351 for ; Fri, 27 Feb 2026 06:51:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Z/JqWa6Wha8fsH3fI3J8ue3gixQVohxYTLtBUxECfyM=; b=Br2U/9G0JyW69Yt8 4O1rupikwWvCOXV9a5an1wEVtp6E0FIZ82FmcPeWtWjxi+5H6/JEmMZRXZvqyIvF plNuxZ8+fg2G3UNw9nGT9YYi6A/AH6X2ruBS098xG/7/a4736p+BcYnvxb96A2mU NQByd3jjCMe5BsG34g/mpOOZIHr42RK4/GNOI3QZukRGUg/0StHgof6xIM480Op7 hTFJWZ5qK2aJZH21F8yhe7vl27sDMxZ8fBan/c2J6FFWZWUJSJ2C+KdytZksNvXk Fxvi/vUCWJeTMdoMBmXquFZCGQ1KDhpI7RSxHPS5/AcIvszB1ShGFeN23a+oJwPR tKfUmQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cjx1xsens-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Feb 2026 06:51:16 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b630b4d8d52so1164226a12.3 for ; Thu, 26 Feb 2026 22:51:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772175076; x=1772779876; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Z/JqWa6Wha8fsH3fI3J8ue3gixQVohxYTLtBUxECfyM=; b=Y2KrLYJElZim03TuLGzxiXluFNthP1kPhPo7IIxFm0WUq/5rbhThagjUJllcBAS8OM 6+6i/KovSE5wUN74zLFPzOak0lJFfmPQED93CQCEhfkliPfxI0QK0udjdVCJgEasVikT qnLcrznRpom9fNKbSIgFSkN9UYLRjpJwhtMwcUAyTgjQHETB1Qb03V5RVWmeGbShuIdl qw/9cC2zRilMavstbF+++oWXg4xvKjIjL2yGLClzsE7O2L5e2v+2bU2THJu0/2OhjWee c6jvcWwPUcApiYtyjaakS7H56xuP+8s+7RdkvMjiKIRX44080JBDKWzuO4xq9rgWLDYx DH9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772175076; x=1772779876; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Z/JqWa6Wha8fsH3fI3J8ue3gixQVohxYTLtBUxECfyM=; b=WEtnuRJk8yrzXWuHwFKq3pazOkZ3WW9LJipvJUUarkFD/7KX+2YD/qrokpW7tGgON+ c7p6QqRI/JBtqDkdWJUVzulcz2VSizS8ZC/NeFz+nKYfnL5pBrhFp8nY61maFpHgcdTM tQahVUvO0sFZdamavFlnmYpkRgRx7GPvInbxL1rZ6HCE+1YLtnqPcz5HZ/3+a7JRAUcm 3tB9qH6vpj0DjWLYcqoYHw7as09JGkujLXx1+Dhb6+QjUaqaw7TIirO1BoniMSKKCAaf 71uF06H4l4FdrAfDcPu5fF8umamV4lIewCopd9jdHH2fqZ6PTPRAnw2J0npbINemz4iT J8gg== X-Forwarded-Encrypted: i=1; AJvYcCUq6jvVmF2CaUS0gJtuN18bqm1uXkFm1yoEn+g8lbAnnvLknEgz98VBLeT9GnpAAug55CnmyMyyFJ4x1HQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/XjcRfB7augCVn+VRqmVjfIf8E1Jdr1fWhlu1n/z62NjHCf/Q CsNEKQOwitKGBf75QNcUwgDHgi9ds11iSY4Pl45tZOb/pmpMS7LIfhXbRAX/WWPCVstzOA0OaF+ S9OZFUBWRkZRaoLiC8EiKX3AjiopuSg2Z8X4gn9IzIZ6ur56H+Dsk9bntLNSYlhmxTfk= X-Gm-Gg: ATEYQzwxKZJD4aq9npwIdsGSVGgS9SGN2aaSwtQCRXXe0kDbvlvPZ1el4Z670nsKKXR mGBR3z9ED+ADYgjuQtJrBTu4nYoRDsszMf0lE+16kpgNf0scipMvnF2dBcHOVckhFhAonXqI7nH QEwtCHEp451Rm07oK+SjAWSYnLhE/ydRVfAfBcTRahGN9Sy7Nw97t2iKs6QB9K6X+ZPDDzlXq4P D9p6kjmR6vyywaem80u9r7VRHWdyUwYduTlK1nJO1NLwpWkHy7Yexy98XyWL7u2A0upIaMvw3tM lvjOybSlTuK3+OAqq4OsVWHsp7Du91+kYz299ybUL42+SP3M+5NSN5zn2qq20H5yeoFZEVmvKPg 9kX/b/bf/VVo58rz2NWYKt+EZz0AR6khzw4O9XnlEtPVTnH4ivfWoXidW/DE= X-Received: by 2002:a05:6a20:258d:b0:395:151c:4eda with SMTP id adf61e73a8af0-395c3ae7748mr2004217637.45.1772175075597; Thu, 26 Feb 2026 22:51:15 -0800 (PST) X-Received: by 2002:a05:6a20:258d:b0:395:151c:4eda with SMTP id adf61e73a8af0-395c3ae7748mr2004189637.45.1772175075075; Thu, 26 Feb 2026 22:51:15 -0800 (PST) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70fa5ea0dcsm3455880a12.3.2026.02.26.22.51.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 22:51:14 -0800 (PST) From: Dikshita Agarwal Date: Fri, 27 Feb 2026 12:21:02 +0530 Subject: [PATCH v2 2/3] media: iris: Initialize HFI ops after firmware load in core init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260227-iris_sc7280_gen2_support-v2-2-7e5b13d26542@oss.qualcomm.com> References: <20260227-iris_sc7280_gen2_support-v2-0-7e5b13d26542@oss.qualcomm.com> In-Reply-To: <20260227-iris_sc7280_gen2_support-v2-0-7e5b13d26542@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Vishnu Reddy Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dikshita Agarwal , Bryan O'Donoghue X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772175063; l=3309; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=FZ3ARdYGTQxmH6JaV2ra/jpTuBox548HjHD9kKuTQec=; b=KMnntYNUbenjJXL/p1ZcDIpmepXzrO5DsGgQ8grRfHj3nf49AavUjF+J4rGc//0Z4B6gRsjDL C0Vb85KsF1TDllCfO6TesEXUFe8D+EpyV7fk9WjCSEueDDC6Q/d1Pel X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-ORIG-GUID: nZYWITezJsCHsJPISpbHe3NT6ay8_0rV X-Authority-Analysis: v=2.4 cv=Vtouwu2n c=1 sm=1 tr=0 ts=69a13ee4 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=3tfMAF2nT37deXqZlAYA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI3MDA1NyBTYWx0ZWRfX4nfC/c7FfTHs KMbptxebiLrO6mfv0+NimDUNfskbHX0zNqMRDPkCwCSGAAi0DINMbOhNvCpgSH46wf2tvCRgshX /v8E0BWnbIhXJoHkcTqu5Uz9herxYiLbtLrNr71kkSBKc4j234SNbehGgJpzt2lUQ5J/Hzu5vS0 N7WvtEMH+KXlEmAEhZMSXGdQzemBg6lKwCBwxhZoudjy22nMrmAFFfHSdSfY674cHO+Y6kizDhG 8eNDJtOAh6ldynQLFg0EMC55eu1yIhdxA+qm16hXvJ94MnERdhZ5f9TYYr8vj4+5iBymbKqSo3V mZ/aopnVgu8fFxYdfv/JhyTxrYcqIfnI28GMZnwBz+SAiV+TnbxHvYtPAlsu0YR8hg3oqmhovTY 0qJfXgSgNBkok85YRmVXSzFMpnNKoruyzJbduDwygoeqEvxaJr4rfl8vCCFusf2Nm3KE0ivRhMZ zaDeUJNUwy5PbYsEg4g== X-Proofpoint-GUID: nZYWITezJsCHsJPISpbHe3NT6ay8_0rV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-27_01,2026-02-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 phishscore=0 bulkscore=0 spamscore=0 impostorscore=0 suspectscore=0 adultscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602270057 The HFI command/response ops were previously initialized in probe() but, we don't have firmware loaded at probe time. Since HFI is tightly coupled to firmware, initialize the HFI ops after firmware has been successfully loaded and booted. Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_core.c | 2 ++ drivers/media/platform/qcom/iris/iris_hfi_common.c | 6 ++++++ drivers/media/platform/qcom/iris/iris_hfi_common.h | 1 + drivers/media/platform/qcom/iris/iris_probe.c | 2 -- 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_core.c b/drivers/media/p= latform/qcom/iris/iris_core.c index dbaac01eb15a0e622e85635fddd29c1f7fc18662..259a1c4597a1ce76a4e0f254904= b135c8fef549e 100644 --- a/drivers/media/platform/qcom/iris/iris_core.c +++ b/drivers/media/platform/qcom/iris/iris_core.c @@ -79,6 +79,8 @@ int iris_core_init(struct iris_core *core) if (ret) goto error_unload_fw; =20 + iris_init_hfi_ops(core); + ret =3D iris_hfi_core_init(core); if (ret) goto error_unload_fw; diff --git a/drivers/media/platform/qcom/iris/iris_hfi_common.c b/drivers/m= edia/platform/qcom/iris/iris_hfi_common.c index 621c66593d88d47ef3438c98a07cb29421c4e375..db48dfcc96b8d923ec49bb4b27e= 7a0ddaac263e8 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_common.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_common.c @@ -74,6 +74,12 @@ u32 iris_hfi_get_v4l2_matrix_coefficients(u32 hfi_coeffi= cients) } } =20 +void iris_init_hfi_ops(struct iris_core *core) +{ + core->iris_platform_data->init_hfi_command_ops(core); + core->iris_platform_data->init_hfi_response_ops(core); +} + int iris_hfi_core_init(struct iris_core *core) { const struct iris_hfi_command_ops *hfi_ops =3D core->hfi_ops; diff --git a/drivers/media/platform/qcom/iris/iris_hfi_common.h b/drivers/m= edia/platform/qcom/iris/iris_hfi_common.h index 3edb5ae582b49bea2e2408c4a5cfc0a742adc05f..498a08314cdeb65b4b621e2200a= ae8685f4a025b 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_common.h +++ b/drivers/media/platform/qcom/iris/iris_hfi_common.h @@ -149,6 +149,7 @@ struct hfi_subscription_params { u32 iris_hfi_get_v4l2_color_primaries(u32 hfi_primaries); u32 iris_hfi_get_v4l2_transfer_char(u32 hfi_characterstics); u32 iris_hfi_get_v4l2_matrix_coefficients(u32 hfi_coefficients); +void iris_init_hfi_ops(struct iris_core *core); int iris_hfi_core_init(struct iris_core *core); int iris_hfi_pm_suspend(struct iris_core *core); int iris_hfi_pm_resume(struct iris_core *core); diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/= platform/qcom/iris/iris_probe.c index ddaacda523ecb9990af0dd0640196223fbcc2cab..22c7b3410710328b900fc49459c= d399aa0e89b02 100644 --- a/drivers/media/platform/qcom/iris/iris_probe.c +++ b/drivers/media/platform/qcom/iris/iris_probe.c @@ -252,8 +252,6 @@ static int iris_probe(struct platform_device *pdev) disable_irq_nosync(core->irq); =20 iris_init_ops(core); - core->iris_platform_data->init_hfi_command_ops(core); - core->iris_platform_data->init_hfi_response_ops(core); =20 ret =3D iris_init_resources(core); if (ret) --=20 2.34.1