From nobody Tue Apr 7 18:46:54 2026 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010010.outbound.protection.outlook.com [52.101.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52F433EDAD4; Fri, 27 Feb 2026 11:19:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.10 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772191178; cv=fail; b=dhVlHCvWV3KIh8c1pOg/oBsEMeOzjEm+B0lbnUJCQ+7HPQX5ELLNSCXXOr1YnKuvp3NBiS7Uo8+SQa1uklRY+anIKqjA8iQPPwKMYjpozUryTW476uBamptgMidFkhFHo+zIhXgufBTpo8FQ2FqVRVk4/us0Rr/Ea5CqVHM/pHA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772191178; c=relaxed/simple; bh=yofNPOQ9WYsq6owUCu+pgz5x88KH3UBxOp5QCvmjRoE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=tQn78IUwLrKOglCN7kRDOhoTsVpkrCZv8JxLi0ghc9rIcXqruKjlxQ3lXIS4LSSgSeTDDwIVv3ENfAtLQDEMHIkrpZP5Dcp4+6T8RkqzdM5k5ZNPyXqAyrAtUlclO2jIFvEhtUvcVzqFXlJlqTIbRkseUgmYH9Xfe90fmy9ujMs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=i+idv23/; arc=fail smtp.client-ip=52.101.69.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="i+idv23/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ixVAA+x+PjdTX7cOme04yZ59EWAsRDaWluICWWnDHtqngDu9uZCVli8tOlPuO55f7onH3jjjuJLdlj4YU6Z31hPrIDqIzPYZ+eMu0B/k6eXumJTEAI7FvpFnPM8RIFnP9oVeOd3u7pkub/Uh2meOSfUtGj1fv54oxz8EpGMRjDhWEHAjeW1lDtWV+iLqhUQVBlPGkgBmE+IMdNCU6zjxNeT7oe5w27vDihbhZPCV7RGEcvnEVphEURnm3A0joUVdXexk8q+06FtyIiGNhL87ApaW05EUD0vuPdU+J2UF16qjqSAxvwkC6e3sQtu3BSv/Rt0ixSyubILUsuFrkbmSsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/oVBNEHSq1SyFdTRJ81U248DIa2mHvj8SDEroebuf+4=; b=UC1kf78CWiLQx6KDg7//8+SnR4LaIJtzkilWsWCUjCsfwFWauY/cjRNEk4SJsW+kumYMLtLQMH1KmQjTMlVYk6U9X0mF0oqw+PWTUwSPRag/e6wpvPJfBQEdlR9iyVWqpkFpReuICb4XBRBuO5mHGXWZe3MXSxRNzs8qlFoFI4Ec/rTHtr6Z9rfx+EFV/i+UCuhrrpUeImqCUrVVju02lzOF/7MjTWF8dzfG8CUgqRF6WbuWojxvVRpgcgCnzLhzDwHOahYDE++QwZkPhFwNIVOcIHRSnswiTVUIPeDoGzbOlkbNHa7whkJNz6SQiwxyDI38MOz85WgRVuHtLx/zdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/oVBNEHSq1SyFdTRJ81U248DIa2mHvj8SDEroebuf+4=; b=i+idv23/menQnOinnKSHVcOOETDAPlHepVH6ani85g5Zadk7osN+Wt8pHT80Ni2qmvL5qrMwgBQJY/PuRUTzP1GDHxTTh758WEDvjmbEjUF3hbvhD6tBd8IiWtSaaJ9DW4tf8FL9kW/vGQqVl0xL3hxZ20LXoeg8AfoFo/e5Yn3H+48VxoApVfTDjSKk1eas8cUq4V7XlyoTMQIlpc4Pq2HtRDt0LCl06IqLMWhb36LX55jt8UapCZ3BKrsmbBqi4sSBPV1yeS4Wlz9ytSbZHlz5SK9Lwte3Vs1tYrr6FMWghrDY5Ed1wlcwB4hGmcAjP6zgXZbPTb4lPyFfzYegRQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by PAXPR04MB8272.eurprd04.prod.outlook.com (2603:10a6:102:1c1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.14; Fri, 27 Feb 2026 11:19:31 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%4]) with mapi id 15.20.9654.014; Fri, 27 Feb 2026 11:19:31 +0000 From: Guoniu Zhou Date: Fri, 27 Feb 2026 19:21:10 +0800 Subject: [PATCH v4 1/4] dt-bindings: media: ti,ds90ub953: Add new range for remote GPIO data Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260227-ds90ub953-v4-1-dea596205f9e@nxp.com> References: <20260227-ds90ub953-v4-0-dea596205f9e@nxp.com> In-Reply-To: <20260227-ds90ub953-v4-0-dea596205f9e@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Vladimir Zapolskiy Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772191287; l=1343; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=lczvwm5JkrRoK67LfWBD9eGBjFDy4kRH0rnYiA0+oGQ=; b=p7QWh5/H8sZW50n2w8GmbJoZCwFcNUyuz6E7d5eL5+JqI+YwC8nXUL83ldRvqXgLNHjzbdyfD U+MdlYr+mP0CzQPCc12evhHVj/pHnFq0lmucbRYBKKCWixzGdathIha X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: SI2P153CA0033.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::21) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|PAXPR04MB8272:EE_ X-MS-Office365-Filtering-Correlation-Id: ee6bad28-4f3d-4f11-5a0f-08de75f2140c X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: qHtCxgufqgQlRA4YzBRCYD06MBZeCb1xZaPNXX4ZqCVDCwsIoStbyNBhm1LEUc3eTRLnF/BAcjkCh/55dLio1wMhqlUyNqRyDls+aKLgk8BNJekwooOPVmPfwpyyOLrro3x6bR12PCeLTJobjBORzshMorerI9GJw2OO/I5FiY6vTmY9mRRsfPsI9Ottvqsa3UU2LXSR/l9bP0IK38X6eamLu4cN87ZuevMx6e12TllmwfjYsS3+lhm/NOLLQMCMq7nlYLTqHqOvxVcRh9DV5XQETgUirwJFJjKD48EPqfx+68RFPY9CE7h2DJTTTqJDhg3XiLmp7u+wqGk8P5fpcnGaps4n2ZhSWZMp/wa9hMR/qfoPK9/vJzEbEUJjIz8C1TZXGe+9QjJbvNYIecZcdexQ4TwSYIfMaT7c+OebLMepk7nq1/8X/FSD/LTDFeQcsn/t2E2XI9zse6RNpJQwpvWIySIma/F+EvHuANVt6aS2icR7MdUkuJtHqTYBOquGGTuDSxdCZ/CL2JJeQ22fuFXYGRoVOHoB4OJm/3BIMuVmmUnmCHHsel+b+nVXfPnqzMP0R6/Jgcb6DKQ34RA7s7g4v80Q2vi9RmLHpX0f9hhvt3ME8XaUHSabAXEM7hiZFRdheR0kcf8OQ02QG8mXCnYGey3fk0F2xwnrRD/ebBNQRvXwfnAzSKmOYt7s14XTnJS6yM6RwJaWtgdrEBlvOyTBXc0rzWUTxaShXbc1Eb2plqg1pS8u24csbSWVFTErdYytlPsNwVXwajM4rxVHrIQGlYiMbZq6WpTdHYusf3E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUxnNTVVdGpkSmd0VlhTTXdPWTc1SzRUR3dmcFI5N3drZ0p1WWZ3RzBtaU9x?= =?utf-8?B?NGpQWE9LN1FtbTRuM29NV2dBWXlrSjh0SW51NnFWSUdwUEdqZUg3WFQvWDlN?= =?utf-8?B?NDRCWGxVdStxd1FOQzN2RXdua25zYVZEY2FwLzVGbENDL3dSWjA3enkrWjUw?= =?utf-8?B?eWQ2cW13ZzJidGY5Q1FzNXBKUWd1SllTMys3WVVqbVdkeDl6Um9zOFhTTXNJ?= =?utf-8?B?Qm5iSFVFdnpMYUtVdXhuWS94R1poUFYremx4OWZ1eHpOU0NVZk9KOFZHVzRs?= =?utf-8?B?VDFDU09aNXpycklqaGlwWW9GVFpoL2dtSGJic3VWOXY3TGE0dStsN0JTYXRq?= =?utf-8?B?WVJZVWFlemgxL3dDYTVzYlF1RHNoTGtKZFoxT2lKeFVjZ2VTSTk3ajBpMTFr?= =?utf-8?B?dGRodlRHbVpoeXdBOS9FQWpIYXQ3dmlERG1BUFdFelFCVCtwSVU1SnJ0ZjRT?= =?utf-8?B?c25pVVowNFZlbUJFUjdjN28vb1ZkcFNFQU5MSHZ6S1hXbUJmaWYvWm51NGlp?= =?utf-8?B?NHZqdmdVRHFsU2ZaTitmd0ZyYUpjZUVQZnZ0NlcxZjRsSUpkSC9CYmkyaFZi?= =?utf-8?B?Qk00cGZyRWJBRlJXeGNwOUdkNEFicThjWjlzeVpyM2gvUjJQZGU3cWw5NXpm?= =?utf-8?B?c3BLbWV6clcvZndLZVVqUGFSbHYwSFlQeFU3TTY5QWRpMjBQOUNoSFZvbEx4?= =?utf-8?B?SWVxUkp0WENxOVo3SE0rWVQwOU9iUURMR2gzSVovbmJjOE9iRGpmdENKYlJX?= =?utf-8?B?RjREK1VWYU1LSlNDVnozWlVTTmkrVllReXdjbWJFUVlZazlFRWFUNWlrVldI?= =?utf-8?B?ZStOcmoybk5CRjlhSGtuVXcwakwreHltaHJXcVloeElxclBqQWVDMHFvdERZ?= =?utf-8?B?N2l0eW5mSGVGU3dmelJrRDFRRnluaWhQWXdPc0wraUJFeWpMRHVXci9YU24v?= =?utf-8?B?VFI1SWpqRWptbDBVM3M3Qk9JRSt1L280RWJLLy84OXFob1RYR2tWRWJNcUU0?= =?utf-8?B?MHFDbE11VnVYcVhDeFhkNXFXakg2TDB5MTg2L05XOXpBUytWcWJwQlpwL3Br?= =?utf-8?B?a3lGUk8wYmt2dGp5RHdFMSthdVV5L3F6b3I1NmhQVmsvTEI5U1BiWlZTU3Rn?= =?utf-8?B?UGxpVWxkYTNIbXN3VnVDRVJHNytOM3dJZk1qK1N2R1FBWm1USW1iRytXcmt3?= =?utf-8?B?S3FhZGxkVmY5OE9Ma3kxL1EwY04wS0xiQkZCUDVxZklHRDBDNGg2MDlWdUJD?= =?utf-8?B?QVJRNkd6SjZzZ1Voa0NlTjU3SHFEcUFrTlZpLzRCMDR4cllvN1hJTnR0eTFm?= =?utf-8?B?eEJpQ2hzZHgrY3p6VUdKQkVHeHZNWExJR2NkRzloYzBmWkpwcEpEU1pzd09Z?= =?utf-8?B?VG53NXNybjI5MmV4d3BPY0dlQUN3UmhGVVdiN3luN1BVMjdrUU04TVBCSHZr?= =?utf-8?B?NkRiU0xlOU9FQ0xFL1JOcGkrMFh2eGd4ME9ZYlBMbEdBS01uQTNvd0pnbWw3?= =?utf-8?B?M3BGV2lrZ3lVZlN2cDZnd21OZFFSb24vejVCQjlSZ2ZmSXpwMkNuOTdLU0RF?= =?utf-8?B?T3BFZ0tWZDJkYlhqenBwM09vdDlPTGdqLzl5UTdMZTAvTmVJV2ErVWdZNmVT?= =?utf-8?B?TnlSOTFBaERBT3lOUVo2bjVmVXhacUtvSmVCd2JuclNEV1Q3aFFjRERHMW4r?= =?utf-8?B?UmNlNkhxNXozUzk2RERpdyt1aDBwK01HWGVFQ3hzWlovRnQydG9rTmRvQURh?= =?utf-8?B?aW5Qb1RYVzhKVnBDOUNFQ2UzeFlRVzZDME4vbWdVcFRMT2hLTEtCanpHVENG?= =?utf-8?B?RmlCZUJwc0JIOWxNTmxIU043SUZQODQ1VVJWQlEzMTVkSVc3UjFiWWJIdngr?= =?utf-8?B?TkZXb3BQYUUxb2FnNUN2akxRVEc1czRlRjNNaWlidFZmVHhYNWR0UktobkM4?= =?utf-8?B?T3lNcDFBYklhcnV3cUtZbEFmVEJvWTZRVlNsL3N6YzNmbm9rUU5ET0I4K2ht?= =?utf-8?B?UVZiZkZRY2JQK0NFOGJ2cS9vYmNKSHRhbHVaTlBWQkhXUWJmZUJFRUtaT2JM?= =?utf-8?B?akJ6STBLVGcxSEEvR1lDeDdGRHI1dDJPeGcydVlscnV1VXBzZkpRL0UxbVgx?= =?utf-8?B?ZVNFY2IvblVQZlh2TW1BbzMzYS84R2lFeGFkUVY2WUQyYVYzNUNlaVhNdEdq?= =?utf-8?B?YnZWcjFYeXpuQnA0cmcwcGUxQ24xU3gzQmJkcnFGSVRsUGdWdTd2b2RTeHk1?= =?utf-8?B?bTRQNUhIc0hrVHM0SDNiU1NYTkk5Rlk3RjZtOU1UcjA1bGVHZDBVMzgrOHBY?= =?utf-8?B?RUVoQjREcUFKNEt2dGdGRmljbWNrMWYyQnc4Ny8rNzBOR0pPVDFXQT09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee6bad28-4f3d-4f11-5a0f-08de75f2140c X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2026 11:19:31.3944 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hCq39yGmyLWIFdrb2yT9r5xN5H6qSjchh1/QKyymkC/y+Z1PhQJo97x8QbWIB/mEPq0obDt6XH5yA7P7/qy1Bw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8272 From: Guoniu Zhou The DS90UB953 supports four pins, GPIO0 through GPIO3. When enabled as an output, it can be programed to output local data or remote data coming from the remote compatible deserializer. Make a different GPIO range for remote ones. Signed-off-by: Guoniu Zhou Acked-by: Conor Dooley --- Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml = b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml index 2e129bf573b79e0ca8f25b4ec5fc6ea76c50abd7..0444f3739b775848d17adfebc41= 58e83b69adf9c 100644 --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml @@ -20,9 +20,13 @@ properties: =20 '#gpio-cells': const: 2 - description: + description: > First cell is the GPIO pin number, second cell is the flags. The GPI= O pin - number must be in range of [0, 3]. + number must be in range of [0, 3] when enabled as an input. + + If enabled as an output, the GPIO pin number must be in range of + [0, 7] and [0, 3] for local GPIO data, [4, 7] for GPIO data coming + from remote compatible deserializer. =20 gpio-controller: true =20 --=20 2.34.1 From nobody Tue Apr 7 18:46:54 2026 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010010.outbound.protection.outlook.com [52.101.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFC513EF0AC; Fri, 27 Feb 2026 11:19:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.10 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772191180; cv=fail; b=lUlxeJFz+Pz+lVzGC0MugpephDiIyQCTtHD+crmeo4BuBWZ2ViCbYYgaEBK6+AAH0r1p4DBBoLmO4f4jeBKPtWJbPu+YliPrK8VBfA7bW7Ha/Sq3GWjytyLpvWqGGRcI1wTCBXO8aWyza4lO3bmetEafYt9CbTLYBLnRxHMbEhc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772191180; c=relaxed/simple; bh=CdyLKvVvmtYg31rL0IKxQ4LOE/TGVoM2XXjxFPveMao=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=lwoRkNbH2VoL/F1ZBxLuZdP0tuyR5AghF+G2bQNNZt2HA0zgfFbB8e/m8+JaekLkY3DqeA1lCC2jBldU3bTz+5I47WWZ1ThPiiwbU/XseYOd045ZffGq52NNRp5B2UZipBPJHW6Aa4ZuoGPqlQ+9VGaDOPbA6oqaRHqe7Kbm/HE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=OFLyGVap; arc=fail smtp.client-ip=52.101.69.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="OFLyGVap" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VlWHnJV1X7oRIvUj8RC+GoNIGaNkuoy3aFiC8FTtdLfvF3YMz7Sj4sV53HyT+ebm4Zpv8oQRI/ZyF/fJSpU1KCYro6rPQhFe86C933yHqIPCU9vOi6L7phwXxxRHcpFT/1YsrCkXBWXd+lz3YxSm6lsSNYzx7Zoa+qFZVzmoUxvuBr3yl/Tm6T7t8pHMQYKxxz1oaXgdI+nNfP28ISNwj54WQyZ/PXSCX/ePrpC7UEJEIuTg0s/RAl9YvcQ1Pf92lvHgvXcGosj2O4VJfcv6NPG1M279nO6ZlS2kOtmOF6hF4ISTVkpiet1BFJw3+DL4tXe4Vu1lIHKh1izc8fIITQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=49d4rXwGeeg1WxBO9LvqpfX7U/pz/TeJxH4D5oBsjU0=; b=o1g7+cm/SMmTSsbMnAqkNXqlNmvmKN6f20reZ7SpmBHR44eH+fD77f5sjymY3oAM/DckNCMsnkWo6sxtGuI9VuVs19BfwngcMn9SUt1uOUboNRFJ1Ks1WgCz49tb6uefg/3y7WAfuDrtGrWirasAuDMTaqUVYTfHF37e9XskSWDtCX27sahBxs3TX1uwjgrWweljGyK1PsQ/2SvWNhraJ9wkaX1lX32w0b7eeOZUTYa48I6tmW3ZnCglJz/+Ww/kaU9OH+OCn2PnJnugQA7CdYGXN7CbiwDWDmgSYNqOcYR2hFKjilfJ440YuDoGyipySCI/4HlNfNfkZmYqjbixIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=49d4rXwGeeg1WxBO9LvqpfX7U/pz/TeJxH4D5oBsjU0=; b=OFLyGVap5nq2d9c3r4RnFrDe8dBg67ipycFISLzM3lpCBjrKjeXQKQy83r7JHQpjaENAMdWozsAarV4fUXl4wpdjqfLlZnmeARKOfICfMj5s4VXlRK9YLML+GaYVLqS2DpWfKql62rSDzvIFanKMKjn0TCIdNqEXbgI03KmS34OV6evKlCNEDWOdpZkHzuwMp7pXHXz6itucv9cbekI6sNTuu8OXgPFojFH5c8/4hHwMDIOPE2HYHG9z+YHbsBolgCZToa9+C7T0Gl361DSIcPH1MphalVbJVl/Xe8M9LlUI9HnBU53g0o8etc5NjRczFkb1OIjm85/WYFeR8gQ0rw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by PAXPR04MB8272.eurprd04.prod.outlook.com (2603:10a6:102:1c1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.14; Fri, 27 Feb 2026 11:19:35 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%4]) with mapi id 15.20.9654.014; Fri, 27 Feb 2026 11:19:35 +0000 From: Guoniu Zhou Date: Fri, 27 Feb 2026 19:21:11 +0800 Subject: [PATCH v4 2/4] media: i2c: ds90ub953: Add back channel GPIO support Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260227-ds90ub953-v4-2-dea596205f9e@nxp.com> References: <20260227-ds90ub953-v4-0-dea596205f9e@nxp.com> In-Reply-To: <20260227-ds90ub953-v4-0-dea596205f9e@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Vladimir Zapolskiy Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772191287; l=4554; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=pISGgEeyAzizsXSUrwBoDuW/Dqxg3k7f4qx2mZIQ9EY=; b=rQOHZaeUU0AQYWSHYBKQ9ZLNoY6+dQkMvqvb92fjz1Kliw7Hv9squmlSQHn6KxVe3MAVnHp8t DhOQWZGFo48CbHzWMzkDm1ncU9juQO4VsQY/Mn5Zf0cHaeYbp7Fgkju X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: SI2P153CA0033.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::21) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|PAXPR04MB8272:EE_ X-MS-Office365-Filtering-Correlation-Id: 1769476f-23a6-4da7-37b8-08de75f21678 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: 6Q10Hwih8xK7pL8l8hRfiaJZmLDMlJWOm+TXXVKsVChgpiAuHeRlv4wWj1FgOejr15AboZqmsxgoqpfQJLsGvmQiPKXBScdIwmJ2032WZCIcyezo/7q3paO+AWlZSUjBCsSVKvudlTZvLVhnu7SCzIg5nv9rQ/nY5rDFc+m/a/c0EJ0GdA3lJjJGyu/5YbTPf40l99GErC5SssUX5eAWzQEQUJtH42cycH7jq8R97FDM452WF3v4tnKs+nawUP2EsFgI0u+aw/xCyH6N4ot33mPGvMMxkdg9xaONXbzHZTLPrb9LtW1W7B8WCSxf51VJPBny9yes2vfCpG19I68nT8ewDhq5Y93HXFbHZvGFqvMITV8352A+eXZJuJ1pr0nhwKQHKeeAObrs+Ghb8YuvzJP0xB34B4IX7vT+sUlHGzfy/TfAZJXp3xEVCTfRa1TBimY2xokNK/XnnJs7C1NFbx8dd/OcigcTXz7gRGqMAmuvlxywuEKT+GhuoMZKU2SF7vaRKLjDjxJhBtQ9I6eU9zjlwebOB2+fn7RddOrQ69ih5xYOnA7K174tA/qszD5L4KTkbeiu4Pkpwv1tNzTpNafklpX1juceAoAUhJKAbjAREmhGsatzfNMr8C5X9pPEFwU8VjV/rk7j3iLL9IhJOt4IrHtaLNgx4bPwMbaovr1tEsBllBEsU/SyjKJ7yjz1QXNw0Zjwf0OiJ4dxEhD7O7ln/kjtbF1UdGHReuFghTZubHv66pTDLai1PcZ+Lw7RuXuzSEZ/eUWfU3ijehylnAtLr8dFpOhtt5ArzeZMWVY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGVPZGV6U1d1ZGZzRWpYeFhvdVNKKzJiaW4wYTFIU2JONHV6Y3VjMVZESkk3?= =?utf-8?B?Z2MxUFFZcjZMV21hZ0tTU2lVdldoSGkxbVRzeTBua0MzTnVMa1ppMDFqbWRS?= =?utf-8?B?cGV5M3U5d3FyVnQrNE83bmtjaWQ0elZEdkpoVXV2YmVPdk42V3l1NDRJZ0o4?= =?utf-8?B?SGp2Mk1CckFvWDUxejBzeEY0RnF2NlhoUnlUbXZ3QzFMYWxkWXVGSmxOMHYv?= =?utf-8?B?SURzekV0SXBWQmJzM0IrSVZxWGdlWmc4QXFFOTRkYWFGZFpRb1BGMlBZaG5N?= =?utf-8?B?UVF5aWh6SlZTQ3BESCs5VHVkLzNBaDBFK3hBVUsxRGQ3cjZuWUZoMjdUbkNG?= =?utf-8?B?RGduaVlwYVNUZlRzOTQzajQzK281a2IvdU1EenN2TzZXS0t0VjBoWERBdFZN?= =?utf-8?B?ZTFvdUxWVFFlUmNkZWVoczNIUWE1NWhWVWVKQzR3cTZ2TnYwVHlXbEp6NFlB?= =?utf-8?B?NGUxYWF2alUvcnlsL0lBbUJSOGhZUWNiZ0RHRW5DTXZSRnRzQWk3TVVnYzRU?= =?utf-8?B?dHh6TU1PdXdxMURzbnphbHdMVG8rQlVYb0MzdVJzQURwZEg4QnBObUhXSGR5?= =?utf-8?B?UHRRMk1wVWdEM1hVaUFhNElmMWZYclhsR3Jud095YVhTbmt2NkJ1T2N6TE9M?= =?utf-8?B?LzVTakNYZm1LU2YweWY2RHBwZ2RGREc3c2g4eWNRbXNvMGpiVk9HUktzSmor?= =?utf-8?B?TFkvWXFvL2VBMENaWHhIRm1KU2ZNb3VLOEhIdWRIL1R1ZmVqM25lN00rNmhm?= =?utf-8?B?NkZ5SGF1YWpLa1QvK1ZjUGFPOVp4UmlWa1dFbzE0MDV0ZThxVWU0bGYvRXpQ?= =?utf-8?B?SDFyR1BKS3lHb20wbXdXY2Y3RlhJenFGUlY0TE9CSGNYekhhVE9NYTduUUV0?= =?utf-8?B?SzBlNEdRVmdFdTFoTjVvaHdNejFZbm9iVGRIdnVEcytKSmlrcXlOenBJc3Zs?= =?utf-8?B?U1lPVFY4bjRIa29lWFY1UXQzWjAvTDBJNHhndjVVTFhITEZad3hVQ2ZKcXhZ?= =?utf-8?B?TUlPOTFxRTAxOXEyMkpHa2hnYmZXZkpNekJldkNlaDUwdDR2WSszZU5kSUtv?= =?utf-8?B?anJ2TzB0eExNMVFYaU1oOHZDMTdZcTJaa1V4WkVjY2hQOFdDNlEvaVlTek5a?= =?utf-8?B?ZTBTVUE5MkMyOElkU3N5bzNMbGJzVFBtZURnbHVXNE10cjBsWUZCL1VYWHV6?= =?utf-8?B?M01DYWJ5TlFYZ2Q2NW9NUlNsUzdTWkFtU3loWEE2MVZmNCtkV3BvNGp2WGhq?= =?utf-8?B?aFZDU3QzUnJxRXdGMElNRHhJVEt1SDNzdndyVGVoTGo1UTd5M1ZqOHV1Rldi?= =?utf-8?B?STFDdkNQK0ViZFUwMHpydTVocFV2dXdTbEw1RWdNVzBMcFRTSUlhSUdPMUxS?= =?utf-8?B?NmNKWk8vWHgvNmpGR3d4NmhMbWJGak9FTGtsZnI0NU5JUVZOWGQ2cXI4Nk5s?= =?utf-8?B?UitlQy8ralRpSktzcnRYcWFRZFV2RDN5L0tZZXYvcjNMWjVwdHdDUjVJb2JX?= =?utf-8?B?WUM0UXl5ODR0cXZsSXZ4V0g0VUhPUHFZTzlnLy96ZmxKUVlUWW9FcjBZbGRr?= =?utf-8?B?S2wzOTY5dldleUk2KzhaSzZOMGZQMEg5TkdWMis1SGdkSEk4RWM3clFyU0sz?= =?utf-8?B?U3ptWi9Lb1JSVkVhRndDMEpzSnRUMkNPUHZLRWJLdEY4bWdaVDBKdEd4bmM1?= =?utf-8?B?bE5EYlU2dGhvQUF0WVZtaXJYZ1JsdjZtVWxwUE9pYktzKzFwVlpNaTRDSFd2?= =?utf-8?B?bTVBUFVDZ2lBK0RFRnoxTVhSazJCbDVSMzgrbC92TEU0L203R1g4dW9sTVhs?= =?utf-8?B?Zkp1TzZtMHVNL1ZXWGkreUIvWmR5NG80UUIwNWRZTllQOEhxOEpiWVlieDQr?= =?utf-8?B?Q0Q0a05Kd3BBbDlwMmVqY1BzRy9vazVCZ0R5Q0UzamdNSHYwTzdpVVJiRkt0?= =?utf-8?B?Ymc1alB4UzhMRk1pdWM4a0tlVDUxQ2JobW9MYjJybFFvdnByUGMrd2dkYzBV?= =?utf-8?B?SDlQQ0pVTHpnelZuMnQrM2o5NG51SEJodDc0bStxMVdXWFlhb0FpUjUzNDEv?= =?utf-8?B?bm9pMU9UKzZUeFJ5OGkvcHF5c0N3eGdFZ3E1QnlZb1JqVmFhRTh5S3dyZmhM?= =?utf-8?B?K1FkVHNOcEIvUldnWmltUGdJSjM5bEpnVkxmc0cwZStja2pzaTExWGl0TlBp?= =?utf-8?B?R1NIQmt4UERZWXlrellFQzg2T3dtUFlZNGFFNm5sb014VHJMMFJndE1RbTRR?= =?utf-8?B?RjhsclZtbTNiWDA2U2tqSDRIZ1dETGl3czhTa2xXSUc3N3FXTDNwVUNSMVdv?= =?utf-8?B?USs5V1M3cElodGMwR0RVejBwVktQaktqTkx4TTFxcFFCZUlNSEVhZz09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1769476f-23a6-4da7-37b8-08de75f21678 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2026 11:19:35.4036 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N4FNm5g6maeS9fJOApqvH5C0+f99r6zqHryA5oVPzjR6olVfg4F0BsQZHDAyVof85Q83N8cvZP2LS4a8cBT4rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8272 From: Guoniu Zhou The ds90ub953 supports GPIO0 through GPIO3. When enabled as an output, each GPIO pin can be programed to output remote data coming from the compatible deserializer using the register LOCAL_GPIO_DATA[7:4] field. Make GPIO range from 0-3 to 0-7 to support this case. 0-3 for local GPIO and 4-7 for remote GPIO data. Signed-off-by: Guoniu Zhou --- drivers/media/i2c/ds90ub953.c | 42 ++++++++++++++++++++++++++++++++++-----= --- 1 file changed, 34 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index daefdb108fbf402453baeaccc61d1f3530521d74..14dd0aa4cc6ceba66a8c3545c7d= 7d19694007431 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -32,7 +32,9 @@ #define UB953_PAD_SINK 0 #define UB953_PAD_SOURCE 1 =20 -#define UB953_NUM_GPIOS 4 +#define UB953_NUM_LOCAL_GPIOS 4 +#define UB953_NUM_REMOTE_GPIOS 4 +#define UB953_NUM_GPIOS (UB953_NUM_LOCAL_GPIOS + UB953_NUM_REMOTE_GPIOS) =20 #define UB953_DEFAULT_CLKOUT_RATE 25000000UL =20 @@ -268,7 +270,7 @@ static int ub953_gpio_get_direction(struct gpio_chip *g= c, unsigned int offset) if (ret) return ret; =20 - if (v & UB953_REG_GPIO_INPUT_CTRL_INPUT_EN(offset)) + if (v & UB953_REG_GPIO_INPUT_CTRL_INPUT_EN((offset % UB953_NUM_LOCAL_GPIO= S))) return GPIO_LINE_DIRECTION_IN; else return GPIO_LINE_DIRECTION_OUT; @@ -277,6 +279,12 @@ static int ub953_gpio_get_direction(struct gpio_chip *= gc, unsigned int offset) static int ub953_gpio_direction_in(struct gpio_chip *gc, unsigned int offs= et) { struct ub953_data *priv =3D gpiochip_get_data(gc); + struct device *dev =3D &priv->client->dev; + + if (offset > UB953_NUM_LOCAL_GPIOS) { + dev_err(dev, "GPIO%u can't be programed as input\n", offset); + return -EINVAL; + } =20 return regmap_update_bits(priv->regmap, UB953_REG_GPIO_INPUT_CTRL, UB953_REG_GPIO_INPUT_CTRL_INPUT_EN(offset) | @@ -288,10 +296,14 @@ static int ub953_gpio_direction_out(struct gpio_chip = *gc, unsigned int offset, int value) { struct ub953_data *priv =3D gpiochip_get_data(gc); + unsigned int pin; int ret; =20 + pin =3D offset % UB953_NUM_LOCAL_GPIOS; + ret =3D regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA, - UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset), + UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(pin) | + UB953_REG_LOCAL_GPIO_DATA_GPIO_RMTEN(pin), value ? UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset) : 0); =20 @@ -299,9 +311,9 @@ static int ub953_gpio_direction_out(struct gpio_chip *g= c, unsigned int offset, return ret; =20 return regmap_update_bits(priv->regmap, UB953_REG_GPIO_INPUT_CTRL, - UB953_REG_GPIO_INPUT_CTRL_INPUT_EN(offset) | - UB953_REG_GPIO_INPUT_CTRL_OUT_EN(offset), - UB953_REG_GPIO_INPUT_CTRL_OUT_EN(offset)); + UB953_REG_GPIO_INPUT_CTRL_INPUT_EN(pin) | + UB953_REG_GPIO_INPUT_CTRL_OUT_EN(pin), + UB953_REG_GPIO_INPUT_CTRL_OUT_EN(pin)); } =20 static int ub953_gpio_get(struct gpio_chip *gc, unsigned int offset) @@ -314,12 +326,19 @@ static int ub953_gpio_get(struct gpio_chip *gc, unsig= ned int offset) if (ret) return ret; =20 - return !!(v & UB953_REG_GPIO_PIN_STS_GPIO_STS(offset)); + return !!(v & UB953_REG_GPIO_PIN_STS_GPIO_STS((offset % UB953_NUM_LOCAL_G= PIOS))); } =20 static int ub953_gpio_set(struct gpio_chip *gc, unsigned int offset, int v= alue) { struct ub953_data *priv =3D gpiochip_get_data(gc); + struct device *dev =3D &priv->client->dev; + + if (offset > UB953_NUM_LOCAL_GPIOS) { + dev_err(dev, "GPIO%u be programed to output remote data\n", + offset % UB953_NUM_LOCAL_GPIOS); + return -EINVAL; + } =20 return regmap_update_bits(priv->regmap, UB953_REG_LOCAL_GPIO_DATA, UB953_REG_LOCAL_GPIO_DATA_GPIO_OUT_SRC(offset), @@ -330,6 +349,9 @@ static int ub953_gpio_of_xlate(struct gpio_chip *gc, const struct of_phandle_args *gpiospec, u32 *flags) { + if (gpiospec->args[0] >=3D UB953_NUM_GPIOS) + return -EINVAL; + if (flags) *flags =3D gpiospec->args[1]; =20 @@ -632,7 +654,11 @@ static int ub953_log_status(struct v4l2_subdev *sd) if (ret) return ret; =20 - for (i =3D 0; i < UB953_NUM_GPIOS; i++) { + /* + * Only log GPIO 0-3 state since remote GPIO 4-7 pins reuse local + * GPIO 0-3 when enabled as an output. + */ + for (i =3D 0; i < UB953_NUM_LOCAL_GPIOS; i++) { dev_info(dev, "GPIO%u: remote: %u is_input: %u is_output: %u val: %u sts: %u\n", i, --=20 2.34.1 From nobody Tue Apr 7 18:46:54 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010052.outbound.protection.outlook.com [52.101.84.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 850063EDAC5; Fri, 27 Feb 2026 11:19:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772191188; cv=fail; b=bTkRjN31pQ3bIgqRrUOjA0KlH84kSOwJ1jDgVtrgcGlwdaBBT5dDMKhboIuBcLN4ZSx16uO3VaFJZiy5uf2lfCTaWOpea2jDqkvBMExNEgePHJg6KWBpl6speETjMVCCaVcIE4dxxwB1mWny9TKcHORNB+C/rG9X6sW1AQCtp9U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772191188; c=relaxed/simple; bh=ore1IFN0JAX7iRYKgaaTxmKz10F6mdKkJRfOVzt/i54=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=oWZZJd05fYs0uWPbLhwtM8Im+YvWN11eNErKZugeA+PRnkIqlrkR0nSbFYERy1fkF22j91+JPMdEymivF70La8U6jt9DtB18CNLaDH823ETref0Fqvjc2Iuo+3WIRLyKIl7acBxoAqMZvR+qEL60BUSykQ4/WFp851CjV2CCqZU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=V77cs/LD; arc=fail smtp.client-ip=52.101.84.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="V77cs/LD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PQE+8rdLyf+fasG5Wy8usy2jVMkmqdWMbNePky5GKfSkexxPimobdl2e6Qa2kTDbNOwjO9JRcjXKSu1kozVDMnn9PUJn+r7sJNd9XEi4wzlQ9+A/lIBQU9OSnbhlEs2+kY4tSBKKxrC2/sBMblCBiQlPEFA1yfO5cbu93uEP6dw6v/AQlvS0ZHNjJ1g2R6RAGHjkp//l65Gg+0Wq/JrD7cv/K4XJu8P0Cif7V/W0th5K9nnPMUSNX2YyK3Q4yP8duPYPRPXTsCdrFMuJLX3GCSKFzv3dMP1xD+YsIFB99W4WJ2WJTzQayYG5qyMQsq3KU/+MuLbgpMTYyM2X6hAQcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PF95Mv+uMZVyYEwHGA1nDKV7VMKtclIbRFQg4zGCO9s=; b=YPO8A6E9RC5r0bEBuAiwg1CHrvOuz64vkHVVibylPdfijjqjAcmWKiXu5JfeHvOTEsMyM5qfF01CbllvmzsJJQQ4MMb9j+AUqNPefyUBLYjeZss4LI6HN0kcN3GO8f1ZnDgTD+B4cASlXPuzsczoE/kHMa4eRs/u/P3QtszTUTVlvRi9Sl9lLRsvOxXO8mtlU5sAW7ouDHmmTDTstxdt+bV4w6Rkib49IBTs+iIzzg/iJBfsq+vqproWGcgkK9awnFejZf5ynZvhUBTgLmDhAbjc/02+IODU0s4ekT0Tj1tBiFIi7+RtyzIv5QYcvC6EwIf/P/PhTovWNCNj+gy4ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PF95Mv+uMZVyYEwHGA1nDKV7VMKtclIbRFQg4zGCO9s=; b=V77cs/LDGm4KPoh3EDYBFWVjoT9YqCMg1ddVFgh5iE9JcE/9RNvie2/e/z90sjELh56CtQWI2yj2oipltfskE1/rySUjGcqcAM7Ru0AKSo2RRUWxcy3FDTOaSzE3eTwEv6EaTwiXxNbFW/xScAcUmBbVS6cFAIeo5XMJCxAhdzdeqvum/S5AYXBLHDRo0HNQod71/NN+2mJQklqrv+ZGMstZa9Wu4hjSaJC/jiiPvnGlMt0fcn6wtGBncQX02/5sPJcx8bokP9exb9GWyJRcu2GnfqTE0BHx5cTGNjDfuNM8NiULPouHIOuaKzL0g0olazlGa5LccgK2jOuOREyBQw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by PAXPR04MB8272.eurprd04.prod.outlook.com (2603:10a6:102:1c1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.14; Fri, 27 Feb 2026 11:19:39 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%4]) with mapi id 15.20.9654.014; Fri, 27 Feb 2026 11:19:39 +0000 From: Guoniu Zhou Date: Fri, 27 Feb 2026 19:21:12 +0800 Subject: [PATCH v4 3/4] media: i2c: ds90ub953: use devm_mutex_init() to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260227-ds90ub953-v4-3-dea596205f9e@nxp.com> References: <20260227-ds90ub953-v4-0-dea596205f9e@nxp.com> In-Reply-To: <20260227-ds90ub953-v4-0-dea596205f9e@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Vladimir Zapolskiy Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772191287; l=2628; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=7CksTlZU9zGrYvj92+U8xHf7qBBsXdtbS4LgUhKVieI=; b=jzgQ1s2W6nhWIaDavIFC5oSpU7U90FO41QlWKkdNCY+cFp6h3J93+ybnzGmcInyvBsRgz9Bn1 x8LqPzimm8XB2vhB2AkFOfbhcabI3ce2q1m8lUfrcYLX0S9IpP97G1k X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: SI2P153CA0033.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::21) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|PAXPR04MB8272:EE_ X-MS-Office365-Filtering-Correlation-Id: 8444b854-8ef8-4c4c-6b5b-08de75f218c3 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: XmhL0vLiisDXIDdZ6jwT0wpmzDZWN4tqImpavuxtf+54ZRk8oeGJtFPZBhcJmp5arL+GTAYmZbZ6l6W2l4ShjRvKNcxUyTYbQ4/9bKNlKKhtmZku8bEwQnBU55KDfJPNuvB7wToRpyX98vZMRWgkR2aBTLsEiCW5x2rntQ+Kw/RIfWglB+tKmG74XO6YZBdzdIgldRH13JGGCzWRmMsmw9JhHYFV5ZSDQqJ4QpMENgUATh4mxZ0Bwvcui+bnm9ccGqWAxxFuy9bcr1ALVjguxkZov3eSdiCGDkWR82i/f7Y6q84nwXRdPBri7RAQi8oS4m9bLmOOD0KsnompPNHha9/NvJ+lPfQiYE142Z7e7BVq5canEe04nNVaqTJb/VPRx66u8ycPBVznkAYZmtbcUWwdgmlbPIml+T9LHn3u/EtUeADAveRGttUXWQeZPTK02qBvlzC1u/amjJgS+CkGeowkQZwxgxydt72SJk2pGH6hIIFVMP2IfG7kihDgZP7z4v/HwZGg3eHdqoLNMGo9AjscCjMEHjJjYTeNiA8qRUng/zFnF6YZDDXDe6oUMBedzWnVzUuKbEdQPXyp2ZDb9lnFrHFm6H35iHb3m+rjfMttnbKot8iO283uW5lNMAI+IvsBTOxtlDl/JI0bmWOFj5rzoaZDJzLvHNSUcVEplK/rlG0C8fs2jgV/E17ro9wDuyigtkvIktCOIAo+75fTlY4gviuojJe9gJdy01CCL/26wyWOoM3T8+n+Q3iD9CTfwd805Lib9hAHzpjJdkAeZKHT/LU+1sGoCSJroTRX0K4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0JaQVhvNGdaejEzZkEwaWk0K0d6ZHlHRm83VzBJNmUwV2xLTFdFWm9IRisw?= =?utf-8?B?dWY0NURWRjZsM01wL1ZSZXhvK0NmOWNjUk8rR1JZRkVJanN5SkZBNGxIN2Ev?= =?utf-8?B?Z1J2bzNMNENHdXpmVkQybCsxTGIyeUxFWTFJSTZVejFsSHdpSzFpUVlQQjVB?= =?utf-8?B?YjNXOGlrL1hIaFAwZ1lOaTYyc0o0amdlLzhlcmd5WHNUTmFHNGRoU09vUTVz?= =?utf-8?B?d0xkTXBPVEd3ZUNneDh6ZGExRW9sNkdDOVdNUzlSNjQya21zdjZhY2NUaWRW?= =?utf-8?B?WmJVQWZOK3h0QzQ5VmpPWm9ic2ZSQm0yYzIwZDIyRmF2YlhNbDZoUHpRY0R6?= =?utf-8?B?dGViT09ZR2gxNUQ5YWpoWXZMQzVXVUlua0t6ZVJnRndxamtFSDNqbGlSOXRu?= =?utf-8?B?SVBNVFNjdjNQYXg5c0tRTmxoeVVWOTlLSnZmQWhROTNXdXRQa0ZSbWhmVGsv?= =?utf-8?B?TWF4QzlnL05JVExReGViNXdRcFVuUjdwVi9QS1BrdXZBZTlvdktlREFnOXdP?= =?utf-8?B?YkI0ejVIc0RobStCTUJaaTRERm11Z1NqcnAxd1lXK0ZWYVcxT2FQQ0oySXVK?= =?utf-8?B?NDFwLzQ0WDhVMEV6VnVPMUlGU0lNMzVsSGRKZnZMUXQzT29abFRud2I3ZjZH?= =?utf-8?B?L1BINHBXMm5PcitXTlh4and1K0hQVVQxSExzcDJpVHNNLzRRZmNYQkhWVkFI?= =?utf-8?B?ZjliTG1hMk5GSnpLbWRadkdIZjJUYVBsMHFZSHhxaFFVYy9vUkpwMHRsMUJa?= =?utf-8?B?Zyt0KzVnYnNQT0I4VUxQY3F6T0piclJQemFMa2hYOERjNE9pV3h6NVBQNHRh?= =?utf-8?B?YWk4Y3dybE5LKytGSWNydC82MXdkZ0M4THdFSkF0UnpOTHkyMlE1NkpuSmJ5?= =?utf-8?B?NlJRWStzMFJZamZnZ3ppWm9jbW1OZm84NTdSM0krUHdHM1FqOWVqVWVzMGNn?= =?utf-8?B?V2F3dFZ0V3NXNkVqSGcwNUQ3RDZVTy9jQ214d3ZCOWVrRXlwdTIvVm04SmpE?= =?utf-8?B?TlVHRnJQNW9wNzRiREg3MTdJQjdWT0pZOWxmQXN1T2MzVGpoWVdoRWpzQXRp?= =?utf-8?B?a1FsMXozRFQ5a0hwUFVGVm13WVI0REYrT1JlT21hY01lRzdEd2diblRMY3Fz?= =?utf-8?B?RXpVZWx2T0tqdU1hOHVheUpOMDA0cHpqMkxrQWFJTHl6anJkV2dRZ1RONDFl?= =?utf-8?B?Y1IrbkZ6Ym1wQmpHcjB1OEd6Z3NHZ1RNY1Y2SVY3TzJSejNnWEFvZVY4TER0?= =?utf-8?B?UjFOamlMQ0hvZ2RnSnJWSHhOVVZiNEhWa04vZWo3MWRDelRtYmQ0czVReVox?= =?utf-8?B?dmZuT01RYnNlRUhySEV5Q2Q3MFNUdHJDZGhlT0psWCtTSGR3MmJqcklqNW95?= =?utf-8?B?bFp1OXNQa0dEY2F3REM3WkJ6UUFrTy9qeFRDS3ZPbkxacURTVmwxbno3cHR3?= =?utf-8?B?WGhDaytaMjJBeEl2UWtuT3QyZ2YwWjlTKytrM2MzMHlrbVF6cEdJNFh4Q1hr?= =?utf-8?B?dHV3aE5XNXcyVTdyZCt0L2d3em0vV290dHdiY05yOVg4S1FveG80K21wakpH?= =?utf-8?B?QVRYbWhleEloVm8wZWpZV3NnWXlvU3E5YU1vNmhtYVEzQi9TaGFQLy9JQUw5?= =?utf-8?B?YnM3QWhxMG9xUXpmc2RFTjM1L0tUTURtOXpNUHlvR0cwS0RtNEhOM0o0ZlNh?= =?utf-8?B?MnVuV0lXSE1zMXA2eVZSZjlhWm1MT25aMnJ5bHR6ZTY2ak1XcnhDSFhTTU91?= =?utf-8?B?Z01KeW9yRS91K3BhdlJRdWhzZ2VoMWZtaTVNMVc2T0dWWk0wdk1IbjRVMEwz?= =?utf-8?B?TGphTW1ZRXRwY0VmVVV4S0dnV1lnNTlRd2FvWmFsc0pmQWtFQldLVE9pV3VH?= =?utf-8?B?N0NyajV1VVNVbkpBMkdaUUdETW02SGhsV1JsUlJZMFFielBvTVViK0huVUtK?= =?utf-8?B?MWtxYTVaK0hlUU8wTnViTlZ0Tll2VEdwZVdIYUZqU0lzK09abkJBQTFvSndx?= =?utf-8?B?UGQrZTExTElEMmVISit5N0hjM2VERlBZYjJ1UTlJaGR3Sjl4a2crenJPQ0Jm?= =?utf-8?B?aERPQVRRWFJtbFlrcG51MGVHbC9HaFEwdEdKL3pNdlQ4ZUFiN0dPOXdkVVB1?= =?utf-8?B?RWhHbmZnNktrNSt5UGxFWlhwRU9kcVdyYStlaXpkcktoVHhaNSt4bDBmcStw?= =?utf-8?B?aWtFUURydkc5S1BpMDhnUDdDNWFhUkZjTEFQYnNxa21PbG8yMWJxWXl2eFdt?= =?utf-8?B?ZGhVQVhIaU5MblZCbm90YnNDWHRGampkOEQ3Q0x2WjZxZkpiejArWEFLSExv?= =?utf-8?B?S1BsSytsb2wwc0twZGdCcXVTRVRsZGM1VjhNK1ZWZG9mYlNvZFk2dz09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8444b854-8ef8-4c4c-6b5b-08de75f218c3 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2026 11:19:39.2894 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DlcO7l7cMGu+dNh3KOaIhHnGLqcPa9OFWxdpUOHsIcCrZ61KKP+IEN/UcN2Y3uM8g2OkcbNcN4sMWj5XmxUWyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8272 From: Guoniu Zhou Use devm_mutex_init() to simplify the code. No functional change. Reviewed-by: Frank Li Signed-off-by: Guoniu Zhou --- drivers/media/i2c/ds90ub953.c | 33 +++++++++++++-------------------- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index 14dd0aa4cc6ceba66a8c3545c7d7d19694007431..a85c6a9b64070491db161ca1586= 179dba9c69cb0 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -1345,7 +1345,9 @@ static int ub953_probe(struct i2c_client *client) if (!priv->plat_data) return dev_err_probe(dev, -ENODEV, "Platform data missing\n"); =20 - mutex_init(&priv->reg_lock); + ret =3D devm_mutex_init(dev, &priv->reg_lock); + if (ret) + return ret; =20 /* * Initialize to invalid values so that the first reg writes will @@ -1354,32 +1356,26 @@ static int ub953_probe(struct i2c_client *client) priv->current_indirect_target =3D 0xff; =20 priv->regmap =3D devm_regmap_init_i2c(client, &ub953_regmap_config); - if (IS_ERR(priv->regmap)) { - ret =3D PTR_ERR(priv->regmap); - dev_err_probe(dev, ret, "Failed to init regmap\n"); - goto err_mutex_destroy; - } + if (IS_ERR(priv->regmap)) + return dev_err_probe(dev, PTR_ERR(priv->regmap), + "Failed to init regmap\n"); =20 priv->clkin =3D devm_clk_get_optional(dev, "clkin"); - if (IS_ERR(priv->clkin)) { - ret =3D PTR_ERR(priv->clkin); - dev_err_probe(dev, ret, "failed to parse 'clkin'\n"); - goto err_mutex_destroy; - } + if (IS_ERR(priv->clkin)) + return dev_err_probe(dev, PTR_ERR(priv->clkin), + "Failed to parse 'clkin'\n"); =20 ret =3D ub953_parse_dt(priv); if (ret) - goto err_mutex_destroy; + return ret; =20 ret =3D ub953_hw_init(priv); if (ret) - goto err_mutex_destroy; + return ret; =20 ret =3D ub953_gpiochip_probe(priv); - if (ret) { - dev_err_probe(dev, ret, "Failed to init gpiochip\n"); - goto err_mutex_destroy; - } + if (ret) + return dev_err_probe(dev, ret, "Failed to init gpiochip\n"); =20 ret =3D ub953_register_clkout(priv); if (ret) { @@ -1403,8 +1399,6 @@ static int ub953_probe(struct i2c_client *client) ub953_subdev_uninit(priv); err_gpiochip_remove: ub953_gpiochip_remove(priv); -err_mutex_destroy: - mutex_destroy(&priv->reg_lock); =20 return ret; } @@ -1419,7 +1413,6 @@ static void ub953_remove(struct i2c_client *client) ub953_subdev_uninit(priv); =20 ub953_gpiochip_remove(priv); - mutex_destroy(&priv->reg_lock); } =20 static const struct ub953_hw_data ds90ub953_hw =3D { --=20 2.34.1 From nobody Tue Apr 7 18:46:54 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010052.outbound.protection.outlook.com [52.101.84.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D0CB3EF0A8; Fri, 27 Feb 2026 11:19:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772191189; cv=fail; b=Uafw4tysYvl+6oVqYXtN+Rou3xd44oJr9FDZQz1IPtSR1RMTge4RTTR9hd3sGgxBwagOS8ErldNSG4MsNLa0/z+xO6FGzVVTXQOWIlC87U6ITEiAyZuC7NGZAOX84MuLWl/U1X/4BoAlpLgXHvo6zk39uFz+OQ7v49PKprEHeig= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772191189; c=relaxed/simple; bh=o3WEJQuvBSglI3gOb6xhO0qM6yjqfrXmqB0glmBDPWM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=AIl5WjxZxAXYaLkSjeudxBHJsyrczgVPg3q8/i7HjQM5ZJy6ufpzh1fGfvv54d7efLCSwxIT2cM/sTGwTGQXO6B9plyWMjgTnAOBav+2teUhUysqt0+/FRx6FWBaRx126aEvoYF6tG5BL3BUgd/vhnH0Sz0wUXy1XLRRilcwfb0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=RwTMrFSj; arc=fail smtp.client-ip=52.101.84.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="RwTMrFSj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gW/XhAKaUzxv6bnmgmJ6ay3h8p5FNhcrvE+Nn5yYC+uss2o24gwc7U2TjL2onJvwPJ4mTF71sSeo5xM4NGzwUNGpOXQMsaj0kgweh8M7wETIjXFp0Oq9OHlkHldjc6oy83oF5msArf5T6OzRJ9+qUlENMHibD2JT84u1S1q6njtyDzgVfem7McNsEZpuOsrNFC9yyIp4i8QJaZxhO0RkVO4P1mXeSJTSf/nUbtH2ccJ5+Gufr+MZu++xM2uzX165wdXk92deYymJPpMZdDWqA56BRFZB4ta4TPFvmAOufMIn92MLMz4jmr/mA6IsRKcqckyJYmhc6+dKAfZVghkdQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lgw5A27Fq/Xmmk6axnGp5p4AdQD2aNs3UIv4EPtH1BU=; b=wfPx9IaXdq4lKeWT/41/aJM7zC8WZIre7KqxRJrhbdhn6r/z1k3HIQ7HVxSZ3kNLp2NCwpecRWVmjSA9nJNqvzgJU/DZmcEIrHz14CbxpHMzULwkPTAud06JHm4czDQLuM8sWzVMS6adhYNfc9o7dBG8/hFEkldX9OyHXCZ/Q/cc6MQ0dcidmI87qjUwXjpJXpNlLtI6Xo//QdVmpo9eRWQTiiqqo7pwHmu/kgOR73hPJDuz1NLiauu+cHx8N8kg9NNZr7w2+Sh5FruVfhWqCYVxjbby0IAMg8zop5Gfd3MdyjItZlEWoi+YMgKJMFGE7s+g8M7wJGnfvkEN7Wi+KA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lgw5A27Fq/Xmmk6axnGp5p4AdQD2aNs3UIv4EPtH1BU=; b=RwTMrFSj4o2Ye8d2aLLVHqplqv9jOomnuzZ6Vn1wGVh4kV44fMHYrTFznnAsl6fQkoWrx1k/F9ZDxE31YHgWaz+bHS6PrpD5r5Nl5o1KSpG0v4KPMV2L5wnKZ2oHAVxvIl7UNaGnvOgcC3Sp5Lefn6R+Cm1nqFMD+7HgtV25+MeHL/d3u2lSb8kcEkuuc9n0zWzIyjCdc2tPdcqns4ZxxowVMjwJPU2nWX6/RMaEwf3/IV9uufnto/+CzFsMoMMr7wRzckSNEIxAGwsGzwbnZkolOde/lYXtg298wIWouu7uFvMVgorIHuip9ITBMQ7FxynaqgWsS/lwJ2E38DVt0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) by PAXPR04MB8272.eurprd04.prod.outlook.com (2603:10a6:102:1c1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.14; Fri, 27 Feb 2026 11:19:43 +0000 Received: from AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb]) by AS8PR04MB9080.eurprd04.prod.outlook.com ([fe80::92c2:2e03:bf99:68eb%4]) with mapi id 15.20.9654.014; Fri, 27 Feb 2026 11:19:43 +0000 From: Guoniu Zhou Date: Fri, 27 Feb 2026 19:21:13 +0800 Subject: [PATCH v4 4/4] media: i2c: ds90ub953: use guard() to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260227-ds90ub953-v4-4-dea596205f9e@nxp.com> References: <20260227-ds90ub953-v4-0-dea596205f9e@nxp.com> In-Reply-To: <20260227-ds90ub953-v4-0-dea596205f9e@nxp.com> To: Tomi Valkeinen , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Vladimir Zapolskiy Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Guoniu Zhou X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772191287; l=3324; i=guoniu.zhou@nxp.com; s=20250815; h=from:subject:message-id; bh=r/v6tcNvULydFHfDTrfblx8lKA6B3paTS1RqF7h0x1o=; b=yJ96B6IfxUkdRGxPVhYJpUk4DGIpKSvOQCbJuPPDDJYMrrQH479KO0Q7hrtYir1RaqNFUmbHR PfZhR3gEqyfDEtqGofPEHzFMh0VJt3S2mnMKJsFkFb2JdDmxm/vDxM7 X-Developer-Key: i=guoniu.zhou@nxp.com; a=ed25519; pk=MM+/XICg5S78/gs+f9wtGP6yIvkyjTdZwfaxXeu5rlo= X-ClientProxiedBy: SI2P153CA0033.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::21) To AS8PR04MB9080.eurprd04.prod.outlook.com (2603:10a6:20b:447::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB9080:EE_|PAXPR04MB8272:EE_ X-MS-Office365-Filtering-Correlation-Id: 1096dc8a-8a21-4b3f-8faf-08de75f21b24 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: 87oGJI2jV23xyGAnWvCmk4EZ295teIASn9UgAATe6mIf5LFHzDE/OSDa6cFDqCbqnWM2YdJQ1LiJ9dbtEzYrdMYz62DQ1x2q0o3npAuYK3nJY9VAFGeokM0Oioqw74ozQ8FmH6tk6Gkeqkxg5pZuVpCQRjOE35GrqDlhQd7X63FRWpqRBV11lDg+WLVkzcx/n1jKL8sMdurUjrG62SmbIPaF/B9wv9+U+7vfQ+1hUfOnmvsjl9yXpN7k7NR+Jdgoa5qyB82Rr3oAG9JK2oBKIjeCearG3Nbq9/JZlMlcprMjFPVb9498T/25pWF0t/QorrMMrjAnKYS1QfvL9uIP0huF6anbYygh+XNVD+K/HasNg4PH7UZWnn0sE58/uJP/yeQByYbgK0exyqI/2vmTc9Yd2VPqFdOKPPMFe8afwUgqMQOyQ9GaYUmwg7Qn+TdCnzXkkx7BDtoYRpqzdPuW0JPZRuqyIr9Dv0x9c1zv77XfE7JeSUsIXxf8l3Nfczj8N/OA168HAPzcWJXdLgu2obVBSGZffS4HaxGO+y9OFghARkKAQoLeXS71LijBUzWu6NmrRchYXxA2kJ5dRXXrfpEL5kavchdr6Sb2JJ9zGolbw3M9w/EBhQ7WEIKYF8UCYf9a1PsUyYpcVqH21T1pvfsncojJlqvi+/jaOZKs7asbmUL7JJ2r0VbA8CZRR40ESlD65eBYmmtyhIu5JawglDu5TrskWW/MtAoP4gjrTAH5izPzc0Z7Yw1YeHwWcsoMbya0F1yrOh+c4OnxSJymr4Y8vnhnbC+ft85DCUlq/kg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB9080.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVlOTjFtWUxLR3kybTBncXVsMGFsYkdNUE1zWUtSM3pmME5nMjBVWkpydXpR?= =?utf-8?B?Mnl3Wkd1UHl1WklwaWUwV1VlaWRDN211VEtpdk50aGVuSzFFbGxZcVFlbjEr?= =?utf-8?B?NitQOXUrdXU3RDRLcTc0Q2EvWjV0RDRzWi9SdXNqQ3c1ZHQ5YXlNYXkyaGNK?= =?utf-8?B?Q2c3ZFhwbUhYNmhFNUtjK2l0SXNJQm84Z3JqUGxiZlo0Z3dRTm5UUGpjQTd0?= =?utf-8?B?bVMzamQxTk9TVzFIV1A2bVZTT21aWnl4UTdVTjBXaHdSWWtoem04TEZhd1Rw?= =?utf-8?B?VVBSV0F0QngzbVo4azJZTHhIVFBYSVA5OU5lTlYzVVJzWDZTbkFJMkFYRE1x?= =?utf-8?B?bVJQOFcrUXhWei9jRkVVZkhRQjZXM3ZRUVlKcXc2anJPNlVrL0dqS21aWVNI?= =?utf-8?B?QWs2eEtWSGJ3cngyQkZreVZGTXZZZlBqTDZyTFNxOFNubmpIYTVBbllUUHA5?= =?utf-8?B?cnVjUlc0aEtHY0JSMEQxWHg4eHVjcVpYRmxLRHJXNVg4cnJmbjRMRHI2aUlx?= =?utf-8?B?ZEFqSysrbk5DM1ROOU1DWmE1clkvZTI1NVpzN284c0FVcmRPc1BCb29EVk5C?= =?utf-8?B?SXdnNzVwNHF2aVRXTGJSV2EzaWVzbDQ1bElqcUtON2FIbnd2UjZ2eittcnVy?= =?utf-8?B?WVRxaVYxdEZLbFdBOExYVXlsbk9lRGU4UE0wbkg2bzdhSjJHWGplZnM0YjZN?= =?utf-8?B?Q3QrUjVMQ01oZlMyaHZ5QWVPWVo1Y1pINkNJVHBsTjduaHlReGdRanJQZExY?= =?utf-8?B?Ti94dDE0V0FRa291THl1TndHMDUwckFZNWdDbnBsWVNMWUIzVEkrZXN4MWlP?= =?utf-8?B?V2FDUzRzY2F6Ymc3dTZSa3BXMnYwRlY0QTBPY2k2SWF5ZXhheDdKTXpDWE92?= =?utf-8?B?OGZBTmlsQVl1Q0RQZElIZXVkKzN5QVYyeG1uckEzd01ycWsrbUovaWdVRFdT?= =?utf-8?B?cHNQcHVINUxMM1YzNnZqOVljSEx2ZGp2TGlmVHFEMVFGNVMrS24zNFMvekRI?= =?utf-8?B?VmpjSU5jYVlDemU5dU96NldsMk1xa0Z0bFpxMjhvck03M2lqRHVYSFNGOExx?= =?utf-8?B?MzFyUEZUd0tqSjJiNUkvSGhoNUZGckpHdlFBb1M2cGtseEdUNmxhMWV1aGN4?= =?utf-8?B?MUtZMlFlQmhBVkRadFI3emRjY1Y1S3h6b1ZrN3RZWWw2bVJIWGpBdWtrMUk5?= =?utf-8?B?TGtjZEdqeGViclBJWGUzN2FjakRpYzNscGg2R1R2NFNkdmNBVGZtckd4U1Fj?= =?utf-8?B?YkhGdm1JdytBbzBKUkt3VHpMdUtRVDhRZkl0N2E5STFyeFBrRDZHNmsxaGFx?= =?utf-8?B?eGhWc2RjSitBNk9NTnoybmNQaHhEeG1mcmQreUY4TStGa05JM3d0a21aV0hD?= =?utf-8?B?ejJVdXR6NEovMnY0eVpnb2d2TTRqbmw3NHBCWTRMSkNyY2RJdUNFS0dGdW5l?= =?utf-8?B?K0cvb0VITEwwZ1dEc0dNUi9paWFZaHBPNlA1ZFhxZjR6ZzFSeEI2QW9ETWp4?= =?utf-8?B?RUtIV1RsQytRQ2RzNWJMbnZiSE1tVVNuWTVGMzNDU0xhQUJtcmQ1Tk5EcEhI?= =?utf-8?B?ckZZVElBTFN1SGtkTUE0UUJSSjNyWkhmc3FKUy9wMVgyZS95UkI5TzU2MkRC?= =?utf-8?B?Y2cyRnRTTktDY0lLK2g4U1hSNjBhaFJHUFg3ZGs1ZUwvck5hZzN0Nm9WMDAr?= =?utf-8?B?d0taUjZsMG9DM0RKQm1tQjd4MlBJQ3A5LzYrSkVZYUNPczFMZXFHckVYTGk2?= =?utf-8?B?VjJ3SzF3akVBS2hPSEs5NjdKa1FMNTA3ejlhVmlYUW40dzhPdVc4REFwZzFk?= =?utf-8?B?RlREZUhKSVB4TnlaN3RaSFlZYTZ2Q1YzcCtZc1dZQ1VpbXgrS3ZEVnd0SFI2?= =?utf-8?B?U09yUEJ5UnY1eHIzaldPc3plMW5QU2RNSGZJdjM3YjhUZHlTdnJBdVRoT25O?= =?utf-8?B?VWtOQzlRUjJNQm52MTZHbDZtWWRjbXkwVkdVTmFDYlUvWVBBOE9ZbzNTNlB0?= =?utf-8?B?NTdMbFZVTGJaTk5DMXpnalZIcHBHNFV4eitoMmpPUHVTTHRMVDZqWFJxWlZo?= =?utf-8?B?UDBPdTBZbGZ5OXVQdytudFQ4aXUvdTR2LzhTZEJSVHhuNWp2aEQ0NlVibzJP?= =?utf-8?B?WWZBUldPN0xMMXBucmU0OW0wWGMrckhQYk4vZmU0UVZ0KzVnUFpUMDNmWjVp?= =?utf-8?B?ZTJ1WWhnLzI3Z2IwVm1heGJMRUY3L2NxZU5HeVE3Zm9YQUxDN3NRMWo5WFE1?= =?utf-8?B?N0ZiTGZibnNLL1JQVHRzSHF4L3JyWXFIUGFRdzVINGlxeDMrS1JQZ3N6MlZP?= =?utf-8?B?a3lzRjUySndlbE5jOEZYRHpFNnpoM3JtMzhPdGRNVzlXYXQ4Ykordz09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1096dc8a-8a21-4b3f-8faf-08de75f21b24 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9080.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2026 11:19:43.3246 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hjJNMFR1aj88Q1AV/EGPkonJHewzJyhjjm1cX8mQiSENxkToHv/lTA1DVoy7Nc2jYH4zuyPzmtUea/aA3ufMSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8272 From: Guoniu Zhou Use guard() to simplify mutex locking. No functional change. Reviewed-by: Frank Li Signed-off-by: Guoniu Zhou --- drivers/media/i2c/ds90ub953.c | 34 +++++++++++++--------------------- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c index a85c6a9b64070491db161ca1586179dba9c69cb0..3a459687aefce05ac025a517c8d= 4cc6d76cd7293 100644 --- a/drivers/media/i2c/ds90ub953.c +++ b/drivers/media/i2c/ds90ub953.c @@ -113,20 +113,18 @@ static int ub953_read(struct ub953_data *priv, u8 reg= , u8 *val, int *err) if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D regmap_read(priv->regmap, reg, &v); if (ret) { dev_err(&priv->client->dev, "Cannot read register 0x%02x: %d\n", reg, ret); - goto out_unlock; + goto err; } =20 *val =3D v; =20 -out_unlock: - mutex_unlock(&priv->reg_lock); - +err: if (ret && err) *err =3D ret; =20 @@ -140,15 +138,13 @@ static int ub953_write(struct ub953_data *priv, u8 re= g, u8 val, int *err) if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D regmap_write(priv->regmap, reg, val); if (ret) dev_err(&priv->client->dev, "Cannot write register 0x%02x: %d\n", reg, ret); =20 - mutex_unlock(&priv->reg_lock); - if (ret && err) *err =3D ret; =20 @@ -185,18 +181,18 @@ static int ub953_read_ind(struct ub953_data *priv, u8= block, u8 reg, u8 *val, if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D ub953_select_ind_reg_block(priv, block); if (ret) - goto out_unlock; + goto err; =20 ret =3D regmap_write(priv->regmap, UB953_REG_IND_ACC_ADDR, reg); if (ret) { dev_err(&priv->client->dev, "Write to IND_ACC_ADDR failed when reading %u:0x%02x: %d\n", block, reg, ret); - goto out_unlock; + goto err; } =20 ret =3D regmap_read(priv->regmap, UB953_REG_IND_ACC_DATA, &v); @@ -204,14 +200,12 @@ static int ub953_read_ind(struct ub953_data *priv, u8= block, u8 reg, u8 *val, dev_err(&priv->client->dev, "Write to IND_ACC_DATA failed when reading %u:0x%02x: %d\n", block, reg, ret); - goto out_unlock; + goto err; } =20 *val =3D v; =20 -out_unlock: - mutex_unlock(&priv->reg_lock); - +err: if (ret && err) *err =3D ret; =20 @@ -227,18 +221,18 @@ static int ub953_write_ind(struct ub953_data *priv, u= 8 block, u8 reg, u8 val, if (err && *err) return *err; =20 - mutex_lock(&priv->reg_lock); + guard(mutex)(&priv->reg_lock); =20 ret =3D ub953_select_ind_reg_block(priv, block); if (ret) - goto out_unlock; + goto err; =20 ret =3D regmap_write(priv->regmap, UB953_REG_IND_ACC_ADDR, reg); if (ret) { dev_err(&priv->client->dev, "Write to IND_ACC_ADDR failed when writing %u:0x%02x: %d\n", block, reg, ret); - goto out_unlock; + goto err; } =20 ret =3D regmap_write(priv->regmap, UB953_REG_IND_ACC_DATA, val); @@ -248,9 +242,7 @@ static int ub953_write_ind(struct ub953_data *priv, u8 = block, u8 reg, u8 val, block, reg, ret); } =20 -out_unlock: - mutex_unlock(&priv->reg_lock); - +err: if (ret && err) *err =3D ret; =20 --=20 2.34.1