From nobody Thu Jun 11 00:36:03 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7162A43E4B4 for ; Fri, 27 Feb 2026 15:45:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772207141; cv=none; b=Vs11HI8xk0yr3kJTsO9gnad835VSdL+vo3Z3xoAbEA4ovzpYgWlkOPluxHK1K/wutjyff7i/Zg5ulXZnvRwjYlub43lkKmBjOaTbhMrvNgnR6HXXsLqRuqr3g+K67rpisjsL/+uMASQ1hdBh4plv1WvrYJCo/5sJzflbb/nU1uk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772207141; c=relaxed/simple; bh=ecLxgr95kMH1lbLgDthjh5JupZqFrWEGXdmOokkkKEk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=jWXciIEFD8unSL7AWxEzLMFYT28sDpgUvJTUiD6Twy0OlaLqrfdMqTYHhzP5zmg8op3mEj76vDpcXWqwX/N2eHT85IxXih1Q8TpYrp0YYFR1APZKIqXtOlBjnvMSlx9LjllSkA1jUTpTqtWa3BcKlpXBb07v7YBEatMjIDTJ8+4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Cv34QE0R; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Cv34QE0R" Received: by smtp.kernel.org (Postfix) with ESMTPS id 2493FC116C6; Fri, 27 Feb 2026 15:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772207141; bh=ecLxgr95kMH1lbLgDthjh5JupZqFrWEGXdmOokkkKEk=; h=From:Date:Subject:To:Cc:Reply-To:From; b=Cv34QE0RaOMCeyYMi70aCZMe5RLBaBMWkpQqaYXMwD32963etT62CTQGz9F6/PMV4 qe/lWHOKMrTK3janVc1NuJlPdzKy6tTZMSgaTznWpETw/GB/LM22dUuT5CpbtqUEWi QInOncyj3IatA6dh6hwIwV4x7fLZA5pc/H3Onl8cCME2kXI7/so7OsNzVHAKLTOmov lH/qossK4gPe3aDVU9Id6VOeVHBigw4ojUmPto5X78/hz91O3N9lT35pw+5OQQ9LBS C/zm+3u9j44l5leN3wEcac2aUd6TwHXquTQbE3R9zspZIYJze6sHzxVFMnx/gxLgAc glHRctgsXo5Nw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D00DFEFB44; Fri, 27 Feb 2026 15:45:41 +0000 (UTC) From: Dylan Laduranty via B4 Relay Date: Fri, 27 Feb 2026 16:45:35 +0100 Subject: [PATCH] pps: clients: pps-gpio: fix echo pin configuration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260227-drivers-pps-clients-fix-echo-pin-setup-v1-1-a5a5f52d7d96@mesotic.com> X-B4-Tracking: v=1; b=H4sIAB68oWkC/x2NzQqDQAwGX0VybsCuaH9epfRgd7+tgbKGRKUgv nuXHgeGmZ0cJnC6NzsZNnGZS4XzqaE4jeUNllSZQhuGNoQLJ5MN5qzqHD+Csjhn+TLiNLNKYce yKmf0IXWva38bMtWYGqr1Hz2ex/EDBhw5xHgAAAA= X-Change-ID: 20260227-drivers-pps-clients-fix-echo-pin-setup-fe52d3b8596f To: Rodolfo Giometti Cc: linux-kernel@vger.kernel.org, Dylan Laduranty X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772207140; l=1541; i=dylan.laduranty@mesotic.com; s=20260227; h=from:subject:message-id; bh=HiKmeAEhQwBWppTE6qjwAahphv1ZtYdeNMPY+D0ILIA=; b=poRC80kTHg5VO4R+2PHD288xVPI7mJaRnkP3y9pYBYTL8ncjq5b0PsUj4knUqGLy4lAeGknLb q3uyiUx99X1AL0F5AILlT6slpL70N2Zdbmrv2zM9SPvQkXnRb9u3trt X-Developer-Key: i=dylan.laduranty@mesotic.com; a=ed25519; pk=RCBv1HNO5gjI2XmhIo71IsjzUhWXcocB5Y9jtzWduYo= X-Endpoint-Received: by B4 Relay for dylan.laduranty@mesotic.com/20260227 with auth_id=652 X-Original-From: Dylan Laduranty Reply-To: dylan.laduranty@mesotic.com From: Dylan Laduranty This patch adds PPS_ECHOASSERT and PPS_ECHOCLEAR to pps_default_params when needed. The pps_gpio_echo() function will check if these flags are set inside params.mode to update the echo pin state. However, these flags need to be set during probe sequence otherwise pps_gpio_echo() function will never update the pin's state. Signed-off-by: Dylan Laduranty Acked-by: Rodolfo Giometti --- drivers/pps/clients/pps-gpio.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c index 935da68610c701e6d9de53c667237f77438d7107..83ca24118eccfdb9eebe272023e= f4980c9d54cf2 100644 --- a/drivers/pps/clients/pps-gpio.c +++ b/drivers/pps/clients/pps-gpio.c @@ -200,8 +200,13 @@ static int pps_gpio_probe(struct platform_device *pdev) =20 /* register PPS source */ pps_default_params =3D PPS_CAPTUREASSERT | PPS_OFFSETASSERT; - if (data->capture_clear) + if (data->echo_pin) + pps_default_params |=3D PPS_ECHOASSERT; + if (data->capture_clear) { pps_default_params |=3D PPS_CAPTURECLEAR | PPS_OFFSETCLEAR; + if (data->echo_pin) + pps_default_params |=3D PPS_ECHOCLEAR; + } data->pps =3D pps_register_source(&data->info, pps_default_params); if (IS_ERR(data->pps)) { dev_err(dev, "failed to register IRQ %d as PPS source\n", --- base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31 change-id: 20260227-drivers-pps-clients-fix-echo-pin-setup-fe52d3b8596f Best regards, --=20 Dylan Laduranty