From nobody Fri Apr 3 11:18:03 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B70D4418E9 for ; Thu, 26 Feb 2026 23:11:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772147479; cv=none; b=lUEAOvRZUT4YygTUQFM1uNj2HLVURTp7Z1HvB/wivWxxlOP9MUZbPQVU3FTg4niuQurZuhx9INE1T4JKspZ1LTrsbIeTNrcYRUkltU/MqRvWeFDI3C+izzgHXe/r6Ov7e5f0ALeaSY1ucWY8LiclkSKseMjewM+Idv4j6LjPOq0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772147479; c=relaxed/simple; bh=TfhL+f7VtjbiWYOT85/9EUVD1Gke8/6vEBgL8gRLVTE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rGeq/nrrG/h+j1gx1kTqcMxlBISPeiBxfGvm5/vQ4nBtjktwrWZPQzMbzujKlCnu+pTUtu7ZzHgYSb+7eHAf9WDM398StcWVRWO5+JWz01wKga/PsNjkAIbQ37Rask+cGYou/S18fwX48CMA6DKYlNgItzZiZLmPUk/Oc2PCQSw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d6RF4snM; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d6RF4snM" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-823c56765fdso823487b3a.1 for ; Thu, 26 Feb 2026 15:11:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772147478; x=1772752278; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jQUc2l2etFAMFSbUDTLR0OFMDbwiSBMKpEjkoUkXXeA=; b=d6RF4snMO8py8nAVgGzvDsFQp+fd9C8Efumvp9lWvf39udpXQKCLu2vDFFVNHNSAUD lqCOjeXuTMEMCrNkv9ObJjI/uCTxnOecaS2Hs3EfbgzgWe+UT5IiI0m5ShpQXnBz/KTM gljM0mynXPu2rZJwx5nhCrEewGJmAwIBPE1qxpqILf2wGB2I6SQdaMhREYD8cGSPDAmu K+6DUlyb+KFEfuLMG3+IPf+dpfmdkfZ2dP4IEeKwSY5L524/Jw1pb9MaqQffJjKS+GNq Q2yQHc7UIxPOJrJOPt5D1qUqgO3BJhqABzFIz3P+OCgUAXfRBnWs0N5zkHMjWVaZXHVc tesg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772147478; x=1772752278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jQUc2l2etFAMFSbUDTLR0OFMDbwiSBMKpEjkoUkXXeA=; b=dhMlDdVQBbJ9830RA0yB2HJSVb0fOB9IG/68uoCqR6ycD5nvjVGD4Rla7MTPutuwBo 1nDbpk8vjcXIBLYO8v+4Tu9vvdV7VJGi/VO83t+JILq6WsTjkCbjIFsoaftoC+pZzQ1V BMNz+e+eC0gyyZ88dJ1iRvj0mg2I3Ggph/FQw4SOQtbhHHs09PHd9y1f3a02v6EItsCx 2uMFfoOOEgcCVxzHTtGYE4v8BvirLYU5R6S7JZMzTu7yLciofU16qaLldnJH4OAd7VrR K2lg2QD8QCzYoOeU0S/5+ZJkcYy6roju4ivMk96NI8M69uqFXzNrEY8wPMd8M0aS06yU eo4w== X-Forwarded-Encrypted: i=1; AJvYcCWiaVo09ygTwnbULEcI7MuYIFuD0qTJM/1hobjufIvNSL7zQjuI2CPZqUfMhk2LlVGl6kaQ1nefVqVFKbk=@vger.kernel.org X-Gm-Message-State: AOJu0YyU+GBbGsMvdwUMPDkii/wWzwlDxMh0l1lGnyQhwKFFUPbgRUPP 48iiqD/1BJTf+cwltovSCN/r+rd2w/RINDCl/cs1/QkEh6mLzUXwBzmm X-Gm-Gg: ATEYQzzb0EoDTsIPlE73pbn46oDN7OhoyAl3vcLz6ugD/ebrutRnfp7sU4SX6v0l5mS TnCJrRplww/mUrapKMZ0Krk+rtwVGsQvJeLePdg+UxCy9zHNcgSUTAJiGj8yK8pfPGPZCqeskUL efAKjrQHZlzdsZiIKIqR9BGkxidbNYJ2kQuYfP8MEl5l4gclMgezQ2thTGsckOo6aHZUJE4B3J8 sYYTlk92uI882tikiY2b3hkP6609+BjBlBmldDtDsOtBlLY3qbg+bwaltNmUY7UHJymN0soAVo3 0rHsTx7ghPP0Z13VwfBYIpfd9/WxIn66Sma+3I2O0yJi6FW6M8yPYI+m5vkIMAOjtSrw4tDS8L7 gGPiZ9zVBMUmz4MgYMXmxbCIar4Uo2wzSRqQzI1xg4q31WvNVtj8mXPWPcqhzxlA6+vuyhVMXIA NPItbrdBnLSLBl6STZ/8MyPN8boQi7sjff7ZY= X-Received: by 2002:a05:6a00:1992:b0:7ff:ecbb:1c28 with SMTP id d2e1a72fcca58-8274d94be70mr564246b3a.16.1772147477764; Thu, 26 Feb 2026 15:11:17 -0800 (PST) Received: from arch ([2409:40c2:5006:5b06:f9ff:5cdf:1c23:a906]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a01054dsm4238752b3a.43.2026.02.26.15.11.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 15:11:17 -0800 (PST) From: Bhargav Joshi To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com, Andy Shevchenko Subject: [PATCH v6 1/3] iio: frequency: ad9523: fix implicit variable macros Date: Fri, 27 Feb 2026 04:40:55 +0530 Message-ID: <20260226231057.20669-2-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260226231057.20669-1-rougueprince47@gmail.com> References: <20260226231057.20669-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The macros AD9523_CLK_DIST_DIV_PHASE_REV(x) and AD9523_CLK_DIST_DIV_REV(x) implicitly relied on the variable named 'ret' instead of using passed argument '(x)'. Update the macros to explicitly use the argument '(x)' for their operations. This also resolves the following checkpatch.pl warning: Argument '(x)' is not used in function-like macro. Signed-off-by: Bhargav Joshi Reviewed-by: Andy Shevchenko --- Changes in v6: - Fixed grammar and shortened the long first line. Changes in v5: - Reflowed all commit messages to properly wrap near 72 characters as requested. - Collected Reviewed-by tag. Changes in v4: - Used full name for SoB. Changes in v3: - Updated macros to use '(x)' instead of 'x'. drivers/iio/frequency/ad9523.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 63c485e9e44c..5725ab62e0fd 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -167,9 +167,9 @@ =20 /* AD9523_CHANNEL_CLOCK_DIST */ #define AD9523_CLK_DIST_DIV_PHASE(x) (((x) & 0x3F) << 18) -#define AD9523_CLK_DIST_DIV_PHASE_REV(x) ((ret >> 18) & 0x3F) +#define AD9523_CLK_DIST_DIV_PHASE_REV(x) (((x) >> 18) & 0x3F) #define AD9523_CLK_DIST_DIV(x) ((((x) - 1) & 0x3FF) << 8) -#define AD9523_CLK_DIST_DIV_REV(x) (((ret >> 8) & 0x3FF) + 1) +#define AD9523_CLK_DIST_DIV_REV(x) ((((x) >> 8) & 0x3FF) + 1) #define AD9523_CLK_DIST_INV_DIV_OUTPUT_EN (1 << 7) #define AD9523_CLK_DIST_IGNORE_SYNC_EN (1 << 6) #define AD9523_CLK_DIST_PWR_DOWN_EN (1 << 5) --=20 2.53.0