From nobody Fri Apr 3 11:07:23 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B70D4418E9 for ; Thu, 26 Feb 2026 23:11:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772147479; cv=none; b=lUEAOvRZUT4YygTUQFM1uNj2HLVURTp7Z1HvB/wivWxxlOP9MUZbPQVU3FTg4niuQurZuhx9INE1T4JKspZ1LTrsbIeTNrcYRUkltU/MqRvWeFDI3C+izzgHXe/r6Ov7e5f0ALeaSY1ucWY8LiclkSKseMjewM+Idv4j6LjPOq0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772147479; c=relaxed/simple; bh=TfhL+f7VtjbiWYOT85/9EUVD1Gke8/6vEBgL8gRLVTE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rGeq/nrrG/h+j1gx1kTqcMxlBISPeiBxfGvm5/vQ4nBtjktwrWZPQzMbzujKlCnu+pTUtu7ZzHgYSb+7eHAf9WDM398StcWVRWO5+JWz01wKga/PsNjkAIbQ37Rask+cGYou/S18fwX48CMA6DKYlNgItzZiZLmPUk/Oc2PCQSw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d6RF4snM; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d6RF4snM" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-823c56765fdso823487b3a.1 for ; Thu, 26 Feb 2026 15:11:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772147478; x=1772752278; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jQUc2l2etFAMFSbUDTLR0OFMDbwiSBMKpEjkoUkXXeA=; b=d6RF4snMO8py8nAVgGzvDsFQp+fd9C8Efumvp9lWvf39udpXQKCLu2vDFFVNHNSAUD lqCOjeXuTMEMCrNkv9ObJjI/uCTxnOecaS2Hs3EfbgzgWe+UT5IiI0m5ShpQXnBz/KTM gljM0mynXPu2rZJwx5nhCrEewGJmAwIBPE1qxpqILf2wGB2I6SQdaMhREYD8cGSPDAmu K+6DUlyb+KFEfuLMG3+IPf+dpfmdkfZ2dP4IEeKwSY5L524/Jw1pb9MaqQffJjKS+GNq Q2yQHc7UIxPOJrJOPt5D1qUqgO3BJhqABzFIz3P+OCgUAXfRBnWs0N5zkHMjWVaZXHVc tesg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772147478; x=1772752278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jQUc2l2etFAMFSbUDTLR0OFMDbwiSBMKpEjkoUkXXeA=; b=dhMlDdVQBbJ9830RA0yB2HJSVb0fOB9IG/68uoCqR6ycD5nvjVGD4Rla7MTPutuwBo 1nDbpk8vjcXIBLYO8v+4Tu9vvdV7VJGi/VO83t+JILq6WsTjkCbjIFsoaftoC+pZzQ1V BMNz+e+eC0gyyZ88dJ1iRvj0mg2I3Ggph/FQw4SOQtbhHHs09PHd9y1f3a02v6EItsCx 2uMFfoOOEgcCVxzHTtGYE4v8BvirLYU5R6S7JZMzTu7yLciofU16qaLldnJH4OAd7VrR K2lg2QD8QCzYoOeU0S/5+ZJkcYy6roju4ivMk96NI8M69uqFXzNrEY8wPMd8M0aS06yU eo4w== X-Forwarded-Encrypted: i=1; AJvYcCWiaVo09ygTwnbULEcI7MuYIFuD0qTJM/1hobjufIvNSL7zQjuI2CPZqUfMhk2LlVGl6kaQ1nefVqVFKbk=@vger.kernel.org X-Gm-Message-State: AOJu0YyU+GBbGsMvdwUMPDkii/wWzwlDxMh0l1lGnyQhwKFFUPbgRUPP 48iiqD/1BJTf+cwltovSCN/r+rd2w/RINDCl/cs1/QkEh6mLzUXwBzmm X-Gm-Gg: ATEYQzzb0EoDTsIPlE73pbn46oDN7OhoyAl3vcLz6ugD/ebrutRnfp7sU4SX6v0l5mS TnCJrRplww/mUrapKMZ0Krk+rtwVGsQvJeLePdg+UxCy9zHNcgSUTAJiGj8yK8pfPGPZCqeskUL efAKjrQHZlzdsZiIKIqR9BGkxidbNYJ2kQuYfP8MEl5l4gclMgezQ2thTGsckOo6aHZUJE4B3J8 sYYTlk92uI882tikiY2b3hkP6609+BjBlBmldDtDsOtBlLY3qbg+bwaltNmUY7UHJymN0soAVo3 0rHsTx7ghPP0Z13VwfBYIpfd9/WxIn66Sma+3I2O0yJi6FW6M8yPYI+m5vkIMAOjtSrw4tDS8L7 gGPiZ9zVBMUmz4MgYMXmxbCIar4Uo2wzSRqQzI1xg4q31WvNVtj8mXPWPcqhzxlA6+vuyhVMXIA NPItbrdBnLSLBl6STZ/8MyPN8boQi7sjff7ZY= X-Received: by 2002:a05:6a00:1992:b0:7ff:ecbb:1c28 with SMTP id d2e1a72fcca58-8274d94be70mr564246b3a.16.1772147477764; Thu, 26 Feb 2026 15:11:17 -0800 (PST) Received: from arch ([2409:40c2:5006:5b06:f9ff:5cdf:1c23:a906]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a01054dsm4238752b3a.43.2026.02.26.15.11.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 15:11:17 -0800 (PST) From: Bhargav Joshi To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com, Andy Shevchenko Subject: [PATCH v6 1/3] iio: frequency: ad9523: fix implicit variable macros Date: Fri, 27 Feb 2026 04:40:55 +0530 Message-ID: <20260226231057.20669-2-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260226231057.20669-1-rougueprince47@gmail.com> References: <20260226231057.20669-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The macros AD9523_CLK_DIST_DIV_PHASE_REV(x) and AD9523_CLK_DIST_DIV_REV(x) implicitly relied on the variable named 'ret' instead of using passed argument '(x)'. Update the macros to explicitly use the argument '(x)' for their operations. This also resolves the following checkpatch.pl warning: Argument '(x)' is not used in function-like macro. Signed-off-by: Bhargav Joshi Reviewed-by: Andy Shevchenko --- Changes in v6: - Fixed grammar and shortened the long first line. Changes in v5: - Reflowed all commit messages to properly wrap near 72 characters as requested. - Collected Reviewed-by tag. Changes in v4: - Used full name for SoB. Changes in v3: - Updated macros to use '(x)' instead of 'x'. drivers/iio/frequency/ad9523.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 63c485e9e44c..5725ab62e0fd 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -167,9 +167,9 @@ =20 /* AD9523_CHANNEL_CLOCK_DIST */ #define AD9523_CLK_DIST_DIV_PHASE(x) (((x) & 0x3F) << 18) -#define AD9523_CLK_DIST_DIV_PHASE_REV(x) ((ret >> 18) & 0x3F) +#define AD9523_CLK_DIST_DIV_PHASE_REV(x) (((x) >> 18) & 0x3F) #define AD9523_CLK_DIST_DIV(x) ((((x) - 1) & 0x3FF) << 8) -#define AD9523_CLK_DIST_DIV_REV(x) (((ret >> 8) & 0x3FF) + 1) +#define AD9523_CLK_DIST_DIV_REV(x) ((((x) >> 8) & 0x3FF) + 1) #define AD9523_CLK_DIST_INV_DIV_OUTPUT_EN (1 << 7) #define AD9523_CLK_DIST_IGNORE_SYNC_EN (1 << 6) #define AD9523_CLK_DIST_PWR_DOWN_EN (1 << 5) --=20 2.53.0 From nobody Fri Apr 3 11:07:23 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E71B2449EAF for ; Thu, 26 Feb 2026 23:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772147486; cv=none; b=jUoIcvMKhk6D5Fw3cGKJMyK3NWdm8TeuvOxeQ4bCkhCnI+Ww2JkgdaMg/2TPllgr7rp0mmcmEIiDmgr4mIZUM6WmiLFfkQ+e/s9vKi01HIaP/l6Snmt1pNKr7trYNg++b2ASfMkLgM3xzA2eW/Vemh2yMuEtWuuBECv2ac31kQk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772147486; c=relaxed/simple; bh=pgDjF+SFynRqwPcTuhu9A71XQCFv4iZQSdb1IQofHC8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l2n0zxfAUjFAodHeiMkzTqQHCxiEDvoehAdgzBsgf+ArFCb/aSh9fuUb22NQruFCTH5DlnoDkTgPhG7HF49il8BxhRheTATY6X6TBPF23sHuNCVRvTKMbNIgFEkpOCZzDEReeCR9AWIdeQ+rOLQ9qGYbcWPS13aXgq4019vm+60= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TlAJ/c5m; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TlAJ/c5m" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-8272c559597so1476723b3a.1 for ; Thu, 26 Feb 2026 15:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772147484; x=1772752284; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vO2yIyX5QV033H/kp7ME/ccMu7iMw0aAmads5tUNKKw=; b=TlAJ/c5mc/2AoysCI7WWJTyk08yCU+JJZbW8QJd5l9KdXSBOMMK6c2tec+mbr07tFX Ph1vILT1NewYbpdbvg2hjavg6aZOdUPH5Bwazu02ouW6v3wP/tyYOa3FD0ZY8tKe52eE +cIbeK0aG2r/4AS59cts71N5S6Jf5XG4raP5PWJcosE3K2FnA4sdeqpKvhcXS3azGwRf bGZjJ7rhbHf+XtjMxIKCmLy5+EDynHddHEayIvC1u6tdBawF/nLhqEM67oqm1IHvIUpS jdYGNMAI1rZXZBfDhtd9seQgMTxn/pKpyQ3W5WjGLQw0fFU1595iXflr1jICTx+bI4Po YbFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772147484; x=1772752284; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vO2yIyX5QV033H/kp7ME/ccMu7iMw0aAmads5tUNKKw=; b=OJwY/8G53HH2UkyUlMXRNm2FKqTK4Gk6gXjKY13nHmbrE3JTyxngMYGyzPSPgtwTRx TcsM/uMts9Z+41MPnlSP2st2AtMArlDLsVJNbnj3OKnzL+fsfQL91CeL6bUC1eDU8q7T yJe+nYCksxmuq6AHdziBPj3miBjx+Duq3wVq/3GrZg7AskdeRkZLznmF/Od9TmnSPKMf KAvEV4g2a9Y+oCYEr4+dBLlzY/kRkBfIj/kYg2/GfAJTz5DXrH54FESCulCDabUKnDxV 6f3SgWARNuh7OmfpDt1ZOykDaqsxNyJgCjCfNHWBdLgZrcmYP6RmAG7c8wb52KhiP0ZQ 3B0w== X-Forwarded-Encrypted: i=1; AJvYcCUZAY9sjyE3R/NMf1T8iI8qPfoU5M9C6bU3+LM0+2Odly9lp049di6MHX7LYYlbQpX4DEKk3WnCWdl9IwA=@vger.kernel.org X-Gm-Message-State: AOJu0YyYl8nX4D12jxvWVHRD69QD1n5hY2VPLPIU5a6RISJ8CikpOlCv MKvdJAjOY5EyEeKYoL9LC1a/NnK5wzswEGXmD8ZtXykSGyc5vZV/G1Qu X-Gm-Gg: ATEYQzw8nrNuMvHqylCwej0NY5YslPslyzss7Oc+ytOi0EHqbCITjS93BBx5Q8Sg7Y7 R4l8FfFV7cB9G8hTIgo7x9jWw1lstdVy2lvsFi9jKnaHSt5f2RLt/NSASZVLy0Wjlk4DTaUuGae wZHQ74RZcuMxq1phevxn/fTLYrVyCSrZqHWWbDzBjSCWNO6Jmt6oDw0yPQ4B7HtrPbk9UY9UI8l 7bxmHBF/m663nX463cpzgoLGcqk7n1stb84SGwUaY0gmskq8pO3ByRrbmPr1C4uQr3QPdSr4FP8 a6yQ+j8Cpk790xuYPGtfRAx9Ud6yNqoqV5ktjfqN1c10glWDn/BUCwFe3YJKYyaWJz7gAR6PAHE +IvACbKx9NgSjd8FbeOxt2zNTmLPnPcUL+KGqN5iEPsGzrCJ3ddBZN+bfwCY+KQXHlSvgnbTJdF RaOG7FVb27y+WkoRDqDQVVFu/c X-Received: by 2002:a05:6a00:1888:b0:823:9c6:1985 with SMTP id d2e1a72fcca58-8274d972c30mr600523b3a.16.1772147484051; Thu, 26 Feb 2026 15:11:24 -0800 (PST) Received: from arch ([2409:40c2:5006:5b06:f9ff:5cdf:1c23:a906]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a01054dsm4238752b3a.43.2026.02.26.15.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 15:11:23 -0800 (PST) From: Bhargav Joshi To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com, Andy Shevchenko Subject: [PATCH v6 2/3] iio: frequency: ad9523: fix multi-line dereferences Date: Fri, 27 Feb 2026 04:40:56 +0530 Message-ID: <20260226231057.20669-3-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260226231057.20669-1-rougueprince47@gmail.com> References: <20260226231057.20669-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Platform data pointer dereferences for pll1_charge_pump_current_nA and pll2_charge_pump_current_nA were split across multiple lines. Bring the dereference chains onto a single line. This resolves the following checkpatch.pl warnings: WARNING: Avoid multiple line dereference - prefer 'pdata->pll1_charge_pump_= current_nA' WARNING: Avoid multiple line dereference - prefer 'pdata->pll2_charge_pump_= current_nA' Signed-off-by: Bhargav Joshi Reviewed-by: Andy Shevchenko --- Changes in v6: - No changes. Changes in v5: - Reflowed all commit messages to properly wrap near 72 characters as requested except for warning messages. Changes in v4: - Used full name for SoB. Changes in v3: - Collected reviewed-by (no code changes). drivers/iio/frequency/ad9523.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 5725ab62e0fd..6daa2ea354a8 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -797,8 +797,7 @@ static int ad9523_setup(struct iio_dev *indio_dev) return ret; =20 ret =3D ad9523_write(indio_dev, AD9523_PLL1_CHARGE_PUMP_CTRL, - AD9523_PLL1_CHARGE_PUMP_CURRENT_nA(pdata-> - pll1_charge_pump_current_nA) | + AD9523_PLL1_CHARGE_PUMP_CURRENT_nA(pdata->pll1_charge_pump_current_nA) | AD9523_PLL1_CHARGE_PUMP_MODE_NORMAL | AD9523_PLL1_BACKLASH_PW_MIN); if (ret < 0) @@ -842,8 +841,7 @@ static int ad9523_setup(struct iio_dev *indio_dev) */ =20 ret =3D ad9523_write(indio_dev, AD9523_PLL2_CHARGE_PUMP, - AD9523_PLL2_CHARGE_PUMP_CURRENT_nA(pdata-> - pll2_charge_pump_current_nA)); + AD9523_PLL2_CHARGE_PUMP_CURRENT_nA(pdata->pll2_charge_pump_current_nA)); if (ret < 0) return ret; =20 --=20 2.53.0 From nobody Fri Apr 3 11:07:23 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3537C39E186 for ; Thu, 26 Feb 2026 23:11:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772147491; cv=none; b=L/61uUUEunQ/ThKkC3tKSToEoUBF0aRy2mEPIDGdSkHJEvs8P7MIQEkeT/k54Xn3HuS1cMApD7CHqQO4HZ/RwnMncObWdDRHLtnZOiDs40r10sgmsyjCxXsDR1EYav3QcYNtmoV9FjaI4Lnn0Dhw9gwNJkAKmcuME3QrE+dfHiU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772147491; c=relaxed/simple; bh=RkrZxJAP4+3qGhNCW1sf2lWrU9hgyO4Rlok3ZUybGr8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zhdmo1e43l9OydntK1bSBN9pH5DlqYRXz/Wpn9ZPd+1HVGPGGwTzsHIYAcgy+UbNH1iwc/O1vBXiYat1f9s1f8Ni8kGtEIbtBBudgW0uMnKl2WHy5ZQKDiH0TOg38GIFXhpv1B/XigsBIOBHOlkiqaQgOcklZhnhDxdkE+kmDTk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lxWxmH0b; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lxWxmH0b" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-826c49b7628so967170b3a.0 for ; Thu, 26 Feb 2026 15:11:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772147490; x=1772752290; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SMkJsKGoP9koSrH1VBJBOqwpNxxFbXiwZhSMj9fjMu0=; b=lxWxmH0bMEHgMptKYkjPyvxeUtFUsM8VE9rE2fAaDt4HlSxkPAiJrYy6X+y9IkKQda B927LgOfjAEsHyeoqk6j6v7s8oFydq7tzhzik1NYxhYfuXM5BvFfv8l4Bbmxonwz4oQ9 drwRdSZhuC5rpgx4OdA949bnur8P5uddLvOptGgg55m7d+TXJ3ErGFGFk6tBLGm/iJj7 bNd0//qYoMyN31jHJcgzg5+3f5Ens9N6z37Vb04RhLD/spFykO6UaMLLLIYXN6gXw498 TWcS5mV8u1XEVaj0TgtHjkfEH3ElgEx/00TkKQ4p6Z7sm1qoP2O+QrBTQphYyd00NBnV EcuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772147490; x=1772752290; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SMkJsKGoP9koSrH1VBJBOqwpNxxFbXiwZhSMj9fjMu0=; b=uXkJaA20+ezS04QPAq/1re3j9N6TTURQaatHnnsAzPnQaem6YBeKZ1/WBAZ5mGlp3z EE/qkbDVE+6+wkwc9gU2L6EP3Xl2TTLP+CZT4ycpR8ToyHnUPDQz4I/zULqkFni44DYW xLJj4CgvG4ULOapkw7+T+BwczzqKgcoHKVCMJjqOqL0qOVA79T75sFUBky3HiQ616LnE YTGYpqTHsmbD7071hlYXnnYobYEx5VPfasf29OGAvwoXK82lb0HoB+48IzZPTY+CIaFu 5peCzyWG2bhYUYXbRQxZWTnuv3HERBCy7MD4pPjfJM1Hl+kDKus78/x5QnN3w5I77Su3 8DIw== X-Forwarded-Encrypted: i=1; AJvYcCX0a0ruypoCpT+2nAekCEtfE1psU/mngaUU1txQUJp947WFPbPIY+hN4O5fptmsiufFNH2Udv7E0gkTUEM=@vger.kernel.org X-Gm-Message-State: AOJu0YyE4aDjuOiOcpcKc+gk15OH4rb3KXDpVmO3bY/ELWShJJpWcByf +4UwtncjteOMiM60apemHlmJM0XiQMFeGggCmHiG2grlvrfhyo3Jn/1I X-Gm-Gg: ATEYQzzMPFq8v+cYWKz2weou2LN5Fln3BfI9u3rB2Sahi/JlTPg8Vdh1D7jLjFUYny/ lfyNQxAQvVrflyyioPjFV+u5XPTDUoRdPj4dHumjvBcq12Hiizg5V3ooundIpPOkB4uBtC9TfDa NDtj9AetHW7dy/9+CadBDwA2jclr2O8U/qDq7qQRRRiYHHZGZgr5kmGTRAntfli/FFpUpreH5EY 7zy1xUbLp0Lb0FPa79mKWq+396uNJ96g/SDceDIfFtJqAobWnWe6qzNXg19ZrOr9tj9wlxdtUN6 HS56fNfMzK7OgjSn9AdbtHEE02FjOox0l9Jd2UJwObpwAGMTWBBV70EznI+89vr6PFBdKMc6aZZ Qc8HmbMONvPDFdhbNal+V3NC2oLW1EjKrUL4TLjbsv6Hz2L/cnrZEdwISMGZovEipSLxa+nWJ0I mcBCLPQQ7hI7/HgqYUqKjr0M1x X-Received: by 2002:a05:6a00:2e04:b0:81c:717b:9d39 with SMTP id d2e1a72fcca58-8274da568e3mr665119b3a.56.1772147489597; Thu, 26 Feb 2026 15:11:29 -0800 (PST) Received: from arch ([2409:40c2:5006:5b06:f9ff:5cdf:1c23:a906]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a01054dsm4238752b3a.43.2026.02.26.15.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 15:11:29 -0800 (PST) From: Bhargav Joshi To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com, Andy Shevchenko Subject: [PATCH v6 3/3] iio: frequency: ad9523: use octal permissions Date: Fri, 27 Feb 2026 04:40:57 +0530 Message-ID: <20260226231057.20669-4-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260226231057.20669-1-rougueprince47@gmail.com> References: <20260226231057.20669-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver currently defines device attributes using symbolic permission flags (S_IRUGO and S_IWUSR). Update these to use octal permissions (0444 and 0200) to resolve checkpatch warnings. Signed-off-by: Bhargav Joshi Reviewed-by: Andy Shevchenko --- Changes in v6: - No changes. Resending because something went wrong with v5. Changes in v5: - Reflowed all commit messages to properly wrap near 72 characters as requested. - Collected Reviewed-by tag. Changes in v4: - Used full name for SoB. Changes in v3: - Fixed vertical spacing and broken indentation. drivers/iio/frequency/ad9523.c | 78 +++++++++++++--------------------- 1 file changed, 29 insertions(+), 49 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 6daa2ea354a8..ad32eb66edca 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -558,55 +558,35 @@ static ssize_t ad9523_show(struct device *dev, return ret; } =20 -static IIO_DEVICE_ATTR(pll1_locked, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL1_LD); - -static IIO_DEVICE_ATTR(pll2_locked, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL2_LD); - -static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_REFA); - -static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_REFB); - -static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_REF_TEST); - -static IIO_DEVICE_ATTR(vcxo_clk_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_VCXO); - -static IIO_DEVICE_ATTR(pll2_feedback_clk_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL2_FB_CLK); - -static IIO_DEVICE_ATTR(pll2_reference_clk_present, S_IRUGO, - ad9523_show, - NULL, - AD9523_STAT_PLL2_REF_CLK); - -static IIO_DEVICE_ATTR(sync_dividers, S_IWUSR, - NULL, - ad9523_store, - AD9523_SYNC); - -static IIO_DEVICE_ATTR(store_eeprom, S_IWUSR, - NULL, - ad9523_store, - AD9523_EEPROM); +static IIO_DEVICE_ATTR(pll1_locked, 0444, ad9523_show, NULL, + AD9523_STAT_PLL1_LD); + +static IIO_DEVICE_ATTR(pll2_locked, 0444, ad9523_show, NULL, + AD9523_STAT_PLL2_LD); + +static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, 0444, ad9523_show, NU= LL, + AD9523_STAT_REFA); + +static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, 0444, ad9523_show, NU= LL, + AD9523_STAT_REFB); + +static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, 0444, ad9523_show,= NULL, + AD9523_STAT_REF_TEST); + +static IIO_DEVICE_ATTR(vcxo_clk_present, 0444, ad9523_show, NULL, + AD9523_STAT_VCXO); + +static IIO_DEVICE_ATTR(pll2_feedback_clk_present, 0444, ad9523_show, NULL, + AD9523_STAT_PLL2_FB_CLK); + +static IIO_DEVICE_ATTR(pll2_reference_clk_present, 0444, ad9523_show, NULL, + AD9523_STAT_PLL2_REF_CLK); + +static IIO_DEVICE_ATTR(sync_dividers, 0200, NULL, ad9523_store, + AD9523_SYNC); + +static IIO_DEVICE_ATTR(store_eeprom, 0200, NULL, ad9523_store, + AD9523_EEPROM); =20 static struct attribute *ad9523_attributes[] =3D { &iio_dev_attr_sync_dividers.dev_attr.attr, --=20 2.53.0