From nobody Tue Apr 7 17:12:29 2026 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A28038E114 for ; Thu, 26 Feb 2026 21:30:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772141405; cv=none; b=pHQn7nY4mtfE0Bl+/QSYE6DzQwjEBkw3JUOQey+fmSIaHNMo3sSRaINHlQCLmNsVW5OXHTppSOwFrRIMH3FPBVsdEs1eVhtn/37vNzhs9Cb4XMyYv+eXK1Q76Rzc0Flqgmh10so+hCUrJ+PAs8bvD3pvI82L4/ZUGdZavHp1okQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772141405; c=relaxed/simple; bh=QRhkc2uP4bcM/LsatLWRGGTQ+sviFI9ge5Ts/pHpRGM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hBzorpz578b4Gj2JFsWFK/4y9TmeEITR6BBO1yTQLPaRG9+b5gS01Mn8gEcN1SbBkVu5c9iDHXQWa5RloJC9z6LwGInAcFQr3FNzN/nw7pdTkqH8mLhS4GVLB/b1owoYnB6+JUe894+rdbc7Fx7QeHd3fpWAVSTfBQzWMqACBqk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=H32EvuyO; arc=none smtp.client-ip=95.215.58.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="H32EvuyO" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1772141401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=yA2lI/2C+h5S4XfL+NjFfiE7eFsCkQ61mJturdSOo3k=; b=H32EvuyOIig0mkZAMRT3EofA/29NLMI5sHQlNC52zBlbXZo5Pz28I7dXIjDSZ/5WTsy/ND kLTGwfaZFF/HfdargXr72QhTTlkTEoo74nsv3ozxYbsT/HwiRGQ2j2vACd8itOOxrzjhJv Jl/kMGoPxlPB4Uf0jhVn+ZPs2ZEGm3w= From: Thorsten Blum To: Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Jeff Layton Cc: Thorsten Blum , stable@vger.kernel.org, Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org Subject: [PATCH] smb: client: Don't log plaintext credentials in cifs_set_cifscreds Date: Thu, 26 Feb 2026 22:28:45 +0100 Message-ID: <20260226212845.784172-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" When debug logging is enabled, cifs_set_cifscreds() logs the key payload and exposes the plaintext username and password. Remove the debug log to avoid exposing credentials. Fixes: 8a8798a5ff90 ("cifs: fetch credentials out of keyring for non-krb5 a= uth multiuser mounts") Cc: stable@vger.kernel.org Signed-off-by: Thorsten Blum Acked-by: Paulo Alcantara (Red Hat) --- fs/smb/client/connect.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c index 33dfe116ca52..038f87062419 100644 --- a/fs/smb/client/connect.c +++ b/fs/smb/client/connect.c @@ -2236,7 +2236,6 @@ cifs_set_cifscreds(struct smb3_fs_context *ctx, struc= t cifs_ses *ses) /* find first : in payload */ payload =3D upayload->data; delim =3D strnchr(payload, upayload->datalen, ':'); - cifs_dbg(FYI, "payload=3D%s\n", payload); if (!delim) { cifs_dbg(FYI, "Unable to find ':' in payload (datalen=3D%d)\n", upayload->datalen); --=20 Thorsten Blum GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4