From nobody Tue Apr 7 18:46:39 2026 Received: from mail-pl1-f228.google.com (mail-pl1-f228.google.com [209.85.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40B6C38551B for ; Thu, 26 Feb 2026 19:04:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772132675; cv=none; b=J6YgCcN+6q6zIySixSM3J8+D1Socd/EmGlAQtDn13jOWlJiIX8x33JHMjFiS1tzJSXuQqQX92xNK8gjze5ygtX2LvRLWn/jCKbmXTLhNVupekJGC3c71/wBlnEWHLtvmy0SIifEDH3e749f7O8Wwa2dPvbjSMyD3ggwAOwb6GTk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772132675; c=relaxed/simple; bh=rEgUCflMnbP+oeHSg611GJ51AOMqm3sC9AviUd3En14=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R5QYaq/xABM14AkoarGn4y9vFX7ceLlme95nzUklDhgr7g4G+thztaYYLcWHlA/dAiNaXJ7kxkG5TpA8YZsMP9QUK6nnLgzBUNWTU8klmtYyTsoib+y3OK/tNkrp1Sr98RsI5IRh9GRgB74DNjSijDtkRi1c/2g4BpENgBZ799c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=I343PEWo; arc=none smtp.client-ip=209.85.214.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="I343PEWo" Received: by mail-pl1-f228.google.com with SMTP id d9443c01a7336-2ab1c8fdc40so1036265ad.1 for ; Thu, 26 Feb 2026 11:04:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1772132662; x=1772737462; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lG8nfg+ASIKQ9CbyoNXjrLj+myT10j8TFxZs8gb+75o=; b=I343PEWojgIdwOJ/KnT/nppkoomlj7SQbCErE8Tc0jAHO/4iPLgZz6czx7XpPFbver ADQMOuX1FebrCYOoS3wtDvqNbxKzcFJclXhimiiHfEE5Qn2/sUK4w6Uzd8ie3xh6qvqV Atqc+CxSg57GhLiXwMpDivV/ciyohJpErBy4sr/rcW4XdPEQo1HmqNdBBQtA73DlmQ4R yDkCkGzbFo0O9mccy65+ieTyn7bJ9AagSbIEqXK2BAkBnfaa7yGS1mLju1rjfzwktptm rEvFYGZmIA6XP2n9pR0+Dja2dcEgN7vypsSnYrml1Ykh9Im/9FthKA7R2AhFK4zyGsMJ wDKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772132662; x=1772737462; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lG8nfg+ASIKQ9CbyoNXjrLj+myT10j8TFxZs8gb+75o=; b=WCmcNvkXBrlulR7MFXjAkrcOUhsIRKr3aaqs5Rbr7mcGPL7iplM49H7YMeFx04fC76 ZElnoycvSXPVunB+7bb5ZMYgYHRcKTzTiRvlnBGf7303KUL0+YVOfEQALwm/fws9IOI3 bQxVGhAYOr9fgnwOtRPNm8c38TdI+aTaKB3zaOyTXBftGYo/hQ/0QjO01hIbcTUwBjc4 tAlNRArgY/bOiICBm+gJ9HPxuBJ0vIXHQ/dBgLSDXEOcZbVHYNDwXFONjhKZlgBgBJwA ymGoXdqUNr3hAG+rDnBOckO1KgTDoNfZjPYLga3QqW9GHSGNM/fJTLDMszcw7KTMR6/i q3mA== X-Forwarded-Encrypted: i=1; AJvYcCX3y3NM2N7dCrrtYktju+OYgLmzAHMmdMQd67y/f4O8bwdYCGGj6Ut3ctt4G0uphxwbtEt+I8jKSAMLLW8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyqt2ZGB87lVuxqZUPy+3nLXgiV62+rkQnG4iFl7Y+L9SZ9YSiW HxNQ1ITvQ9l6c1SLJhm5/v8NI7JerHY05pIlTh2FDxcOvg0RQnNMXE7AmW8k9fGFAF2Rt7hffLC 6oXe5u++RaoqWvkYeaq7svx+xSsugR5IUNqyz X-Gm-Gg: ATEYQzzlw1E78LVkGQJ0e1xKWz5/DiqqoDaRYeUPrm27aw/3eqmUgeyE/OnCr5Sg+SQ bpfzXhqR97wp/QVeY3LPK6ofIeDUFe0STUvg9UorDRYp9ZZylxsg1khUQYqWGRylVP1zlm5GuaL B/FDU3DQz3KqFfkSQDNkDyfCjI2SrlHYRG8MDsveTIFOW4dsfBfDoECFBnfPAmoKhNX3rnyJC+M 6sUA3hMYqrzLuiNPT9krtdcgQa6h7r2XMYr4KI6H5VdvXfredxjU4Ztor2xjEBgVZtoyLRurOMV AvwwVSb07b5GvHYQK1sqwoSbe663nGC+QNgKnxoAORL42n9DYFAACWToD8BVf2KZqpvCwzmN1CS coP8yAh9rKvGpnSVYSjmJ1wyjmpjTZQKCavNZhcrjK8qmbqCpWDJ9dw== X-Received: by 2002:a17:902:c951:b0:2a9:5b48:2b1f with SMTP id d9443c01a7336-2ae2e035543mr267335ad.0.1772132661783; Thu, 26 Feb 2026 11:04:21 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([208.88.159.128]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2adfb2710bdsm3572105ad.21.2026.02.26.11.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 11:04:21 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 7E3AA342109; Thu, 26 Feb 2026 12:04:20 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id 79581E41254; Thu, 26 Feb 2026 12:04:20 -0700 (MST) From: Caleb Sander Mateos To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Caleb Sander Mateos Subject: [PATCH v4 5/8] nvme: add from0based() helper Date: Thu, 26 Feb 2026 12:04:12 -0700 Message-ID: <20260226190416.297725-6-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260226190416.297725-1-csander@purestorage.com> References: <20260226190416.297725-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The NVMe specifications are big fans of "0's based"/"0-based" fields for encoding values that must be positive. The encoded value is 1 less than the value it represents. nvmet already provides a helper to0based() for encoding 0's based values, so add a corresponding helper to decode these fields on the host side. Suggested-by: Christoph Hellwig Signed-off-by: Caleb Sander Mateos --- drivers/nvme/host/nvme.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h index 9971045dbc05..ccd5e05dac98 100644 --- a/drivers/nvme/host/nvme.h +++ b/drivers/nvme/host/nvme.h @@ -760,10 +760,16 @@ static inline sector_t nvme_lba_to_sect(struct nvme_n= s_head *head, u64 lba) static inline u32 nvme_bytes_to_numd(size_t len) { return (len >> 2) - 1; } =20 +/* Decode a 2-byte "0's based"/"0-based" field */ +static inline u32 from0based(__le16 value) +{ + return (u32)le16_to_cpu(value) + 1; +} + static inline bool nvme_is_ana_error(u16 status) { switch (status & NVME_SCT_SC_MASK) { case NVME_SC_ANA_TRANSITION: case NVME_SC_ANA_INACCESSIBLE: --=20 2.45.2