From nobody Tue Apr 7 18:51:36 2026 Received: from mail-pf1-f225.google.com (mail-pf1-f225.google.com [209.85.210.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 988B2330321 for ; Thu, 26 Feb 2026 18:47:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772131627; cv=none; b=KG41qpswlsq/YEQaRSW5pRKDuVsVNnJSChar1LfeZfSYqszWvYNsof5h70BGHN06o7isgNTWHwzxbcBj6IeBDG86GHvqQmqxG6I1Lv3y7apcO5b3l7GZOu8G2U1WEKy1x/u471V3K7iW/7Kxj0HVv+314Da1EP561HRiWVwzm9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772131627; c=relaxed/simple; bh=W86nEt6NxrH/azDYUo8e8qcXbO9XW3P9ASHlOypQvuE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UYMhSbWiTjPZn9rsqibMmRS3Yw3SbLbvHLbZJXlTtmw4g0meQtSiQmg6RMdNstYtSIB8x39Yd7BG0WN/62KB/PCgSMN3Thpx6CxEKs8o8QueitkjRybDC7FEVtGmx7Wev/n6OBOl+WT4J/1fbQonB81JPXSIxgo7ZKYTj/QbgRQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=GxuSCWox; arc=none smtp.client-ip=209.85.210.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="GxuSCWox" Received: by mail-pf1-f225.google.com with SMTP id d2e1a72fcca58-827270d50d4so1282337b3a.3 for ; Thu, 26 Feb 2026 10:47:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772131626; x=1772736426; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HBpIii1a6ci9G3XxJ980AkP2auUKLh+wfXsf/L+7o90=; b=NdSOjFRwG3M5fsBhr4lAKcuic1UFsxboeVxFzZNu60+lgK4YRp9aqCrgkuuSW8S9b6 np3+IzyKPS7uxCRIizujLuyFDPJnVqmmpbMWJM2Pg3onlEUdI7RbEt4vLOiObhtuz39m bMKuC4ZYGTzdd2dwSGD8vLPIiLOVHyxiINbjiqH8nSnlmWK+0vuhg0VIBFz2TudgONiQ P/LX8LhVLUWMF6astJnrJok0H5RvV/YlyC0ViPcAjZTzOcTxFvBjorAMo/5g8oyJew/b Xd/TBK9ACzH4BXClNuBUg56fiRodeCTCiaqr5026ptGoUmHToVtCa3YdonbVfFKoQTAv JojA== X-Forwarded-Encrypted: i=1; AJvYcCUi90WtB6SjG2fNgz9crIzB6pFRqoZa9vfAirhxDPUYN01KLBan1KZhAWQoRl6cTR0uHvemCxrriuYTwU8=@vger.kernel.org X-Gm-Message-State: AOJu0YzXpZgBMUpLKHmQHbKS53B9uYPoCSQ2b91xksbKAptj35d/XvOs 2DL3MqtVECDIZAdTEFZxmjCKACDCISN93gGLsmcA4psjBMlMU1+PT8TXUipmWbGn0DCh0ssxv+j NQpWT/jw6eMCzNpNUJdLiAwm+ftbTcO2MAeV7dgyxYlZMEf5N/cKq5V1CsFjz1ToJGPNAh1p7NA 7NPYQg3n9gqMtp/qhUzeQ/2bF1BmuTAp/lAkXRR9otJnj8j8FGC50D44bE1/j72DCvV+R8/6m+e M2kIbMhY1a7P1b6cYWR X-Gm-Gg: ATEYQzxevk23AEJpxDJ790G2OSnhRyvFstOSinwIlK8u6nBvqQKIWIovFhM5efcS7nO tZkGal8FMz4iqVXmNz6tNh1e2WZKkP4uFNe9yg0X+l/7+Bp5v5ZbbjZALE6h2uHWQOkMzIlafDE lYxWad5lKGPNjz4eX39OxzG+CvD4jiVGkjYMgTNojAD5Jk0G8hx189a/MN0HS4M3vVhyA3jAtOk uAQe9j3PZ8E/l2ZD5CWtMvFTXn5vAKsyz9Ajo3IdlQ4ynTJmsh2dJ+/59r/RKReIKF+OF3CiooZ GFbp5nmortEZvwbuxNKg7F2sUHhJvYGtBnqRdSLLhKSJ/g+j1QOlGdqgPw54yLCkXbQNGh62JTu 2EF7qSPF4PGXDtw0yeQTkwYduoUkupK/Ua0A4pWRHf88dSYS1eeGsCGvpHDBz4Olilt0m2epAXB xJcX45ikBl7VjNKL38/l8s2ht+abN9YWNEn5651VNq/2u6+wsXeE4n6LQ= X-Received: by 2002:a05:6a00:6b93:20b0:81f:3f88:89ee with SMTP id d2e1a72fcca58-8274d9408dcmr73095b3a.12.1772131625852; Thu, 26 Feb 2026 10:47:05 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-27.dlp.protect.broadcom.com. [144.49.247.27]) by smtp-relay.gmail.com with ESMTPS id d2e1a72fcca58-82739e492a6sm335912b3a.5.2026.02.26.10.47.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Feb 2026 10:47:05 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c71500f274so123363885a.1 for ; Thu, 26 Feb 2026 10:47:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1772131625; x=1772736425; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HBpIii1a6ci9G3XxJ980AkP2auUKLh+wfXsf/L+7o90=; b=GxuSCWoxCs9dnunJSI0/zZJUiH065i5fsy2mFBGYlqCLaQ7LxIeQVYX7IGhPK6+h4h pxgxEXxzUYNE8hM8cth8YaLNpWRKy4O0achHsURAgC8LDnT9RHquiJu0jXqJjxqSgmwz Y1woy4xlxE9tzijAm3qnt+/WHa/peBCHirJBw= X-Forwarded-Encrypted: i=1; AJvYcCUaXfoSoYFNPh9HUFHS07/cX4auEC0NshRmWpn0UvCxHpTkYnI9ICEEKa6CWmxWJLreog3JVCaKyqpZ+tM=@vger.kernel.org X-Received: by 2002:a05:620a:1a90:b0:8ca:55:ac60 with SMTP id af79cd13be357-8cbc12294fdmr421801385a.78.1772131624405; Thu, 26 Feb 2026 10:47:04 -0800 (PST) X-Received: by 2002:a05:620a:1a90:b0:8ca:55:ac60 with SMTP id af79cd13be357-8cbc12294fdmr421794885a.78.1772131623840; Thu, 26 Feb 2026 10:47:03 -0800 (PST) Received: from lvnvda4076.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf6f5c41sm255721485a.24.2026.02.26.10.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 10:47:03 -0800 (PST) From: Kiran Kella To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, daniel.zahka@gmail.com, willemb@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jayakrishnan.udayavarma@broadcom.com, ajit.khaparde@broadcom.com, akhilesh.samineni@broadcom.com, Kiran Kella Subject: [net-next, v3 1/2] psp: Support for transmit on logical device when the underlying transport device supports PSP. Date: Thu, 26 Feb 2026 10:46:53 -0800 Message-ID: <20260226184654.3180648-2-kiran.kella@broadcom.com> X-Mailer: git-send-email 2.45.4 In-Reply-To: <20260226184654.3180648-1-kiran.kella@broadcom.com> References: <20260226184654.3180648-1-kiran.kella@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" This is achieved by propagating the psp_dev from the lower device to the upper devices in the device stack via a netdevice notifier. The lowest device owns the psp_dev pointer while the upper devices just borrow the pointer. When the lower device is unlinked, the borrowed pointer is cleared in the upper device. Assumption being that psp_dev is set on the lowest device before any upper devices are stacked on that lowest device. Signed-off-by: Kiran Kella Reviewed-by: Ajit Kumar Khaparde Reviewed-by: Akhilesh Samineni --- net/psp/psp_main.c | 117 ++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 116 insertions(+), 1 deletion(-) diff --git a/net/psp/psp_main.c b/net/psp/psp_main.c index a8534124f626..303a3af3bdf2 100644 --- a/net/psp/psp_main.c +++ b/net/psp/psp_main.c @@ -3,6 +3,7 @@ #include #include #include +#include #include #include #include @@ -110,13 +111,45 @@ void psp_dev_free(struct psp_dev *psd) kfree_rcu(psd, rcu); } =20 +/** + * psp_clear_upper_dev_psp_dev() - Clear borrowed psp_dev pointer on upper + * device + * @upper_dev: Upper device that may have borrowed psp_dev pointer + * @priv: netdev_nested_priv containing the psp_dev being unregistered + * + * Callback for netdev_walk_all_upper_dev_rcu() to clear borrowed psp_dev + * pointers on upper devices when the underlying psp_dev is being unregist= ered. + * + * Return: 0 to continue walking, non-zero to stop. + */ +static int psp_clear_upper_dev_psp_dev(struct net_device *upper_dev, + struct netdev_nested_priv *priv) +{ + struct psp_dev *psd =3D priv->data; + struct psp_dev *upper_psd; + + upper_psd =3D rcu_dereference(upper_dev->psp_dev); + if (upper_psd =3D=3D psd) + rcu_assign_pointer(upper_dev->psp_dev, NULL); + + return 0; +} + /** * psp_dev_unregister() - unregister PSP device * @psd: PSP device structure + * + * Unregisters a PSP device and clears all borrowed psp_dev pointers on + * upper devices (e.g., VLAN subinterfaces) that reference this device. + * This prevents use-after-free if upper devices still have borrowed + * pointers when the psp_dev structure is freed. */ void psp_dev_unregister(struct psp_dev *psd) { struct psp_assoc *pas, *next; + struct netdev_nested_priv priv =3D { + .data =3D psd, + }; =20 mutex_lock(&psp_devs_lock); mutex_lock(&psd->lock); @@ -137,6 +170,12 @@ void psp_dev_unregister(struct psp_dev *psd) =20 rcu_assign_pointer(psd->main_netdev->psp_dev, NULL); =20 + /* Clear borrowed psp_dev pointers on all upper devices */ + rcu_read_lock(); + netdev_walk_all_upper_dev_rcu(psd->main_netdev, + psp_clear_upper_dev_psp_dev, &priv); + rcu_read_unlock(); + psd->ops =3D NULL; psd->drv_priv =3D NULL; =20 @@ -313,11 +352,87 @@ int psp_dev_rcv(struct sk_buff *skb, u16 dev_id, u8 g= eneration, bool strip_icv) } EXPORT_SYMBOL(psp_dev_rcv); =20 +/** + * psp_netdevice_event() - Handle netdevice events for PSP device propagat= ion + * @nb: notifier block + * @event: netdevice event + * @ptr: netdevice notifier info + * + * Propagates psp_dev pointer from lower devices to upper devices when + * upper devices are created (e.g., VLAN subinterfaces). + * Excluding from this logic, the upper devices that have multiple lower + * devices eg., bond devices. + * + * Return: NOTIFY_DONE + */ +static int psp_netdevice_event(struct notifier_block *nb, + unsigned long event, void *ptr) +{ + struct netdev_notifier_changeupper_info *info; + struct net_device *dev, *upper_dev; + struct psp_dev *psd; + + if (event !=3D NETDEV_CHANGEUPPER) + return NOTIFY_DONE; + + info =3D ptr; + dev =3D netdev_notifier_info_to_dev(ptr); + upper_dev =3D info->upper_dev; + + if (netif_is_lag_master(upper_dev)) + return NOTIFY_DONE; + + if (info->linking) { + /* Lower device is being linked to an upper device. + * Propagate psp_dev from the immediate lower device to the + * upper device. The immediate lower device would have already + * got the psp_dev pointer set in a previous notification (or + * owns it if it's the lowest device). + * Upper devices just borrow the pointer. + * + * Use psp_dev_tryget/put to guard against a concurrent + * psp_dev_unregister that may have already cleared the + * lower device's pointer and started freeing the psp_dev. + */ + psd =3D rtnl_dereference(dev->psp_dev); + if (psd && psp_dev_tryget(psd)) { + rcu_assign_pointer(upper_dev->psp_dev, psd); + psp_dev_put(psd); + } + } else { + /* Lower device is being unlinked from an upper device. + * Clear the borrowed psp_dev pointer on the upper device. + * Any devices stacked above upper_dev will get their own + * NETDEV_CHANGEUPPER notifications as the stack unwinds. + */ + psd =3D rtnl_dereference(upper_dev->psp_dev); + if (psd) + rcu_assign_pointer(upper_dev->psp_dev, NULL); + } + + return NOTIFY_DONE; +} + +static struct notifier_block psp_netdevice_notifier =3D { + .notifier_call =3D psp_netdevice_event, +}; + static int __init psp_init(void) { + int err; + mutex_init(&psp_devs_lock); =20 - return genl_register_family(&psp_nl_family); + err =3D register_netdevice_notifier(&psp_netdevice_notifier); + if (err) + return err; + + err =3D genl_register_family(&psp_nl_family); + if (err) { + unregister_netdevice_notifier(&psp_netdevice_notifier); + return err; + } + return 0; } =20 subsys_initcall(psp_init); --=20 2.45.4