From nobody Tue Apr 7 19:03:34 2026 Received: from mail-qk1-f225.google.com (mail-qk1-f225.google.com [209.85.222.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A85A142883C for ; Thu, 26 Feb 2026 18:22:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772130178; cv=none; b=Jq+rqRRaYi7j8n1yJAk8Xl+ZAXt2t7xy6KVUICzG/rHoZXyKwYtPhIMU2lJoyD2LOPCpMRY1bCKCi+Pmj5+6NGr/ER7J8V0LZqjttpqokfVmFc8St9+OlCSQ2x4zkAvD951aLbb9t80B8f2bJTJQB4iC2YdmDkYfk2vmTy6qgUw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772130178; c=relaxed/simple; bh=VAJPtSz2Fi4CfU/cWreGio0ngANvFTPjoaoTm2qwyKc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UCxSRAzvDGWDxxkeXsH6lYmVUTMsdZ+xGzu8atVrwdOVQeadPGSmPUf5xpAGg59Xux20YJxwbdA81VRg1Io3r1E1Yen3eqMp35CAib16965bXYO+rV2yZvYWrR5+vMvolIsjU4YttI/CSshHywfWSY2YtfgygjK4+83VjlaWJ84= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Y9eAN07I; arc=none smtp.client-ip=209.85.222.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Y9eAN07I" Received: by mail-qk1-f225.google.com with SMTP id af79cd13be357-8cb3dfb3461so106797285a.3 for ; Thu, 26 Feb 2026 10:22:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772130175; x=1772734975; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HOSdVE7QGMpM1n9UC5hcdfQe4GJ8NgDaBIZ1ScDmGuU=; b=wXGySzuG296tnnP12IM3lYnVm3f3TJhxNDH03FbYELSDrw/wXuKK1qzS6sAX4Tn6q2 +z83JAgYx7m5kQ8YTi3jg3wJPobu4uxIGbFRQ0rtfB8SQq1RhQEZEeD1JzmNS16Vyo6z ddOav4FW2jKWah2gf+On70XoQBBGCR3a9Jzms1E8w7i+BJ0b1VhLgT1kccJHnDs9p2lx XGol4HQnG/vgud75xzLMmjeg8kIeRb4G79QtWJmbZEwVMgb4T1nnAt7RzZhmF5cHO1eK vq0wrWJPPyG7liz2s6RjLW0gPLk5n0JNKZLbCd9zVtgv0jT5e24FszlSZ9s3wscx2RHh BZaA== X-Forwarded-Encrypted: i=1; AJvYcCUrj41dT7jk+Z+xatQ+ccvkjQ54ItPzlEkj3+ZLhJzMFBJvw2hVOaTT6hnQjFm44Qd5lMjmglo5G5jqmgM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1qQxocejC49/vUtQcZ3y/y75bej1UzBnuw8bPnelNto2Qa0q0 HkSFmwi75Q6QTO+ZGzvVN+Ld0HulthM3047CoirmmY8VA6W4QO0ZI/20uiXyGEf5LDO8N8CftKt VTbj6XAWn6uFHW+yBprcdO57s1A+rn9mnvDW+r9IriAs6v+jOQpgg+I4/PMMjuFE15/4Kj3dKON 7/2DSE4hdui+W0n69BSVb0tN2tU98sjiH1ZJC1nodkYho8Rny/REGzvjOgyNPdZkJChyG2YRy/t 83Dg3aG83PfpGdA/W2iPCy6SQ== X-Gm-Gg: ATEYQzzRpAVkz1iT0ZGkMSZxPhP4f5SvL9RfQTaXX4SWzecozw3WasKPIMXooFvlJoV vfnMHCxUG3McUrsfKaLhndjcc4Dpe2Zh4yzqwQGrg5B69cwSjxsuV1ENkRYTrH4wRp+8EJkCu1W 8UcHES77qa3GLhIwolcDlxskCc4c9vVZUNe1RqHjGsQIoouMnv9W4zGVMUE8HP28WapzGW9IzO9 S64N+5s7p4dT4J4n6b+C5VOSUS2fego+8YqpCYu6oQy1l9bDDfRjKzY+UTof5S41FD0+REhXhvo jI1LDCUK6CTi8kCxUt+fHGsxd4oUKY2hin1oapZjKZFT7SJJ0XY1bhHRaWYjx/iK2yHaDJ2pzt/ agAEjcgOKG3vjpF5BhpbGS4kfyBVjUNZxE//cjTR2UGZAkiB7Zbzd0wXrC1zEhm5zvFCz9FEQOx yfZif3YIMsZz3sVoFlMvKf7wzyz3XHFLSsHY+xDPBlcnWwqyrq0xDjoL+WZyLQPlNOKA== X-Received: by 2002:a05:620a:d84:b0:8cb:8251:3fe0 with SMTP id af79cd13be357-8cb8c9fcffamr2547959285a.24.1772130175395; Thu, 26 Feb 2026 10:22:55 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-103.dlp.protect.broadcom.com. [144.49.247.103]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-899c714673bsm2497566d6.4.2026.02.26.10.22.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Feb 2026 10:22:55 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2aadeb3dee4so62223825ad.2 for ; Thu, 26 Feb 2026 10:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1772130174; x=1772734974; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HOSdVE7QGMpM1n9UC5hcdfQe4GJ8NgDaBIZ1ScDmGuU=; b=Y9eAN07IILeW9meO+Vx67S8ed0Z4YrcS9yX1t8wBkB1SwIKSVMW2PUbR9S1nw49YoA PuzsjJx7paY7es1s1OkxPo/RgdYB4/a0JYugeEgKICq5h8U4ehTw0EoM7Ee1bK0fvEu6 sNQ1u1wj+zQDTwM4KePlcLgg2w612fwDYlbdI= X-Forwarded-Encrypted: i=1; AJvYcCWSnDYVrnuIqoVoJpt2KURA+LYuWtaNgm92SSvXRr6Y1MNyGikf9OIiAzGZzkTeMCD5zvDd4xRdzxgRll0=@vger.kernel.org X-Received: by 2002:a17:902:e785:b0:2ad:c1e1:c286 with SMTP id d9443c01a7336-2adc1e1c458mr76045475ad.24.1772130174083; Thu, 26 Feb 2026 10:22:54 -0800 (PST) X-Received: by 2002:a17:902:e785:b0:2ad:c1e1:c286 with SMTP id d9443c01a7336-2adc1e1c458mr76045045ad.24.1772130173384; Thu, 26 Feb 2026 10:22:53 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb69ef1csm35941565ad.53.2026.02.26.10.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 10:22:52 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Ajit Kumar Khaparde Subject: [PATCH net-next v2 8/8] bng_en: implement ndo_get_stats64 Date: Thu, 26 Feb 2026 23:51:33 +0530 Message-ID: <20260226182133.1566714-9-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260226182133.1566714-1-bhargava.marreddy@broadcom.com> References: <20260226182133.1566714-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement the ndo_get_stats64 callback to report aggregate network statistics. The driver gathers these by accumulating the per-ring counters into the provided rtnl_link_stats64 structure. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 111 +++++++++++++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 2 + 2 files changed, 112 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 2b772956df8..7de82a0ce9a 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -468,7 +468,8 @@ static void bnge_sp_task(struct work_struct *work) =20 static bool bnge_drv_busy(struct bnge_net *bn) { - return test_bit(BNGE_STATE_IN_SP_TASK, &bn->state); + return test_bit(BNGE_STATE_IN_SP_TASK, &bn->state) || + test_bit(BNGE_STATE_READ_STATS, &bn->state); } =20 static void bnge_free_nq_desc_arr(struct bnge_nq_ring_info *nqr) @@ -2934,6 +2935,106 @@ static int bnge_shutdown_nic(struct bnge_net *bn) return 0; } =20 +static void bnge_get_ring_stats(struct bnge_dev *bd, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr =3D &bnapi->nq_ring; + u64 *sw =3D nqr->stats.sw_stats; + + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + + stats->rx_missed_errors +=3D + BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + + stats->multicast +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + + stats->tx_dropped +=3D BNGE_GET_RING_STATS64(sw, tx_error_pkts); + + stats->rx_dropped +=3D + nqr->sw_stats->rx.rx_netpoll_discards + + nqr->sw_stats->rx.rx_oom_discards; + } +} + +static void bnge_add_prev_stats(struct bnge_net *bn, + struct rtnl_link_stats64 *stats) +{ + struct rtnl_link_stats64 *prev_stats =3D &bn->net_stats_prev; + + stats->rx_packets +=3D prev_stats->rx_packets; + stats->tx_packets +=3D prev_stats->tx_packets; + stats->rx_bytes +=3D prev_stats->rx_bytes; + stats->tx_bytes +=3D prev_stats->tx_bytes; + stats->rx_missed_errors +=3D prev_stats->rx_missed_errors; + stats->multicast +=3D prev_stats->multicast; + stats->rx_dropped +=3D prev_stats->rx_dropped; + stats->tx_dropped +=3D prev_stats->tx_dropped; +} + +static void bnge_get_stats64(struct net_device *dev, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_dev *bd =3D bn->bd; + + set_bit(BNGE_STATE_READ_STATS, &bn->state); + /* Make sure bnge_close_core() sees that we are reading stats before + * we check the BNGE_STATE_OPEN flag. + */ + smp_mb__after_atomic(); + if (!test_bit(BNGE_STATE_OPEN, &bd->state)) { + clear_bit(BNGE_STATE_READ_STATS, &bn->state); + *stats =3D bn->net_stats_prev; + return; + } + + bnge_get_ring_stats(bd, stats); + bnge_add_prev_stats(bn, stats); + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + u64 *rx =3D bn->port_stats.sw_stats; + u64 *tx =3D bn->port_stats.sw_stats + + BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + + stats->rx_crc_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_fcs_err_frames); + stats->rx_frame_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_align_err_frames); + stats->rx_length_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_undrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_ovrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_runt_frames); + stats->rx_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_false_carrier_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_jbr_frames); + stats->collisions =3D + BNGE_GET_TX_PORT_STATS64(tx, tx_total_collisions); + stats->tx_fifo_errors =3D + BNGE_GET_TX_PORT_STATS64(tx, tx_fifo_underruns); + stats->tx_errors =3D BNGE_GET_TX_PORT_STATS64(tx, tx_err); + } + clear_bit(BNGE_STATE_READ_STATS, &bn->state); +} + static void bnge_close_core(struct bnge_net *bn) { struct bnge_dev *bd =3D bn->bd; @@ -2949,6 +3050,13 @@ static void bnge_close_core(struct bnge_net *bn) timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); + + /* Save ring stats before shutdown */ + if (bn->bnapi) { + bnge_get_ring_stats(bd, &bn->net_stats_prev); + bnge_get_ring_err_stats(bn, &bn->ring_err_stats_prev); + } + bnge_free_all_rings_bufs(bn); bnge_free_irq(bn); bnge_del_napi(bn); @@ -2998,6 +3106,7 @@ static const struct net_device_ops bnge_netdev_ops = =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, .ndo_start_xmit =3D bnge_start_xmit, + .ndo_get_stats64 =3D bnge_get_stats64, .ndo_features_check =3D bnge_features_check, }; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index f28edf94257..775438bccd0 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -291,6 +291,7 @@ struct bnge_sw_stats { enum bnge_net_state { BNGE_STATE_NAPI_DISABLED, BNGE_STATE_IN_SP_TASK, + BNGE_STATE_READ_STATS, }; =20 #define BNGE_TIMER_INTERVAL HZ @@ -382,6 +383,7 @@ struct bnge_net { =20 u64 flags; =20 + struct rtnl_link_stats64 net_stats_prev; struct bnge_total_ring_err_stats ring_err_stats_prev; =20 struct bnge_stats_mem port_stats; --=20 2.47.3