From nobody Tue Apr 7 18:51:34 2026 Received: from mail-dl1-f100.google.com (mail-dl1-f100.google.com [74.125.82.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFD59428472 for ; Thu, 26 Feb 2026 18:22:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772130173; cv=none; b=kyXvUA3w4wEJ1mxDu189+KPqwc4qipGKsW/L+yuTbozKXsz2IpV2oRmzry0Sk5CxnoMGCPGIiD2ebyepYGoxq0L30B+I2+K72j1hflT84PynyPmCivB0SVE0xN8gYE1sGMZ71XOXxyr5eBwzRfIan8XRQE4JeP8qOrszTk43db4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772130173; c=relaxed/simple; bh=j9pXrqilMEivb3kenCdVrVeZoo3VQ0pz99CklD/zhPo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uu6S//SO8W6nM7/ue7Jt+Uw+XaBCt1DisWGg9beW0VkPPf3uyJ/bH87jPu3viXB/oFXh7KJndnErznCWYdsux8O2xTvwVgAW4lMZT0EnpBmQ18wO86Zh4miktgiU4tbsh7m8mlEGAD3c89U2XX/TrT8UITMLQG++XPbXIgvzo0Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=FcipaMKd; arc=none smtp.client-ip=74.125.82.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="FcipaMKd" Received: by mail-dl1-f100.google.com with SMTP id a92af1059eb24-126ea4e9694so1087838c88.1 for ; Thu, 26 Feb 2026 10:22:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772130171; x=1772734971; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FlTV+qVzUdFJA5OXCVkJ9bsWka+6SR1Yh0G21rFd6Gw=; b=ltwcQezVTiJ0rKLkH3OVwDC5H22zoalUjpbtav7vEYp9oXucZm24UhMxB8UQx79ztZ 3JUbDKH8BnaF179ksYg9MvzD25+9+JRVy3U3GF0SY5V1Fdkjpwq2TPn2w2caUUXIcLz2 Bu52FmuZ+weYkpy/3R1mkAxnRap9Xw8vV4wqu+iudyutGmy2AjhvRY4eKUfvm+RbBO8J Gq86iW+ISS00m6I3D2gg7CEQi29FZWQMyH9YWZIyOd1ccXOlQ6q1HOZw9dOJZkidjIAx VQv5Ph+n0sUt9z3CGI5ra1KG7IHht9dtwWuO1jvAeZZ6HXXaYnsleK7sKpQEorStiKNW j+GA== X-Forwarded-Encrypted: i=1; AJvYcCWpxCMjAwPPuMysb89xRnUof4rZjBmTKuIdurg0oVaEmvDm7hYCgZoTwYbM91HYPcGCccwXouIEgauzO80=@vger.kernel.org X-Gm-Message-State: AOJu0Yww8wDxEfDVPIOLIqTE0EATetE+ehyjozx9hg596157EUoA+2J0 0tprfycB9zjMHFyj7EEi8BRwxJ7fxszPj9g1BqA7sd56fEtLAnhsF8WAz2tLHLh65qaf4lhwSIa vdPi9VyPAbLHGLxPcnwzUU4HdWItDujpEYwsh4EC7DQ+Vwimf4J5227kazSZawIVtTA8gQXFg3o kbW8SGh+Ht7eviLqWqFbeWfrpuW9KLgrkdSlNX2gLTJruhiBtjxT+PymeOqKM99p46w5Dl71i0n 7dsQxRK2HdS+LjenB+MMFLguA== X-Gm-Gg: ATEYQzy9KHmzFXz23IoJvrZZ8Bl6ANR3sRKteWGmk2aYPGIV0zFG8X6dJILt8lPQqsx 52w2QczMw86KWyv00DPdtZSb1VV3TB1P9ELBraPemr/2eqs/bgF8RXSXY0ad7YMJNM+ZuEcrlia Zi4YFJ/GzDEOy4PbwYdJ4Zva4uRvq8KSUTrDCz1ogeWjddXbgt+o6gn05EMgPQmTeowFGSSced/ el0W2IkMsRarOfeDpfE8s2piV69LCkJL4Wi/iZBDdSn0iz8MOkphIVNJ2xlizCdlUYYtyYhqYSa Fa2xSm1vO57qytuW8/BRfgTWRq7j/uBW9PkSKMVdytSs6Hrj+d+Z0FWPq2wqFvzxcI6lEwZtwxb 1kfkc8cRGLaIsS7dtszvx3rm2P5lb/L1k4+VHAAnK61PYwfxyfssIurfB270JtR9D+yJIewKFbs KZYqLJNPqdZEH3LMm2pTuo/UO7tq6XsaK2nKzli90nBRoaYMY8jrwgkkltKMWfQK3xBg== X-Received: by 2002:a05:7022:11d:b0:11b:8161:5cfc with SMTP id a92af1059eb24-1276ad3909amr8225871c88.36.1772130170924; Thu, 26 Feb 2026 10:22:50 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-118.dlp.protect.broadcom.com. [144.49.247.118]) by smtp-relay.gmail.com with ESMTPS id a92af1059eb24-12789a20cd1sm385895c88.6.2026.02.26.10.22.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Feb 2026 10:22:50 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2aaeafeadbcso11887225ad.1 for ; Thu, 26 Feb 2026 10:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1772130169; x=1772734969; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FlTV+qVzUdFJA5OXCVkJ9bsWka+6SR1Yh0G21rFd6Gw=; b=FcipaMKdXmXoI07tLLmXVzHHAzO8RDxA179sSwTpzyALprBB1g1LHIhDqMBjUqpVjq 95l4+mvHFG+pjFystmp7MXpRkNjUtPJWlzL9kV/nSXzTs1EF2UyAK1zkPWyKSYBUvT3A /bkBoOGVQWoCnnC8aemTrP/Mae9Q+Mo+qy8xM= X-Forwarded-Encrypted: i=1; AJvYcCWu79vSB5Y299TcR1YrqMR+/sN+qtGk51RJ2mU3Q/IbjdzkQ3ff8rpFQqVqVlTenryLevjnFu9+1yA5vHg=@vger.kernel.org X-Received: by 2002:a17:903:2445:b0:2aa:dad4:d34f with SMTP id d9443c01a7336-2ad74515d10mr186150285ad.27.1772130169110; Thu, 26 Feb 2026 10:22:49 -0800 (PST) X-Received: by 2002:a17:903:2445:b0:2aa:dad4:d34f with SMTP id d9443c01a7336-2ad74515d10mr186150105ad.27.1772130168646; Thu, 26 Feb 2026 10:22:48 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb69ef1csm35941565ad.53.2026.02.26.10.22.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 10:22:48 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rahul Gupta , Ajit Kumar Khaparde Subject: [PATCH net-next v2 7/8] bng_en: periodically fetch and accumulate hardware statistics Date: Thu, 26 Feb 2026 23:51:32 +0530 Message-ID: <20260226182133.1566714-8-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260226182133.1566714-1-bhargava.marreddy@broadcom.com> References: <20260226182133.1566714-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Use the timer to schedule periodic stats collection via the workqueue when the link is up. Fetch fresh counters from hardware via DMA and accumulate them into 64-bit software shadows, handling wrap-around for counters narrower than 64 bits. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rahul Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 90 +++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + 2 files changed, 91 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index c7b5de5a9c2..2b772956df8 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -322,9 +322,93 @@ static void bnge_timer(struct timer_list *t) } } =20 + if (BNGE_LINK_IS_UP(bd) && bn->stats_coal_ticks) + bnge_queue_sp_work(bn, BNGE_PERIODIC_STATS_SP_EVENT); + mod_timer(&bn->timer, jiffies + bn->current_interval); } =20 +static void bnge_add_one_ctr(u64 hw, u64 *sw, u64 mask) +{ + u64 sw_tmp, sw_val; + + hw &=3D mask; + sw_val =3D READ_ONCE(*sw); + sw_tmp =3D (sw_val & ~mask) | hw; + if (hw < (sw_val & mask)) + sw_tmp +=3D mask + 1; + WRITE_ONCE(*sw, sw_tmp); +} + +static void __bnge_accumulate_stats(__le64 *hw_stats, u64 *sw_stats, u64 *= masks, + int count) +{ + int i; + + for (i =3D 0; i < count; i++) { + u64 hw =3D le64_to_cpu(READ_ONCE(hw_stats[i])); + + if (masks[i] =3D=3D -1ULL) + sw_stats[i] =3D hw; + else + bnge_add_one_ctr(hw, &sw_stats[i], masks[i]); + } +} + +static void bnge_accumulate_stats(struct bnge_stats_mem *stats) +{ + if (!stats->hw_stats) + return; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + stats->hw_masks, stats->len / 8); +} + +static void bnge_accumulate_all_stats(struct bnge_dev *bd) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + struct bnge_stats_mem *ring0_stats =3D NULL; + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + struct bnge_stats_mem *stats; + + nqr =3D &bnapi->nq_ring; + stats =3D &nqr->stats; + + if (!ring0_stats) + ring0_stats =3D &bn->bnapi[0]->nq_ring.stats; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + ring0_stats->hw_masks, + ring0_stats->len / 8); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + struct bnge_stats_mem *stats =3D &bn->port_stats; + __le64 *hw_stats =3D stats->hw_stats; + u64 *sw_stats =3D stats->sw_stats; + u64 *masks =3D stats->hw_masks; + int cnt; + + cnt =3D sizeof(struct rx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + + hw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + sw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + masks +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + cnt =3D sizeof(struct tx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS_EXT) { + bnge_accumulate_stats(&bn->rx_port_stats_ext); + bnge_accumulate_stats(&bn->tx_port_stats_ext); + } +} + static void bnge_sp_task(struct work_struct *work) { struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); @@ -338,6 +422,12 @@ static void bnge_sp_task(struct work_struct *work) return; } =20 + if (test_and_clear_bit(BNGE_PERIODIC_STATS_SP_EVENT, &bn->sp_event)) { + bnge_hwrm_port_qstats(bd, 0); + bnge_hwrm_port_qstats_ext(bd, 0); + bnge_accumulate_all_stats(bd); + } + if (test_and_clear_bit(BNGE_UPDATE_PHY_SP_EVENT, &bn->sp_event)) { int rc; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 823060737da..f28edf94257 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -305,6 +305,7 @@ enum bnge_sp_event { BNGE_LINK_SPEED_CHNG_SP_EVENT, BNGE_LINK_CFG_CHANGE_SP_EVENT, BNGE_UPDATE_PHY_SP_EVENT, + BNGE_PERIODIC_STATS_SP_EVENT, }; =20 struct bnge_net { --=20 2.47.3