From nobody Tue Apr 7 17:13:27 2026 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 750F0428824 for ; Thu, 26 Feb 2026 16:38:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772123937; cv=none; b=o4hzuUQIyqiR9RG/9noxm38lveO9TciM4o69ZMmOjm29lURk9vSLl3vwA8CNED9AuTUntybwECKhQ61v0c017iu5qnQx/JKhCefEVIhLglA5rCWleSuns7iNTNDm79gVAqUlhIH4YapmaABeBWnGWuG7w1wOX5T9gC83pkKEIbk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772123937; c=relaxed/simple; bh=3ZOUU2ErlWmNwDZe9kOOLOwTpgY9iXMrxZCheD02Nrc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=vCV2NmhGV0Wp44ds7rcFelWahCKuVqfOkhwBogTA3AoV0AcLTlEFcrQap6ulK/uc4SXWuqVdIIQ5DSUL6luCgPhvkQiabXrC0qifB8PuSEjaQOAThZVe4omrwdErRyAmzq56tFqzRpH1bc74KQ8fp/V/BuTaNy9efU3foyyttqk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bh5TxDNE; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bh5TxDNE" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-7986d231b3cso24687357b3.1 for ; Thu, 26 Feb 2026 08:38:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772123935; x=1772728735; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VQsc8cJztTF76PG4R+gL+xvTB4Nt8EQAhsB9W1n8IoE=; b=bh5TxDNECq8kTr25qufrSamdXE4URv4CTyKpgBf2pCGsOifbVnyDQalrNpS89bX9XX tjsop9xQGHNX5q2BiGBcU+GAJtxzNA3xHmeVq9rbeJcOKX/6lWgHP1AiA/v5n2Sey69I oBq5qsFuWZmqU7lSl447ab07D71MnSziSYVzg85xMT+B0ZptAsv2cJwUoGMBHUaIS9VV lN9tAXT9jt5C9J05J1jlG4XbYCRg4FL+ohPnHgm+xysJ9W25Z1sjEooCsH8QUJmR5hQu zFO9EF5cOjdZBYE3vfgMDj6zoRWl6NrcrchWmyFiRuAoChQHpVebd6tWi8ZvcKL/7gcy Mnpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772123935; x=1772728735; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VQsc8cJztTF76PG4R+gL+xvTB4Nt8EQAhsB9W1n8IoE=; b=RlFOJe91evhNBgcV0AJuJbon8WMb6AesuvbMONowBo+VaapiexJzTFnMD6Cbc0CRJy ZrGdLyuamrAarIn0/NRSvZZ0T02kLK4z1jDiNvYTno4U5/kbdtnq9qnRsMRAvBSURFhq EnPFRTNRVx+MouqFb54VWjahYvksCb0ifhLBZVgOtFmgro0OErVAt+3FqpR+G1cotz7A 0UOv+L4kEjA/9/L79/w57qS6im3EmRrZKU+N7lD/fA/f09II7nPnREvEqRScZOFUiE5V uiwf6iOeu+9NPO4JM2pITzNFs2U3o5aToA+iwgFs4Ky3Sn+0rpiGo/0JXox/CdHbC188 IYkA== X-Forwarded-Encrypted: i=1; AJvYcCUHmq1kyJjASeu5ak0L1oSbZhwFf09b6Jr0OebzWSCWVdoet4tfoocrmzqU2XCt10uL1wgWNToONk88scY=@vger.kernel.org X-Gm-Message-State: AOJu0YxHosBBnp66TgaZKcK33390bYMYuDtp+x6ZMHU6cbLWxGgvrFJ5 EnEGuxupSkUxsB/qzOZ8ipyXTYyjUGFcTPkg8Ldum0sCqyENpBkX61jO X-Gm-Gg: ATEYQzxw5TTjHret3h1KpDRWEJOIlzrhcOXyHXuXzim8aItVMFp120RDvsKEh4rStWr DLqTyzoPllo7I7ywsxhg+0GvNV/cEWsl85oLvyeJJRkLp9Ef41Ngrvqw2KHLZcfoqLtuL2ruzPp Rc5fDeBNUyUJQmm5Mz7qbhWeegfxdKQ3NqZ0pM3oVm+0IZqsQJCLMATb2HJSAaf8S1600zCBD33 JkL5dFh9L5iq26gERFi2N7fDNovdomMx+diUsHbB7XYz2GXZUv/AoaTAnsw3kl5/oMsfXXT5Mse 7VgtPcEi2Ac6TnHIQXlaOF63PJGHf59NQPpJyNp+HPVHdT/EaeCWQ2dlilk1oHU1ViYFray1bjA T9Bj/uMowSYD1D7kcLvSQ/pND9VlavcgdSjDB7xzXH87rU8PwGvn7j1lzgsB2BhljD7Pafte2uv JzjY+Q/OHutFucAG1v96C0lF/TV08w0hSx0hV6pD5hMosuwNKMmowOwp/CscmkuKOEFT5i/XGra 28PGQ3jQPzQXVr1T5VMnlGs X-Received: by 2002:a05:690e:4492:b0:63f:96d7:a369 with SMTP id 956f58d0204a3-64cb6f19ad3mr2308595d50.28.1772123935319; Thu, 26 Feb 2026 08:38:55 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb74b985asm1150803d50.0.2026.02.26.08.38.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 08:38:55 -0800 (PST) From: Ethan Tidmore To: wens@kernel.org, mripard@kernel.org, jernej.skrabec@gmail.com, samuel@sholland.org Cc: maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] drm/sun4i: Fix resource leaks Date: Thu, 26 Feb 2026 10:38:36 -0600 Message-ID: <20260226163836.10335-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Three clocks are not being released in devm_regmap_init_mmio() error path. Add proper goto and set ret to the error code. Fixes: 8270249fbeaf0 ("drm/sun4i: backend: Create regmap after access is po= ssible") Signed-off-by: Ethan Tidmore Reviewed-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun4i_backend.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/= sun4i_backend.c index 6391bdc94a5c..e989f75c09b7 100644 --- a/drivers/gpu/drm/sun4i/sun4i_backend.c +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c @@ -881,7 +881,8 @@ static int sun4i_backend_bind(struct device *dev, struc= t device *master, &sun4i_backend_regmap_config); if (IS_ERR(backend->engine.regs)) { dev_err(dev, "Couldn't create the backend regmap\n"); - return PTR_ERR(backend->engine.regs); + ret =3D PTR_ERR(backend->engine.regs); + goto err_disable_ram_clk; } =20 list_add_tail(&backend->engine.list, &drv->engine_list); --=20 2.53.0