From nobody Tue Apr 7 18:51:41 2026 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C88AD35A394 for ; Thu, 26 Feb 2026 16:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122173; cv=none; b=GLU7WdnsNWVShheyG6RtwLAeL9pUtRrspF1vo8kn727IKUO15mOhhDsaN1Bw74NTW51GJbAFXORswQYdKVpkrJlCVyvMScoOAj0vvnF8OkP5QGyX7gqhTh/gp2SL4ISZav4shI2vNi0oVwp/XMA7NIsAxOazSb9ubBuwpOuJji0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122173; c=relaxed/simple; bh=mGwXJxQ8B9+61F8/VPcfgs6XYDIXRha1M1Q+adyZkxw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XeEzReBnlBPrphw+TgLVC+JgN6GIKSkGfEhtLuhb8UdCoqSbZ3NXfCx178HphLfDXJYAzPANsIUBe8ug5GkSHOzS4J1ey4Oo4IQWROJTWoA7QiKcNix3bn5noS4javS/nq+6FnrMYhCnKvYLwE1/CjMnGH0sVInmsC2geA54fzI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZkKW0TcO; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZkKW0TcO" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-79868cde1eeso10840317b3.2 for ; Thu, 26 Feb 2026 08:09:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772122166; x=1772726966; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OtssGMmgpsS0GlJdNGMxqurgMvcq6MJjd3dPtJY3SVc=; b=ZkKW0TcOoLZUPtOuXL19MBosyrwtx4L34DQfFdD5C7q5TXDyK6C7+6XBWMjR8Qx86e kfnTWsblnqP9PvI8cFL8GGdzTZfmTGPCGtheXsgac7wFIdnjSY5cpf9H8H5fvg2z4Uea h4tWyHKZyw5rl//4PEm+0H01LqRb4gTKEJqSyPOOcMnHrbEcw26UTStgYDCapS38GZ8b ni7W61YMVGoZftbs8l9o9q2UREPyFacfCIDgABVlRnvuYLdOSTuDwM1Dh4rsP2ffeyD3 CCbGvzSoOCD8INuWeo/AOy+hewL6azcj+0E+zsAO3amX60gjjtAQ3tbY5D2DwGVMEJUT qWfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772122166; x=1772726966; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OtssGMmgpsS0GlJdNGMxqurgMvcq6MJjd3dPtJY3SVc=; b=HRHJzL9iq5OFPaNVvButhub94OR9ovTvoJvrntuLHNqJqXGkaXstCI0aLMa9l1WACA txgPaG7V6jwd8F+TEyDkqzuOXjhwkSMwAsHwkBZRkAZ2016QQxBHnolfn8vSh3yH2rjh HIbMTNIM/b6At2j5bJqGxY13RCuCWlO/HQIx7od6LEMeMFiedTAi8MSsqGjHs8K3HxlQ jLcu+Mh/5eo1gDoiaY90wPkUZHG1GuT6kNFtUIwVv/5D05YNlq+/j4BKXY5GhQA5KIOv Fv/eUFmcTJUcJiRZ32Qx8gpXg2MD12Fj2PvXs2MycS14LgGT0dK6LGt2TLVjLdbaw7bf RPGg== X-Forwarded-Encrypted: i=1; AJvYcCW8qT2kqq7lQqKqFZEFBUJwe9HYcGB+U4a9ZgMMcv9hLfniy0W2w+stXGBenhiagi01K+Nn5aR/VjgoM00=@vger.kernel.org X-Gm-Message-State: AOJu0YzKR3/iXfc0sMVL2QCOb0ltY4eJy5E8Rh/L7CSnLpzuCWif+qE6 88duGbnpyPY6vxMTj7r8r3gM4B8AevZFUonABOclFiaC99PyzYQ02sPt X-Gm-Gg: ATEYQzxSD5LvFrz64u6qAWLjJmqml/06p2YZqPr1G2ZzHd/mHpGTEiXvUYGHBv+Hq5g EM6PTPHkA4NxAG8DtTUO2RCmVvjSUC/rpbWZ2aInXF4sjmgDzfIc8p988S+l/h+lTn4kWunMwRU Lf59n2jhaxMwDcBBF9Dj4RD55D9LPwAJnE+f8t0qGwdqGC6sx+SGy4K87/ClxwiM9uV9J2OJltt GxJT6mrWaIRomKuL05SGi115WZyAXoy5Pn9ivYClEw5uFp5lNuqVN3zCXUDWjqm4pO0Git8IuT/ ZE4jwBEUIuQN1NgWzdtfHjuNxhad/jDo0x+FhzpNirByi0Jot5sMO2qL1mu3QUlxd77oBC3k//I YYjTYepLXjhCx9DEcJN7IKm2u3rRQmxgGETD/2I0NlZjj7lPQJngHFmKkh1rLNGQhvgf/XbqcGA JYZpbZO0SVgjbSh99AlS/HWVwxW9dtDnz8RUjJArWJtezqLBvcva2r3R8yKK09CfQhEVO8/+B+5 yWfXggkL6/qqMa9pFGL/6M+ X-Received: by 2002:a05:690c:d8a:b0:797:ddf2:7cac with SMTP id 00721157ae682-798291548e2mr177249357b3.63.1772122166458; Thu, 26 Feb 2026 08:09:26 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876cb9f19sm10225967b3.53.2026.02.26.08.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 08:09:26 -0800 (PST) From: Ethan Tidmore To: linkinjeon@kernel.org, hyc.lee@gmail.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 2/3] ntfs: Add missing error code Date: Thu, 26 Feb 2026 10:09:05 -0600 Message-ID: <20260226160906.7175-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260226160906.7175-1-ethantidmore06@gmail.com> References: <20260226160906.7175-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If ntfs_attr_iget() fails no error code is assigned to be returned. Detected by Smatch: fs/ntfs/attrib.c:2665 ntfs_attr_add() warn: missing error code 'err' Signed-off-by: Ethan Tidmore Reviewed-by: Hyunchul Lee =20 --- fs/ntfs/attrib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c index e260540eb7c5..71ad870eceac 100644 --- a/fs/ntfs/attrib.c +++ b/fs/ntfs/attrib.c @@ -2661,6 +2661,7 @@ int ntfs_attr_add(struct ntfs_inode *ni, __le32 type, /* Open new attribute and resize it. */ attr_vi =3D ntfs_attr_iget(VFS_I(ni), type, name, name_len); if (IS_ERR(attr_vi)) { + err =3D PTR_ERR(attr_vi); ntfs_error(sb, "Failed to open just added attribute"); goto rm_attr_err_out; } --=20 2.53.0