From nobody Tue Apr 7 18:51:42 2026 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F811364946 for ; Thu, 26 Feb 2026 16:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122173; cv=none; b=DNk6IdpWcxoDb51l0gAMyW3qX9OrA3nzprhjGYbZT0h2MtUAe8Ljofe2DZZeCPp8GcYY5NSZLv3AoIzwCeMjXesI3n5uVy+nZyiRY/Cl9nj5WyYZoYjjelPLy0+ZiytI/UKBMNL2wk4cyjRScARSMkEZikPn0N2Rc8WIJa1WmDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122173; c=relaxed/simple; bh=V/GXiRpANGsEMhYKzBOchE0smCbiEsiW2zG9TTOtkjQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UzAk2cqNvoP/yOKx197soizfJYn2RpFEJtXeKc0nYJCqx3Jfol5zfe0vxQw5HDscMmwJzXndAAprlUWa+JBYd6bMZR3bCuWaaSeJXVpCiuPUq03Mox9cUTEJILXkRWHmX1JTgGyAR6J0j8Sg7OEpl4j2lt3YXwNKWQrcUNslDDo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BtcPq9Nc; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BtcPq9Nc" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-7986e0553b0so9349537b3.2 for ; Thu, 26 Feb 2026 08:09:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772122166; x=1772726966; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cqBzIH4InHJCj/l4Dt60MIlWrD3B8yAylq+UyEFD2Hw=; b=BtcPq9NczadZlyXkSbt2xvrdHNwagek20lgJEJ2dc8DUAF+ibkYwUzD47TKBwrRQ8a Gdf1U0v8B3tFspkrHzxicXTI5dcy4XJrYfrl3MrDk2+XY7ljV+RzAyvowkHYPdphkneN OY+SPzjxbSYbyRx6apfQWxnYAxoI332KQCZtFPXwkhktdljq1khu6FbmNcOp3h4BY0AG 1sVKNDDIt+chEILQjFzg+Nw/2i9IzhIImL/ydXknddOeNnbojgOYQY0s6VjLr3rg5ZHD XkhAWEyXuq8fxkKooFrPGj/5Dg9MzuxuxZDcXnW3KkzEVmBOCs1c0mInVPDgufn1Io5X 7YhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772122166; x=1772726966; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cqBzIH4InHJCj/l4Dt60MIlWrD3B8yAylq+UyEFD2Hw=; b=BYrywZkRnEOAVayLBy3gDbyal+9/O+j5p01F97zQrw29Go6USLW9/CPQvMeafnNmzE fUwM1cXZCLDJN0lxglb905WHxS973zg5yz/CKh6tujHCMKhlIUSfI3sf1NNdwzApyDu2 Ht3JEHcOdxQdXe0qjHnpdFprA0Vh0T2VsdlNUtqOMWrXrLkzQ7BAi+42WFB2h5dii+mA nyUPHYxhXQ0+w+w2v/i5UC/T5clmD8+abUycOa/m/yY5HDiRCyNcL4ELVw/h7FxiT/GC kllf4YwTlviAPvA2IHz6eXQHiNKFdTqUpEymvxwGn6y4G4pJUWWOSrKbJkHSJDd1ZPOP P7EQ== X-Forwarded-Encrypted: i=1; AJvYcCXeD/LJ/CJif5V3Sbw7zwJ/eays+N+CgG5whx8hTplz639U8fTmgiZRYYJxTtW9uARDgAaIB/UduWnWWuw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4wyH6FmK2DKy4Ev0hwgGJK1pas4peDgMzPxeYxVuphGxp9vPZ ww7mtY+Iv2pK5ibi9xawSsfAHwGwoqjTxdSimzcx4Ru/1UpK+7IQqmCUTg/wogDhdRM= X-Gm-Gg: ATEYQzw7/7TQbOcjSMeQ4V8wk3Q8+cnsrq0YfIhFLMg075gpZrATWK/N1TlWwNtI0wf 4vFySMSl+CxiKH2T4zAwpuXk+PqgjqlIALTzgiLcKndTT8qQ9gCDr9LVbCTZ07eSPWAQFxV4pYm In090/VL3QpeROGOrJlZg6Sg4gBz8ebbTEAkKyQ7RNRNsZJbq+zeRn+yIJWBiEVUhZWvcmEgrod mtcpEk2MhmYgLZZfGov9Y1D33nZZDVqW+x8bObVOBazhL0JWKbbu2nFo84su3sCeX8NTF3fSqKf A8eETqlAGXV4uGVvzGyxHILL28BAIZ+nW67nPtOM8PLklWtiaUp9v9OaUdQtNmyEe62rCT/VESd 5hyhjopQVJEMGGJ9etRyXIw+dy2Mj2iBhaI/wzDMMFg84mJfOynyJ02ix0RYaDydwrro22d5zOp DXO9mFoxUmrRrjNbGqmMUlvxV7jy0MqXuJFGxFHcs+nr2eMiqEkwJFiv3Kl5wXhzUuwGyHuNdjM ELeKkl3hekwK7FQczMdDJ19 X-Received: by 2002:a05:690c:d83:b0:796:6da9:bfa3 with SMTP id 00721157ae682-79876bcd9bdmr20581847b3.7.1772122165932; Thu, 26 Feb 2026 08:09:25 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876cb9f19sm10225967b3.53.2026.02.26.08.09.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 08:09:25 -0800 (PST) From: Ethan Tidmore To: linkinjeon@kernel.org, hyc.lee@gmail.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 1/3] ntfs: Place check before dereference Date: Thu, 26 Feb 2026 10:09:04 -0600 Message-ID: <20260226160906.7175-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260226160906.7175-1-ethantidmore06@gmail.com> References: <20260226160906.7175-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable ni has the possiblity of being null and is checked for it but, only after it was dereferenced in a log message. Put check before dereference. Detected by Smatch: fs/ntfs/attrib.c:2115 ntfs_resident_attr_record_add() warn: variable dereferenced before check 'ni' (see line 2111) fs/ntfs/attrib.c:2237 ntfs_non_resident_attr_record_add() warn: variable dereferenced before check 'ni' (see line 2232) Signed-off-by: Ethan Tidmore Reviewed-by: Hyunchul Lee =20 --- fs/ntfs/attrib.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c index e8285264f619..e260540eb7c5 100644 --- a/fs/ntfs/attrib.c +++ b/fs/ntfs/attrib.c @@ -2108,13 +2108,13 @@ int ntfs_resident_attr_record_add(struct ntfs_inode= *ni, __le32 type, int err, offset; struct ntfs_inode *base_ni; =20 + if (!ni || (!name && name_len)) + return -EINVAL; + ntfs_debug("Entering for inode 0x%llx, attr 0x%x, flags 0x%x.\n", (long long) ni->mft_no, (unsigned int) le32_to_cpu(type), (unsigned int) le16_to_cpu(flags)); =20 - if (!ni || (!name && name_len)) - return -EINVAL; - err =3D ntfs_attr_can_be_resident(ni->vol, type); if (err) { if (err =3D=3D -EPERM) @@ -2229,14 +2229,14 @@ static int ntfs_non_resident_attr_record_add(struct= ntfs_inode *ni, __le32 type, struct ntfs_inode *base_ni; int err, offset; =20 + if (!ni || dataruns_size <=3D 0 || (!name && name_len)) + return -EINVAL; + ntfs_debug("Entering for inode 0x%llx, attr 0x%x, lowest_vcn %lld, dataru= ns_size %d, flags 0x%x.\n", (long long) ni->mft_no, (unsigned int) le32_to_cpu(type), (long long) lowest_vcn, dataruns_size, (unsigned int) le16_to_cpu(flags)); =20 - if (!ni || dataruns_size <=3D 0 || (!name && name_len)) - return -EINVAL; - err =3D ntfs_attr_can_be_non_resident(ni->vol, type); if (err) { if (err =3D=3D -EPERM) --=20 2.53.0