From nobody Tue Apr 7 17:12:33 2026 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F811364946 for ; Thu, 26 Feb 2026 16:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122173; cv=none; b=DNk6IdpWcxoDb51l0gAMyW3qX9OrA3nzprhjGYbZT0h2MtUAe8Ljofe2DZZeCPp8GcYY5NSZLv3AoIzwCeMjXesI3n5uVy+nZyiRY/Cl9nj5WyYZoYjjelPLy0+ZiytI/UKBMNL2wk4cyjRScARSMkEZikPn0N2Rc8WIJa1WmDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122173; c=relaxed/simple; bh=V/GXiRpANGsEMhYKzBOchE0smCbiEsiW2zG9TTOtkjQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UzAk2cqNvoP/yOKx197soizfJYn2RpFEJtXeKc0nYJCqx3Jfol5zfe0vxQw5HDscMmwJzXndAAprlUWa+JBYd6bMZR3bCuWaaSeJXVpCiuPUq03Mox9cUTEJILXkRWHmX1JTgGyAR6J0j8Sg7OEpl4j2lt3YXwNKWQrcUNslDDo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BtcPq9Nc; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BtcPq9Nc" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-7986e0553b0so9349537b3.2 for ; Thu, 26 Feb 2026 08:09:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772122166; x=1772726966; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cqBzIH4InHJCj/l4Dt60MIlWrD3B8yAylq+UyEFD2Hw=; b=BtcPq9NczadZlyXkSbt2xvrdHNwagek20lgJEJ2dc8DUAF+ibkYwUzD47TKBwrRQ8a Gdf1U0v8B3tFspkrHzxicXTI5dcy4XJrYfrl3MrDk2+XY7ljV+RzAyvowkHYPdphkneN OY+SPzjxbSYbyRx6apfQWxnYAxoI332KQCZtFPXwkhktdljq1khu6FbmNcOp3h4BY0AG 1sVKNDDIt+chEILQjFzg+Nw/2i9IzhIImL/ydXknddOeNnbojgOYQY0s6VjLr3rg5ZHD XkhAWEyXuq8fxkKooFrPGj/5Dg9MzuxuxZDcXnW3KkzEVmBOCs1c0mInVPDgufn1Io5X 7YhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772122166; x=1772726966; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cqBzIH4InHJCj/l4Dt60MIlWrD3B8yAylq+UyEFD2Hw=; b=BYrywZkRnEOAVayLBy3gDbyal+9/O+j5p01F97zQrw29Go6USLW9/CPQvMeafnNmzE fUwM1cXZCLDJN0lxglb905WHxS973zg5yz/CKh6tujHCMKhlIUSfI3sf1NNdwzApyDu2 Ht3JEHcOdxQdXe0qjHnpdFprA0Vh0T2VsdlNUtqOMWrXrLkzQ7BAi+42WFB2h5dii+mA nyUPHYxhXQ0+w+w2v/i5UC/T5clmD8+abUycOa/m/yY5HDiRCyNcL4ELVw/h7FxiT/GC kllf4YwTlviAPvA2IHz6eXQHiNKFdTqUpEymvxwGn6y4G4pJUWWOSrKbJkHSJDd1ZPOP P7EQ== X-Forwarded-Encrypted: i=1; AJvYcCXeD/LJ/CJif5V3Sbw7zwJ/eays+N+CgG5whx8hTplz639U8fTmgiZRYYJxTtW9uARDgAaIB/UduWnWWuw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4wyH6FmK2DKy4Ev0hwgGJK1pas4peDgMzPxeYxVuphGxp9vPZ ww7mtY+Iv2pK5ibi9xawSsfAHwGwoqjTxdSimzcx4Ru/1UpK+7IQqmCUTg/wogDhdRM= X-Gm-Gg: ATEYQzw7/7TQbOcjSMeQ4V8wk3Q8+cnsrq0YfIhFLMg075gpZrATWK/N1TlWwNtI0wf 4vFySMSl+CxiKH2T4zAwpuXk+PqgjqlIALTzgiLcKndTT8qQ9gCDr9LVbCTZ07eSPWAQFxV4pYm In090/VL3QpeROGOrJlZg6Sg4gBz8ebbTEAkKyQ7RNRNsZJbq+zeRn+yIJWBiEVUhZWvcmEgrod mtcpEk2MhmYgLZZfGov9Y1D33nZZDVqW+x8bObVOBazhL0JWKbbu2nFo84su3sCeX8NTF3fSqKf A8eETqlAGXV4uGVvzGyxHILL28BAIZ+nW67nPtOM8PLklWtiaUp9v9OaUdQtNmyEe62rCT/VESd 5hyhjopQVJEMGGJ9etRyXIw+dy2Mj2iBhaI/wzDMMFg84mJfOynyJ02ix0RYaDydwrro22d5zOp DXO9mFoxUmrRrjNbGqmMUlvxV7jy0MqXuJFGxFHcs+nr2eMiqEkwJFiv3Kl5wXhzUuwGyHuNdjM ELeKkl3hekwK7FQczMdDJ19 X-Received: by 2002:a05:690c:d83:b0:796:6da9:bfa3 with SMTP id 00721157ae682-79876bcd9bdmr20581847b3.7.1772122165932; Thu, 26 Feb 2026 08:09:25 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876cb9f19sm10225967b3.53.2026.02.26.08.09.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 08:09:25 -0800 (PST) From: Ethan Tidmore To: linkinjeon@kernel.org, hyc.lee@gmail.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 1/3] ntfs: Place check before dereference Date: Thu, 26 Feb 2026 10:09:04 -0600 Message-ID: <20260226160906.7175-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260226160906.7175-1-ethantidmore06@gmail.com> References: <20260226160906.7175-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable ni has the possiblity of being null and is checked for it but, only after it was dereferenced in a log message. Put check before dereference. Detected by Smatch: fs/ntfs/attrib.c:2115 ntfs_resident_attr_record_add() warn: variable dereferenced before check 'ni' (see line 2111) fs/ntfs/attrib.c:2237 ntfs_non_resident_attr_record_add() warn: variable dereferenced before check 'ni' (see line 2232) Signed-off-by: Ethan Tidmore Reviewed-by: Hyunchul Lee =20 --- fs/ntfs/attrib.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c index e8285264f619..e260540eb7c5 100644 --- a/fs/ntfs/attrib.c +++ b/fs/ntfs/attrib.c @@ -2108,13 +2108,13 @@ int ntfs_resident_attr_record_add(struct ntfs_inode= *ni, __le32 type, int err, offset; struct ntfs_inode *base_ni; =20 + if (!ni || (!name && name_len)) + return -EINVAL; + ntfs_debug("Entering for inode 0x%llx, attr 0x%x, flags 0x%x.\n", (long long) ni->mft_no, (unsigned int) le32_to_cpu(type), (unsigned int) le16_to_cpu(flags)); =20 - if (!ni || (!name && name_len)) - return -EINVAL; - err =3D ntfs_attr_can_be_resident(ni->vol, type); if (err) { if (err =3D=3D -EPERM) @@ -2229,14 +2229,14 @@ static int ntfs_non_resident_attr_record_add(struct= ntfs_inode *ni, __le32 type, struct ntfs_inode *base_ni; int err, offset; =20 + if (!ni || dataruns_size <=3D 0 || (!name && name_len)) + return -EINVAL; + ntfs_debug("Entering for inode 0x%llx, attr 0x%x, lowest_vcn %lld, dataru= ns_size %d, flags 0x%x.\n", (long long) ni->mft_no, (unsigned int) le32_to_cpu(type), (long long) lowest_vcn, dataruns_size, (unsigned int) le16_to_cpu(flags)); =20 - if (!ni || dataruns_size <=3D 0 || (!name && name_len)) - return -EINVAL; - err =3D ntfs_attr_can_be_non_resident(ni->vol, type); if (err) { if (err =3D=3D -EPERM) --=20 2.53.0 From nobody Tue Apr 7 17:12:33 2026 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C88AD35A394 for ; Thu, 26 Feb 2026 16:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122173; cv=none; b=GLU7WdnsNWVShheyG6RtwLAeL9pUtRrspF1vo8kn727IKUO15mOhhDsaN1Bw74NTW51GJbAFXORswQYdKVpkrJlCVyvMScoOAj0vvnF8OkP5QGyX7gqhTh/gp2SL4ISZav4shI2vNi0oVwp/XMA7NIsAxOazSb9ubBuwpOuJji0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122173; c=relaxed/simple; bh=mGwXJxQ8B9+61F8/VPcfgs6XYDIXRha1M1Q+adyZkxw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XeEzReBnlBPrphw+TgLVC+JgN6GIKSkGfEhtLuhb8UdCoqSbZ3NXfCx178HphLfDXJYAzPANsIUBe8ug5GkSHOzS4J1ey4Oo4IQWROJTWoA7QiKcNix3bn5noS4javS/nq+6FnrMYhCnKvYLwE1/CjMnGH0sVInmsC2geA54fzI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZkKW0TcO; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZkKW0TcO" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-79868cde1eeso10840317b3.2 for ; Thu, 26 Feb 2026 08:09:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772122166; x=1772726966; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OtssGMmgpsS0GlJdNGMxqurgMvcq6MJjd3dPtJY3SVc=; b=ZkKW0TcOoLZUPtOuXL19MBosyrwtx4L34DQfFdD5C7q5TXDyK6C7+6XBWMjR8Qx86e kfnTWsblnqP9PvI8cFL8GGdzTZfmTGPCGtheXsgac7wFIdnjSY5cpf9H8H5fvg2z4Uea h4tWyHKZyw5rl//4PEm+0H01LqRb4gTKEJqSyPOOcMnHrbEcw26UTStgYDCapS38GZ8b ni7W61YMVGoZftbs8l9o9q2UREPyFacfCIDgABVlRnvuYLdOSTuDwM1Dh4rsP2ffeyD3 CCbGvzSoOCD8INuWeo/AOy+hewL6azcj+0E+zsAO3amX60gjjtAQ3tbY5D2DwGVMEJUT qWfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772122166; x=1772726966; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OtssGMmgpsS0GlJdNGMxqurgMvcq6MJjd3dPtJY3SVc=; b=HRHJzL9iq5OFPaNVvButhub94OR9ovTvoJvrntuLHNqJqXGkaXstCI0aLMa9l1WACA txgPaG7V6jwd8F+TEyDkqzuOXjhwkSMwAsHwkBZRkAZ2016QQxBHnolfn8vSh3yH2rjh HIbMTNIM/b6At2j5bJqGxY13RCuCWlO/HQIx7od6LEMeMFiedTAi8MSsqGjHs8K3HxlQ jLcu+Mh/5eo1gDoiaY90wPkUZHG1GuT6kNFtUIwVv/5D05YNlq+/j4BKXY5GhQA5KIOv Fv/eUFmcTJUcJiRZ32Qx8gpXg2MD12Fj2PvXs2MycS14LgGT0dK6LGt2TLVjLdbaw7bf RPGg== X-Forwarded-Encrypted: i=1; AJvYcCW8qT2kqq7lQqKqFZEFBUJwe9HYcGB+U4a9ZgMMcv9hLfniy0W2w+stXGBenhiagi01K+Nn5aR/VjgoM00=@vger.kernel.org X-Gm-Message-State: AOJu0YzKR3/iXfc0sMVL2QCOb0ltY4eJy5E8Rh/L7CSnLpzuCWif+qE6 88duGbnpyPY6vxMTj7r8r3gM4B8AevZFUonABOclFiaC99PyzYQ02sPt X-Gm-Gg: ATEYQzxSD5LvFrz64u6qAWLjJmqml/06p2YZqPr1G2ZzHd/mHpGTEiXvUYGHBv+Hq5g EM6PTPHkA4NxAG8DtTUO2RCmVvjSUC/rpbWZ2aInXF4sjmgDzfIc8p988S+l/h+lTn4kWunMwRU Lf59n2jhaxMwDcBBF9Dj4RD55D9LPwAJnE+f8t0qGwdqGC6sx+SGy4K87/ClxwiM9uV9J2OJltt GxJT6mrWaIRomKuL05SGi115WZyAXoy5Pn9ivYClEw5uFp5lNuqVN3zCXUDWjqm4pO0Git8IuT/ ZE4jwBEUIuQN1NgWzdtfHjuNxhad/jDo0x+FhzpNirByi0Jot5sMO2qL1mu3QUlxd77oBC3k//I YYjTYepLXjhCx9DEcJN7IKm2u3rRQmxgGETD/2I0NlZjj7lPQJngHFmKkh1rLNGQhvgf/XbqcGA JYZpbZO0SVgjbSh99AlS/HWVwxW9dtDnz8RUjJArWJtezqLBvcva2r3R8yKK09CfQhEVO8/+B+5 yWfXggkL6/qqMa9pFGL/6M+ X-Received: by 2002:a05:690c:d8a:b0:797:ddf2:7cac with SMTP id 00721157ae682-798291548e2mr177249357b3.63.1772122166458; Thu, 26 Feb 2026 08:09:26 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876cb9f19sm10225967b3.53.2026.02.26.08.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 08:09:26 -0800 (PST) From: Ethan Tidmore To: linkinjeon@kernel.org, hyc.lee@gmail.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 2/3] ntfs: Add missing error code Date: Thu, 26 Feb 2026 10:09:05 -0600 Message-ID: <20260226160906.7175-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260226160906.7175-1-ethantidmore06@gmail.com> References: <20260226160906.7175-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If ntfs_attr_iget() fails no error code is assigned to be returned. Detected by Smatch: fs/ntfs/attrib.c:2665 ntfs_attr_add() warn: missing error code 'err' Signed-off-by: Ethan Tidmore Reviewed-by: Hyunchul Lee =20 --- fs/ntfs/attrib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c index e260540eb7c5..71ad870eceac 100644 --- a/fs/ntfs/attrib.c +++ b/fs/ntfs/attrib.c @@ -2661,6 +2661,7 @@ int ntfs_attr_add(struct ntfs_inode *ni, __le32 type, /* Open new attribute and resize it. */ attr_vi =3D ntfs_attr_iget(VFS_I(ni), type, name, name_len); if (IS_ERR(attr_vi)) { + err =3D PTR_ERR(attr_vi); ntfs_error(sb, "Failed to open just added attribute"); goto rm_attr_err_out; } --=20 2.53.0 From nobody Tue Apr 7 17:12:33 2026 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81C9A364954 for ; Thu, 26 Feb 2026 16:09:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122174; cv=none; b=mzDg0dsLdbYmMcFqT05aI88kEn5N888VirXLLJ+yKt+Ekx2mRzaQCJZdI7IBxKkkIG4wA1z4kX7gLuSLnxB0Ww78u52bBBpExLXjlfMesMyla4EBqvuLafmZRk+G7ZxOJ6AJkA6DKfzu2bmm2MIddRfV/KXTHI0ixFTYPpEGM34= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122174; c=relaxed/simple; bh=BNXRnQsioUUb9bosFAHfjcgiZPyuhfz+W0IXydZGb0g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y/vKdUVwiDCLZj/odEZGYS/XM9ZgV3eYfuvMkisOjaKrYlsPA8uTQY6Rws/gP7llRBXe0tpYkzuiwXcSG64siCdSbKpqzFd1/sVmVNcF7FMbAo4FnvYrNAD0TrmhDTkPJtFrD1aTVdnwMKBTK+oGqMhHmONOyFhV/Ced4Jb/5XM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cfBu1XsT; arc=none smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cfBu1XsT" Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-7986e538decso8729267b3.1 for ; Thu, 26 Feb 2026 08:09:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772122167; x=1772726967; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jr9OUWJlzV6KyFu2dUOpeqmh+0oHETiN+VeCYXo8ah4=; b=cfBu1XsTQkI1a008eCqXGxY3tkKfttEch8XfgjUSLaN8RqWwIFWszHDIBhHVAcMFEX ryVUiGjxrSp/2kHB698H8IAgs/skkoefYEzd3d1/K9/nnS2Z8pqCDp4ZqRqTEoFpHHf0 5OgU/iJVI7i7IinkTtnl2gIAXniZTlPRd/c5Tby697L9VsPdDBGWCHO9LwV3uVOt0sZk /u0Opluor8xrkGCh0O2F9eGR3ANL6/GkrQ/jimX63g1eCFxVjQ7BK0KIWmVR+9gI+H0p LDSFJfNK+oChvOZ5lMbVsR35tgfr1fU3OlCS0gons5+yroukFRK8EpVfCouf7/PemKs7 8v5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772122167; x=1772726967; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jr9OUWJlzV6KyFu2dUOpeqmh+0oHETiN+VeCYXo8ah4=; b=iYd0YBaR+bacTJ7s5u5+m7jTWyPSTJpEH+ex82OZnvb/LJ+aaXcykt77MB3SghRill iQ+sLYxSo8lm4yNcctd1UySXH8NpWopqDMc/xoscfW5XtOKzSM2XN4Zk1etT6X9fdzDr mPi5ob0p7NQBqNaySmKAM0GtSOBEZxOxLXQcqPX7XYzuRXxgPffxgzirAnxOYfrf8dC0 L0RAS4iXqKQqpqBakbxz2mYvjqz6Dxuc9o+4OyK3Ef0D1+mWXp7hKj5eUf2JFwpIgaQa P47Cf7n6M44FP4JawHwddHrwKuXxomDpVc+zULcH4AHD4UCMZ1PwkOTPAzidQiWcjrHM v4Gw== X-Forwarded-Encrypted: i=1; AJvYcCXmrKdjlxqwk7wTeX7cE5uVVdRyhE17B5dSFOdIjbheEKErguBdXky29weyCKcONB7c81jtVBpEZ5c0EeA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxfgotk5N7Ah4EGR8kg7hCvZOKaPE+pfT5hHEu+s77MKZAZ7vvJ 0+RO+v9OKGpnClwnu63xq9yTx7kYK2ivo413j7hFIXydKYwCVoWC8c65 X-Gm-Gg: ATEYQzwe8wDZTOzg3FbQzsGmxWTqABLyPtL1Q1hP0rZpz1g8GdNRB5OoSCfdmDstEGT EsYSLEDJkccwCHHbqnq0Q2+zk+zG5u03v3nB/2oVet4dGxQnFdZ25uplaEc3N+CD60Wd6v9HC4c HobmZSQMl1NXobsoSiK5Sitq0lS4L4aVehE7vLTzRalhnKBRY7Gz86Q/ynb0wjsaTyZhyVO8M6w nlnJvNqcYVBDV8g2lff7/GXuHNTrmkrtyyajvfSDm8bFFN0veE6mSsvZ80cb5bMOFs0UPYwSfbJ vRV+IWZC1sbSG4oFYRKmpL9lKx15Xf27LtwvLGdrEwT+LxlYsxh60/rg8kcZgytQt4pi2eEW3cH 9J7RWIPq4rieSKoVm2JB4nvBu5i5EQpNtEQwOs+qmMz3DQt9mFtQy1hixrEvoZctxmbbogGxOO0 J+/Ksby/JX21HC2ry2qcmk5tEKcrDtqJwNCuCbg42aTtyMhhv6zv/C+mHKeDLIV31HOXr+jL9Dc o7Zfua17o7bXVwzaYDiiR40 X-Received: by 2002:a05:690c:389:b0:798:270:fec0 with SMTP id 00721157ae682-7986fc9b3afmr44428927b3.5.1772122167314; Thu, 26 Feb 2026 08:09:27 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876cb9f19sm10225967b3.53.2026.02.26.08.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 08:09:26 -0800 (PST) From: Ethan Tidmore To: linkinjeon@kernel.org, hyc.lee@gmail.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 3/3] ntfs: Fix possible deadlock Date: Thu, 26 Feb 2026 10:09:06 -0600 Message-ID: <20260226160906.7175-4-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260226160906.7175-1-ethantidmore06@gmail.com> References: <20260226160906.7175-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the error path for ntfs_attr_map_whole_runlist() the lock is not released. Add release for lock. Detected by Smatch: fs/ntfs/attrib.c:5197 ntfs_non_resident_attr_collapse_range() warn: inconsistent returns '&ni->runlist.lock'. Fixes: 495e90fa33482 ("ntfs: update attrib operations") Signed-off-by: Ethan Tidmore Reviewed-by: Hyunchul Lee =20 --- fs/ntfs/attrib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c index 71ad870eceac..2af45df2aab1 100644 --- a/fs/ntfs/attrib.c +++ b/fs/ntfs/attrib.c @@ -5124,8 +5124,10 @@ int ntfs_non_resident_attr_collapse_range(struct ntf= s_inode *ni, s64 start_vcn, =20 down_write(&ni->runlist.lock); ret =3D ntfs_attr_map_whole_runlist(ni); - if (ret) + if (ret) { + up_write(&ni->runlist.lock); return ret; + } =20 len =3D min(len, end_vcn - start_vcn); for (rl =3D ni->runlist.rl, dst_cnt =3D 0; rl && rl->length; rl++) --=20 2.53.0