From nobody Tue Apr 7 12:21:37 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 041A33F0774 for ; Thu, 26 Feb 2026 15:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772119985; cv=none; b=uEO4v5M4xsAePuW+TPW4Bm1WyYI3KLDVpxPqRRgJQZCHy/e2fPRKtuONhe9cvNStW0eJWu5Q24nVAeL450Wc6dZv1iBBvs53AmUznD3CKmBtZiSunh0ZKRMfwfsoufJOV6i+ZOSJ2RGO5QBeXtxV0K72QAf86znjByibyp/n3dQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772119985; c=relaxed/simple; bh=c1SiJQ+mtrwggWTRz06IeBax2Ht6wj3Y5QVnKautFIY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oSfn+Uqa64hdQQuGdnMmFy3z1s/ih4WV1lhoCj7+30yzSZQCmEYcnlcomoQAm3KmXIgoGO46JTVuDQ5J7ceSwuoTOX38EDWnalMoIdTNVOEb0u8q8C/QqBm9pkQHzefO247OQxAE7xIPmzJdojkRgEkQ1qS7sMPegY5HuHC4VzU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AAxmhlY7; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AAxmhlY7" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c6e5998f90dso365927a12.1 for ; Thu, 26 Feb 2026 07:33:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772119983; x=1772724783; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=czT64XVAAmaM0nwz2K1ZEj7YNNi99MV6HlVNHnaACJw=; b=AAxmhlY7jWlsp1V9sBt3fEbFw/vT3lCo8V7oJ7kodinpuy1msag0ijhMtd+f8jvamw AUfUrpYL5+RhkEIRHPtn7tg5+iixu9HivhKtBPA92An3t6I3Y8E/o2HNKdxPDH2qzyi/ 5kjn6ltTxQbSwGKackbS2xL3zVdPZmxkK68009k3M3ywt20NTY2UG0aQK12lJ3nI3+eV c6/ft7/5stQpwbQuKqTAzi466FhmpZIGFIYR57lN7lEZvdUSdmsfHbT5bFoAC10UCces 1kUFcgZwT+tKP3lAe6vjwifTb6ZWiiX2I69GJgiOZM/bQS3vcRT+5CE1usEuRTIRfbBz 7WNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772119983; x=1772724783; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=czT64XVAAmaM0nwz2K1ZEj7YNNi99MV6HlVNHnaACJw=; b=WFgF1CIgYVf1b9CrBrNBFEpRaD/ld5gIlBoyRejzRj/cxoHZIyGnO5qZvbZZ57Rjxf 6G2BkXMj8wr2BQQQ61Ouhf3DWV0h63X3RrXvdcEBsycdzTFb3pKW279vlW2eXS9BPByG n9xdBo733k39fGJ7P91pJXuYhQKxrQ/+L00LcUrTkql5VfgJ0IxFxpDglCieSjqzaBsq ogYXqqNLUJUmPXUK5gOY+zpii4aEcR3Aa2eywVwzt5CUVUDhJdHMyRcgQu39RrY9uO8z IK6kLTpGoZUkdnTnDvlroG8sQINRDERF/yUFO6/gHtpa8N5LhUuHYhAmka4kt7WQv5yJ 9xgw== X-Forwarded-Encrypted: i=1; AJvYcCVnjazDCLR0a4gel9XHzwZ5OKaf/oauGFK3ad7uS8aTPq+CVXIKPxK0yjomyfJED1eIKqD2xPSwNbZJKCA=@vger.kernel.org X-Gm-Message-State: AOJu0YwbAYElFJK2zu2q8f+On+hpDnO1QTFyqfUeWZiq9eJ9Dgtrr1cP gLAe/kpiCg4twSXZrKNri+KPFWvd0+oXqrMh/emLWZ5ypa8IpNZPvBngpfGBM8pmxIM= X-Gm-Gg: ATEYQzwexqFVCfbo7eTN0GAu3T1O9PbW7hDesSSOM48muJMg0XIl3r5o94NI6QmsU9U d5hgxPdFWw/QXjFnsEb98IBmqlav/js14XPxyuS3Zxn3nKxXoCXz+QjqjESPhQpWAijLncUGpnP 20sEyVpUqyxOKXfCTdWPxBb+pYMB93HeZCflRRLeZltj8AAfaDRv6XwaqlnR6a9z87qYf1pen/A m/M1Ew3dkkTKdA0bcWyMQO7FsYii71awItod011FJ12GzYMjRXBn92K2495xeodF84fVljFIfyy 1dhb4g+v4zfkQYK6KuknCrTTjO8sZOebPT2frPU75ZQagRwSAZEZRiL/aoulDAMQ7wEBjdRCqtn 5aP01gv4x7dn3W0S7OEDrcDQ6Btd2iblQEZv4xtWBnqTqGfRxqrW1Ct89KAlbcjM/sibVIb084P IQsCDZmF/d6EVCubAgPa+u2v7IZOcR7rE= X-Received: by 2002:a17:902:d4cd:b0:2ad:9421:6136 with SMTP id d9443c01a7336-2ae0305ede6mr25763805ad.1.1772119983292; Thu, 26 Feb 2026 07:33:03 -0800 (PST) Received: from lgs.. ([223.80.110.53]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb69f996sm26706535ad.50.2026.02.26.07.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 07:33:02 -0800 (PST) From: Guangshuo Li To: Greg Kroah-Hartman , Yaxing Guo , linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v4] uio: uio_pci_generic_sva: fix double free of devm_kzalloc() memory Date: Thu, 26 Feb 2026 23:32:50 +0800 Message-ID: <20260226153250.18079-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" uio_pci_sva allocates struct uio_pci_sva_dev with devm_kzalloc() in probe(), but then calls kfree(udev) both on the probe() error path (label out_free) and again in remove(). Because devm_kzalloc() allocations are devres-managed and are freed automatically when the device is detached (including after a failing probe() and during driver unbind), the explicit kfree() can lead to a double free. If probe() fails after devm_kzalloc(), the error path frees udev and devres cleanup will free it again when the core unwinds the partially bound device. On normal driver removal, remove() frees udev and devres will free it again when the device is detached. This issue was identified by a static analysis tool I developed and confirmed by manual review. Fix by removing the manual kfree() calls and dropping the now-unused label. Fixes: 3397c3cd859a2 ("uio: Add SVA support for PCI devices via uio_pci_gen= eric_sva.c") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v4: - Add description of how the issue was found and tested. v3: - Add changelog below the --- line describing changes since v2. v2: - Reflow commit message to keep lines within 75 characters. drivers/uio/uio_pci_generic_sva.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/uio/uio_pci_generic_sva.c b/drivers/uio/uio_pci_generi= c_sva.c index 4a46acd994a8..152201047334 100644 --- a/drivers/uio/uio_pci_generic_sva.c +++ b/drivers/uio/uio_pci_generic_sva.c @@ -129,15 +129,13 @@ static int probe(struct pci_dev *pdev, const struct p= ci_device_id *id) ret =3D devm_uio_register_device(&pdev->dev, &udev->info); if (ret) { dev_err(&pdev->dev, "Failed to register uio device\n"); - goto out_free; + goto out_disable; } =20 pci_set_drvdata(pdev, udev); =20 return 0; =20 -out_free: - kfree(udev); out_disable: pci_disable_device(pdev); =20 @@ -150,7 +148,6 @@ static void remove(struct pci_dev *pdev) =20 pci_release_regions(pdev); pci_disable_device(pdev); - kfree(udev); } =20 static ssize_t pasid_show(struct device *dev, --=20 2.43.0