From nobody Thu Apr 16 17:40:03 2026 Received: from forward202a.mail.yandex.net (forward202a.mail.yandex.net [178.154.239.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CE2540F8E7; Thu, 26 Feb 2026 15:38:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.154.239.91 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772120316; cv=none; b=rGO7tR9XDHHdHdLwFAI3qe6602s5fz/TMXr7N3rltgUDgGfgubQ+pZl/0TViLX8gDi9MpnYE3B5igNZOb0EeH3HZqL3Gu2/iGteQHBeZ7Uk15PUTTu1dQ+sGCvLv9Txuk38Z7Cid9irXcWziMX2GlnQsY4FU6wnmI6C87f6gDbI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772120316; c=relaxed/simple; bh=Jc1KCw4PS7kSTbxiHStSFaR3kFALt652H8w/cv7GtBk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PuWyWz6EOG10/D3ur2wjr9JRNwd9akw9sdtdytF365aYbNpjoid7FfjZD2v4LwrKsR84aiTyomLgcDRQzEnGB7yhkukZeIsvIhCNPGBA+O3h+fdkNBn2jK50Ca+TDOHDKisMwbk/lc6F/BiZJPNoAjexL/h15Scz7rEo6947QzA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yandex.ru; spf=pass smtp.mailfrom=yandex.ru; dkim=pass (1024-bit key) header.d=yandex.ru header.i=@yandex.ru header.b=pifSszUl; arc=none smtp.client-ip=178.154.239.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yandex.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yandex.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=yandex.ru header.i=@yandex.ru header.b="pifSszUl" Received: from forward101a.mail.yandex.net (forward101a.mail.yandex.net [IPv6:2a02:6b8:c0e:500:1:45:d181:d101]) by forward202a.mail.yandex.net (Yandex) with ESMTPS id E6A57851EA; Thu, 26 Feb 2026 18:31:37 +0300 (MSK) Received: from mail-nwsmtp-smtp-production-main-95.iva.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-95.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:1ba7:0:640:dccd:0]) by forward101a.mail.yandex.net (Yandex) with ESMTPS id 9729980D13; Thu, 26 Feb 2026 18:31:29 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-95.iva.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 8Vkqhh1GMGk0-wRfDlrsE; Thu, 26 Feb 2026 18:31:28 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1772119888; bh=9u+hw7P1kZrxGYw4H4TMvbi/ck0cvcuM+YKL6lqFTQo=; h=Message-ID:Date:Cc:Subject:To:From; b=pifSszUlb2N/rZIVP+qPjlC1mTVLnGQ+aRmMCUd0EMVWv+lDjZEr8EPNi6shDDHhn AVTXYtpAvv1hL7QnGdCeD62wWo9sPP9ztWQFT2kYkBa5nUH7tWc/THp1QataVcsfs+ BBuIH0Csbof6gtSyHXiCymRbThXXJaK7riUut3FY= Authentication-Results: mail-nwsmtp-smtp-production-main-95.iva.yp-c.yandex.net; dkim=pass header.i=@yandex.ru From: Evgenii Burenchev To: stable@vger.kernel.org, Greg Kroah-Hartman Cc: Evgenii Burenchev , lingshan.zhu@kernel.org, mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] vdpa/ifcvf: handle dev_set_name() failure in ifcvf_vdpa_dev_add() Date: Thu, 26 Feb 2026 18:29:23 +0300 Message-ID: <20260226152924.38790-1-evg28bur@yandex.ru> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dev_set_name() may fail and return an error, but its return value is currently ignored and overwritten by _vdpa_register_device(). Abort device creation if dev_set_name() fails and release the device reference to avoid continuing with an improperly initialized struct device. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Evgenii Burenchev Acked-by: Jason Wang Acked-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_mai= n.c index d46c1606c97a..ab6d6ab3b3d8 100644 --- a/drivers/vdpa/ifcvf/ifcvf_main.c +++ b/drivers/vdpa/ifcvf/ifcvf_main.c @@ -734,15 +734,22 @@ static int ifcvf_vdpa_dev_add(struct vdpa_mgmt_dev *m= dev, const char *name, ret =3D dev_set_name(&vdpa_dev->dev, "%s", name); else ret =3D dev_set_name(&vdpa_dev->dev, "vdpa%u", vdpa_dev->index); + if (ret) { + IFCVF_ERR(pdev, "Failed to set device name"); + goto err; + } =20 ret =3D _vdpa_register_device(&adapter->vdpa, vf->nr_vring); if (ret) { - put_device(&adapter->vdpa.dev); IFCVF_ERR(pdev, "Failed to register to vDPA bus"); - return ret; + goto err; } =20 return 0; + +err: + put_device(&adapter->vdpa.dev); + return ret; } =20 static void ifcvf_vdpa_dev_del(struct vdpa_mgmt_dev *mdev, struct vdpa_dev= ice *dev) --=20 2.43.0