From nobody Tue Apr 7 15:30:35 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0FDB2DC34E for ; Thu, 26 Feb 2026 14:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772114939; cv=none; b=ZXrho1KiTzy21cNzxxxd3Oho/fLvOGHIQefVo/cWmBIuuDQgpuWC6DBDWQfXCb/Qhp22dv3wGt3GZO7HM1nqj098NYsosHzVUutYKjeiBCJ1vDVF1NOw/Y9tKqfYRrWMu0FZINFTeP7dh1aKb3FYFX53V3rcx2fMeYUQDqegVuE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772114939; c=relaxed/simple; bh=oBywhqwQ3NuuW7HpvW8cGpArRPBK0BosoB3SD+Jy5mE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ijj52lTbOHFUSaE8oYaK2TmvtVOYRYYEU4f4NuGncnAtfBIIfsroDwNppGjfzO53AeZZAtKBV1OOQL4CHdfCazpojOX0BssXBO5HHP29cPe2iIJ3U7M0RB5r8a1LJCCK8m4PK87EEEbWLU5pB8xUBMyLkVciRYTnfFooC2WBHqA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f8ppcmDx; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f8ppcmDx" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-483ad568d68so1519765e9.2 for ; Thu, 26 Feb 2026 06:08:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772114936; x=1772719736; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=e8CGDEkXyAlDrk2ZX9C97+DX4JOqZgHJ4c1D8odhccs=; b=f8ppcmDxhChq7CrrHf6iHNNJmMN3FjTN/lX0oi4mFZML2BC7DkUa++od+FDr5dpe/a N5xnX0cxnjVqPLkpJ8mfAHQ081tNMgGKGGdCzrRJPGbj4RekIvItlP6CbPg8xt1yD1nP QdXfCJPf/SNiepDLd7FVNI80n12jAVRQFMLocoGtgFECC8PuebsvNNux//+o1bUmqRtn BkgyLj0DjNbudwGKWq3BpVPn06B0oS3z3hxg5H53fw/RNg7XnC7SXGMkRK7JiR7u0gzP VpGwWXBdLvQ/Mr+CEK43GPi3U39W0BQr++lU1FuM2VqDoe5flbVQ15d8JkiJeCyO0OeY DfIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772114936; x=1772719736; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e8CGDEkXyAlDrk2ZX9C97+DX4JOqZgHJ4c1D8odhccs=; b=GsmpYfLlH2ZO/G+sjD8Vk5WwbzExfMvSfJ3FYJaJbKgVXAJxXmA1yKC0Bvzpr4lqRD UmC6TQWgj5Xl3uH0pDaWuOqxwzc/9qZ85bim9XGtgVQlzxFLblHc/eLqBYWjHb1Yallc cYllH/H2gInweV20Wn0/1Bcv5Fq1TxopZgo/zOJhZpbbB9xQAO31u/tIWjOqek0y9UKo G4anV+cPNO5ZFptgw+QptSa2N6vCRvN5lkOKdusWPwfl+O/AeicRm5qS+b/C6vcOIQAQ tFkezEAThnG0YxHhyPhZTYAVKSApEo66cs5RTxAjuOWOD+aVGEiUNN4busN23roCJpUw xuNA== X-Forwarded-Encrypted: i=1; AJvYcCUMoRxldxA4qvUrMGeeOupNNmqimMfbTr2RB49e7s2ri8XPeRt/DnVrN8tCMCfbiGHOTCIng+xojgMhERk=@vger.kernel.org X-Gm-Message-State: AOJu0YxB4e2Y1Y1dLWDtNgFYxoWLqL5AhGL0C6/A+ejYWOEYv5dPV3gG pZ2eYKW5KFhbm2zJ9NP+5KQKvKJFDu8zEG5LYFzrrFfOZzGRteN/Dit5 X-Gm-Gg: ATEYQzz+XGefUlY7nlK4eGK9mbi1ydrGMvm6WgaZ1+wBSOfGDY3nDY3xyOgX5OBzOio NP/SfZeuaTIzRhxbJYU4i7od2e5YxwRd03rS0TmSJRpffEfT/e/ATBDHGF9/GLVWWyfzRSIcxET zFjBkJOmb4mKit3Kl4oExUHelXsyBezt///UfJ2/7xdxIdv3den541v0Q8L1/o8vBMSxKp/cuth wuQLKAogpvC9IApL/VfcYf9L9L9cKrZ2cgRQa0B1OIh9mi5HwHTZXoMJeMKLC20qIHFMqI1uN1o cdLinauXFPtaQS347wCKXaW2q5O/VwVTU6pjYtckjhWL4CG/rOYY2upRYJomyrIbI6D7Us/jebg cs9/89VKPPclfL5mSuQACuzaLcpj7GHzSfy5KzLNUApnPFvWlo9O+M7gs/TXLvFLvl/RLAhTST3 XM8kTx6p3+c1O9dpXPhrvhvzTM/qimdFak4WYwKn/wQz5ocH+UGBDlJ2Sj6LyY4lPhPGVFZUwB3 5IK/n26ig2Hjd/NKfPuZSYuLxq6gZ74/i3p6gC43k1hgW/tjo+K X-Received: by 2002:a05:600c:450c:b0:471:ab1:18f5 with SMTP id 5b1f17b1804b1-483a963d0e4mr183011585e9.7.1772114936190; Thu, 26 Feb 2026 06:08:56 -0800 (PST) Received: from fedora ([149.3.87.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483c3b346ccsm43771845e9.2.2026.02.26.06.08.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 06:08:55 -0800 (PST) From: Giorgi Tchankvetadze To: antoniu.miclaus@analog.com Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Giorgi Tchankvetadze Subject: [PATCH v2] iio: adc: ade9000: fix wrong register in CALIBBIAS case for active power Date: Thu, 26 Feb 2026 18:07:02 +0400 Message-ID: <20260226140700.481317-3-giorgitchankvetadze1997@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The switch statement in ade9000_write_raw() attempts to match chan->address against ADE9000_REG_AWATTOS (0x00F) to dispatch the calibration offset write for active power channels. However, chan->address is set via ADE9000_ADDR_ADJUST(ADE9000_REG_AWATT, num), so after masking the phase bits, tmp holds ADE9000_REG_AWATT (0x210), which never matches 0x00F. As a result, writing IIO_CHAN_INFO_CALIBBIAS for IIO_POWER always falls through to the default case and returns -EINVAL, making active power offset calibration silently broken. Fix this by matching against ADE9000_REG_AWATT instead, which is the actual base address stored in chan->address for watt channels. Reference:ADE9000 datasheet (Rev. B), AWATTOS is the offset correction register at 0x00F (p. 44), while AWATT is the total active power register at 0x210 (p. 48). Fixes: 81de7b4619fc ("iio: adc: add ade9000 support") Signed-off-by: Giorgi Tchankvetadze --- v2: - Added Fixes tag (Andy) - Added datasheet reference (Rev. B, p. 44 and p. 48) (Andy) drivers/iio/adc/ade9000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ade9000.c b/drivers/iio/adc/ade9000.c index 5dcc26a08970..1499fb1c718a 100644 --- a/drivers/iio/adc/ade9000.c +++ b/drivers/iio/adc/ade9000.c @@ -1123,7 +1123,7 @@ static int ade9000_write_raw(struct iio_dev *indio_de= v, tmp &=3D ~ADE9000_PHASE_C_POS_BIT; =20 switch (tmp) { - case ADE9000_REG_AWATTOS: + case ADE9000_REG_AWATT: return regmap_write(st->regmap, ADE9000_ADDR_ADJUST(ADE9000_REG_AWATTOS, chan->channel), val); --=20 2.52.0