From nobody Tue Apr 7 15:26:16 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DAAD361677 for ; Thu, 26 Feb 2026 13:59:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772114368; cv=none; b=mmF94AYn4+LNw0qV9gVf6KdaOkOSbDYHqX/tOUuQ1QGWLBW0aartM4/Ue5XTNi1aiOO5WBu5vX6JA+Bq1ZB966pyojyCjFUuzLfL/Jey8tz82FIwX9faamPGxCWhJ0WcFLTgCHPwtBWyVFF+MTjztnSpsyF71182pux6tzSy4Fs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772114368; c=relaxed/simple; bh=FA8g05qWcqZtrQ6kzSuDpxdXxqN0KSUBHl3vjHncbHI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rv8DL0VgPmVp/zTDA8qXlPpMujyULyBDFzH2y4+E9YhQWYX1XZYp2olxyIMDgFuFLYTmsLy3as3z9QZ1Oc+OCz0iy6YykgGInHroP2O0Xlwmr6mgfIJ7VB1wxQOVyaN3SLwhmTFx26YhZNWvuLIKdah+qo7BpIGd/89+FyELpJ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=E7S1ztHh; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="E7S1ztHh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772114363; x=1803650363; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FA8g05qWcqZtrQ6kzSuDpxdXxqN0KSUBHl3vjHncbHI=; b=E7S1ztHhmFzchWPPTy5AHiy6Heub1b/S0mkSLSVxLCv9+hi4cOHjp8W2 Vu9qWmcDKg9NJIrRln9RXlnbqKiWHfi74S4pkjLQDfsLLOFWw3VqyP8zM LKmRriFBKtKu0RejuUnX+zOyufGaGeSFKZBtdXQ26b1FpyTNML534Gp1G mNiyB9JpNPhOQdseBazal8qKlGUJNrRlNVZVH+k98lWsdJ0wBGco0lfsy hDhL4apJbwu2eMB/wosizXiwR7++FtI9splD2qqThGFxkvVtrBlB7UGow 0ZvVIR8xxfiDvrWcc62oJcnkjCDRfUISXod7mio5p2j+A65Or3Lda9Es5 Q==; X-CSE-ConnectionGUID: SZedv5ohRmWn1Ythgw7L5Q== X-CSE-MsgGUID: QGBleITmTJq2ngvsyWwiaw== X-IronPort-AV: E=McAfee;i="6800,10657,11713"; a="60749591" X-IronPort-AV: E=Sophos;i="6.21,312,1763452800"; d="scan'208";a="60749591" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2026 05:59:22 -0800 X-CSE-ConnectionGUID: bpc5D/T/R66vMBGaJqkvCA== X-CSE-MsgGUID: znLvCAYvT5u1FdXFGMi4Dw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,312,1763452800"; d="scan'208";a="215275436" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa008.fm.intel.com with ESMTP; 26 Feb 2026 05:59:20 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id CEB3E99; Thu, 26 Feb 2026 14:59:19 +0100 (CET) From: Andy Shevchenko To: Mark Brown , Andy Shevchenko , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich Subject: [PATCH v3 1/3] regcache: Move HW readback after cache initialisation Date: Thu, 26 Feb 2026 14:57:09 +0100 Message-ID: <20260226135918.381979-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260226135918.381979-1-andriy.shevchenko@linux.intel.com> References: <20260226135918.381979-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure that cache is initialised before calling any IO using regmap, this makes sure that we won't access NULL or invalid pointers in the cache which hasn't been initialised. Signed-off-by: Andy Shevchenko --- drivers/base/regmap/regcache.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index 73cfe8120669..bde60255ddbb 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c @@ -67,6 +67,14 @@ static int regcache_hw_init(struct regmap *map, int coun= t) unsigned int reg, val; void *tmp_buf; =20 + /* + * When num_reg_defaults_raw is unset, it means there is nothing + * to read back from HW to set up defaults in the cache, so skip + * this phase without an error code returned. + */ + if (!map->num_reg_defaults_raw) + return 0; + map->num_reg_defaults =3D count; map->reg_defaults =3D kmalloc_objs(struct reg_default, count); if (!map->reg_defaults) @@ -202,14 +210,6 @@ int regcache_init(struct regmap *map, const struct reg= map_config *config) count =3D regcache_count_cacheable_registers(map); if (map->cache_bypass) return 0; - - /* Some devices such as PMICs don't have cache defaults, - * we cope with this by reading back the HW registers and - * crafting the cache defaults by hand. - */ - ret =3D regcache_hw_init(map, count); - if (ret < 0) - return ret; } =20 if (!map->max_register_is_set && map->num_reg_defaults_raw) { @@ -227,6 +227,15 @@ int regcache_init(struct regmap *map, const struct reg= map_config *config) goto err_free; } =20 + /* + * Some devices such as PMICs don't have cache defaults, + * we cope with this by reading back the HW registers and + * crafting the cache defaults by hand. + */ + ret =3D regcache_hw_init(map, count); + if (ret) + goto err_exit; + if (map->cache_ops->populate && (map->num_reg_defaults || map->reg_default_cb)) { dev_dbg(map->dev, "Populating %s cache\n", map->cache_ops->name); --=20 2.50.1 From nobody Tue Apr 7 15:26:16 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3246C3A63E4 for ; Thu, 26 Feb 2026 13:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772114369; cv=none; b=MBxpNdk9qfXm8RoGGL2wKvFlIE1+MgOfNBsFpeMUZSgRubQoGfI4gVG33MZRCSzunIVxJyT7rkuGEf5lGUHWO8hWEcYdi7RtygZse/hr4U8kbORaIhzLbiMc9n9EVdX3Eonj0GuezCJjuhWzdMqlldcK0TiA7blLT2DCkIZQKeg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772114369; c=relaxed/simple; bh=3scbGjnD9BGgCkN2tuuQjEIZEdznr/MSJfSKAXHxJxo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d5hL4TkFXk478Wl5R24PZ3Qmh/zud7R44ZtihrjZuvNySvsER7dXzILl+VyNd37dFQCXu7RHyyF/b7JWLVcQA7QRC+jZ8mBG3WaL/zpXAT5oBkvlN2awFFd3HPgeXKhPXp4QJYQWYjhBVGEs4Tszg2Ej60fV87hopoKs5w+1bak= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZH0qm2Sg; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZH0qm2Sg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772114364; x=1803650364; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3scbGjnD9BGgCkN2tuuQjEIZEdznr/MSJfSKAXHxJxo=; b=ZH0qm2Sgr/4JXfssYzNq8hZ49gCgZqI7M/hzIkb+/nf3WWNWA0waIepS bT/Yf2AQ92SEWbPJlnQQ/WFMDB7mV6k0h9NjI1lwOixZD7+BvXebh/6PD 9feeNu7MHbHa+x4TUGZA3ThicccT14GFG0UpYdWAGGi3LeAYQ2aoUlAdM HEn6R0WFoeGj/X6XoqZXYPRzz0WB+KU9TI2Ph8fCSznSo2b6ICI8XMYcT r/CTSm3UHxWzP78ljcK267HKu3nNIbgiM80PtlQy/4594jlgAgNStVFb/ ddPCgZTT06t89qHF09hGYLx9BwwphDOzPXpGSosLYzIiXJmstXiN5HD2u w==; X-CSE-ConnectionGUID: sUPJqaSUQmOlcljEH+EwPA== X-CSE-MsgGUID: ajqOdp9oTi6nT5ZWZhBS6g== X-IronPort-AV: E=McAfee;i="6800,10657,11713"; a="73044503" X-IronPort-AV: E=Sophos;i="6.21,312,1763452800"; d="scan'208";a="73044503" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2026 05:59:23 -0800 X-CSE-ConnectionGUID: yG9+9U5xQl+OC1ACnLbwjg== X-CSE-MsgGUID: 2Us88m+aSraEO/BFxi3hYg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,312,1763452800"; d="scan'208";a="214549629" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa010.fm.intel.com with ESMTP; 26 Feb 2026 05:59:21 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id D25989B; Thu, 26 Feb 2026 14:59:19 +0100 (CET) From: Andy Shevchenko To: Mark Brown , Andy Shevchenko , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich Subject: [PATCH v3 2/3] regcache: Define iterator inside for-loop and align their types Date: Thu, 26 Feb 2026 14:57:10 +0100 Message-ID: <20260226135918.381979-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260226135918.381979-1-andriy.shevchenko@linux.intel.com> References: <20260226135918.381979-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some of the iterators may be defined inside the respective for-loop reducing the scope and potential risk of their misuse. While at it, align their types based on the type of the upper or lower limits. Signed-off-by: Andy Shevchenko --- drivers/base/regmap/internal.h | 2 +- drivers/base/regmap/regcache.c | 13 ++++++------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h index 5bf993165438..c77f3a49a89e 100644 --- a/drivers/base/regmap/internal.h +++ b/drivers/base/regmap/internal.h @@ -162,7 +162,7 @@ struct regmap { bool no_sync_defaults; =20 struct reg_sequence *patch; - int patch_regs; + unsigned int patch_regs; =20 /* if set, the regmap core can sleep */ bool can_sleep; diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index bde60255ddbb..4a27fb871877 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c @@ -44,11 +44,11 @@ EXPORT_SYMBOL_GPL(regcache_sort_defaults); =20 static int regcache_count_cacheable_registers(struct regmap *map) { - int count; - int i; + unsigned int count; =20 /* calculate the size of reg_defaults */ - for (count =3D 0, i =3D 0; i < map->num_reg_defaults_raw; i++) + count =3D 0; + for (unsigned int i =3D 0; i < map->num_reg_defaults_raw; i++) if (regmap_readable(map, i * map->reg_stride) && !regmap_volatile(map, i * map->reg_stride)) count++; @@ -62,7 +62,6 @@ static int regcache_count_cacheable_registers(struct regm= ap *map) =20 static int regcache_hw_init(struct regmap *map, int count) { - int i, j; int ret; unsigned int reg, val; void *tmp_buf; @@ -103,7 +102,7 @@ static int regcache_hw_init(struct regmap *map, int cou= nt) } =20 /* fill the reg_defaults */ - for (i =3D 0, j =3D 0; i < map->num_reg_defaults_raw; i++) { + for (unsigned int i =3D 0, j =3D 0; i < map->num_reg_defaults_raw; i++) { reg =3D i * map->reg_stride; =20 if (!regmap_readable(map, reg)) @@ -849,13 +848,13 @@ static int regcache_sync_block_raw(struct regmap *map= , void *block, unsigned int block_base, unsigned int start, unsigned int end) { - unsigned int i, val; unsigned int regtmp =3D 0; unsigned int base =3D 0; const void *data =3D NULL; + unsigned int val; int ret; =20 - for (i =3D start; i < end; i++) { + for (unsigned int i =3D start; i < end; i++) { regtmp =3D block_base + (i * map->reg_stride); =20 if (!regcache_reg_present(cache_present, i) || --=20 2.50.1 From nobody Tue Apr 7 15:26:16 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F31F32ABF3 for ; Thu, 26 Feb 2026 13:59:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772114374; cv=none; b=AGPqmKEmO8zzI8uonKt6NSmW2cGPI7zY+TYl0oxwOa2aJJnR3g68FkxsMbi6OS85ENYkhT0NYo6LhXWwwCsl8dqFts/qhzOjdmkQdtJXk4NYKJDbRQAVTDJf4tFjWepiLaDM9Yq7FnnJaGiu89qSo6LIX15wtm/mXqtztCZONk8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772114374; c=relaxed/simple; bh=5pUf4Cex0OtjkD/0khprn0E7BOXzDucdy5k1hn/MaD0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ekQKKCvhYluHAlgzUlhNbRY/h98PoaoSesnno4B/pk4tr+TlUwAIko5C9FaZcAnkcfbCNlkeAoLtTc0gr/hrK9WprRlHQrno/wny8eAT6GnTfnCSk6K72NbnnZlYnPOWACprtUJWrkYfM6DUfp8YxApZS7LCQthtiaKvn2IAdUM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JuQlnQfk; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JuQlnQfk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772114368; x=1803650368; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5pUf4Cex0OtjkD/0khprn0E7BOXzDucdy5k1hn/MaD0=; b=JuQlnQfkjqSbEDjeiE3sbtSBkL4bRziRMWxkQ0SKc22LgZrIpURdYR4u Nt6dtxYtljfjXFl1xINEkPQyCS6n5gW/BFvutXPGISMIN3DKE1XjLqFZC HfvRGyp5LADCrQSYOqe4W9cqZWiKYB6gvrt1D7+vE45jXg3nwCChDYL7r C+InBb/2y6aG1Xw0mCpwGoRD+gW1VoZe8iNMGbYvgM2lVKe+0mr13ONwb h4uTZOiBRkDCzjewI9+UlS352g4si6GIg4WeXs4CufbTRt3fQW+VMR4Le BsGyxVsbGkcms9kwmuie5xMMtONqx7D8cfi95XCvxm2pezD71D0vSmkpB A==; X-CSE-ConnectionGUID: xXwP+sebScW+aaTsPdjf2g== X-CSE-MsgGUID: t1n5DKdETS2mhd9ZUzdYCw== X-IronPort-AV: E=McAfee;i="6800,10657,11713"; a="60749593" X-IronPort-AV: E=Sophos;i="6.21,312,1763452800"; d="scan'208";a="60749593" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2026 05:59:22 -0800 X-CSE-ConnectionGUID: bJYNem8vROCW+Jffg4geVA== X-CSE-MsgGUID: lj3jOVLFQbqcGY4k6nOLeQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,312,1763452800"; d="scan'208";a="215275437" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa008.fm.intel.com with ESMTP; 26 Feb 2026 05:59:20 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id D6CCB9D; Thu, 26 Feb 2026 14:59:19 +0100 (CET) From: Andy Shevchenko To: Mark Brown , Andy Shevchenko , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich Subject: [PATCH v3 3/3] regcache: Amend printf() specifiers when printing registers Date: Thu, 26 Feb 2026 14:57:11 +0100 Message-ID: <20260226135918.381979-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260226135918.381979-1-andriy.shevchenko@linux.intel.com> References: <20260226135918.381979-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In one case the 0x is provided in the formatting string, while the rest use # for that. In a couple of more cases a decimal signed value specifier is used. Amend them to use %#x when register is printed. Note, for the case, when it's related to the read/write, use %x to be in align with the similar messages in regmap core. Signed-off-by: Andy Shevchenko --- drivers/base/regmap/regcache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index 4a27fb871877..221bbeb60f53 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c @@ -120,7 +120,7 @@ static int regcache_hw_init(struct regmap *map, int cou= nt) ret =3D regmap_read(map, reg, &val); map->cache_bypass =3D cache_bypass; if (ret !=3D 0) { - dev_err(map->dev, "Failed to read %d: %d\n", + dev_err(map->dev, "Failed to read %x: %d\n", reg, ret); goto err_free; } @@ -517,7 +517,7 @@ int regcache_sync_region(struct regmap *map, unsigned i= nt min, bypass =3D map->cache_bypass; =20 name =3D map->cache_ops->name; - dev_dbg(map->dev, "Syncing %s cache from %d-%d\n", name, min, max); + dev_dbg(map->dev, "Syncing %s cache from %#x-%#x\n", name, min, max); =20 trace_regcache_sync(map, name, "start region"); =20 --=20 2.50.1