From nobody Tue Apr 7 15:26:15 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 004AC28489B for ; Thu, 26 Feb 2026 13:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772113208; cv=none; b=tj3pvRvdCTEK/QDsixu15Dik/x1Din5mUJpXR8U0rwZ1pH0X0IBepBUfj72YgC287NNt4xqFoTs4oh6miOEDOpN1n4dWYG6neJYWCOPzvbwTq0r4zuLiypx5fg5upT7TgOPBhMvloOgPz0lQdirhK/x0deJ6+Dtf0bXJ1wMhUcE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772113208; c=relaxed/simple; bh=J62PbT+KnxTsMw7VMieKbDTerOoCCuXHu60WqWgn7yk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RPbi47tLa+4ItfGaLqhEp1YJK2LRJx3/q9mY0aWs6t9/7flvItCKq9NT2ApLjpWGHDwGemTYgiNDZnaoI4vO4XWSf1IMvhyRvrJpShUHnpipRo1FNZtObQfsw3bunGQtKjFsrgDcXNZZLAl+2C1F2kzLMxSR3d8RCq4XsYsMDqI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=g4Ir3i0d; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DP95Ky5h; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="g4Ir3i0d"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DP95Ky5h" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61QAL3Jt288740 for ; Thu, 26 Feb 2026 13:40:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=Y+hnAw9byw7VsoKquyQktEK2L5U4UdglZDx 00bpdQ08=; b=g4Ir3i0djJoOBbb9zyR3vSLA/3nbLNf8IORmxV4+8cvnehH/uIz CI7o+se6iVDu3rU7W3VmWVshOd092pN9mRA6jkz9BLVad5rsDODMSNMMJz2GZmiW jSHo1tq700XdvTnBQh+IJr20fHK4IlRxnBBQwCElrFQVmLm1TbCEhva+AbLwos0G DnTNxSuYgqf4ttcJgJxyBXgtAF9iRXPMvcnhdYghhKJwbVFMa7Nt5QHs6WAXG/I+ +OGiISfhWCIrPP5/egrejvP50DU/M6l0/6nHY8uf616gUJsdMRfW0k33dbO8rzat 3lpKslCHCX+5BbUI4rijEBuhtqg+5R4f8cQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cjm8u0hbm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Feb 2026 13:40:04 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2aad6045810so8444095ad.3 for ; Thu, 26 Feb 2026 05:40:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772113203; x=1772718003; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Y+hnAw9byw7VsoKquyQktEK2L5U4UdglZDx00bpdQ08=; b=DP95Ky5hpWkr+pbYEnmA5ptax2u2Xj186z4g2G9IAdGZz6wMbHZF8wQkwo1Vgbzd1e tXmWC70r8Qn4NJ3b5KPM6gRHdoqMhnyndL1NsBEzuD3mxdAeGR2QqIg9FqcFiQ8k3ilG 5HQbSkNUjZ5yAzQ2Yw18QTCzVxfXiDc6MWHTOc9Ri+/I0XPqQwN6YYMBJEseyq7inJAQ ztpzVZFjpT/+DGYRbtrLUxB0biFGZcq6EmNz9bG61SRXyvX1sT92086H8jTlTGiFjTzT 8/xNP18/UgHfElaf59g7vwn0ormuwr2ID2rEAumdryu0Gaqw4A79cmG0HJcDQqWT2e2n 3Jrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772113203; x=1772718003; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y+hnAw9byw7VsoKquyQktEK2L5U4UdglZDx00bpdQ08=; b=bZuVAU3ATyAXgnogObrtGSoAih2R937u1QKm+gwfmN1yWacRW2KE54SMhJsyRBrDrf FVzMQ05TFE4Z3ItLVqogvS6oc3NZO22MU6ynDcCBcEmAojzY1MdlTn+OwFvIUNM96+4I 1keaemZBxP1rhI9hDd42dnIgQrOjkPoxNVpn+ThqalrdmYo7hYSreA2MKDMQ6nX6tq6e Nz5NfWNk4mHa5WOB8Ot7x08zVhrkBYlyZRQc4IMN3XUlKpFnpYWrd+A6CEfyHQjdaWYe OIZn+R4QOxncUxmBmdkfA6cFr11YiBCLuwJioxyM/rdLXFsUz+kl5qEMnb9Q2ojzFjSm eIpw== X-Forwarded-Encrypted: i=1; AJvYcCUYhObffwNtgGykYhbBtWgz3KGJqrNapVLnAl4/72FV0LLWKBFfpqwSMdYdmX2OL85aTpBBJMW2ckZgSJY=@vger.kernel.org X-Gm-Message-State: AOJu0YwofOSElDy6SWI6c9bHcIaTEnw7xJXQqIOjQwZUa1GnbAVnF7vZ 3cPJL3Gj88HoI4OWx2Im4+7/Qbs0SLZjJJ7p46mS4r4XqA39Q0NSYGFPkhkmsYi7qJu9SHZ1eT2 m+NsU2JV1B3uJMwdKO5y82FR9w5KOosqpNp9qaiIx0drdaXY/USwjOzy8SbfVbhkI+kzTVmIEnp o= X-Gm-Gg: ATEYQzznTXB1niVZJ6DfE7C2zG17XxYGt+G1MpNFAHNjMeEnn52EnrIRpiV+3A0AbJQ hg8TbIFnTHaWxDOo4XuIHKrlylmJVWuW0qA94MFEKhHhsFRf2vw0/OIlF2D1qWKzxIYEHY2dyy8 RHU+aMF4+L/v+te8vOjEQ/JwFCcAzQSEZNbZ6uCLLNSxdXkzZFWthTWrV5W+9z27fXsKFIZ9ARV aC3jG3wkjuaTupcXptd31l90l5fYvQz79IpK5wtYgdbN3C9dgOsP7kWc+qvugz7VMNrgWvwhusK 0CYkRsBFZKp+btnxbeKf9M6Ow0jowqaDU0uSPymsfgKcTBu5JwgABDPAaNzJKB+DqUT+1t5YQ0R 3XFDYH1jIIb8= X-Received: by 2002:a17:902:f608:b0:2a8:f8bd:bb72 with SMTP id d9443c01a7336-2ae035d05b1mr23395395ad.50.1772113203407; Thu, 26 Feb 2026 05:40:03 -0800 (PST) X-Received: by 2002:a17:902:f608:b0:2a8:f8bd:bb72 with SMTP id d9443c01a7336-2ae035d05b1mr23394975ad.50.1772113202820; Thu, 26 Feb 2026 05:40:02 -0800 (PST) Received: from work ([2401:4900:8fe5:3076:521d:50c0:367d:1d7b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb6a03fbsm34960915ad.43.2026.02.26.05.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 05:40:02 -0800 (PST) From: Manivannan Sadhasivam X-Google-Original-From: Manivannan Sadhasivam To: jingoohan1@gmail.com, mani@kernel.org, lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Senchuan Zhang Subject: [PATCH] PCI: dwc: Perform cleanup in the error path of dw_pcie_resume_noirq() Date: Thu, 26 Feb 2026 19:09:51 +0530 Message-ID: <20260226133951.296743-1-mani@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI2MDEyNCBTYWx0ZWRfXwVaAJx97v6Pb 5yzkL3puJPf5WZWalJawVDpDMh0s9KIlR+F6kQlCvkhnS5wzuadwpDLlyCwJf371ndIDwcTXhnB MnWSeeS97B0X4Zcj51PGLcCX87gr3SaW6URGXCB03Y/LnTgPhAsnRhq8o5zpqBE+SvT2Xmh38i+ LTynWKA2oG+NBxqo8XWVfAu1VJVreqZFVUlO82Rdbj2364Xah0EjDQHHqKjkAJAzCTnqfi3RN4v F+ra0PpESyhPgk75UiZ2ej7serRpFkkAh6IOkxqMawrIDYA/PrJ77NEL6XRd1JBfLhlZeZ2qF34 PYczHOnkyt1IE8QD5K2tZvKBjW7O+KE+7oz8dHuIjQnT1ozbhCZnrMcM4JPBWwL88c8wYebfyTA OWkJg6wiVNuBUbZ70DZ4kh7KLzhxRFDTt1GBgamhEEjbmNG3Lexe6OzwmbpLbmOo4zOIfpTVdLP MTlu3Bn070/97WbhcKg== X-Authority-Analysis: v=2.4 cv=O780fR9W c=1 sm=1 tr=0 ts=69a04d34 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xqWC_Br6kY4A:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=h4SL0BZ7AAAA:8 a=EUspDBNiAAAA:8 a=K8sXToTmQG9RiKs_eVkA:9 a=uG9DUKGECoFWVXl0Dc02:22 a=Cfupvnr7wbb3QRzVG_cV:22 X-Proofpoint-ORIG-GUID: b6DLy1uXWXajkg_DWV7fF0hW6zbotwiM X-Proofpoint-GUID: b6DLy1uXWXajkg_DWV7fF0hW6zbotwiM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_04,2026-02-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602260124 Content-Type: text/plain; charset="utf-8" From: Manivannan Sadhasivam If the dw_pcie_resume_noirq() API fails, it just returns the errno without doing cleanup in the error path, leading to resource leak. So perform cleanup in the error path. Fixes: 4774faf854f5 ("PCI: dwc: Implement generic suspend/resume functional= ity") Reported-by: Senchuan Zhang Closes: https://lore.kernel.org/linux-pci/78296255.3869.19c8eb694d6.Coremai= l.zhangsenchuan@eswincomputing.com Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-designware-host.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index ba183fc3e77c..a74339982c24 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -1304,15 +1304,24 @@ int dw_pcie_resume_noirq(struct dw_pcie *pci) =20 ret =3D dw_pcie_start_link(pci); if (ret) - return ret; + goto err_deinit; =20 ret =3D dw_pcie_wait_for_link(pci); - if (ret) - return ret; + if (ret =3D=3D -ETIMEDOUT) + goto err_stop_link; =20 if (pci->pp.ops->post_init) pci->pp.ops->post_init(&pci->pp); =20 + return 0; + +err_stop_link: + dw_pcie_stop_link(pci); + +err_deinit: + if (pci->pp.ops->deinit) + pci->pp.ops->deinit(&pci->pp); + return ret; } EXPORT_SYMBOL_GPL(dw_pcie_resume_noirq); --=20 2.51.0