From nobody Tue Apr 7 15:29:13 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6126F279DC3 for ; Thu, 26 Feb 2026 13:38:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772113100; cv=none; b=kF/pwyDcwvAOXZa3G0zaUzehOkZi2VSUtjylIe0pcouhNbonkCzawznbPp6XAJfWz0eNSLCIoc1gIHQd/P4t/Sje8wKllVuugaXbdoC5iqZ+aEPAJdaE1eD3sxei6xxXRIgnGdYByVYTKON1g/7+i0EKiwx3l8rKzntbAgr8pGc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772113100; c=relaxed/simple; bh=wVxNffTo0MyurTujHOZd8sjHwapMrj3UcnLfWc6pU/Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BMjkeIb8ZZvi+YNMZEeU3y+Gc60ssbGsR9g33G+j5amTJh0zelFrTzOVHNOX7rjtWAsMfsTIafp5/mL3XXCXkeHiK8BetnuUBvp/ocrbCnqdgAne7ihg74eo/L0+bjIX1/R9duSGPG0ovP5upSsSk9+H8dpZPmbZIm+DlqeG4Zc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c7GjhCWI; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c7GjhCWI" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43985ddb926so62928f8f.1 for ; Thu, 26 Feb 2026 05:38:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772113096; x=1772717896; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=r5DnFv96R8qo/DzwUZdYVIzEVryNz44N4oswd6WMEXo=; b=c7GjhCWIw9ekr/siomlVDvr7/VKyxwROpHg5HAyIzjfqYsZ6E12VTIWttGVeQKbATT AQtvblpB4GLZX5y3tDM3T6uNiP9JYncrhXPArxAMp7PyIjeFA8slprel+WR7zcco++jp 6FGTUhucGI36CIZIAOJHjF+CEQR1qzR8ViBFxatKCdzFnMa0KwvF6STKf5FZx7SVBYfX E0oDmPJmFsc4SGlb1RMzzG/s9/VS6rPSfB30KbVnxw5NqwiVenUbTl4knuKShg9Uvyux l0S0mUPsefMz+CHG+HjMcLVRlwnxMCHtupjvsSo+/VaN1CGlwZzk0YlVrzg//hPSEOFE q2HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772113096; x=1772717896; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r5DnFv96R8qo/DzwUZdYVIzEVryNz44N4oswd6WMEXo=; b=JV+/oPzT1WpV/VP53B7u8ycpy3I9/5g4Cmh8ccXFRkUrGIo2YMDeIxGtdkfWQ3xNNq EalwEChAPvVTjKZs8/jZD279I7b9LIB92QdfrRx+jMrt1WTET3LGImWesYI+78o/FNLA JYUAbx9Gz1IEUdyZbSKS6q+bP1dGzZHNQLEu2lucU9uLs+9YXSkDf4JqGFTEoaSzsaRd NKK329Jp6D90XrumFOkjwg44y9pt1vBxuW0CTJDEKvVX/4eAwbrOGTBSJ+JC8Am/444o 8ihsMs9uGp//M4msIB+b8xCau31jGoNg+0G5R0EDTNp8XPXklfg2tiGYNwilfDfHz5CE jmlw== X-Forwarded-Encrypted: i=1; AJvYcCWWeH5z4qZaCdysBT3uV3g7ebYjIua1rtIR5imTflJ5Ynf1rubzywPETZB2menzdwzH0FufBiDYp11Ug7g=@vger.kernel.org X-Gm-Message-State: AOJu0YzhTEOFA4B2I8u3epzOFy5eVUUHFNK1IYccACDOrOJnNZUCOsMc VjZzPghrxBWy6PginZQBAiZMdXSGEeGuS91r2sob69OW3CaDv9rs838W X-Gm-Gg: ATEYQzwCgXfi1iUsWN8WcWsx/IZMLNANGPpHU0OLLad/uFJKLDxs1AMUDVeS+EXjxpK j5Luhhvb+P11wAYhMOeTvRsPABhuySQ3mtCaDYqlJG4Kf9kxlt0Lmf5nEMo5w2tZcask4hlzWiq SyEmNbtLEOV3r8bF2tTNS8UZiC076/qdeEX0USO8P619HuHa09mm7kWkaoi5TnO1txPykFYFxwo OnCK6S3ZsJyQTXhthsr0yzsgCI+EgegQ6tnfw5Cmmwml/6hMnm8FCvnSl8m+h5GdBlPpVrucw2H Ca8zuC7O/Wiz7nZhsVNaUn26SUdG7k9HKESJY4w24N50VlolH+8Rqte7zKSSq7gPKaXJDB2p5PE /meQNTc2zhqy2wb7OJRO931W94nPWQr9+yjGBs/0OqFfsQYO9pPEsHEF3DLoifR9+TooWpegccd mVtij3WOEkHCWwRvrRIzbsEdlZ9rAfwE2KIjAXmn9NdtSvlX2zesdN7ASnb2UsV5tI6xqY8UgbS rT1FFiEClYbbD9zYARc2tEocUB7yKPwF1/OER5VDIMvgA2D3bw8 X-Received: by 2002:a05:6000:3109:b0:42b:2deb:829 with SMTP id ffacd0b85a97d-4396f194113mr19214226f8f.3.1772113096294; Thu, 26 Feb 2026 05:38:16 -0800 (PST) Received: from fedora ([149.3.87.76]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43986aa2f84sm19235652f8f.7.2026.02.26.05.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 05:38:15 -0800 (PST) From: Giorgi Tchankvetadze To: antoniu.miclaus@analog.com Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Giorgi Tchankvetadze Subject: [PATCH] iio: adc: ade9000: fix wrong register in CALIBBIAS case Date: Thu, 26 Feb 2026 17:37:42 +0400 Message-ID: <20260226133741.437403-2-giorgitchankvetadze1997@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The switch statement in ade9000_write_raw() attempts to match chan->address against ADE9000_REG_AWATTOS (0x00F) to dispatch the calibration offset write for active power channels. However, chan->address is set via ADE9000_ADDR_ADJUST(ADE9000_REG_AWATT, num), so after masking the phase bits, tmp holds ADE9000_REG_AWATT (0x210), which never matches 0x00F. As a result, writing IIO_CHAN_INFO_CALIBBIAS for IIO_POWER always falls through to the default case and returns -EINVAL, making active power offset calibration silently broken. Fix this by matching against ADE9000_REG_AWATT instead, which is the actual base address stored in chan->address for watt channels. Signed-off-by: Giorgi Tchankvetadze --- drivers/iio/adc/ade9000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ade9000.c b/drivers/iio/adc/ade9000.c index 5dcc26a08970..1499fb1c718a 100644 --- a/drivers/iio/adc/ade9000.c +++ b/drivers/iio/adc/ade9000.c @@ -1123,7 +1123,7 @@ static int ade9000_write_raw(struct iio_dev *indio_de= v, tmp &=3D ~ADE9000_PHASE_C_POS_BIT; =20 switch (tmp) { - case ADE9000_REG_AWATTOS: + case ADE9000_REG_AWATT: return regmap_write(st->regmap, ADE9000_ADDR_ADJUST(ADE9000_REG_AWATTOS, chan->channel), val); --=20 2.52.0