From nobody Tue Apr 7 15:26:15 2026 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2D56306D2A for ; Thu, 26 Feb 2026 13:03:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772111027; cv=none; b=pNJEQl6iSpF/W3W5Kl5VzH0tH5a1yTdiUtfCUFyDOV1xa1E4zf8+cfviWhhQU2gdRtstOoL/A2fcb9NXbbhv7hGLr2h5E+CUHWUF57lGhJEYrQWTnXndGJT+2ki34Cv3IqmXnrz19MpjGzjKg7EyYhOd+1ciiYWnbtyUxH/i158= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772111027; c=relaxed/simple; bh=CljBitToiiCsHEC8o0VoSQk0Hgcy8MtRTvJbXd0B90o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=p+lUDoDmv793M+i4PhDEuWG/ybkjDmDC0LBn2K+NeyomRlQFcJo7R76yXrkth1o1demE1B1yalRykMvelRGWC8IIWcwiNgJd8Qgei5mncOjB8Y+qUi5kCcqT++3bRXKI7UKCldJbX6CLgNhMmNBIA2wbYU1TULBYXODm5JB1+mE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YAYIA3ld; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YAYIA3ld" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-483a233819aso8922765e9.3 for ; Thu, 26 Feb 2026 05:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772111024; x=1772715824; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=P+k9slBbXIMT8raqXAmbjQVMB6j8pAmCCht+k7ff844=; b=YAYIA3ldS53frva8A0sEs1dhFSMlqsRjGZZGQcy7QrKdnWNlNLtQXUhThmE/VNtLXP x3VrpMk8okwJR81HJYE6D4Ut7YUxeMd4moogXwbL8ZsUJQaGg7WijhGVPT/hgkKJOf+L tOAu560vfX/rFit3Wn04mOl6UA8LlidbwZS4bPQkuz7Gltkdn+erz6RyjnH4nn2rTUWe D0oBOxKHe/k8LhmCwdvfOpMg8tsZW9M7BnlxFFs8vymscAkjsuF6GIm08Us4rHzF3zfK FXmtPPy0STs9P1Wi59CwkXFWztQhS1ervpVHcsPmS16GPyAFSrcUY+f31Mlf0R+eba0N avSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772111024; x=1772715824; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P+k9slBbXIMT8raqXAmbjQVMB6j8pAmCCht+k7ff844=; b=A5J7s2hYMFLySZ2bDQ+ZxM98aJqV/0DMoebdJ6DxAeNOD5BAxGjAp3yyofcUCdvBjA p8Ir5UAmw64V0XJ5ll7aXtJPFtwcu9csnKx51UD0YFqT1V+AtelWBUHosuL7t0gYFyK6 yMZiIchQcSK3tT9onVxp/McXK+yyPwc05UpPPvaxjucOxctTHewWHZJ7Y45K3U0Sb6WH PLSCfCeFwpfM18kQhnRmtk7cBnoQNwSwfH5NhWF3o4BWewdnTbiMeU5C8mjtqhu8IZ8b 89FSS+MUIZp8nHqz+/aJARbyYARzJBTzU90wXGXBldf4sYq4FXnYwWS3HQKzXZiDbFZB WcTQ== X-Forwarded-Encrypted: i=1; AJvYcCXO3Qf8ismM093OgTOZxgGt0zHuIenhkw/TFw9uSLVAtO7yJv1JSYYX9lSrFZWulzjpU9ZDGuHedVBLCP8=@vger.kernel.org X-Gm-Message-State: AOJu0YwE05wD2UPY3IgzoSPYynlxs0AZNrsJ9YUxXLVdp99C6adoHCY+ VwtvumYZpjzSgwfmfJwxC89TY/EI8MjLCII7D6x3nN4rEBlYfRuKhYvW5F1GIqnmCcI= X-Gm-Gg: ATEYQzxcqnYj5ewb4YIo3UfajAsaVDXevsL2y5yQjHcjm1kgJWKZQR9jREHtAR+f+1+ FbiC7l4dkPQM30tTXclLH47rTxeLvJnBRYMEVwYn0gvjKgX/PYdsAwjyf7c/AGOx3kv9Xvg+Gp2 DDH9ySWBqVR3UmaWjUjrUNpNMttCIpDt6FDTW37W9xFHpxzC9YuMZUNEROeOFRi4B5khtMzkENu /2JUYGS0hLUe+7IuVcjcTHK0ngmAKYocPr55kXu+lKWAzIwuJTOYbKLFyEw3lMh0z8QXXeHU2Cs d4Q0c4S0JruODqpSAHwLAsKa4Vj3MuF8BQRKI0z79wXaeFwXQJYfUjZCskmnIEf7vTmPaKVAbhH eFs+zMRPpp6B7aNjOHdfSdb/Pb7X80dVtcnZLv5PLxEmv7DzuxY5rQcQB5KxoW9sOX4v7Y1wXZk EMR3CZBvMJttmO80uTh2o5fot+5h9tbU4IYK5SFQPP X-Received: by 2002:a05:600c:3e8e:b0:47d:18b0:bb9a with SMTP id 5b1f17b1804b1-483c3df7207mr32452085e9.33.1772111024311; Thu, 26 Feb 2026 05:03:44 -0800 (PST) Received: from DESKTOP-BTQF5RC.localdomain ([85.110.79.247]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfccb9f9sm36679485e9.23.2026.02.26.05.03.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 05:03:43 -0800 (PST) From: =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= Subject: [PATCH v2] staging: rtl8723bs: refactor halbtc8723b1ant_CoexTableWithType() to remove duplication Date: Thu, 26 Feb 2026 16:02:53 +0300 Message-ID: <20260226130253.2145-1-b9788213@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Replace the verbose switch-case block with a constant 2D array lookup. This makes the function much more concise and easier to read without changing the underlying behavior. Signed-off-by: Bera Y=C3=BCzl=C3=BC --- V2: Removed '-1 < type' control V2: Wrapped line correctly V1 link: https://lore.kernel.org/linux-staging/aYiMi-X5r4aUEC32@BERA.locald= omain/ .../staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 58 +++++-------------- 1 file changed, 14 insertions(+), 44 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/stag= ing/rtl8723bs/hal/HalBtc8723b1Ant.c index 1af101ba9..b3e34f97c 100644 --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c @@ -684,52 +684,22 @@ static void halbtc8723b1ant_CoexTableWithType( struct btc_coexist *pBtCoexist, bool bForceExec, u8 type ) { + static const u32 table[8][2] =3D { + {0x55555555, 0x55555555}, + {0x55555555, 0x5a5a5a5a}, + {0x5a5a5a5a, 0x5a5a5a5a}, + {0xaaaa5555, 0xaaaa5a5a}, + {0x55555555, 0xaaaa5a5a}, + {0x5a5a5a5a, 0xaaaa5a5a}, + {0x55555555, 0xaaaaaaaa}, + {0xaaaaaaaa, 0xaaaaaaaa} + }; + pCoexSta->nCoexTableType =3D type; =20 - switch (type) { - case 0: - halbtc8723b1ant_CoexTable( - pBtCoexist, bForceExec, 0x55555555, 0x55555555, 0xffffff, 0x3 - ); - break; - case 1: - halbtc8723b1ant_CoexTable( - pBtCoexist, bForceExec, 0x55555555, 0x5a5a5a5a, 0xffffff, 0x3 - ); - break; - case 2: - halbtc8723b1ant_CoexTable( - pBtCoexist, bForceExec, 0x5a5a5a5a, 0x5a5a5a5a, 0xffffff, 0x3 - ); - break; - case 3: - halbtc8723b1ant_CoexTable( - pBtCoexist, bForceExec, 0xaaaa5555, 0xaaaa5a5a, 0xffffff, 0x3 - ); - break; - case 4: - halbtc8723b1ant_CoexTable( - pBtCoexist, bForceExec, 0x55555555, 0xaaaa5a5a, 0xffffff, 0x3 - ); - break; - case 5: - halbtc8723b1ant_CoexTable( - pBtCoexist, bForceExec, 0x5a5a5a5a, 0xaaaa5a5a, 0xffffff, 0x3 - ); - break; - case 6: - halbtc8723b1ant_CoexTable( - pBtCoexist, bForceExec, 0x55555555, 0xaaaaaaaa, 0xffffff, 0x3 - ); - break; - case 7: - halbtc8723b1ant_CoexTable( - pBtCoexist, bForceExec, 0xaaaaaaaa, 0xaaaaaaaa, 0xffffff, 0x3 - ); - break; - default: - break; - } + if (type < 8) + halbtc8723b1ant_CoexTable(pBtCoexist, bForceExec, table[type][0], + table[type][1], 0xffffff, 0x3); } =20 static void halbtc8723b1ant_SetFwIgnoreWlanAct( --=20 2.43.0