From nobody Tue Apr 7 17:12:24 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73C0F2DA76F for ; Thu, 26 Feb 2026 12:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772110446; cv=none; b=DgqSbSKSNEl//RGkzNLy2Aly9lUw+h9L7HVMEMgRNr+gR5JZiR7wv1t8IqMYX6V/P81UKwfmKBCyGB2OXNVug7abGRKIIV3lezaf3/w3C60Tq7zLOChD5gmOYvol1/ClM72NpE9QwfvI6d0xASLs8OW9jitn1pLNsP3nxMJ1aQ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772110446; c=relaxed/simple; bh=gjny3v/eTWHbeutrMbxDNE40G5kG1Ylj5usbZJzU9HE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r9PpB9nQvuf81gbugH2swxYydmIihgFiam5lHXbHo/I+azYf6itdZhErX3QbM7stBKVG1EfHj5kQB63tD6Z0zp4qp6pOTNtGwPOg/PgClggAHE/sMRvX6tszCSZpSIvdgaQ3DNm04QlCrRFW/tFL24nqbMGDkEjW/1Jpa3WDW8U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jKBpYqkv; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jKBpYqkv" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c70ea5e9e9dso317424a12.1 for ; Thu, 26 Feb 2026 04:54:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772110445; x=1772715245; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OUrXcfq9vgrgpVWA1902DBETXrF91GneB4Umctz9Jao=; b=jKBpYqkvvDZ43qLCn2J9H4npJeUPeMOS9kff2arjTHxORA+TyDvzDTmJKgUR9vSPRM 4kxaXdZRt3EIzDhYrrkDN8izIYcRg0G+M87P/2NZhLN4HFEXjD4M9irA2L2cUoA35++P 7qNvnTGAlRIC2rNm+CsDZtNky5I/iYV6trVfRW+MW607IhCbZxifrp5tfhTd7F0v9kS6 a5V7/hXG9DxaahZ/9s62ioznhaRzRr9dWCSGek4iCBsT4rAmPDeiz1xKg3jXhE3wtQGd pRffVY3Gbg7snti1KKLL8R5lHANi74c95kRZJ9+x10+VoYXeL31TrGPmJw/QCRE/An4Q IIfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772110445; x=1772715245; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OUrXcfq9vgrgpVWA1902DBETXrF91GneB4Umctz9Jao=; b=g/m6hHpJH0Jxw02Xj34lgprfD6fV+aNxf5dIYIqfdubK1v+Dpd9sAlulmE32ve+ExS Ctjw09+jjox1EXpiQl66MZi8q926/Z7zaqH1fx4+gdwVDLH71lr2mDUs6jlL+ryIRLSJ 2cDWvJ4iOq/EqCJ8TTIqXPLuYw2FEshF2MXenKvf080+19fsFjNWofnZAe0bWcaGd0mj 8LVhc8KQDTTLmLjobZkwa+BaNtfOTouu+sbOf1bkQU4BTb/DGB45HCR/nqjlYOwr55pn F+fh3xHc62Jlx4MQ7bEtmOhl9sboBGgfM9p1E0HSqRpZC1tYsb5QdM7QaKzFJvCIvdiF +7Aw== X-Forwarded-Encrypted: i=1; AJvYcCWIE4by2V+sAeDZc+1I3fCLnyxzrbBqynd43PCQWkE+ez681ibujb4Q/bz0HeAj/u8Y2cC3BcJa7RTip8M=@vger.kernel.org X-Gm-Message-State: AOJu0YwLR4ZtoRFpMUD++aWqgeB4vfEp4gj5kMCuUPwyXchAAh9F7Aye oQn4WNVJKEonlLJ8n7Ja4nj+atQsaQjhA7zLZlvhtg6f9eK+sqRuBzSB X-Gm-Gg: ATEYQzxK/MG0qNTkJiY0lRxRhvf4tK1vLE71bInAIZxjBF7e0xcslX7SUirlbL7HH3x TOHSyqplu6fs3CgMb/pgLLOv3DMTopwWbYOPVrwoPZJQgk1Emd+Ajylswut18iCuoPKMPoZCIx2 SCjNYEVv/qUY5VsdZdLMz8p0lqwoLQ2WdN1f9QDhMezAHYrMRJ+wzB57cj7Jm9KZeQ0Wco05MVC QFO7743jv5lAUJ6oKvNGTzdkuKOvwKivF5R4R4IjV1O+avenuzDsAHkmBTOlZ7nijVusD6YJswE C8O6b+y8XqwQ8ubE6RMVUYLcWSV/7BLkA41lGHhZ2si7Gi3Zr8mq8EFjBzwjcgiPEckEef0mzE5 MLrxtUpu1pYNQMUXh1stwriEyzCXTzrKITKf2uPI70BjHjLFGOMtH5LhoBkaSj3NwobvDk1DmZt ET8XjQFUlhpgyTWiI4zxNWj0B7/Ho= X-Received: by 2002:a17:903:19eb:b0:2ad:99bb:3129 with SMTP id d9443c01a7336-2ade9a9fa34mr42879505ad.50.1772110444926; Thu, 26 Feb 2026 04:54:04 -0800 (PST) Received: from fedora ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb705b53sm25276715ad.92.2026.02.26.04.53.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 04:54:04 -0800 (PST) From: Hangbin Liu To: netdev@vger.kernel.org Cc: Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Nikolay Aleksandrov , Mahesh Bandewar , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Hangbin Liu Subject: [PATCHv3 net 3/3] selftests: bonding: add mux and churn state testing Date: Thu, 26 Feb 2026 12:53:30 +0000 Message-ID: <20260226125331.28147-4-liuhangbin@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260226125331.28147-1-liuhangbin@gmail.com> References: <20260226125331.28147-1-liuhangbin@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the current LACP priority test to LACP ad_select testing, and extend it to include validation of the actor state machine and churn state logic. The updated tests verify that both the mux state machine and the churn state machine behave correctly under aggregator selection and failover scenarios. Signed-off-by: Hangbin Liu --- .../selftests/drivers/net/bonding/Makefile | 2 +- ...nd_lacp_prio.sh =3D> bond_lacp_ad_select.sh} | 73 +++++++++++++++++++ 2 files changed, 74 insertions(+), 1 deletion(-) rename tools/testing/selftests/drivers/net/bonding/{bond_lacp_prio.sh =3D>= bond_lacp_ad_select.sh} (64%) diff --git a/tools/testing/selftests/drivers/net/bonding/Makefile b/tools/t= esting/selftests/drivers/net/bonding/Makefile index 6c5c60adb5e8..e7bddfbf0f7a 100644 --- a/tools/testing/selftests/drivers/net/bonding/Makefile +++ b/tools/testing/selftests/drivers/net/bonding/Makefile @@ -7,7 +7,7 @@ TEST_PROGS :=3D \ bond-eth-type-change.sh \ bond-lladdr-target.sh \ bond_ipsec_offload.sh \ - bond_lacp_prio.sh \ + bond_lacp_ad_select.sh \ bond_macvlan_ipvlan.sh \ bond_options.sh \ bond_passive_lacp.sh \ diff --git a/tools/testing/selftests/drivers/net/bonding/bond_lacp_prio.sh = b/tools/testing/selftests/drivers/net/bonding/bond_lacp_ad_select.sh similarity index 64% rename from tools/testing/selftests/drivers/net/bonding/bond_lacp_prio.sh rename to tools/testing/selftests/drivers/net/bonding/bond_lacp_ad_select.sh index a483d505c6a8..9f0b3de4f55c 100755 --- a/tools/testing/selftests/drivers/net/bonding/bond_lacp_prio.sh +++ b/tools/testing/selftests/drivers/net/bonding/bond_lacp_ad_select.sh @@ -89,6 +89,65 @@ test_agg_reselect() RET=3D1 } =20 +is_distributing() +{ + ip -j -n "$c_ns" -d link show "$1" \ + | jq -e '.[].linkinfo.info_slave_data.ad_actor_oper_port_state_str | ind= ex("distributing")' > /dev/null +} + +get_churn_state() +{ + local slave=3D$1 + # shellcheck disable=3DSC2016 + ip netns exec "$c_ns" awk -v s=3D"$slave" ' + $0 ~ "Slave Interface: " s {found=3D1} + found && /Actor Churn State:/ { print $4; exit } + ' /proc/net/bonding/bond0 +} + +check_slave_state() +{ + local state=3D$1 + local slave_0=3D$2 + local slave_1=3D$3 + local churn_state + RET=3D0 + + s0_agg_id=3D$(cmd_jq "ip -n ${c_ns} -d -j link show $slave_0" \ + ".[].linkinfo.info_slave_data.ad_aggregator_id") + s1_agg_id=3D$(cmd_jq "ip -n ${c_ns} -d -j link show $slave_1" \ + ".[].linkinfo.info_slave_data.ad_aggregator_id") + if [ "${s0_agg_id}" -ne "${s1_agg_id}" ]; then + log_info "$state: $slave_0 $slave_1 agg ids are different" + RET=3D1 + fi + + for s in "$slave_0" "$slave_1"; do + churn_state=3D$(get_churn_state "$s") + if [ "$state" =3D "active" ]; then + if ! is_distributing "$s"; then + log_info "$state: $s is not in distributing state" + RET=3D1 + fi + if [ "$churn_state" !=3D "none" ]; then + log_info "$state: $s churn state $churn_state" + RET=3D1 + fi + else + # Backup state, should be in churned and not distributing + if is_distributing "$s"; then + log_info "$state: $s is in distributing state" + RET=3D1 + fi + if [ "$churn_state" !=3D "churned" ]; then + log_info "$state: $s churn state $churn_state" + # shellcheck disable=3DSC2034 + RET=3D1 + fi + fi + done +} + trap cleanup_all_ns EXIT setup_ns c_ns s_ns b_ns setup_links @@ -98,11 +157,25 @@ log_test "bond 802.3ad" "actor_port_prio setting" =20 test_agg_reselect eth0 log_test "bond 802.3ad" "actor_port_prio select" +# sleep for a while to make sure the mux state machine has completed. +sleep 10 +check_slave_state active eth0 eth1 +log_test "bond 802.3ad" "active state/churn checking" +# wait for churn timer expired, need a bit longer as we restart eth1 +sleep 55 +check_slave_state backup eth2 eth3 +log_test "bond 802.3ad" "backup state/churn checking" =20 # Change the actor port prio and re-test ip -n "${c_ns}" link set eth0 type bond_slave actor_port_prio 10 ip -n "${c_ns}" link set eth2 type bond_slave actor_port_prio 1000 test_agg_reselect eth2 log_test "bond 802.3ad" "actor_port_prio switch" +sleep 10 +check_slave_state active eth2 eth3 +log_test "bond 802.3ad" "active state/churn checking" +sleep 55 +check_slave_state backup eth0 eth1 +log_test "bond 802.3ad" "backup state/churn checking" =20 exit "${EXIT_STATUS}" --=20 2.50.1