From nobody Tue Apr 7 14:02:48 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA8BA18050 for ; Thu, 26 Feb 2026 07:49:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772092143; cv=none; b=X8+Kxh5KNC7IPGeSlxxc77GRrZ/iaghVNtATkiekDJ0ezcPY3bqFKfV8i19lGYybCkF3QwX11QelLEeQPZggAAbbbXTOHmObDfFPDwz5epVCE3Nqc4//NZpngoR6BOaVhKWcKntVchmWlP0xLvWztWe0VwkP+mgqyLKAtzLw03A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772092143; c=relaxed/simple; bh=3Y1sRV66tPa0iCH8Y7SbBFhIlTW9UBOtVElNQxJXw8Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V6A2+ypsvsNZgEHEUL8ACOeK3qV4TGzC6pSBxzV62k14cPCxW4UryJhd9wVS4Hn3rtnGe/edtdmy6vjlIesQogMYMR76FNxllPpxCSIxMV2TrWiLjQGzCLgg77jSJSpbE++UUI2nh4aMNmaFgYLlOR9/DED8WomR8IJF4N46vvE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GNApsi7k; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GNApsi7k" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-4376de3f128so324990f8f.0 for ; Wed, 25 Feb 2026 23:49:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772092140; x=1772696940; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Obp+jlj4fAJJnC5C1xFGFcA2X3tdhF8x/67LbIKcCNc=; b=GNApsi7klwvNvh9LcMmqAFKhCWduAI1TEP6cvoam0hfub3X+sp8y3WYPSQFhATa8JX VScSDPgPdaSHRjLxYZBVss3XLKalFjMe4wrLr6tDXiSFBnXCG1R7zWV8/wgqeNTW9f6C 1Kfl/RPjaLgPIHxPfQ69Y8BC9cDFzLtgWxJuczLzhcJyKxrZGdpe8nFFpVXeFlgfnNHn JrOBMMJhonpfS68MabgXydyqRdVgqo6isnsEuN1zny6ctEYkRG9teies8+IApxXjEGxg l6bQASJdEtvpXaI2fPisVH5i8S2qys7jMO39wLsLvH00W1tjAH3XUqHCWdgAgqlpIPu4 WaBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772092140; x=1772696940; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Obp+jlj4fAJJnC5C1xFGFcA2X3tdhF8x/67LbIKcCNc=; b=Er/9tVPYoX3tDcJqkgDENP1AtsxNj4GdN/BLfcqOSsJmSCa48wB4PA+a+4S2GIISjq FZ9J6mn8AeRBK2TUcq9bj/xJG4XlCkSYErKUn7yGFlS1LMzbjS2K7aqq+EncTZx2+8Pg wwfZvKj7a367/KRCmiKpKtVfzsVvgPHm4UXSetZp0K/2cyzKbilT/HZK+3VkVeIBXhCr a5KyPN+huBi88fI3Pv61pqWjSVgBgSU3UejD0p2OvrVb7/nWR2btQoD0d0G7ju3jd9lj qtLj5kJ40qba+IECffKCz01yOYx0wdC48h+oxFJOh4C1qpHFNTWYOxLYoTSbIzw0C9UY 0K6g== X-Forwarded-Encrypted: i=1; AJvYcCXNymc28XukBoZa7euSJrtPmJafflRRjTStB5xqYXB8FNkIY7Rb0b3HhyQXbXmQQ9vy3AYnszEVyzLXoq4=@vger.kernel.org X-Gm-Message-State: AOJu0YxXTUIcY9pixa5fVMv4o+eWad5Yyu9kNmMm6Bsn/HNA0pyW2Rl+ rl2/9Nu2Leheb4Kcjzk2kWSWEOQzBwuXapORKfSo6i2iAAOg0uv1qfLF X-Gm-Gg: ATEYQzwPad2DVQg2yDxxAmN2ghb3A75b3Irs1gWfcF4OmoxMkQIolBCa/MuaKt9DhAR jPLg/awNskEV3mpnESoyfAnpgMosOgDm4EeQiTXu5V4rcyIL982iLuUZdAw9brex4Q3ChFbGU1F CAset3PXbSUUZTNBqrmse+87ZZgedWUx/qFoQ4q9/hOqJEGRGzlt3o3Ucn7AzTnqHD5uxYRdl4a FUkuXX9tiOjYVomBhqj2w55aHR7OLanJjklaU7dJsLSedpd7BS+dQWKO662EpKOvONnXZ742WN8 IYyMMzlfSRaXLdiATUlHRx94D9wZ+/roUZp+mWrPijtEq7eFIvzT9CBVJCXjFljzCC/Z8VvaYOq Q8p0+Kdz2tOOWqxSbSBLvBObzKfymLALFUiZ7ZdaE1TT9Px95v0EIgbVCywfMUFBcXs2l21mF1A == X-Received: by 2002:a05:6000:250f:b0:439:881a:656c with SMTP id ffacd0b85a97d-4399429ca55mr5857411f8f.6.1772092139934; Wed, 25 Feb 2026 23:48:59 -0800 (PST) Received: from kimsufi.. ([2001:41d0:303:6f54::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970bfa015sm39244229f8f.8.2026.02.25.23.48.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 23:48:59 -0800 (PST) From: Ruslan Valiyev To: Vaibhav Hiremath , Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: Dan Carpenter , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ruslan Valiyev Subject: [PATCH v2] staging: greybus: arche: use sysfs_emit() instead of sprintf() Date: Thu, 26 Feb 2026 07:48:58 +0000 Message-ID: <20260226074858.67635-1-linuxoid@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260225212955.57102-1-linuxoid@gmail.com> References: <20260225212955.57102-1-linuxoid@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace sprintf() with sysfs_emit() in state_show() sysfs attribute callbacks in arche-platform.c and arche-apb-ctrl.c. Checkpatch complains about code using sprintf(). This code here is obviously safe as-is, but it would be more appropriate to use sysfs_emit(). Signed-off-by: Ruslan Valiyev Reviewed-by: Dan Carpenter --- drivers/staging/greybus/arche-apb-ctrl.c | 10 +++++----- drivers/staging/greybus/arche-platform.c | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/gre= ybus/arche-apb-ctrl.c index 33f26a65f..19a6e59b6 100644 --- a/drivers/staging/greybus/arche-apb-ctrl.c +++ b/drivers/staging/greybus/arche-apb-ctrl.c @@ -300,16 +300,16 @@ static ssize_t state_show(struct device *dev, =20 switch (apb->state) { case ARCHE_PLATFORM_STATE_OFF: - return sprintf(buf, "off%s\n", + return sysfs_emit(buf, "off%s\n", apb->init_disabled ? ",disabled" : ""); case ARCHE_PLATFORM_STATE_ACTIVE: - return sprintf(buf, "active\n"); + return sysfs_emit(buf, "active\n"); case ARCHE_PLATFORM_STATE_STANDBY: - return sprintf(buf, "standby\n"); + return sysfs_emit(buf, "standby\n"); case ARCHE_PLATFORM_STATE_FW_FLASHING: - return sprintf(buf, "fw_flashing\n"); + return sysfs_emit(buf, "fw_flashing\n"); default: - return sprintf(buf, "unknown state\n"); + return sysfs_emit(buf, "unknown state\n"); } } =20 diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/gre= ybus/arche-platform.c index f669a7e2e..de5de59ea 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -374,15 +374,15 @@ static ssize_t state_show(struct device *dev, =20 switch (arche_pdata->state) { case ARCHE_PLATFORM_STATE_OFF: - return sprintf(buf, "off\n"); + return sysfs_emit(buf, "off\n"); case ARCHE_PLATFORM_STATE_ACTIVE: - return sprintf(buf, "active\n"); + return sysfs_emit(buf, "active\n"); case ARCHE_PLATFORM_STATE_STANDBY: - return sprintf(buf, "standby\n"); + return sysfs_emit(buf, "standby\n"); case ARCHE_PLATFORM_STATE_FW_FLASHING: - return sprintf(buf, "fw_flashing\n"); + return sysfs_emit(buf, "fw_flashing\n"); default: - return sprintf(buf, "unknown state\n"); + return sysfs_emit(buf, "unknown state\n"); } } =20 --=20 2.43.0