From nobody Tue Apr 7 14:03:42 2026 Received: from mail-yx1-f50.google.com (mail-yx1-f50.google.com [74.125.224.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DA083115B8 for ; Thu, 26 Feb 2026 04:04:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772078658; cv=none; b=LdgRNIxO6dYP0IPK/cnaOvU0h6SwOx1dXg09C2QUDwA48PqlLiJIN/ZLronrw7/OZy6+FZQ7eHsbJmQ9sWze5dEevpIlPD3bIkbCBpbAsT0vYkyqKWDBPgYkRaf6TC7I85SKGmixW0xlI/Taa0ZtNNfkXDXMkM+17nnfiYYLkhA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772078658; c=relaxed/simple; bh=9QnsUH1b8xu9HS7Lr8NBFEdFNO86Z9sWzIxCtwZ5Yio=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AyoxuFwVg2EuaV1m9sWeVVD3vMDvgERJg/UwS8dPEpH39NbqTAirUX6Mm7OXejJvMyax4LeObttmlQGYFxjKP4q/gs+GyGfoA/mO8QrO+ypd3XrjTCg7KZiXb9xnbiPH3KxeX52QWAuIrJS+M/hEK8h6kWSYcoXSYSsI+mbQ3vw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iJJ60pW/; arc=none smtp.client-ip=74.125.224.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iJJ60pW/" Received: by mail-yx1-f50.google.com with SMTP id 956f58d0204a3-64ad46a44easo279527d50.0 for ; Wed, 25 Feb 2026 20:04:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772078656; x=1772683456; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OW2A0GS7O+4pmpGmbAo6fa4SoWiUi8MSUjgZBunJX3U=; b=iJJ60pW/vBrRRj6NVIV0KCXXsTF6YSr7yx/kRgmD5A8GXesWanT59o9ataANxw1/NO PRNY1UXQX7GpmNujqQHU8KZZa3KCscGfRJEdEvNXvLW8a5g7DDHCWTuua04PiMl+BTIj RxMRvp3vKBFvNtyxgNu73SXH4k7tY9bkBfaUtSB7W+vqqpDaSGaisbvUqy1cwqvpYFsK FZXh0PFaku+aDnKSNc8JCsGQdg6AwPojh6RFFsOfAyVXk5AdPz0TuLaQB9Y4FnX/nc2D nB2ng9t5plr6lig8pBRUTkmCksKlbJadndeBxY2GskV85KHuiF4GJgCeefvAZokzeHaL i26w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772078656; x=1772683456; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OW2A0GS7O+4pmpGmbAo6fa4SoWiUi8MSUjgZBunJX3U=; b=X8cSuXlAtcNCN1mPxj0MfzUnvXdO7c/o7lIDYUPfNmRvHHp2z3tnlsgpf30m3t8x6k LKvAyRTpU8PxUpwJINBf2GuqOqDQtQn3LI4tOrM7KVna2bYg2i5skYkDuNF2ZeheQo3X j9meZlQnGwqvMNda8g6Keofnpgva0ZMtKR5N0lsXLtLy9lLHcI4MfeaPh21z3gnz9V85 7ya56mAU3ugpAL1HkZ1y9dT1pKJ7T2vE9KK4RtSY0YtBt4DUtphyYslMi6pyGtpd9VVY iltCkryyn08NFXXJ5d0ODyxrhkW0XEBbjv6CRkl4I4/J3zF1YueMF54u+Cze+oF/8HYX o7jw== X-Forwarded-Encrypted: i=1; AJvYcCVGl9hPy9XUUlsncZuVcM+3Ile0FLJ3qFeESqSDVCGSzq9xDnGs7in1P1EgsggRBBEFOVlm8QrrpXDYnpQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxA4EHOhC1Wcu+IkUY4vc3v/D10oUJfrJYL3FJtQzUo/NYotILX VaCibR7vBG2bhanmSXQzhi9sL8jvJjgaRiD91320xpr8MH4kvU3Gkq9o X-Gm-Gg: ATEYQzyyHRp92QJ5tAMof3pxtHAQrti4E91Y+GP7xaDx3YD6/kglRJL28TFkHbXiRxd qIu7mCc+IJZhEgIuAankggi3hH3zKeqmHuxVIl7qXipmAQI4FQSiGnGlFdv/klGZdfYMmRlF1KZ wf/5+V++XP1OpNU50HwQkQ2MzGhPpon7f98jMJ5Y0OmZHhOeJ31LAb7rNcXvQoKsV9uO72OuXdJ xANrwoyFif1abcVl57oJk5pNGKyOxDGXMPY84qL/XiXbM6k1AeiD7yeycKfyUAAWH2BYUr0BIZu zPSyvYS2Dh98lvCE1d2KujigRbXfjnLuV+h2tdIB4u6c3zOPMyvomdXkAnI6aMMkvpMpGkpl7v/ 0pYyCzy3GjmSDom9meKNF4Cz5f16KM/WkkNRz5KRdQN59cx2WKjdMwraie+QxscfqtznraCoozU 1zVRhTAuYkNZ/EZHSavPPp6u+kenLJUG1GyNiBwBeFwqFV2RrdesQ0rfMhbET89/eDWzclguo9m Pg/1PyJ0NvjXQzwyj3LsGkV X-Received: by 2002:a05:690e:168d:b0:649:d79c:1608 with SMTP id 956f58d0204a3-64c787d43b6mr16826743d50.18.1772078656402; Wed, 25 Feb 2026 20:04:16 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb759f638sm498466d50.7.2026.02.25.20.04.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 20:04:16 -0800 (PST) From: Ethan Tidmore To: linkinjeon@kernel.org, hyc.lee@gmail.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 1/2] ntfs: Replace ERR_PTR(0) with NULL Date: Wed, 25 Feb 2026 22:03:54 -0600 Message-ID: <20260226040355.1974628-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260226040355.1974628-1-ethantidmore06@gmail.com> References: <20260226040355.1974628-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable err is confirmed to be 0 and then never reassigned in the success path. The function then returns with ERR_PTR(err) which just equals NULL and can be misleading. Detected by Smatch: fs/ntfs/namei.c:1091 ntfs_mkdir() warn: passing zero to 'ERR_PTR' Signed-off-by: Ethan Tidmore Reviewed-by: Hyunchul Lee --- fs/ntfs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ntfs/namei.c b/fs/ntfs/namei.c index a21eeaec57b4..cecfaabfbfe7 100644 --- a/fs/ntfs/namei.c +++ b/fs/ntfs/namei.c @@ -1088,7 +1088,7 @@ static struct dentry *ntfs_mkdir(struct mnt_idmap *id= map, struct inode *dir, } =20 d_instantiate_new(dentry, VFS_I(ni)); - return ERR_PTR(err); + return NULL; } =20 static int ntfs_rmdir(struct inode *dir, struct dentry *dentry) --=20 2.53.0 From nobody Tue Apr 7 14:03:42 2026 Received: from mail-yx1-f51.google.com (mail-yx1-f51.google.com [74.125.224.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F19B37648D for ; Thu, 26 Feb 2026 04:04:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772078659; cv=none; b=NZiu7fhFtYUQ695iM87Ix+ERHXxnq8vwLMxSF+eb5AANjDhCdEthHdZtU+PCDYA8yM/TEHLC2rkvYk9STH8P8ra6brV7JuahpEMKAofeHxwj+Cqi9cJh2lWSGJ46opALWXjQwvyIcFiGrsISjwmYVcjHMiWKMBmkm3rn94Ad9TA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772078659; c=relaxed/simple; bh=hzQVhjaSP+qcRRN6UWE5+eHmnCqVf4TOTLjd2mdvzcs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cvPYOZ8JSBAHi15Lt0LuIAMRgvzvLa2Ol9ZvOPaEgEv6rdV4YG4xM3QS8wpKLvsXTNTcOFzPfGpLNn7pGmUqxVDVqOdVViXZn0GYBNTkdYCWhDEqGdNoZbja33/cNsVrZeC01HNcAiQn92c4nRFg9rXvLZdqno80u51QlfG2VlM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hEYQbSZD; arc=none smtp.client-ip=74.125.224.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hEYQbSZD" Received: by mail-yx1-f51.google.com with SMTP id 956f58d0204a3-64c31ca77b4so293671d50.2 for ; Wed, 25 Feb 2026 20:04:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772078657; x=1772683457; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NnZ/pDUrDFnoEM6bg4B+njajENgtjVHfzWtgYjXZ31I=; b=hEYQbSZDFA3udI0S6kx3UtdGFB5e8mvL1n4sFyEO08WaVx9uhU9VlXyp6LV490SAOh UJkwcDaTD+uUpLUU0DCiqRljUEMRZlc9U47X0Hz8XUHRzQIq0fcPOl+AsYJFxwJC6WH2 zmOVOkwwWAYdJKGpGQCuxmO1NFn2o9nP4mHyupX+N+UnlL2cPN4wbtU5pxapfUHby/zU Z8HfBnw9OGvGgTmU9/QFQvIIpg2IJvUGfKWRnRtnQgCm+xeyGsUpKlFrLHsQrEHZ95gt znbY+STNHSyrGnKmyfU8qQHJkRvijqELV2lNXq9MxYOQQhkD25dwE4zaL4joe96MWym5 +3mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772078657; x=1772683457; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NnZ/pDUrDFnoEM6bg4B+njajENgtjVHfzWtgYjXZ31I=; b=KjFW+1aErmyS5i3j0lpAW7/mtDyIiXEDWJRm8pmnixUJVVavb4w5vFPZO95rMHLUVW rPvqJ4fTobFp4DmC+2u0sT4t7eLO0LGzBbOn0tbBblFCdahJEWves7CURhiJHGftqEte 806LU4bjxJY7jUQhTq3DpSpXE7ChWQpNYCKDa9YYchyiiy3HMvyAXI92trny3GzOnoQu d8iOgIsHvjA+wujqoeLLtzHQS6LTL2IstnTmgS791r3Fg3ckBUysB+CBp7zCrvoDoJtZ sK2CG5TiVDyvqh8YiWfusDWES09lnAptNvz2ac80NBl0Pt3ubggYjgzjFoXTSWqiVhGx pyyQ== X-Forwarded-Encrypted: i=1; AJvYcCW//0vtnExDt9YmrS047hUySw4ADn/NibANtEYp384c+7sdfitYqfkDdUTsKgKpBzRJFQQFIDi6u66fRFw=@vger.kernel.org X-Gm-Message-State: AOJu0YxepOuXdqvZs+6sjMjRiQRaUK0ZdbNpz64rtEsrxFRgC2TSZq/o RPk+AFy3WJ4Mn0q0tKCzTMfUFB1yJuREMR+DczfN8y8mHM3GoUQxkqRa X-Gm-Gg: ATEYQzwa1jtGWUz9uVG1uUT+RSrq8XpPxZh5Ad1PqbLXEJpS1oeA9EBR8ZVFPCVYoqS qPSoieNomm6n8rUMFhNK2FNkflPMoWhGkvbzJeDenpqtAE7zZjZDExycHORn4s+mdQ/hsid+Lak mwHyRj5TteCkjPGIfGjpmHEKmRSmyL0KvVJX01mmsbbF2H3+WJ0LnWaGmQ0zdXpy7B3+bW8FRBW 8EszlkU0tT/H9lvR7twVu7D6rqY+hZyl39sRvj8m/VilnNO48kvBogWy9wUKQU5qBQSzy3Zss0H LGllIIHMzKdV5hOKsHCw6sRE+wNZZjnSfaJm0fbS1WVu7Rc9+JwosOwEMm90ZytBmQx5UYio5Nf HSvmPvUGxl4u5FYuD1GJsSeYda7qTjN2VMonec9bBkuSTGXxFy6TQEV9GG22IYGm71eXA/qHxwq scFd93M0bhY32hQ/qbhWD/kvCR/WNR9YPR7yAO1Ig6BEHuq3ZmI1V1eJ5mhK6692LrXbpA05pfv QzjQWT91jW7mcB6/4EH+GXZ X-Received: by 2002:a05:690e:1915:b0:649:d502:3bfd with SMTP id 956f58d0204a3-64cb2523b04mr2441186d50.68.1772078657113; Wed, 25 Feb 2026 20:04:17 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb759f638sm498466d50.7.2026.02.25.20.04.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 20:04:16 -0800 (PST) From: Ethan Tidmore To: linkinjeon@kernel.org, hyc.lee@gmail.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 2/2] ntfs: Remove impossible condition Date: Wed, 25 Feb 2026 22:03:55 -0600 Message-ID: <20260226040355.1974628-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260226040355.1974628-1-ethantidmore06@gmail.com> References: <20260226040355.1974628-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable name_len is checked to see if it's larger than the macro NTFS_MAX_NAME_LEN however this condition is impossible because name_len is of type u8 and NTFS_MAX_NAME_LEN is hardcoded to be 255. Detected by Smatch: fs/ntfs/namei.c:1175 __ntfs_link() warn: impossible condition '(name_len > 255) =3D> (0-255 > 255)' Signed-off-by: Ethan Tidmore Reviewed-by: Hyunchul Lee --- fs/ntfs/namei.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/ntfs/namei.c b/fs/ntfs/namei.c index cecfaabfbfe7..2952b377dda2 100644 --- a/fs/ntfs/namei.c +++ b/fs/ntfs/namei.c @@ -1172,10 +1172,7 @@ static int __ntfs_link(struct ntfs_inode *ni, struct= ntfs_inode *dir_ni, =20 /* Create FILE_NAME attribute. */ fn_len =3D sizeof(struct file_name_attr) + name_len * sizeof(__le16); - if (name_len > NTFS_MAX_NAME_LEN) { - err =3D -EIO; - goto err_out; - } + fn =3D kzalloc(fn_len, GFP_NOFS); if (!fn) { err =3D -ENOMEM; --=20 2.53.0