From nobody Tue Apr 7 15:28:51 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75E0A37475E for ; Thu, 26 Feb 2026 02:05:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772071529; cv=none; b=oIsudlfBFsAyNaVL8LOO7nRkN3JJT9UlUumZMnJtZPZnVYnUNXIC9qxGfFDu+x5oWQA0jSeXeyOmwdUNqbnFAEtaHzxB3phPvdeP4DJv1JCf90INZpv+fib/4Vxw3qJNHDiuceid+lXJa3ISHJH7D+uL2w4Er9FuptHbTIwS0cU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772071529; c=relaxed/simple; bh=FQ7+8UQrfazchx/xR38mGEbVPKuFWRswgYVgS6aEHrs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QzEK+p2aRMXdsfLjh16Fz/yvH/DugU8KK7NqRcV0ez/CTNCNIVOoHudoqwEDCuithKbZeCZJ6lQbNlD2yjyAcUxaB2gjt1kJRm7dMcXfLtP98ok9/nG/bAnd2yveb7L+RSTbmIjcgtbuuYSyFhYqzSfIKL5q7S0T7+R/llNb2x4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lOAU6/Zc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bYoPB9lP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lOAU6/Zc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bYoPB9lP" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61PKfU4e2523290 for ; Thu, 26 Feb 2026 02:05:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Z465nXzp8HC BbM4FmGtCUWDvb5Hdu3C6MJbefety11I=; b=lOAU6/ZcYPvVfNLJPEQq4gjH75H YxqUdBwVI6DuUK6KtgugySG/Vwi4exzQoyQ6Dnck/2gKv52xvfNzJylst84COvgM yyIvGcKKXaZC1PitLHKGT4/hQFrh/s/1NViUQTAn1kAOj2S8I3v/MbDULSY8cP2x s7rnkNih2eH4A0mMDrmTMLWU2stoWo/oRs6cQhZLJM9u5B349tnfey06d3p16IPC wvxCT7C6NBSiHtz+ccCUAfO835UOWQYIj7QgbnVDoGg0jU3InZaPu7u/TNNhxtWI 6TtblXGpcS9osf/vEwKHymcN3js5QQlJhpHxKd6O1/7l2GTn/O6/GvT+rbw== Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cj8bd8pdq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Feb 2026 02:05:26 +0000 (GMT) Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-6798747187eso4135254eaf.1 for ; Wed, 25 Feb 2026 18:05:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772071526; x=1772676326; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z465nXzp8HCBbM4FmGtCUWDvb5Hdu3C6MJbefety11I=; b=bYoPB9lPEte/vYuQkw76YQv4pbDZTfUDVY8sgcVYCz9UHMTQWWXyPNS4ctwmrHnlgH uwaWB2/Rq8Gjhr9ibd9eF/sL2EjOGyMrC0j+21GBfvOO893s7gTZ0CdzzetcRlkDEgvP jpRCdxrSqYONu8OZaJxMB5W5ysp0I8YOqDpNG45pbPsEETmudYE86VL6TWXrL/WmSmR2 eCVojvu8+bc5ZcNF4EfoZC1sGv7e5SxXUGZklupl0EUZw0j95b3hQY3zcerI2YLgSpbW jLkQlZ2vAiv7KU+xr3vOGdM68EyUQEQdB/q8yVWEgVeHjJ/7w8LZ+/gon2yasAaZklvC EBCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772071526; x=1772676326; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z465nXzp8HCBbM4FmGtCUWDvb5Hdu3C6MJbefety11I=; b=HRymNQ57RFmAJc2Ff2humv6Nm6qTL1rB1Z6E+Rbey14OYPPwSNW7srxtJ0ZuDMDtO9 SFgy0PHPVQx60pTtphiD8ZZgl3hVxfZVV9erv5S3fBPzMBBtoCtpxCn+65lWitCFwUd8 i8Eh5vNwNr/Wg639rg/LH10dGHSt2q/Ub5xLtue/GjINMDTpI78m2XzNA3eGILoNzrh3 p7jEPgnsHBuDhW+7BPxrvM0r3eti2gmPiWDD1kWnvInqMn8Nag4Nhh+l3IncwVT35Jd9 kw+BD70Z5xsKaTisnBxAQI7+szbm2c0lfDtFilSr+l76nuW3WJXRASggnHPY4d3wSCGB 5dxQ== X-Forwarded-Encrypted: i=1; AJvYcCWSTlfkyJxhNDK1Qk/oUfOanwjHoBe5jR5W3ymmkUql9vPCrHF+dCWzAx2Vxk3uJU5XknTG2nEt/9X22GI=@vger.kernel.org X-Gm-Message-State: AOJu0YzbUYi/vrofawUpg6ervPEYGwC8L12H/6qxma1zKw17Cl1tO0mK /3tJblWT+9Qkx3ceh6M3VWLh6HxHlXwwzr+fyltUOR7vq6e2kzBZL5RtguuvMCiUhHeCA/wQP3k TQ1efv5tOTMtPgaIhZ+3lbHhOCsZG7gmaG5vp/twSXf3/gs7bOu47k9oJa+AXmRer3Zg= X-Gm-Gg: ATEYQzxju95mIHh3hYMIqk/7HI02K5JuWo3bNfKTAyoxnyV9TvhC1UBjwhL9pGEFVH+ miPWmeJvOKUYmEn8JcBsDXPM465G4QKTeYp0cBzB5Er4btduX5PRsAl8r94AU+bEyOypriWdc4A eC6K3gEt1xm4aMouDQK0beYfn3Udztohkmw01lVcn9tQJHabVAMXLPHY2mbwWTunWMNyUHagESz v5uwWyciFDamqEVC4zP1YaN9fSeUFY/YfL1AEoqT4gOLoWoh4Aon2fua1v2f0q7n+Q/iRJXxiub V/fFspGYA97/WckBWBn4wEQF4Kd3w5OQhos8s/CPAEcNKQmDdWG5LuHP8qOKj4WzEiEwB9Tu5Xm 6XGBLcTWprt5EHPqSrWJLFK6ppkg5+ua87LsRsX8SBUxY3b99B9tDv59g7rRAhiwRCz/cR0lOPD hE X-Received: by 2002:a05:6820:308e:b0:672:8d08:af5a with SMTP id 006d021491bc7-679f3dc2fdamr267191eaf.66.1772071525779; Wed, 25 Feb 2026 18:05:25 -0800 (PST) X-Received: by 2002:a05:6820:308e:b0:672:8d08:af5a with SMTP id 006d021491bc7-679f3dc2fdamr267180eaf.66.1772071525405; Wed, 25 Feb 2026 18:05:25 -0800 (PST) Received: from hu-songchai-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-679f2d9e8d6sm549939eaf.13.2026.02.25.18.05.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 18:05:24 -0800 (PST) From: Songwei Chai To: andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, konrad.dybcio@oss.qualcomm.com, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: Songwei Chai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org Subject: [PATCH v11 5/7] qcom-tgu: Add support to configure next action Date: Wed, 25 Feb 2026 18:04:52 -0800 Message-Id: <20260226020454.3210149-6-songwei.chai@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260226020454.3210149-1-songwei.chai@oss.qualcomm.com> References: <20260226020454.3210149-1-songwei.chai@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=FKQWBuos c=1 sm=1 tr=0 ts=699faa66 cx=c_pps a=lVi5GcDxkcJcfCmEjVJoaw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=s623Ih-0px1LxcEVn60A:9 a=rBiNkAWo9uy_4UTK5NWh:22 X-Proofpoint-GUID: usBcHu2bNoFwC6p3JpWWKcCu3xdIqomA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI2MDAxNiBTYWx0ZWRfXw+24/CdrWLM1 f2l1YHj6vFiHVThBA+cTWWfs/QGOMmqA5n4xNRvmcsFPSN5TS75DC5Nd28czwtVopOVsGgKa37c Dyhvo0Ygkz0Zby0uDGs67iWs9+C2icEbJxsE56kmTynPGfFj1XWEhWWYgwjYx1cUqSfAOn6pUw6 H8Opnnyj9cyg7+Qb3BwFsThajCAsjYY7HpuOH9o+EUuQHW3uPmT1efL0U/5UcRQ14Grek/ZA+A4 0cA1Lil0QDV35JYkb2tPXKcUliM88B2X9cC52tINrd9s8zfedVRALQQ4lYwzakNSWqRs6flcm49 b46No/7FbzvRWY+cqBMvn/UbyJ3oNWDvODq196DRPy8abXlzqzMliAwGA+OcazUzMot8NRGulHE tRAfUoeokgVg0DjrSQ+LbTnEFbX8qCl4ABHth+SWP9RhEUv1DmlHMeh8vPbJlerxA5JjZPg/kVF KGDDrHw7rg0TXStu1cQ== X-Proofpoint-ORIG-GUID: usBcHu2bNoFwC6p3JpWWKcCu3xdIqomA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_04,2026-02-25_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602260016 Content-Type: text/plain; charset="utf-8" Add "select" node for each step to determine if another step is taken, trigger(s) are generated, counters/timers incremented/decremented, etc. Signed-off-by: Songwei Chai --- .../ABI/testing/sysfs-bus-amba-devices-tgu | 7 +++ drivers/hwtracing/qcom/tgu.c | 53 ++++++++++++++++++- drivers/hwtracing/qcom/tgu.h | 27 ++++++++++ 3 files changed, 85 insertions(+), 2 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu b/Documen= tation/ABI/testing/sysfs-bus-amba-devices-tgu index a18f6e4c797d..fbe8efe470d1 100644 --- a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu +++ b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu @@ -21,3 +21,10 @@ KernelVersion 6.20 Contact: Jinlong Mao , Songwei Chai Description: (RW) Set/Get the decode mode with specific step for TGU. + +What: /sys/bus/amba/devices//step[0:7]_condition_select/reg[0:3] +Date: February 2026 +KernelVersion 6.20 +Contact: Jinlong Mao , Songwei Chai +Description: + (RW) Set/Get the next action with specific step for TGU. diff --git a/drivers/hwtracing/qcom/tgu.c b/drivers/hwtracing/qcom/tgu.c index 85fe1140eab5..1d996b9e303a 100644 --- a/drivers/hwtracing/qcom/tgu.c +++ b/drivers/hwtracing/qcom/tgu.c @@ -29,6 +29,9 @@ static int calculate_array_location(struct tgu_drvdata *d= rvdata, case TGU_CONDITION_DECODE: return step_index * (drvdata->num_condition_decode) + reg_index; + case TGU_CONDITION_SELECT: + return step_index * (drvdata->num_condition_select) + + reg_index; default: break; } @@ -71,6 +74,9 @@ static ssize_t tgu_dataset_show(struct device *dev, case TGU_CONDITION_DECODE: return sysfs_emit(buf, "0x%x\n", drvdata->value_table->condition_decode[index]); + case TGU_CONDITION_SELECT: + return sysfs_emit(buf, "0x%x\n", + drvdata->value_table->condition_select[index]); default: break; } @@ -112,6 +118,10 @@ static ssize_t tgu_dataset_store(struct device *dev, tgu_drvdata->value_table->condition_decode[index] =3D val; ret =3D size; break; + case TGU_CONDITION_SELECT: + tgu_drvdata->value_table->condition_select[index] =3D val; + ret =3D size; + break; default: ret =3D -EINVAL; break; @@ -146,6 +156,13 @@ static umode_t tgu_node_visible(struct kobject *kobjec= t, if (tgu_attr->reg_num < drvdata->num_condition_decode) return attr->mode; break; + case TGU_CONDITION_SELECT: + /* 'default' register is at the end of 'select' region */ + if (tgu_attr->reg_num =3D=3D drvdata->num_condition_select - 1) + attr->name =3D "default"; + if (tgu_attr->reg_num < drvdata->num_condition_select) + return attr->mode; + break; default: break; } @@ -184,6 +201,18 @@ static ssize_t tgu_write_all_hw_regs(struct tgu_drvdat= a *drvdata) drvdata->base + CONDITION_DECODE_STEP(i, j)); } } + + for (i =3D 0; i < drvdata->num_step; i++) { + for (j =3D 0; j < drvdata->num_condition_select; j++) { + index =3D check_array_location(drvdata, i, + TGU_CONDITION_SELECT, j); + if (index =3D=3D -EINVAL) + goto exit; + + writel(drvdata->value_table->condition_select[index], + drvdata->base + CONDITION_SELECT_STEP(i, j)); + } + } /* Enable TGU to program the triggers */ writel(1, drvdata->base + TGU_CONTROL); exit: @@ -223,6 +252,8 @@ static void tgu_set_conditions(struct tgu_drvdata *drvd= ata) =20 devid =3D readl(drvdata->base + TGU_DEVID); drvdata->num_condition_decode =3D TGU_DEVID_CONDITIONS(devid); + /* select region has an additional 'default' register */ + drvdata->num_condition_select =3D TGU_DEVID_CONDITIONS(devid) + 1; } =20 static int tgu_enable(struct device *dev) @@ -356,6 +387,14 @@ static const struct attribute_group *tgu_attr_groups[]= =3D { CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(5), CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(6), CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(7), + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(0), + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(1), + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(2), + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(3), + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(4), + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(5), + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(6), + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(7), NULL, }; =20 @@ -363,8 +402,8 @@ static int tgu_probe(struct amba_device *adev, const st= ruct amba_id *id) { struct device *dev =3D &adev->dev; struct tgu_drvdata *drvdata; - unsigned int *priority, *condition; - size_t priority_size, condition_size; + unsigned int *priority, *condition, *select; + size_t priority_size, condition_size, select_size; int ret; =20 drvdata =3D devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); @@ -415,6 +454,16 @@ static int tgu_probe(struct amba_device *adev, const s= truct amba_id *id) =20 drvdata->value_table->condition_decode =3D condition; =20 + select_size =3D drvdata->num_condition_select * drvdata->num_step; + + select =3D devm_kcalloc(dev, select_size, + sizeof(*(drvdata->value_table->condition_select)), + GFP_KERNEL); + if (!select) + return -ENOMEM; + + drvdata->value_table->condition_select =3D select; + drvdata->enabled =3D false; =20 pm_runtime_put(&adev->dev); diff --git a/drivers/hwtracing/qcom/tgu.h b/drivers/hwtracing/qcom/tgu.h index ca8dfbef0cd2..5beaf82b4b8c 100644 --- a/drivers/hwtracing/qcom/tgu.h +++ b/drivers/hwtracing/qcom/tgu.h @@ -53,6 +53,7 @@ #define STEP_OFFSET 0x1D8 #define PRIORITY_START_OFFSET 0x0074 #define CONDITION_DECODE_OFFSET 0x0050 +#define CONDITION_SELECT_OFFSET 0x0060 #define PRIORITY_OFFSET 0x60 #define REG_OFFSET 0x4 =20 @@ -64,6 +65,9 @@ #define CONDITION_DECODE_STEP(step, decode) \ (CONDITION_DECODE_OFFSET + REG_OFFSET * decode + STEP_OFFSET * step) =20 +#define CONDITION_SELECT_STEP(step, select) \ + (CONDITION_SELECT_OFFSET + REG_OFFSET * select + STEP_OFFSET * step) + #define tgu_dataset_rw(name, step_index, type, reg_num) \ (&((struct tgu_attribute[]){ { \ __ATTR(name, 0644, tgu_dataset_show, tgu_dataset_store), \ @@ -77,6 +81,8 @@ reg_num) #define STEP_DECODE(step_index, reg_num) \ tgu_dataset_rw(reg##reg_num, step_index, TGU_CONDITION_DECODE, reg_num) +#define STEP_SELECT(step_index, reg_num) \ + tgu_dataset_rw(reg##reg_num, step_index, TGU_CONDITION_SELECT, reg_num) =20 #define STEP_PRIORITY_LIST(step_index, priority) \ {STEP_PRIORITY(step_index, 0, priority), \ @@ -108,6 +114,15 @@ NULL \ } =20 +#define STEP_SELECT_LIST(n) \ + {STEP_SELECT(n, 0), \ + STEP_SELECT(n, 1), \ + STEP_SELECT(n, 2), \ + STEP_SELECT(n, 3), \ + STEP_SELECT(n, 4), \ + NULL \ + } + #define PRIORITY_ATTRIBUTE_GROUP_INIT(step, priority)\ (&(const struct attribute_group){\ .attrs =3D (struct attribute*[])STEP_PRIORITY_LIST(step, priority),\ @@ -122,12 +137,21 @@ .name =3D "step" #step "_condition_decode" \ }) =20 +#define CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(step)\ + (&(const struct attribute_group){\ + .attrs =3D (struct attribute*[])STEP_SELECT_LIST(step),\ + .is_visible =3D tgu_node_visible,\ + .name =3D "step" #step "_condition_select" \ + }) + + enum operation_index { TGU_PRIORITY0, TGU_PRIORITY1, TGU_PRIORITY2, TGU_PRIORITY3, TGU_CONDITION_DECODE, + TGU_CONDITION_SELECT, }; =20 /* Maximum priority that TGU supports */ @@ -143,6 +167,7 @@ struct tgu_attribute { struct value_table { unsigned int *priority; unsigned int *condition_decode; + unsigned int *condition_select; }; =20 static inline void TGU_LOCK(void __iomem *addr) @@ -173,6 +198,7 @@ static inline void TGU_UNLOCK(void __iomem *addr) * @num_reg: Maximum number of registers * @num_step: Maximum step size * @num_condition_decode: Maximum number of condition_decode + * @num_condition_select: Maximum number of condition_select * * This structure defines the data associated with a TGU device, * including its base address, device pointers, clock, spinlock for @@ -188,6 +214,7 @@ struct tgu_drvdata { int num_reg; int num_step; int num_condition_decode; + int num_condition_select; }; =20 #endif --=20 2.34.1