From nobody Tue Apr 7 14:04:27 2026 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F15BB146A66 for ; Thu, 26 Feb 2026 01:16:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772068606; cv=none; b=pqElW+EUc9ij/iY2du4nwRd9JMpcjYll5qz62basTyFrjMBpMicM2eCFz3oS9fhsw6UWNYQTBEyWcFxtoTC9gwAl6Tf7j5xTEv5LEo3yofxLPUkJnGZygOm4A47UYHoCPzEJvgPFbl1xkYFIXB4DYVxZfKqI655IK1zNC2ZLhNY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772068606; c=relaxed/simple; bh=ENqURwaU8/1yRCEgfkhafxoMbf8j1scSOZPIwFQMbQg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=e/N1Nk6NtlHXqZv5JDWNv0axO5fgqoz0kXO+EC5wVL5nAZ6IlySURSpyPIGUAug381EhjSETEihocJDBfFz59bmASG5Zh73bd+TaezpteJZv1Z2oYWh2kCHTStd/9sRtwlalKwpRXZVuwEOPCj0wRHYcxpnSe+hyAMJ+i/So9WM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HBAchVwL; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HBAchVwL" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c6541e35fc0so152885a12.3 for ; Wed, 25 Feb 2026 17:16:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772068604; x=1772673404; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=s2crz5lIBVPU51U00I+WoWcNetEa5OXzY48VN/urTqI=; b=HBAchVwL8bEWLe+Ja8gPSWu8TZiQoD4D18tSFOJkvM6iIPaoQHveijbcmCEgRX4vRL 6uIl8S2ZbkP5RUhVJeEDHOoWRE0wugn4TgNubOwyHVfOTSBiZW/TpcB1oVmGidwfMD5a IKduhtM4tvY5y6RK46VrSUBuP2b8Nc/PLDv9ggvMffQZgb84OZnx+6JLqj1WEM1Q65qr gaVbq40hl8OiqUdO9EScxgE7UNDPooC5XAiFRs52e+oD41pkA8ZxhK271pY0sJ2QcAZ2 MNh0MjK4dPrDO4/mjVsb4helzud3lOwkkG/Kwo1+a5y2qa+i0OGLgyL6U06JZ8GTQxkk 3e9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772068604; x=1772673404; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s2crz5lIBVPU51U00I+WoWcNetEa5OXzY48VN/urTqI=; b=pQoAXMzdy+FHdw7ZtfWqWoX5kg1WA5iZPVG+p/JWi0s9cWIOVPzR6y9BKpCG7snjUi afyAsP3I9L/ExQ1L5ero+O++50FDvc9V2mFxKEk6u94XUcfVWut/fhyAuHuV2oeKVk6L Nts6/Q5QrEdhTT82iuOy9Bi8KNHxTadxr0XbEbhZHQnMgWb+AeehMnyJ8nO2y3xXwK1x Vzuq/EoWJIugpsiPmk2uyH9Wp2bQYVOXSRtEwbAKwuWPLfEiNT+TWjQOw1QVZWNd8PEV 8jF6j2Z6oC8Fjq31m9NUwUn9bjJdLg4KSrJgJxNIx++0LoLjw/qXVDFAx8JERmp/6htu 0tSg== X-Forwarded-Encrypted: i=1; AJvYcCVsB3UJbzi84hbalZ5nCKY2meVXfpBeeHwDAlWg4ucex3kQoQia0a0AOHkofip42fk77aqhcXHBFauS2lc=@vger.kernel.org X-Gm-Message-State: AOJu0YwohrN12GmrZ7dibGutyLA9WAMXiBV4TH3zIWN4Uf30zLc569Su fUZjwH/CBp0sbI1Qguo9gokgb+2+yy1OO7rePZd9UxymBgyskoGPW5rq X-Gm-Gg: ATEYQzxBy1YiBV5u9BiIoLe43FwDCP6OvtRrmqWrF2wam9yoSCI1EvOJwHwC0W97oQ5 bQGjJRgx1ZKfPrUdNBOm0i7PtthKp1GKlLiG5OeTfcPBFPsmFdvMyS0pdDBlNM15BrFbqQVkijS EXUDNID9oBoFniOD02Bpfcsg9GX4kdENhakIhHWIpvtcrE25o+WM54L8pB3O8PFkY5z4HGdyJjn s/rrpAQ+68maKADNMlN8Jhp9SEzcB+L9YQu9BfyHo4lR2YlxSd4TkMNPz9Q+eeVI/s/9XmOXuad MLwLLEfW3/cc4D1ITfpajDKhdUEG1IhY26l51D8P9UDFcJ9iEklaLsUAhLsKOu94Gdq68+6B2Ov OakMYk4ZdZDRVrKtW2wOhUBKgDkLnEFiQtd99i807O6u7HsH58DEpXB6SGMr7+dLUJqRvsBd0iP ASSAxGlX/xyPslELEGkXRLL8LPIET6uHc= X-Received: by 2002:a05:6a21:730e:b0:38e:c789:4f39 with SMTP id adf61e73a8af0-395b4963ff9mr478589637.49.1772068604262; Wed, 25 Feb 2026 17:16:44 -0800 (PST) Received: from lgs.. ([223.80.110.53]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70fa801963sm224387a12.21.2026.02.25.17.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 17:16:43 -0800 (PST) From: Guangshuo Li To: Greg Kroah-Hartman , Yaxing Guo , linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v3] uio: uio_pci_generic_sva: fix double free of devm_kzalloc() memory Date: Thu, 26 Feb 2026 09:16:32 +0800 Message-ID: <20260226011632.4186353-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" uio_pci_sva allocates struct uio_pci_sva_dev with devm_kzalloc() in probe(), but then calls kfree(udev) both on the probe() error path (label out_free) and again in remove(). Because devm_kzalloc() allocations are devres-managed and are freed automatically when the device is detached (including after a failing probe() and during driver unbind), the explicit kfree() can lead to a double free. If probe() fails after devm_kzalloc(), the error path frees udev and devres cleanup will free it again when the core unwinds the partially bound device. On normal driver removal, remove() frees udev and devres will free it again when the device is detached. Fix by removing the manual kfree() calls and dropping the now-unused label. Fixes: 3397c3cd859a2 ("uio: Add SVA support for PCI devices via uio_pci_gen= eric_sva.c") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v3: - Add changelog below the --- line describing changes since v2. v2: - Reflow commit message to keep lines within 75 characters. drivers/uio/uio_pci_generic_sva.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/uio/uio_pci_generic_sva.c b/drivers/uio/uio_pci_generi= c_sva.c index 4a46acd994a8..152201047334 100644 --- a/drivers/uio/uio_pci_generic_sva.c +++ b/drivers/uio/uio_pci_generic_sva.c @@ -129,15 +129,13 @@ static int probe(struct pci_dev *pdev, const struct p= ci_device_id *id) ret =3D devm_uio_register_device(&pdev->dev, &udev->info); if (ret) { dev_err(&pdev->dev, "Failed to register uio device\n"); - goto out_free; + goto out_disable; } =20 pci_set_drvdata(pdev, udev); =20 return 0; =20 -out_free: - kfree(udev); out_disable: pci_disable_device(pdev); =20 @@ -150,7 +148,6 @@ static void remove(struct pci_dev *pdev) =20 pci_release_regions(pdev); pci_disable_device(pdev); - kfree(udev); } =20 static ssize_t pasid_show(struct device *dev, --=20 2.43.0