From nobody Thu Apr 16 20:58:09 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BAA4288517 for ; Wed, 25 Feb 2026 16:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772037211; cv=none; b=o6Ays74w1Xod2axCVeOGW2+mSc0y26hf47C0kNnBISHZ0bmzhDGowpTfA5h5Ellz6om9w7g2EK+RC1QB0KTWQ/QJVFF8vrE/B15ciTvZOmV+4bUZsBakWX0VldNVGmHThcaKw/+WUIhdP+FuxkP4jFk9V65JQBogCyRjl+cK7rg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772037211; c=relaxed/simple; bh=W+jP3zwPXvbN6VQlSiaHn6aD2hpSIbT32Oq/GSFkHGI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=CB/I9gn7WrPmXeYD9fGPVIKLbzAl+eakYWQvghaBpLi83jae6PNN9cq0EDtVAsYZtvXSqvvWCvopZGTKeUfq1ap8IRS3Ij49QW9tYWy8JjMdH9igYVhwl9hav1OzDBOjWSSiiYo1OehKQv3dQt0c7Er9AYWMSSNv34Xrgfsfoqw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aQvaT5oe; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aQvaT5oe" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c70ef340a02so384176a12.2 for ; Wed, 25 Feb 2026 08:33:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772037210; x=1772642010; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=ddQboShUAU4xr9xh3nmF5l6YT/z5QDVdd1na5dDuboI=; b=aQvaT5oeKBneak5dZK55Xjkd6uipPwP+wZMxa26YbYxz9RpGfh+S8bAN/Bt6+vgn9S +rizGvDhWk6R1Tcv1i1ZcxingN6o1OYT7tGpLc4fm1vReVz9pXPD+SZb8DR/+MwyZgHm 69PgZQ39FbTdhqRaB6o0r4eVSwX4SzXkcdWXCVIdYXNT8m3D1ua74dRLpCD4UZMwfWJO djI1MmQo/6d3H3MITYF/tHzBZ5L/B1ZqJh3jZq1F1lv1fifvhwYUajJ0I4RT0x3VT5RO W/ZksoS4VL9RxOM5BEk9xUCe0qTi3s1TsaAUv/5vdwfp4TfcvXbLVYdz8PJy72xhW3pa W2eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772037210; x=1772642010; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ddQboShUAU4xr9xh3nmF5l6YT/z5QDVdd1na5dDuboI=; b=fLH8bnbj22VPHiEG1Tq8Q7bh/i5REeK0kMWTF5cmDG2MZvceEQpvHtkjlImu5BXJKS 0G1Et/SSMBrcAak5C8AlWfuLwQGJAv/35xqX/G3BDiiQgRDwYce6l+4M8h/aF1ccNSr3 Cut+2PGysmccVTQXcip1f+EGAz6JM+UIYnuRONxaK9DUtpT7ZEQoWkujrtDQq3/bK2yu xb+Zf1ahEha7WYzvlgHFTlOZbRI/pycfODKdC8uNeenQtUeItd7OwoBAvdsOV7eufT3W LpF09slnOkq1DmfkunWFmSuUIsL3xYLE6WvA7FS9C5d808GOs9kcBgI0Yszz9FoFUSU3 R9kw== X-Gm-Message-State: AOJu0Yy3f2p9/vNxvyZ3aHRgyK7nkN1eMo9V2nnACiGGv/AeM7syd5A/ h+GLiR0MFyhKJ91VL0yxMDMtxqzd//YVhnIneyCgYR1deyqLDzCbrran X-Gm-Gg: ATEYQzxP/HZ5QlEYQ9ZeCru1FGioMW/E0x8B3CAsCDXtIxXWkNTb0H25mYj+oEeW/k9 Ih6X9Mf42o6Q1Qi/h4SFUU7zph6JRscQ8OlK6AmwrW60idS7ApYP99kmwFAme0qTp8dcojg44kh B605K4dH7zyfEdkD49up944pPT9xemEm7Tu6ieLs4j8/96jHGjWSud02aDPifSKINzEQ0gg/MET vkqJbXxR9oyy1HsL8Dg73787v7lsuAyH1T65p/WITUrW39uYkDyx7MwEr5hSNPnAkiLIeoqKcHi 1HUK7e/GNHazqieCVzF5y7UkcdOqFmuz/stAJYQcUTHQAlTGxyxPFn5lL44s/8FNt2AbiXfc9GU 59NMuD834h/DA12uByi8qAI5yCa0rMKVM8UgOhJ0NHHHeKc9+SewZf3SzrXArkx544iKmJH2jTH zXOvn/OIFWuMnlT+CjdYlCfQovrolprgcW1/xV X-Received: by 2002:a17:90b:4987:b0:339:ec9c:b275 with SMTP id 98e67ed59e1d1-358ae7e86a8mr15320596a91.6.1772037209583; Wed, 25 Feb 2026 08:33:29 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9009:3f2:55d9:d867:54ea:d951]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359037af167sm3335665a91.15.2026.02.25.08.33.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 08:33:29 -0800 (PST) From: Felix Gu Date: Thu, 26 Feb 2026 00:33:24 +0800 Subject: [PATCH] mailbox: mtk-vcp-mailbox: Fix the return value in mtk_vcp_mbox_xlate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260226-vcp-v1-1-766c5877017d@gmail.com> X-B4-Tracking: v=1; b=H4sIAFMkn2kC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDIyNT3bLkAl3jRAtTYxMTc6BgqhJQZUFRalpmBdiU6NjaWgDxwXc+VQA AAA== X-Change-ID: 20260225-vcp-3a853447202e To: Jassi Brar , Matthias Brugger , AngeloGioacchino Del Regno , Jjian Zhou , Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772037206; l=961; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=W+jP3zwPXvbN6VQlSiaHn6aD2hpSIbT32Oq/GSFkHGI=; b=A/kPlRCS6V2E+kcdMjDircq5UF5u5qvwoxlGCWmLXVI6bOhw4nyn1gIgaR/jjArtEVtu/mn28 cAgO0P9PlqYDVFsfrrdx5LSusYs0BjvWhrCnLB3brTGMgo5KtRrD2WK X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The return value of mtk_vcp_mbox_xlate() is checked by IS_ERR(), so return NULL is incorrect and could lead to a NULL pointer dereference. Fixes: b562abd95672 ("mailbox: mediatek: Add mtk-vcp-mailbox driver") Signed-off-by: Felix Gu --- drivers/mailbox/mtk-vcp-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/mtk-vcp-mailbox.c b/drivers/mailbox/mtk-vcp-ma= ilbox.c index cedad575528f..1b291b8ea15a 100644 --- a/drivers/mailbox/mtk-vcp-mailbox.c +++ b/drivers/mailbox/mtk-vcp-mailbox.c @@ -50,7 +50,7 @@ static struct mbox_chan *mtk_vcp_mbox_xlate(struct mbox_c= ontroller *mbox, const struct of_phandle_args *sp) { if (sp->args_count) - return NULL; + return ERR_PTR(-EINVAL); =20 return &mbox->chans[0]; } --- base-commit: 3ef088b0c5772a6f75634e54aa34f5fc0a2c041c change-id: 20260225-vcp-3a853447202e Best regards, --=20 Felix Gu