From nobody Tue Apr 7 17:15:30 2026 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F635313295 for ; Thu, 26 Feb 2026 13:11:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772111504; cv=none; b=hJNYBupM3pxi8uCvIAOA3JRtSNu1KVbd2j/F8oh57wJ4itdp0LtVyfjKsD3X47TKwGoQP7zSe6wOwHcc2ndbFFEhw82deQZ3sRYIB3uVDW8uUDXP+GJflRiOxLaA+W/WkoZ8QDdwweHhoZH0qb0jvSIEijwkVEKB96cdsWVLd3Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772111504; c=relaxed/simple; bh=dN8f41bDXLag1KExFhMc74SNVuHCSIm9nPSwzqJfuzA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rlELgXHIXQDaoR9z/VF5TerJQ04rUA5V0pucrq6Mi301lq1iYGhG6ujYuAzH5Y2P8VidXQAerkmUh9hGwJ16p0V7+wJ8lN9bRr6VL/dJ2qKycvmmj7WLdJHZspWjcq3kHzQaPUSGubXckJ3wNfKPU3vPy0/8i3DJ/AeR+1Kbwa8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UXlzJYkb; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UXlzJYkb" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-65a2fea1a1eso3121662a12.0 for ; Thu, 26 Feb 2026 05:11:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772111500; x=1772716300; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ELA1QB+7rfEMiXDUeYSPxVC8r4onmGwJXoRsl094MSo=; b=UXlzJYkb+u8ztZa2t9jj4bEuALmwysSjAcEXqGby6LKrZiNp4AXo7brDlZhkmDhYoY jJyOJREbj6+k23EGXNHMB0lE7uqZrUz4QYTqrC4mDFbBSpf4bvshEkrXomrocvWOzuzA /qWrQ8vO4IBjTMHXlr37M7lBg9UhszB43in6Ptu3x29bnUVslSPCxRE90Xr/CXZ9G2zF tiK5u+/VdIOYPhmQL+RGgC4ku7hfsJ2uZZNGCl4EtYtuiHHzjpvz8Ex0C132pM95fMxa OETDkpuSPrb/m7aBXt+G+F4mTpuxeYYn1AWn7qUlPF9vI2P1lYdhTMijzwWIBpqddhgu gZqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772111500; x=1772716300; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ELA1QB+7rfEMiXDUeYSPxVC8r4onmGwJXoRsl094MSo=; b=ZSQtgSwpvNGlVpu7QhqyEXgdjMOamUulyjZFeAfULOTmU2ExP1KIG2pMz7PmQa27+X BRNstH3bNZuEy2cRMPPjrFtedrlwapcWRKg2/k2IgJ49DapvS9FddHJyA9rxYx5tlOx/ ir5NVxE/x87zBlmUf1uNHHOaYNP+t7UOjAUdXwMgSjUh+u9q0tysOLJ41gCV4Jue4+9k q2U2GFpexH36i90ZLeWdquoytdKDEX+n+hD/tM4g7M4N8kUkNNSO/qR3nEztjO5vB+KK VYlu0SgF720i2u/5ytBpauOsfCpLVYEhEqqkqPzEUccTXSZ8KtJ/18JLoSFto1eCxzlg PUQA== X-Forwarded-Encrypted: i=1; AJvYcCV2NO0NPlmtTDtxEj9ghxOMurVIPxJz2cLP2GFYuCkl/Sw1zG+xJbkXHIqKSWnzWk6v7Gsb51YHf0aUUZw=@vger.kernel.org X-Gm-Message-State: AOJu0YyFxaO3fob4ejTyKOqEUALerjvj0yD1ag8IlJHUDezr1Kyo5g8S AVhyTdj4K3ziApMhu4Wm1euBCy55D+m4MtzYn5CwOLLpY6ZcJUb9aUahRcjcfAXha1c= X-Gm-Gg: ATEYQzx7+/y0xr1n0H5bgO+tWzgIy07XIpuERfNqXc4A0ZexP8VCukcsV46Mp7AXAcF gfo5aJhmrZM+l9no1n5r7bZIf1aTDWhBChU9FFq7O+a5gXuUFXaMIbi7DnuUNgArzaIeB/HA644 lZHgFMQst3rkV6tKBg7sldK/d3W5iFSTrRWF7oGAHRQyj5LO95ih4sOS09UBQs3lxS2PlHFGUsf BJ/Gp4/QhVRdF1GaFl1dMkIrTLNw1ZNyxBzrf1/Avw0POZj0bUyZbyUnNylevEhf76WTMwkprLP iJg3AXNa7Z/aura0CGusrQszZpS7qfxDUU/E+Xq6TqhH4FwyaMbvSdX2HVQg9/VedxRjKFBMwhq TZHZAl+6wlU9JQC12vQSiz3jbZp42K+NTPY5Y8Drdb4l6576iQP+GNkKZUAm7X64f3lp0w+Nx6T sDIyegJK5ffxtC7rfBilOWB2S8EHVyf3x91GWuXf9Mj2uRLwAoUDtQZXiq9KeQfdV3yRkLvG7ok 8xFpKMt6ovagZs4Jw== X-Received: by 2002:a17:907:cd07:b0:b8f:c684:db37 with SMTP id a640c23a62f3a-b9356f47682mr164714966b.9.1772111500272; Thu, 26 Feb 2026 05:11:40 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935ac73d2asm55125866b.26.2026.02.26.05.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 05:11:39 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Thu, 26 Feb 2026 13:11:39 +0000 Subject: [PATCH 05/11] power: supply: max17042: use dev_err_probe() where appropriate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260226-max77759-fg-v1-5-ff0a08a70a9f@linaro.org> References: <20260226-max77759-fg-v1-0-ff0a08a70a9f@linaro.org> In-Reply-To: <20260226-max77759-fg-v1-0-ff0a08a70a9f@linaro.org> To: Hans de Goede , Krzysztof Kozlowski , Marek Szyprowski , Sebastian Krzyszkowiak , Purism Kernel Team , Sebastian Reichel , Rob Herring , Conor Dooley Cc: Peter Griffin , Tudor Ambarus , Juan Yescas , Amit Sunil Dhamne , kernel-team@android.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.3 dev_err_probe() exists to simplify code, harmonise error messages, and set the deferred probe reason if relevant - there's no reason not to use it here. Signed-off-by: Andr=C3=A9 Draszik --- drivers/power/supply/max17042_battery.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply= /max17042_battery.c index 07759d4fdc37..b9277f81a25d 100644 --- a/drivers/power/supply/max17042_battery.c +++ b/drivers/power/supply/max17042_battery.c @@ -1053,16 +1053,14 @@ static int max17042_probe(struct i2c_client *client= , struct device *dev, int irq chip->dev =3D dev; chip->chip_type =3D chip_type; chip->regmap =3D devm_regmap_init_i2c(client, &max17042_regmap_config); - if (IS_ERR(chip->regmap)) { - dev_err(dev, "Failed to initialize regmap\n"); - return -EINVAL; - } + if (IS_ERR(chip->regmap)) + return dev_err_probe(dev, PTR_ERR(chip->regmap), + "Failed to initialize regmap\n"); =20 chip->pdata =3D max17042_get_pdata(chip); - if (!chip->pdata) { - dev_err(dev, "no platform data provided\n"); - return -EINVAL; - } + if (!chip->pdata) + return dev_err_probe(dev, -EINVAL, + "no platform data provided\n"); =20 dev_set_drvdata(dev, chip); psy_cfg.drv_data =3D chip; @@ -1090,10 +1088,9 @@ static int max17042_probe(struct i2c_client *client,= struct device *dev, int irq =20 chip->battery =3D devm_power_supply_register(dev, max17042_desc, &psy_cfg); - if (IS_ERR(chip->battery)) { - dev_err(dev, "failed: power supply register\n"); - return PTR_ERR(chip->battery); - } + if (IS_ERR(chip->battery)) + return dev_err_probe(dev, PTR_ERR(chip->battery), + "failed: power supply register\n"); =20 if (irq) { unsigned int flags =3D IRQF_ONESHOT | IRQF_SHARED | IRQF_PROBE_SHARED; --=20 2.53.0.414.gf7e9f6c205-goog