From nobody Tue Apr 7 17:47:43 2026 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF4EE33032D for ; Thu, 26 Feb 2026 13:11:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772111509; cv=none; b=HH7ffjNtsJygeqn55GlAHClj6InaNaduvUdhXlXStZKSnklCMzDoq5/Syy/+pXyH8F6tCLvehcBRS8NaAl+YKKjdVb1S/86lwAktIsILIIaQn/8ra0NRcErcBJYauGPD00XsRj+xJ/5mqsb0pDfmU2taVtI/bRwk2uModkTP7nE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772111509; c=relaxed/simple; bh=GPfoLWJNaZbAuE5sFY9vCrczQONk3K2jd0EZPiGevHY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fstRBXa6m7FBFy1PHQk0LcHNgxpVpGDXGhmzJHRxmyJpF6aOUZKQ35gQY7EkwKCY6HZeWMhxHt20+dXiQZE5tFNHLS7sOhgAhds89CblEKOwcueKNX8O5GtCrLCGWmF3OpEbIbwOLXrliWxD0pK1hU9a9SsaSqjGxGsMJTcFkIw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NC1n05GK; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NC1n05GK" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-b8f97c626aaso142227266b.2 for ; Thu, 26 Feb 2026 05:11:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772111504; x=1772716304; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+jqX19aDR1PCz0IO4VxlMpvKqSC9cfQfLdsBYQBVkyw=; b=NC1n05GKgRjeMqSAMaNptOEI6JpKCDmRZk+++IUELVZhgu6xsz8PKIQOYsYTLt3u5Q oalbvFnMkJCtI4sodKBCGvi7st/Xkoff01cXo6vqIxs//Aqq3XayCUkAm6jhTv3ZjF0y Iw1su11pyePz3Kyt5l4buZtFZ5uhIR2JVElQK8rUGzwHGSltnGtCBJLPf0viBnDie7QZ hzHUb3pqs2WVCkUVo0jwP7HokXeUn+Jwm+5nW1+MQawyt+7pYECSr2SqiMCHkYd5Xn7a 7iHNhe3JqqVy0bj6qZ+RgIjXyiP6ki6WYt473y9D1mnxZBF80lb9cws5Hc6Mjv3TU+uT IEZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772111504; x=1772716304; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+jqX19aDR1PCz0IO4VxlMpvKqSC9cfQfLdsBYQBVkyw=; b=C/U6QCXQy9L5nA4xpHu2AUfh41Qubr58FY4PnZv/LXV9w/FiPrURVpl2BgZSTfgnH/ pAAQrAOtqLEwggZYE8+FioYwdIUv9Ogg3WUOjFQmC+cIThrmE7G+xV0HTajKeJPQ3YHN PkpsQAOEEYnbjHjxTqL9OB7/k5a2E1gnhOkeworfiPt5qDYDzgwq65VbD04insGYJIrr E3U2PlmxYbnj9PT4W3xCayse1UXASfTy1fKVjZjiDkkcsvavfs5Qt6Rrlk5Et/WApQFg jhk4NOvjCwJ83kgbx3tzq75FUF9YvL2KE6AZ9aSj+4dHHgYmRKYtu/uxr/FAFaIQZ5Su DvnA== X-Forwarded-Encrypted: i=1; AJvYcCXEHVGFNMYLOJt+I0TW4cOKDT6EXENHAIjFT0NOItQ/jk2YUwIRI6eRAkjYiXpiOy6pHULXLLvxyW1jPQw=@vger.kernel.org X-Gm-Message-State: AOJu0YwLt/qYXXgwt/BSEyxnkYlA5QGiV0SyPsbCn7ZzaywTOaVJ+hQL VjzU+yplhH2cGfWe62oWURxEAuH9t63eE0oRu2GmG6Vu1dcgjsE/w1KJwxpm0K0D8Dc= X-Gm-Gg: ATEYQzzYLrHpyqTzCBQxKGLdnZZIH8MspHfMBfdhShPKJnK0Z23tehsH5mMnApjnvPw Uw13Tm+k2FOf1CNwQ5PJ5rpiv5X4pIEBpK5w80Pf+GzlQdXEIleW9H51WIxVw9vSbEK+CrgiWWy iTzypUl4/hZFUZ8rQ3zqzgChtYpyg73gt0lVrnqCG4vj/qipmjShanhAzj3ejeVi2CSUggsYJim wMxXJKgJ+6NiOoz+Va5+hwn4gu7z8Yi9erN7Z+/zmsaRWTKpIkBAZiVDWQFBmnSwx5rcpOOGyP2 UMW0e/dZNVeb4gdlHOXbty6X7HrUmtJU19YUWivv9CUZCGG0PEba7R0FnruyLYkiG/vZWJvog1v B3OQjU3KFj42Y78zdHmzetaDAdxH/7wlcv/z6MxgW76V0cjikOp/CIoYEfUJX+MVX0qzs6jIXdp /0arYYntlGu7usRgg3J0EAbTQqhVy6Kvm/AHDojYTkijSG1DNDnYYnlUfdMuPpoUMYXEpgv4s2h eX1whHYKr68Zr+atw== X-Received: by 2002:a17:907:9445:b0:b93:60a3:8a47 with SMTP id a640c23a62f3a-b9360a38b06mr95155166b.45.1772111504172; Thu, 26 Feb 2026 05:11:44 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935ac73d2asm55125866b.26.2026.02.26.05.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 05:11:43 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Thu, 26 Feb 2026 13:11:44 +0000 Subject: [PATCH 10/11] power: supply: max17042: max17042: consider task period (max77759) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260226-max77759-fg-v1-10-ff0a08a70a9f@linaro.org> References: <20260226-max77759-fg-v1-0-ff0a08a70a9f@linaro.org> In-Reply-To: <20260226-max77759-fg-v1-0-ff0a08a70a9f@linaro.org> To: Hans de Goede , Krzysztof Kozlowski , Marek Szyprowski , Sebastian Krzyszkowiak , Purism Kernel Team , Sebastian Reichel , Rob Herring , Conor Dooley Cc: Peter Griffin , Tudor Ambarus , Juan Yescas , Amit Sunil Dhamne , kernel-team@android.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.3 Several (register) values reported by the fuel gauge depend on its internal task period and it needs to be taken into account when calculating results. All relevant example formulas in the data sheet assume the default task period (of 5760) and final results need to be adjusted based on the task period in effect. Update the code as and where necessary. Signed-off-by: Andr=C3=A9 Draszik --- While I do believe this should apply to all devices supported by this driver, given the register description in max17042_battery.h, I've made this change specific to max77759, as I have no way to confirm this works as expected on those. I've found a data sheet for max17047/max17050 online, which does describe the relevant register 0x3c as 'reserved'. --- drivers/power/supply/max17042_battery.c | 20 ++++++++++++++++++++ include/linux/power/max17042_battery.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply= /max17042_battery.c index 44626abdab34..89909b140cf9 100644 --- a/drivers/power/supply/max17042_battery.c +++ b/drivers/power/supply/max17042_battery.c @@ -61,6 +61,7 @@ struct max17042_chip { struct work_struct work; int init_complete; int irq; + int task_period; }; =20 static enum power_supply_property max17042_battery_props[] =3D { @@ -335,6 +336,8 @@ static int max17042_get_property(struct power_supply *p= sy, return ret; =20 data64 =3D data * 5000000ll; + data64 *=3D chip->task_period; + do_div(data64, MAX17042_DEFAULT_TASK_PERIOD); do_div(data64, chip->pdata->r_sns); val->intval =3D data64; break; @@ -344,6 +347,8 @@ static int max17042_get_property(struct power_supply *p= sy, return ret; =20 data64 =3D data * 5000000ll; + data64 *=3D chip->task_period; + do_div(data64, MAX17042_DEFAULT_TASK_PERIOD); do_div(data64, chip->pdata->r_sns); val->intval =3D data64; break; @@ -353,6 +358,8 @@ static int max17042_get_property(struct power_supply *p= sy, return ret; =20 data64 =3D data * 5000000ll; + data64 *=3D chip->task_period; + do_div(data64, MAX17042_DEFAULT_TASK_PERIOD); do_div(data64, chip->pdata->r_sns); val->intval =3D data64; break; @@ -362,6 +369,8 @@ static int max17042_get_property(struct power_supply *p= sy, return ret; =20 data64 =3D sign_extend64(data, 15) * 5000000ll; + data64 *=3D chip->task_period; + data64 =3D div_s64(data64, MAX17042_DEFAULT_TASK_PERIOD); val->intval =3D div_s64(data64, chip->pdata->r_sns); break; case POWER_SUPPLY_PROP_TEMP: @@ -1146,6 +1155,17 @@ static int max17042_probe(struct i2c_client *client,= struct device *dev, int irq regmap_write(chip->regmap, MAX17042_LearnCFG, 0x0007); } =20 + chip->task_period =3D MAX17042_DEFAULT_TASK_PERIOD; + if (chip->chip_type =3D=3D MAXIM_DEVICE_TYPE_MAX77759) { + ret =3D regmap_read(chip->regmap, MAX17042_TaskPeriod, &val); + if (ret) + return dev_err_probe(dev, ret, + "failed to read task period\n"); + chip->task_period =3D val; + } + dev_dbg(dev, "task period: %#.4x (%d)\n", chip->task_period, + chip->task_period); + chip->battery =3D devm_power_supply_register(dev, max17042_desc, &psy_cfg); if (IS_ERR(chip->battery)) diff --git a/include/linux/power/max17042_battery.h b/include/linux/power/m= ax17042_battery.h index 76b85ad3cf48..c82043414c88 100644 --- a/include/linux/power/max17042_battery.h +++ b/include/linux/power/max17042_battery.h @@ -17,6 +17,7 @@ #define MAX17042_DEFAULT_VMAX (4500) /* LiHV cell max */ #define MAX17042_DEFAULT_TEMP_MIN (0) /* For sys without temp sensor */ #define MAX17042_DEFAULT_TEMP_MAX (700) /* 70 degrees Celcius */ +#define MAX17042_DEFAULT_TASK_PERIOD (5760) =20 /* Consider RepCap which is less then 10 units below FullCAP full */ #define MAX17042_FULL_THRESHOLD 10 --=20 2.53.0.414.gf7e9f6c205-goog