From nobody Tue Apr 7 12:38:52 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EC3D3A0EBC for ; Thu, 26 Feb 2026 09:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772099809; cv=none; b=t0NmbWtUuhlq7UJVX1OJWhXoD+6A5cORQKRMR/X4MZkCtRaR9ntbm9+mYJGQkM1BBMIfBWIqwwG42Et1148l1NiW5pDFJjqjdx1er2lUolWOaDja1eT3E7o+NI7ZnPvbuVK4K7ibQ/I2BBx5x344wRagTAyWcLdB/9SnnNFY2V8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772099809; c=relaxed/simple; bh=kItaKAqyxjdvGZtBXO3UKNJA2wkkDFA5lJJiBNSJYJg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=H7carcmY95OHWHQBCVzlqSYyQG5Vv6b1g4QqEhTUwL7YlWSzwzn1PbR54AVPNte+Sxvubt41el6bFuSSXr86k3+z59BSIhtETFLZsmywkMfKucliXx/LELSN4rpQVIxGuPkFQlrPLs+bEfvWg3mDqp9pdnFGnuSZN+OOZglqww8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AQOHqq+H; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fg7u/eB1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AQOHqq+H"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fg7u/eB1" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61Q4V8BV918920 for ; Thu, 26 Feb 2026 09:56:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=B/JzSCAM22A18oBaej0zWP 9dP40bO9wNTPlDvXSSlGw=; b=AQOHqq+Hm8bZ6Xlpyyxj9IACVBM4R2qLUWDl6l o/1yd6D+ZsHNdRWdvjgEtWYkz1nqEBrorNQ0LL2aKQkEQJW/SB/5gKmwK7+mlc5t ESgycFiaFZ906lauHCmn0YFL15guTpMFfHvyuEbqlF+R+0NccFX25K6xFXYxtIdJ JysS6HeoiW8pNLtOuEsE+53m1zIv2Mb+OhhdopNwEIj0WJpTvEGuxIf3MswWVaR5 JEDLLJ4gKDWTI5p6k/+81cf4UEbpNNwO76oBzAiqOqIS3z6sjvVMrDygMUBHt3Yb mEfwn2wt+M1f/c29cv8H+y/bpK0KlhzIhik1oOQ0AbU5E8pQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cj4w4tt90-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 26 Feb 2026 09:56:44 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-896f84e69b6so110031776d6.0 for ; Thu, 26 Feb 2026 01:56:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772099804; x=1772704604; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=B/JzSCAM22A18oBaej0zWP9dP40bO9wNTPlDvXSSlGw=; b=fg7u/eB1vSjQm/pLFcF7w7Ldx8VJmkGmoOc7ZFYEbL3y3ZeYwsuUdgn5chQFVLKDTE nle9W+X0F5sikgFQph/tSE7cH5GrH4OElQYA8gZobWhm7sy0HmjrW6/dv8uJwHXU8bRC qPz7vEDwYjyUJH+JSPss7f2S6un1LXzGdNvKKz0wlZS+EP7GvH8kJis1eFtdmzcgNmAv jWL88PcSCzstBxS7eCHbnSpnIvHxSxIU1aTtnMSdfgIhZAwASO33WFgeAnFWODFIMFxb VVvUWFiJnXS5oNMdPM+6E19/cP5QmRQ9eqgg/AGEPSCgZvOtw91DwznFo+qXBmC++csn Sf0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772099804; x=1772704604; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B/JzSCAM22A18oBaej0zWP9dP40bO9wNTPlDvXSSlGw=; b=suVzDZIkT++MfnNf5e4swcVwPwH+VTjdRjpG1LgLRO1ZKL9WLrBSovHnDEUV4TQafp sk+3bhqJYJRqV69Q+uAbN6rPv4JglPni5iQ1DJR28hmbdJrotIZxMYnERHShjJEt0h3S RtzZ+49J1VlmI7uhDs3sPF/oDseUO8fd+GqpTTommNdAf4LECsPu9mq3P3heN4L6pyDf N90CMIMwbAIFRKWTKzfRhN/Tiifxz4bITOX6yQs8Fj6ZCPKc7JuVwDePnumbxMlg4Qe8 kQmvd86N17UPmvC2LuVvzpGAO81qk+zYQGZrFdYOtRd4UHTqK6ECffJaS7taCziGaTPm VKTQ== X-Forwarded-Encrypted: i=1; AJvYcCXvXdZyCPFPInapRpqUh6/g8f0OGzufmOa+xkg8wDZ19+WY6/IO5myrV6EmvYRAoAvV7EJlgoYImse0ftk=@vger.kernel.org X-Gm-Message-State: AOJu0YysDw72uppu9Mw9ib1Tv99C2IhVfg5GvYc7i+NoWXuOlFx74MKR f4Euddow10pAfUqahdm5C7jNmaHctHTbSOWkjL9FQAuVrAiJNBhFHx697MtnRI55EVBzIacODcg TfBxsb+oShkn3rpfef3R2CKpODnbCSUYF8hL1i8sHrRajCMW6HtWXxrja66GADUU57ow= X-Gm-Gg: ATEYQzyK4Gqq9c72eFj79Xey3ZG5T6+Hy79BTs/Jz4ecMxo39VDPtHW587UYC7mHreE delOmJ+DX1Jjl573Boxs8/sRgRZohaM/me5B8jX8VqF4Htx1Wl7Am+5n7UIJbAhCb6FiYRcmgKY rzwr6UKVHANw17g2wpmfam+TN+pBTPXznvPQhnsy6veki4Z5KLlO/2nEAG8VsO0788vFlLZkVMF phTHNa97Q7CqqmrHmaH4ekhlZFB0J1W0vLQgux9Kk2MD6ECjdp6mwnV/kXdsTV8VuP3LO85p0lQ 0b+L4rX6vIvCU2Gi2FWJQUGAi8M7pk54NjVbzFGqY5GFMojSxk2YnybNjCJgAAl9/qJG7z02zeS mo+p/mcm5W3BFdFjT1C2bflZJ9viD+SJ9gNFXxjsBJLQPwfC7Zm8= X-Received: by 2002:a05:620a:19a1:b0:8ca:ffe3:33a3 with SMTP id af79cd13be357-8cbbcdee7a6mr464044185a.0.1772099804265; Thu, 26 Feb 2026 01:56:44 -0800 (PST) X-Received: by 2002:a05:620a:19a1:b0:8ca:ffe3:33a3 with SMTP id af79cd13be357-8cbbcdee7a6mr464041185a.0.1772099803749; Thu, 26 Feb 2026 01:56:43 -0800 (PST) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:961d:5276:3187:97af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd75dfaasm114555355e9.12.2026.02.26.01.56.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 01:56:43 -0800 (PST) From: Bartosz Golaszewski Date: Thu, 26 Feb 2026 10:56:36 +0100 Subject: [PATCH v4] gpiolib: match secondary fwnode too in gpio_device_find_by_fwnode() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260226-device-match-secondary-fwnode-v4-1-27bd0cfbd8c6@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIANMYoGkC/43NTQrCMBAF4KtI1o7kv9aV9xAXcTLagG000Wopv bvRlQtFNwNveHxvZJlSoMxWs5El6kMOsStBz2cMG9cdCIIvmUkuLZeiBl9KSNC6CzaQCWPnXRp gf+uiJ9CIwipCXRGxYpwS7cP95W+2JTchX2IaXnO9eH7/lXsBHJzVtPS6MnqH65jz4nx1R4xtu yiHPQd6+YZK9QuVBa2tRc6xJqLdF1S9o+YXqkCAq4SR3GihjPuATtP0ACzu92d7AQAA X-Change-ID: 20260219-device-match-secondary-fwnode-4cc163ec47ee To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown Cc: driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@kernel.org, linux-acpi@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2534; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=kItaKAqyxjdvGZtBXO3UKNJA2wkkDFA5lJJiBNSJYJg=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpoBjVuYrsaIA4liDr72biMiWiwhj3FioVCfPax k5Fj9gLfQaJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaaAY1QAKCRAFnS7L/zaE w1aIEACC8eLH11eTqfdYIXHAIFmnXDcFGpxvziZdR8E0LModLvOxjY1VciCd5ihIlA6DHfFHTlH ZpiX+ZaFKOMXoWB/ks4mbt0VQ0C8G+aodw7TZe81C+k+a5NPI4rE1wWUS6RDcIrC605gRdPqKcN IG/xwy/DAHOGSM7h6XUXo5ZkltnrjkE+YJeTl8UWtFqG6MpVT1EPTN6VkDKSvY6OPrs6wbWhicS DNDAJ78+VXmvzzAaTYb2+el2C/eosZGNGbEIj1bYszAuV+il2sMoGbhJcyI7prh5nxZ7tDvrOve 9SEtVjyP0xTtK5vHtoDEg5zHtLuc31ZFD7Qfjyo1zseeUvUp6SPuAH+tCHst3v+FLajgJyn6g0U rA1XcA4pT7qRy0h3aZu7uZO9MeJQ0es52O3gomVZnxTPCre+DRcjHoYXuGyh4GbOqLXlVGs2XpK q5gJvQOR8ZNsLTXn5Sq+SmpPQdytWIf4d7lhBFy10C9TM9P7sonjNakgSWiVqVQkmCEPjFGaGZX tLuCgdKT02BlCJ1JfNllnNqTRITJXJEryfj8n0U0ab3b7BbZEgvcIfZWlp2YHRiyvyY78cliGJT 2HWMxAxrVRr+8OO62Thg85kNqLOsaILB5738KnnMatqh+L4pYjs2kpo1/LSzOFuvYFbO4z/W+Zu 830xOemrGD7BLOQ== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-ORIG-GUID: q13L0g520x7MKyLCIrtZ_lTERq8QSVZ9 X-Authority-Analysis: v=2.4 cv=IqMTsb/g c=1 sm=1 tr=0 ts=69a018dc cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=1XWaLZrsAAAA:8 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=GosmCm27k2yXtJg_9XwA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI2MDA4OSBTYWx0ZWRfX94AhJ/M4pbxW GslY1+zZPSoZDNZ4NAknrRJdF2/2GogCr4Xb0B+qLGMUM+kYzwkV1fKYNkaEQgWktcbzeEqdfn3 9BroBuumPsEjeNZA5ie+L/wmuJ3JsbNR43dibNmqdu3s8sD+aOIaGvjbOI6aCFfqr3pI3af18KA gZP2JqVRjlVZst1f7fKbM2NszMK+RLIv/28eNihl6YmfnG8+G4R5kIJnVog9KYnMazRYbiCxkAa FJusJnw8BfN9UuXUErI7EiC/pU5MItlhGs6iM3jfuyHh1qRTEqcFTFh9Q0A+RDedeUr7CHlm8gY k/fmCKNqUTWu+qBO/IKPBlR8PEJIVDJ4198aAkaozqMWiT1Gbpfg1FVpD7tWRdBE4t6BJPou7Ob 2JMTbNl0g9OLyqOdfV+nSIFUV4QTA/WJUisHfA18m/kN31xus+YGFuoApfn/D6d9Exr7cq3iOHz K/uNrLJVyqZJbZzdBVQ== X-Proofpoint-GUID: q13L0g520x7MKyLCIrtZ_lTERq8QSVZ9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_04,2026-02-25_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 adultscore=0 impostorscore=0 spamscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602260089 In GPIOLIB, during fwnode lookup, after having resolved the consumer's reference to a specific fwnode, we only match it against the primary node of the controllers. Let's extend that to also the secondary node by reworking gpio_chip_match_by_fwnode() Suggested-by: Dmitry Torokhov Reviewed-by: Danilo Krummrich Reviewed-by: Rafael J. Wysocki (Intel) Reviewed-by: Linus Walleij Signed-off-by: Bartosz Golaszewski Reviewed-by: Sakari Ailus --- Link: https://lore.kernel.org/all/aZUIFiOYt6GOlDQx@google.com/ --- Changes in v4: - Drop redundant !IS_ERR(node->secondary) check - Link to v3: https://patch.msgid.link/20260225-device-match-secondary-fwno= de-v3-1-a7152054135a@oss.qualcomm.com Changes in v3: - Remove the controversial patch 1/2 in favor of hand-coding its functionality in patch 2/2 - Link to v2: https://patch.msgid.link/20260223-device-match-secondary-fwno= de-v2-0-966c00c9eeeb@oss.qualcomm.com Changes in v2: - Fold the code initially put into driver code into GPIOLIB as advised by Rafael - Rework the logic as suggested by Andy - To that end: make fwnode_is_primary() public - Link to v1: https://patch.msgid.link/20260219-device-match-secondary-fwno= de-v1-0-a64e8d4754bc@oss.qualcomm.com --- drivers/gpio/gpiolib.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index c52200eaaaff82b12f22dd1ee8459bdd8ec10d81..780e30a033859578dabe3eda984= e74db200507f7 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -1395,7 +1396,16 @@ EXPORT_SYMBOL_GPL(gpio_device_find_by_label); =20 static int gpio_chip_match_by_fwnode(struct gpio_chip *gc, const void *fwn= ode) { - return device_match_fwnode(&gc->gpiodev->dev, fwnode); + struct device *dev =3D &gc->gpiodev->dev; + struct fwnode_handle *node =3D dev_fwnode(dev); + + if (IS_ERR(fwnode)) + return 0; + + if (device_match_fwnode(dev, fwnode)) + return 1; + + return node && node->secondary =3D=3D fwnode; } =20 /** --- base-commit: 50f68cc7be0a2cbf54d8f6aaf17df32fb01acc3f change-id: 20260219-device-match-secondary-fwnode-4cc163ec47ee Best regards, --=20 Bartosz Golaszewski