From nobody Tue Apr 7 15:27:24 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010062.outbound.protection.outlook.com [52.101.56.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B8C63644DB; Thu, 26 Feb 2026 11:46:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106411; cv=fail; b=mWzH1uge+rvkzG2zrLjYXAiBrF66KAZC6YSLREbgFH6B7q4VJDhyEcPn262l0tp0b3DBt7QrNRg8d45ICXpFOdvHeeyyS8PG5uLRqm7ZJwwnSJjW+vBHqQ1N50HbjfrJbfKZSCBvoCO/0hsizn5OVfpg4z1QoEVEjuz6aBViNGo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106411; c=relaxed/simple; bh=lkOr3PqHOZQRe53fKYGGKhYAkA3COG0a1hRb8KLJ2DQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=WRqVoiNznOJUusiUCvqG+xu4lIbvqv510IswNyU3IfDfj+3NQjjWVCbjEDg7ZrB8gUHJpsTW4ROYOui9W1Snu+7LNk36qGGNZPFSN7CBAHsOZoopkIAv8Y8/pD4NgQLAlyHU4M/T9HLqo56I8s9t9XKtuYk4EZdoTVs8epnLx3M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=U85loN84; arc=fail smtp.client-ip=52.101.56.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="U85loN84" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O1+rfEAaSjL//SOyE5C/kDYd047uUdEIIcwBBn1Rr0zEUNTDsMSNgCUCvlwrXev82VaSxHCfVz1oW6/+ClJtGmk4PyN4sOF1kPpoAnBYX1oVp00kv2TxpfDm4sdTDQCUs2B9qiVDvZgRn3i5BRtGzPwCkGHJI40nQH7iX7RblccIaPdp3uxRQ0O/nIGrvymdP4s96A1lcG/dHs4oG0i50THqdRDLSOs7LSiJoalyj09VkjXVztamlPbTUT66QAPr4chQtZIvouTFCyoKzRY2vNpfZeYSk0JTYIKvsDuHwHiEuQ3WbNfZa8wCbdU7iRJNstupMyYg1hpqXmtDSxJOSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RlV2elmORmaHKw7bZCVBzJCNQE8R07ffJJ9cr27FbKM=; b=gipHNlUYHg9aWKJ6pOrsomZAy0mEvwWcmL9yxCAyXA8LF7utMCpZk7BjpD+Rb/YP1w6vd55KZeG4P+q534vENJ5uQdDcCpnuW7B7rpDYSf1OBvS2vG171xuxx/UvWfdSIHWX28rfbhYgBSX04C/0eV/Bi3RP9A30CnAl9PjVS+matlEBZK3A1PyW0eSZDmSls6e4oCRVla8frloc4hD6s90nDdkdnlDASTWgaZxw2gvuUYQM47e2p1pSc9BOh7RXRraSlZgVQpZXA5WxPkprmhUapgXKDLvwE+z5GRwSJByI0H52ar4nE0CsIZ0/sqbCBrjrutNhmq/8aJDy5diW8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RlV2elmORmaHKw7bZCVBzJCNQE8R07ffJJ9cr27FbKM=; b=U85loN84xByGcRuF4r21iG/Uo8lN9GKXKGP4M6KbTG/NMYGxQxusuH4QnLPA2ZhctWK/Rc9XDLCNKwXgHI1pCalvkFfux4ZGdE8Evapd88y4e/WOA2OmO4JkNkuVqwoEb1GlDaCDSIzMRnAieJsVNh8x2h/DyXikL5kNG+jOG/bIAKhHx6nlVizUX0DvpNBJ82ZMjIPv+CwORUIzDq+H8Vw/XTXQo60uvAYBL3sIqM21wsoHfFHCRukIFnd0wdEsPO8qdOvL8FeQAJi9OA8DvAGcst+uI6fY4sNieTqY3oBixtIqEAoQ1ZHHu/ymKA4jaf0YiEW7JQnJK+VE1H10ew== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB7112.namprd12.prod.outlook.com (2603:10b6:510:22c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.20; Thu, 26 Feb 2026 11:46:46 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.007; Thu, 26 Feb 2026 11:46:45 +0000 From: Eliot Courtney Date: Thu, 26 Feb 2026 20:45:33 +0900 Subject: [PATCH v3 1/9] gpu: nova-core: gsp: sort MsgFunction variants alphabetically Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260226-cmdq-continuation-v3-1-572ab9916766@nvidia.com> References: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> In-Reply-To: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney , Zhi Wang X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCPR01CA0059.jpnprd01.prod.outlook.com (2603:1096:405:2::23) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB7112:EE_ X-MS-Office365-Filtering-Correlation-Id: 689c7b0e-3830-47d0-aeae-08de752cb775 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: GQHFo21pQshG0734nlKa1dGdZj2uXsbMteb4PgWJnE+oW0DcwndP1ZkPtPk55+FwArHOOKPx+EDuSMisqVfFFJVv3gn0Imz8aRPi0KNMHI5mFFTRDHDOXRuSo2Z6VTRBExm/QOoaYvWFwJnu4PE0h+BYQcG6hmUrIwMnxuNhxscACtucJs0qz5eOkTeWW/qMvzmAW9x1nq1tIUVc6t57UjY7F8N3MFVP/m4ToteYnQW5TxnZZokAeB0Mz9LV9Et29AEUl6cDefMM4W5TYA8ZRzNeP93KtS7fGBgSsM+8voJ5b0J1uPb9DwCwRJF+vXaRZ4ASxdH+1+0nrj69GPCC5gXNnSaTQ5OiWIvfgmxqzJRHXeSdGoUnwOlXOz25QJ0gguvZJDI0EXonVMVm5W4tCFlJPyWcQat8fgID/wkqR+kvaBQiJeFr2V8ObS76E7MMqnEhWdAJh9Ompzfnt/h9gYYo2f9d9dabDst46jK7rkg0e8N6Ksk70wDldpNWcfBXMg1nJV0ZW7TrxHHXTIiu9XFNIbJB4rhYaEKyG7x6IVsyn7zRljnXPR5Qlk5auGFIsy9omp2oyB8tVuUBvC/AMx9XGy1fxjhTaKGywj9fChQI836H4aj1C7MEa/VknFY463F/Coz0bwjVFI1VR8T4DN5hJB5bwZQGGcPKwliTzk+vm/9umnR/Z2jkme9b4cDxDp2IYOq1AWBCwe6JYA/H8UbaMAZBYR41MEVVsNuKiNRrl11KAKxZn/94k5xxQhFvnhqE4mNUVtR7HU64Tmaoww== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEVRZ0k4bkE2SktBejhKOEF0OWNZNnhtMDFVOXVZTnFYcW5iM1V2T3czRmVv?= =?utf-8?B?NEdxU0xhbFdlU0kyQk11UHdyY1R1Z0VQZXh6dzl5enNCazA2elc2Y1JvVUxI?= =?utf-8?B?OWczRlJYUTFwUXJaZytLeXVFV3FRbmx6VFZ2R1BkWmsxdXk2R3h4QjJsUjVq?= =?utf-8?B?UkJiOXVOeDhZZGszVm9kRG02L0NmY1lwYWRlSEpBbE1vc3hzd3RwblJ3UTh0?= =?utf-8?B?VEhXRi84a1Z3U21mT0lyd1hsQnovUjQvRVU1RWVZVEdKazA4N2hhRWpHSjFx?= =?utf-8?B?M3RTS3FVRFkvVDNNQ0VCT1dHc1hRd2RrTTJGbkZVbDVxRG80MjFnN2lXeGVo?= =?utf-8?B?ZUdlSVViSzI5UURyd1BqeWx3cnVFMnFMcytRbTNQY0ZaWjNWbmMxZndSbnlB?= =?utf-8?B?ZTMyZjUwVkJZVndQWnhwUE82eStEYU0yVmQrcTNuMWliTnJNa1NsdThDd0Nw?= =?utf-8?B?TkVhU24zTnNFZVQ2MkZmdW95cFlnd0JZWXJyUVNhekkvQWdzWHpkcHYxbTQ4?= =?utf-8?B?VEIwQ0Vra0RCSTZZbCtNMU1jQ3g5RDhNeXdtTXVkN29EM2pPWHF3NklHZVBx?= =?utf-8?B?Wlp2cGFQOXJScVlXaEd3OEFvU2duaHordnlqUEViT1FZcVVlSllsRVF3NXho?= =?utf-8?B?OUNjQTFITjVMRDUvWU1MRkdhSFdTKy9MS3hPY3ZXSzM0ajQ5VVFMMzV4UFg5?= =?utf-8?B?RUVoY2FMa1hMYmJMYmNTYUNsYjBSTE83MTF1Y29GWDlITElQWW9jRUphd01Z?= =?utf-8?B?NDdJMEFhYitQNXlpSHpiMGc3d2VpUVRRK05lWFcxZm9FRDBoTDNJbWphMFFL?= =?utf-8?B?RFl2Vmo0UytKWUhuaEI5VDM1ZGdRWXhnVEtGSDVVM3dmQ015SUJKNll0M296?= =?utf-8?B?OStIckVUaTFxdmkzZTByUTFwdStNcVZuSGJWL0lQQjJCZWtuM1lrUk9UOXBt?= =?utf-8?B?U3Z2bzIrcUIrclUzMHpTenhYMDd0d0VENk03ZHBnTnZQY01YR0JJem9ITjJ4?= =?utf-8?B?U29CZGpHaWVrcXBVRnBNOVliQUNyWGdqL3hFeEFyeXphRlBkZm1oeloySkJv?= =?utf-8?B?WmlBTGFMN2ZGb3hKZmtFYjdobTd0UTNXcFlIL3RXdlErRzZBaFZFS2Y4dkxo?= =?utf-8?B?SHJOVS9kL2FaWENwdTFranh3bGtPd1JDa2k5VXJvWmNtOWthZVF3Q1ZsRU94?= =?utf-8?B?QUlUbXQvNDliQkxjdmtiZHVhWDRuVUJRaG0wYm5vSzVEcEMxcDFkVllTaXcw?= =?utf-8?B?Y0JTVHdFaUN3QWxqZFpQR0ZUU1V2Z25KR0VxNXQ0QzdpRWt5eGtYTjZFVUxQ?= =?utf-8?B?ei9SZExtZStzcEZZdCtrR0JDTzBJNlBCUkFpanVNQ0xjUmRlRTVhL2hxaGlx?= =?utf-8?B?NUdBWjVQYmtxcWVJaTU4OHRUcnI3ajJqdmFma1FoRDJVQXJnaE54cS9aWExH?= =?utf-8?B?eDZJVW8vQzVRNXFJaHRGQ2hQR2xyNTN2ZTdqb25ESVZSRDJnVllwc0t0Wk9w?= =?utf-8?B?SVpUd2cxTlE1TU5tU2lMZENRU3Bzb2QvSll5bnhaN0E1bUNmYmZwN3R4dUJx?= =?utf-8?B?T09Kb01OMC9UaFEwUHlFWmh5aC93cVFPUWJReVVlMHIvQVRQbTlUamtlL1FO?= =?utf-8?B?d2lXWXNiaTdmUHVKbXJPRWFXOFFVQmxkekZPbDVFQ2pLRTczZWpDUXFkVGc5?= =?utf-8?B?NXZ2K1ZKSEswOHl3b3FVbHUxSVdWcTRkZEJwV1dGazkvVlZoejI0WnZpUFIw?= =?utf-8?B?ZEZQZ0t6czJERnhCc3BkTytEUWd5bk5PN1hTY1ZjSTBrMVZJQmhMSlF2d1BG?= =?utf-8?B?WnhzUCtlNXBNTy92SlBuV2kwT1p2Ni9nUWxObE5tR3NiQ3VETHdxMnU1ZXJO?= =?utf-8?B?QzdTWFErcjMycVpmY1BrQTVsM1hWVCt6RUdhc0tNT1JQalRDNnM2TnNpV3oz?= =?utf-8?B?TWFYTGd2T2g2NU9INTRIdDZlOCtWSitZZWRyQmxlTUZLaUlEU2FvTFMrd0s1?= =?utf-8?B?TkRrYW1velgrZ1VVV1VOeVpwM0RFMW43ZHN2RkxuKzc0RjRMYTBOcDZJbHBt?= =?utf-8?B?T2l0MTdNeEhrQ1cyZGdUVmpsSVJIV0dWNDRuLytPeXArZUFpUHo5SHBxMHJC?= =?utf-8?B?dFAwa3hHZzRGTUpib1kzdy83NGl6T29Pc2tXMWZNaXlWMEJONERnUThmaFNZ?= =?utf-8?B?aG1RbFVNa1pSYWxXSlZ6eFdWMjlvTTBjQ3B0U2kyd3FKeUtkcEwzS25IbnRG?= =?utf-8?B?WG9OaWZ5OVJDU3RhS0VpakdadGhRazJqblU3bUU3SXhBbVY0bVNoWHVreU5F?= =?utf-8?B?U1U1V1hmNzlSNFErY2ZIMDFzUStnN3NOVXhYOWxlRUViRVcvaEd1SlExWVpr?= =?utf-8?Q?YQc3DB/pXQwxOp/2QzDGOdGkXJvkzKKv2vy4lUX/0khzC?= X-MS-Exchange-AntiSpam-MessageData-1: gYbAKjn63EcjIg== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 689c7b0e-3830-47d0-aeae-08de752cb775 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2026 11:46:45.2806 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3BTa4qSKEpUolk5/ObjxwegslvCIjGd3l9eqrYGV/SR6k7zTGUNtbC4fBtNLrH3HaDswzQvQtlteIajFpjY16w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7112 There is no particular order required here and keeping them alphabetical will help preventing future mistakes. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/fw.rs | 67 +++++++++++++++++++++----------------= ---- 1 file changed, 35 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index f1797e1f0d9d..4b998485360b 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -191,34 +191,34 @@ pub(crate) fn new(gsp_firmware: &GspFirmware, fb_layo= ut: &FbLayout) -> Self { #[repr(u32)] pub(crate) enum MsgFunction { // Common function codes - Nop =3D bindings::NV_VGPU_MSG_FUNCTION_NOP, - SetGuestSystemInfo =3D bindings::NV_VGPU_MSG_FUNCTION_SET_GUEST_SYSTEM= _INFO, - AllocRoot =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT, + AllocChannelDma =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CHANNEL_DMA, + AllocCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CTX_DMA, AllocDevice =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_DEVICE, AllocMemory =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_MEMORY, - AllocCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CTX_DMA, - AllocChannelDma =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CHANNEL_DMA, - MapMemory =3D bindings::NV_VGPU_MSG_FUNCTION_MAP_MEMORY, - BindCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA, AllocObject =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_OBJECT, + AllocRoot =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT, + BindCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA, Free =3D bindings::NV_VGPU_MSG_FUNCTION_FREE, - Log =3D bindings::NV_VGPU_MSG_FUNCTION_LOG, GetGspStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_GSP_STATIC_INF= O, - SetRegistry =3D bindings::NV_VGPU_MSG_FUNCTION_SET_REGISTRY, - GspSetSystemInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GSP_SET_SYSTEM_INF= O, + GetStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO, GspInitPostObjGpu =3D bindings::NV_VGPU_MSG_FUNCTION_GSP_INIT_POST_OBJ= GPU, GspRmControl =3D bindings::NV_VGPU_MSG_FUNCTION_GSP_RM_CONTROL, - GetStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO, + GspSetSystemInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GSP_SET_SYSTEM_INF= O, + Log =3D bindings::NV_VGPU_MSG_FUNCTION_LOG, + MapMemory =3D bindings::NV_VGPU_MSG_FUNCTION_MAP_MEMORY, + Nop =3D bindings::NV_VGPU_MSG_FUNCTION_NOP, + SetGuestSystemInfo =3D bindings::NV_VGPU_MSG_FUNCTION_SET_GUEST_SYSTEM= _INFO, + SetRegistry =3D bindings::NV_VGPU_MSG_FUNCTION_SET_REGISTRY, =20 // Event codes GspInitDone =3D bindings::NV_VGPU_MSG_EVENT_GSP_INIT_DONE, + GspLockdownNotice =3D bindings::NV_VGPU_MSG_EVENT_GSP_LOCKDOWN_NOTICE, + GspPostNoCat =3D bindings::NV_VGPU_MSG_EVENT_GSP_POST_NOCAT_RECORD, GspRunCpuSequencer =3D bindings::NV_VGPU_MSG_EVENT_GSP_RUN_CPU_SEQUENC= ER, - PostEvent =3D bindings::NV_VGPU_MSG_EVENT_POST_EVENT, - RcTriggered =3D bindings::NV_VGPU_MSG_EVENT_RC_TRIGGERED, MmuFaultQueued =3D bindings::NV_VGPU_MSG_EVENT_MMU_FAULT_QUEUED, OsErrorLog =3D bindings::NV_VGPU_MSG_EVENT_OS_ERROR_LOG, - GspPostNoCat =3D bindings::NV_VGPU_MSG_EVENT_GSP_POST_NOCAT_RECORD, - GspLockdownNotice =3D bindings::NV_VGPU_MSG_EVENT_GSP_LOCKDOWN_NOTICE, + PostEvent =3D bindings::NV_VGPU_MSG_EVENT_POST_EVENT, + RcTriggered =3D bindings::NV_VGPU_MSG_EVENT_RC_TRIGGERED, UcodeLibOsPrint =3D bindings::NV_VGPU_MSG_EVENT_UCODE_LIBOS_PRINT, } =20 @@ -227,38 +227,41 @@ impl TryFrom for MsgFunction { =20 fn try_from(value: u32) -> Result { match value { - bindings::NV_VGPU_MSG_FUNCTION_NOP =3D> Ok(MsgFunction::Nop), - bindings::NV_VGPU_MSG_FUNCTION_SET_GUEST_SYSTEM_INFO =3D> { - Ok(MsgFunction::SetGuestSystemInfo) - } - bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT =3D> Ok(MsgFunction:= :AllocRoot), + // Common function codes + bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CHANNEL_DMA =3D> Ok(MsgFu= nction::AllocChannelDma), + bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CTX_DMA =3D> Ok(MsgFuncti= on::AllocCtxDma), bindings::NV_VGPU_MSG_FUNCTION_ALLOC_DEVICE =3D> Ok(MsgFunctio= n::AllocDevice), bindings::NV_VGPU_MSG_FUNCTION_ALLOC_MEMORY =3D> Ok(MsgFunctio= n::AllocMemory), - bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CTX_DMA =3D> Ok(MsgFuncti= on::AllocCtxDma), - bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CHANNEL_DMA =3D> Ok(MsgFu= nction::AllocChannelDma), - bindings::NV_VGPU_MSG_FUNCTION_MAP_MEMORY =3D> Ok(MsgFunction:= :MapMemory), - bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA =3D> Ok(MsgFunctio= n::BindCtxDma), bindings::NV_VGPU_MSG_FUNCTION_ALLOC_OBJECT =3D> Ok(MsgFunctio= n::AllocObject), + bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT =3D> Ok(MsgFunction:= :AllocRoot), + bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA =3D> Ok(MsgFunctio= n::BindCtxDma), bindings::NV_VGPU_MSG_FUNCTION_FREE =3D> Ok(MsgFunction::Free), - bindings::NV_VGPU_MSG_FUNCTION_LOG =3D> Ok(MsgFunction::Log), bindings::NV_VGPU_MSG_FUNCTION_GET_GSP_STATIC_INFO =3D> Ok(Msg= Function::GetGspStaticInfo), - bindings::NV_VGPU_MSG_FUNCTION_SET_REGISTRY =3D> Ok(MsgFunctio= n::SetRegistry), - bindings::NV_VGPU_MSG_FUNCTION_GSP_SET_SYSTEM_INFO =3D> Ok(Msg= Function::GspSetSystemInfo), + bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO =3D> Ok(MsgFunc= tion::GetStaticInfo), bindings::NV_VGPU_MSG_FUNCTION_GSP_INIT_POST_OBJGPU =3D> { Ok(MsgFunction::GspInitPostObjGpu) } bindings::NV_VGPU_MSG_FUNCTION_GSP_RM_CONTROL =3D> Ok(MsgFunct= ion::GspRmControl), - bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO =3D> Ok(MsgFunc= tion::GetStaticInfo), + bindings::NV_VGPU_MSG_FUNCTION_GSP_SET_SYSTEM_INFO =3D> Ok(Msg= Function::GspSetSystemInfo), + bindings::NV_VGPU_MSG_FUNCTION_LOG =3D> Ok(MsgFunction::Log), + bindings::NV_VGPU_MSG_FUNCTION_MAP_MEMORY =3D> Ok(MsgFunction:= :MapMemory), + bindings::NV_VGPU_MSG_FUNCTION_NOP =3D> Ok(MsgFunction::Nop), + bindings::NV_VGPU_MSG_FUNCTION_SET_GUEST_SYSTEM_INFO =3D> { + Ok(MsgFunction::SetGuestSystemInfo) + } + bindings::NV_VGPU_MSG_FUNCTION_SET_REGISTRY =3D> Ok(MsgFunctio= n::SetRegistry), + + // Event codes bindings::NV_VGPU_MSG_EVENT_GSP_INIT_DONE =3D> Ok(MsgFunction:= :GspInitDone), + bindings::NV_VGPU_MSG_EVENT_GSP_LOCKDOWN_NOTICE =3D> Ok(MsgFun= ction::GspLockdownNotice), + bindings::NV_VGPU_MSG_EVENT_GSP_POST_NOCAT_RECORD =3D> Ok(MsgF= unction::GspPostNoCat), bindings::NV_VGPU_MSG_EVENT_GSP_RUN_CPU_SEQUENCER =3D> { Ok(MsgFunction::GspRunCpuSequencer) } - bindings::NV_VGPU_MSG_EVENT_POST_EVENT =3D> Ok(MsgFunction::Po= stEvent), - bindings::NV_VGPU_MSG_EVENT_RC_TRIGGERED =3D> Ok(MsgFunction::= RcTriggered), bindings::NV_VGPU_MSG_EVENT_MMU_FAULT_QUEUED =3D> Ok(MsgFuncti= on::MmuFaultQueued), bindings::NV_VGPU_MSG_EVENT_OS_ERROR_LOG =3D> Ok(MsgFunction::= OsErrorLog), - bindings::NV_VGPU_MSG_EVENT_GSP_POST_NOCAT_RECORD =3D> Ok(MsgF= unction::GspPostNoCat), - bindings::NV_VGPU_MSG_EVENT_GSP_LOCKDOWN_NOTICE =3D> Ok(MsgFun= ction::GspLockdownNotice), + bindings::NV_VGPU_MSG_EVENT_POST_EVENT =3D> Ok(MsgFunction::Po= stEvent), + bindings::NV_VGPU_MSG_EVENT_RC_TRIGGERED =3D> Ok(MsgFunction::= RcTriggered), bindings::NV_VGPU_MSG_EVENT_UCODE_LIBOS_PRINT =3D> Ok(MsgFunct= ion::UcodeLibOsPrint), _ =3D> Err(EINVAL), } --=20 2.53.0 From nobody Tue Apr 7 15:27:24 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010008.outbound.protection.outlook.com [52.101.56.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3DA336A032; Thu, 26 Feb 2026 11:46:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.8 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106415; cv=fail; b=WTc/75T979zwTQYLEz4B2xmEKyX4R3QvxNXQA2XvtUiha7ujMd2TkvKyYreyWGT9zvMnsF5VHbxc54Xqmai9yWnvQyXBdm/uKMBQr57AE0aLdugDvqwUPmlaRdpgyihmwIduAlRjYr8IWSTF74KS99BgQLY56CH1dfU0nzH2ZQ8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106415; c=relaxed/simple; bh=r4YBXdwshOgrpGDV+66LkMJlKRPzPLh1+MGX08Vl8bc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=I0DqlnpkfMujkYnnEV1M1p/LqTk5Ur1PDFW56SfsRpYr6TKJRTiPpJg77wsMjDlytjmlBKEPs3t6LXAO2/NG+LTDc8Qob2XgDQt+wEt/FzNCei9D3ofvovTxr9I1Qtm2VF+AWH69I9QtgGB4vq8kjMt4csLH22Q6N4GJNJ2GuSs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=IAzwdK5t; arc=fail smtp.client-ip=52.101.56.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="IAzwdK5t" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NakLcKZlmFIX2kmbMnjyje28GKFvHN0rG94gMmEgUOOuEoducbmj68qL85Af20Pfqc1NRjA/AqT6dAur3YSdv3GmwU/VMYGuyY2m7Jc2vanhh6Fo8953dXaMoSwNV11CTDPOjPzWrVeDIJL9z5lX/Qe931pjPBGYlWPWJwNZ11ExBHvHpKwDplnmtafuekNLSNASJaDDhqWBQmIpc/+DwVsrS+6hpWITKX7pqNPec0AkUWSSs8gJXJra7XnAommyiXLvBYTYDCzS/v0KOc+68KOkanOXfx9pz7g73eSNStGj2I91x+/PJRcjeRhrzNb297GTttx3bILTTlwmBmWnHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yLnBNSG3LZd9hKsFkZruHcQsngzYJOAs65QeLA9FC/E=; b=Ymg01p6I3l289mj+ATY03mhP8CxgmyXsuXvpRIzJyKMTKOkZfmjfC8xUo6EyN9YdbxLfDY9F2yyACruvKsoV8Vro+wfwNvt8YrN10AUetinTgAGK8A/AspQx+RpuLTCFyZGbRCX5dqjhMeAhThbppkGavnGwPU+zUsuWLbhL1i9a8MYQ3cfMP20VgU3vbUS1ppeyvZIAseuv24UEY8YbBnGBzotjoOO9njgwXsPi3XMfM1nsS8sY7bJ+dH4c4euo/V8k4nWxlVuLD8VNN6mEL1h+MxKn+2WTm0QzzFnNk4Xob8JL9eru6gn4zovv+IZIZ0F3qlVHF6W/NQFBFRLjRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yLnBNSG3LZd9hKsFkZruHcQsngzYJOAs65QeLA9FC/E=; b=IAzwdK5tWkbZrlN2eHmy25TOa4sq4esamXUcwpEzB7X0JkXc5za8vXsRhbT5Zy1XcUkyB/4C5fpjQ1MWF5SYYD1MgYvIy2OGCbRsAJry3Alj7/2v2ZsXUt/V8tpkP66MOExdROrJJpMlhn6GQ9zFEAHILKnPdCH3KwEaNV2nlGePh2Iz/goUpkiKWJeGAe4Fl6Hhkfov3IRCm19pT2aHsce0tHF8Qy6KVKegzE3SPTxYdiPEw2KrHbo+YMlluD6qqALBRVBwjhN4n8LaIsC+ciGniqIUlYaabroZXbWt8Z86uWo7HVxsSs5OzXD/0brdimk+U9l49T2nWFgbqqBNzA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB7112.namprd12.prod.outlook.com (2603:10b6:510:22c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.20; Thu, 26 Feb 2026 11:46:49 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.007; Thu, 26 Feb 2026 11:46:49 +0000 From: Eliot Courtney Date: Thu, 26 Feb 2026 20:45:34 +0900 Subject: [PATCH v3 2/9] gpu: nova-core: gsp: add mechanism to wait for space on command queue Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260226-cmdq-continuation-v3-2-572ab9916766@nvidia.com> References: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> In-Reply-To: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney , Zhi Wang X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0097.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:2b4::11) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB7112:EE_ X-MS-Office365-Filtering-Correlation-Id: ad08e6dc-efb0-465c-d94c-08de752cba0e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: JDfVImzXqICCsMDlNRg5sqC2T3uHIxRXYF9NyyUrPbAN7MJHfoDR19yh5OaUHf9jHAWBOvLDg92r3/ReOJ/YCcmb0j7xoOZMgjqYvc4DBi/IccXeeyFWGgeX1wjhfLUiDrys/a9TMuvu34htXTbS3wv30wYEx8n4JkmATMolzT4K0E6zYq6vg9+8JNn6A/OYaqOihfEa6ygdhqH1xHZ/n7dEMu75B6eS+ODObdZlgbvubKHcYq4HIj6gkO1zxjiZBp6eaIiEKgrx8f0WWj1IFb2Aae6wW/q+QmgSHEL2hPRbvEq4EHYSA2ZiKQLsf196vm+XhmFBgLtqPdY+kE3Vr2sVOQF45T9tm+cadwlyago6hYn45AIEaqkMUWB/PpYCsR/mFx6uPf4ipcbpjV6iUyuFCe+O9mgDfo+no9Bdoo6HnKE9TIEytwmfNy29V5X9F2iTlXKQ713IJX+CFJP9a84cLUIGrKb0gUuc+2OW4OKSA08XAIjrKgdq5hmDjtP4JmF8F1l6ND3PNzFsUN3ZLFxo1J0BZWYiDCHSRUkkCBX07HMOvUMH0wmnn3rqbcIA3d7/I8+VCwEA69qg7kX+d6sfai2I9spiALwafgZYjutSPqeFSfvMLIv7FsfVbXO1xJg1yc7nYwDJ5lvasKJMPqPZym0mbNHNOrtJ0qX1vLOKwxT13vd1XjTkwF3xqRIes2OVWwcwNpadeqa2cZQf1szLi/qKUwcKSnhe0+ieqAOR1SDKpwLDCeJLBIqwlrjLXQnPWl11Tqn4ztVmH1lOlg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sll2dk92UFNLR05VTjI1OFp5WWx5VnZuU254RGMzRnFCQ01zdFQ1cEw0cnlt?= =?utf-8?B?MG5KbW1UUytnUVlrRDZhK243b0oydkMxOENreFYwM3ArQmR0SlRob0Y4V01X?= =?utf-8?B?dzM5ZlZzcDNyT0tTN1I0Y3l0ZTUwcXNSMlZ0K2xBNlZxMEJwd09lOW51TjR1?= =?utf-8?B?VStPQ2d2YmZMTVpraWhVeTJYSmlUbHdzMWZneEoySjFuSG12Z2c3cVB2N2Vr?= =?utf-8?B?WDBzWWhWSXo1NmhTbFhHdGNZdzFuWXRkZG1IRnlVWlJNOWorZ056V0lOK2Nq?= =?utf-8?B?N0l5VXR0YngxcmRWSWhVL01ZK2wzelhYc1BpYlQ4NW4ydWxOd2JPZ0MvTEFK?= =?utf-8?B?T3NsYzYxZ3MvWEE4YWlwYUIxMlI2MFlGOCtTNys2N3Z4MXZsaE1oRFlJZWQ2?= =?utf-8?B?MlhzMS9XSE15OFBVVTliWGYxSVJUTWdhUUR4Q2s1b0JkeU5YNnA3VmZ4TG5K?= =?utf-8?B?b0VPV3JBWDBJSW1LVUw2UkFNYTNxS2s3YnU0UjBXNTAwL2N3TS9uQWwxYVFj?= =?utf-8?B?bWpXZlNGa0FHN2lpbThXZ0RHNVd1c29pQnUwVjRxNWUxK2JZblNBdWNjOUUz?= =?utf-8?B?ZDlDb0lCeTNvcnE4YTZWSkRycUVGcEhkaEYvWk85cGVIanBXQ1Z4a0YyVVov?= =?utf-8?B?TXdiRnh5bUxuSXRPK2ZtSEh0ZFlQYWZuNUI5d0I3a216MFlBeXBaZHRyS2RS?= =?utf-8?B?MU5MdS9majVaamhRUUhLZWJ5eVdZYWZ3UWFkRjViSGlrdHhhR3NsRlFOeTRM?= =?utf-8?B?N1ozV0NwOE1CSERSOTB0TWhKOFdCbnY2QTVzVEw1NE1rQU5rRHlHYWwvbGRs?= =?utf-8?B?UlZDSlVsa1l5cTFRUDVBSXl5cDQrc2dVTDZlTGNNVE9FWFEyUDNzM3Q3V2Fh?= =?utf-8?B?emppTWcvQkRsMGc4NTErRFk1THpFaGFneUJMYWJJcGRIVGdjTnQvSkNxSnJl?= =?utf-8?B?QXJNS0ZNTmVtVURkSFUxWTJ5dTlIK2pGcjA2RGZJREIybFlCcTlXUDZ0Rk5t?= =?utf-8?B?c1ArbnBZRTg5aXEyTis1UlJ5WS9xL240eEhjaU5pd0FHTmpISTJyVzJPV25i?= =?utf-8?B?enJ2blN2aW1EQVVwNSszd1FUaTB1ZktBaENDcHF4b1A4U0lnZFNCVVkwQUNn?= =?utf-8?B?RDJOUWZocFMrUEFjemZqdERlTXV5T3gyV1ZZeGdnb3NtY0RRZzl1RitmSnpX?= =?utf-8?B?M3VQRE9YNWQ2ZG5mdDdSZmphblN3eVUySG5ManJDK2E2d25wdlJNZXp6bFpu?= =?utf-8?B?TXYrY1BkYXNORjJUR1h3UGYzUk5LQm1YUlpHVnFRcnBZTTgxZCt6QkY2WWZG?= =?utf-8?B?UktyRnluNE0yV2VDRUc3SFVaa1VlVG00T25JQWNZVHg3VWd3bnBMZ25wWFdC?= =?utf-8?B?UjFSTHRZa1lvdncyTFJ0d2RBU3hhSTNLRnFwRGdQc2pjYWtQMlVhMklIa3F1?= =?utf-8?B?Z3BTRzRXdmo4RFpOMUxZald3S3MzRk0yeTlnc1JKUk1BclVHYlFwWW1udlBH?= =?utf-8?B?eGdGWU5QRWhacGQ4Zk1KdXcyeStrenF2dmo1Qkl2SEdsVG5DdmR0bnF2Si9p?= =?utf-8?B?bXdkbXRLOC9TN25sdjFiVFNkSW5DeUtkQjVNSEZ4QkhNenJoeEdVZ29KRWo2?= =?utf-8?B?eUdWekhBK0pNamE3dGJqM0RZaWZuMVdnYkU4SktOY2xLK0N1QW1Bc2JuOStK?= =?utf-8?B?STJmOUFXQjdITDliNndUVnNxalYrZlNoUG5jTys3dU8yQ2dtUXJacHZva2d3?= =?utf-8?B?UC9zUkNJSjNxN0U3RzR6MU9hYmdEWnhOMmt6RWphRXhVNW5XbWRhQ0RPRHFR?= =?utf-8?B?UEx2K3hIT082M1cvM2NEc3JObmFldHVMQVV1V2ZQYUtxL2w2emVNMU1pNWFW?= =?utf-8?B?RzA1Ukp5OUxEeHpBM3JnZVczYWtxSGlscXRvblVIVzIyVlpJOVNkTjZkakFs?= =?utf-8?B?VjZSbFArUkF1K2J6TXV2UG9xamltdkZmZDJTNGpkWkdqRVNYRWNJdkNFY2lY?= =?utf-8?B?V09PVHFsWlROTkZiRUZpb3VTVFMzU3FYQTBFYjI3a2MrQXl4bklSWE0wN3dB?= =?utf-8?B?cnM1emUzbkZHc2UxWHdOZVRVVXhLUENHWWhnMzBvMkNwZE9uSmcvaGxDTEd3?= =?utf-8?B?aGRyeHhSa3U5ZlFGUGJEeEtiK1NmZTE4ZWJQVm5oc3ZSL1FSWnZwSFpHaWx2?= =?utf-8?B?MjVyM1V1WmZBNTc3aDZ0YzIrelkvU0ZNRTRjdjBRYVpEM3hCRHdpbkhlbE10?= =?utf-8?B?OHVmODJ6REMvQUN5aUhvb1Z5d3JiajdscUNxZlVOaHQxbDV2ekFsaVh4M2RJ?= =?utf-8?B?ZG5NZi9ISTlLSlByMzNuMmNyZ0JRWUFCTHVpS1ZSYVZETTI3NUtCWExMQTMz?= =?utf-8?Q?QaxzvHw8G5V7Lw3vMQw8Hn347YYctjoXa0kJEvNFo0o/9?= X-MS-Exchange-AntiSpam-MessageData-1: aAcJL3ze9nBZlA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad08e6dc-efb0-465c-d94c-08de752cba0e X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2026 11:46:49.4679 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PuEq++DahqlmBihDm4537G6Qew8XEE+4eeQG+SSTqsIJuX+OAtsHiHxPZz4WUjyEfAtKNPW14OlWHOSsicWZGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7112 Add a timeout to `allocate_command` which waits for space on the GSP command queue. It uses a similar timeout to nouveau. This lets `send_command` wait for space to free up in the command queue. This is required to support continuation records which can fill up the queue. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 39 +++++++++++++++++++++++++++--------= ---- 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 87dbbd6d1be9..efbbc89f4d8a 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -250,6 +250,19 @@ fn new(dev: &device::Device) -> Result<= Self> { } } =20 + /// Returns the size of the region of the CPU message queue that the d= river is currently allowed + /// to write to, in bytes. + fn driver_write_area_size(&self) -> usize { + let tx =3D self.cpu_write_ptr(); + let rx =3D self.gsp_read_ptr(); + + // `rx` and `tx` are both in `0..MSGQ_NUM_PAGES` per the invariant= s of `gsp_read_ptr` and + // `cpu_write_ptr`. The minimum value case is where `rx =3D=3D 0` = and `tx =3D=3D MSGQ_NUM_PAGES - + // 1`, which gives `0 + MSGQ_NUM_PAGES - (MSGQ_NUM_PAGES - 1) - 1 = =3D=3D 0`. + let slots =3D (rx + MSGQ_NUM_PAGES - tx - 1) % MSGQ_NUM_PAGES; + num::u32_as_usize(slots) * GSP_PAGE_SIZE + } + /// Returns the region of the GSP message queue that the driver is cur= rently allowed to read /// from. /// @@ -281,15 +294,22 @@ fn new(dev: &device::Device) -> Result= { } =20 /// Allocates a region on the command queue that is large enough to se= nd a command of `size` - /// bytes. + /// bytes, waiting for space to become available based on the provided= timeout. /// /// This returns a [`GspCommand`] ready to be written to by the caller. /// /// # Errors /// - /// - `EAGAIN` if the driver area is too small to hold the requested c= ommand. + /// - `ETIMEDOUT` if space does not become available within the timeou= t. /// - `EIO` if the command header is not properly aligned. - fn allocate_command(&mut self, size: usize) -> Result> { + fn allocate_command(&mut self, size: usize, timeout: Delta) -> Result<= GspCommand<'_>> { + read_poll_timeout( + || Ok(self.driver_write_area_size()), + |available_bytes| *available_bytes >=3D size_of::() + size, + Delta::ZERO, + timeout, + )?; + // Get the current writable area as an array of bytes. let (slice_1, slice_2) =3D { let (slice_1, slice_2) =3D self.driver_write_area(); @@ -298,13 +318,6 @@ fn allocate_command(&mut self, size: usize) -> Result<= GspCommand<'_>> { (slice_1.as_flattened_mut(), slice_2.as_flattened_mut()) }; =20 - // If the GSP is still processing previous messages the shared reg= ion - // may be full in which case we will have to retry once the GSP has - // processed the existing commands. - if size_of::() + size > slice_1.len() + slice_2.len= () { - return Err(EAGAIN); - } - // Extract area for the `GspMsgElement`. let (header, slice_1) =3D GspMsgElement::from_bytes_mut_prefix(sli= ce_1).ok_or(EIO)?; =20 @@ -497,7 +510,7 @@ fn notify_gsp(bar: &Bar0) { /// /// # Errors /// - /// - `EAGAIN` if there was not enough space in the command queue to s= end the command. + /// - `ETIMEDOUT` if space does not become available within the timeou= t. /// - `EIO` if the variable payload requested by the command has not b= een entirely /// written to by its [`CommandToGsp::init_variable_payload`] method. /// @@ -509,7 +522,9 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, co= mmand: M) -> Result Error: From, { let command_size =3D size_of::() + command.variable_pa= yload_len(); - let dst =3D self.gsp_mem.allocate_command(command_size)?; + let dst =3D self + .gsp_mem + .allocate_command(command_size, Delta::from_secs(1))?; =20 // Extract area for the command itself. let (cmd, payload_1) =3D M::Command::from_bytes_mut_prefix(dst.con= tents.0).ok_or(EIO)?; --=20 2.53.0 From nobody Tue Apr 7 15:27:24 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010008.outbound.protection.outlook.com [52.101.56.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CCCB37756A; Thu, 26 Feb 2026 11:46:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.8 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106417; cv=fail; b=W1Jf9lGj1CIdbMZWB9m+R8i3RPc4DKdmwJ9lKYkzq2ISdxy2qm6jNDyUJ2PJK9xt+RbmJ7Ii2ZkWKhTLu9cR5fnI3/B+J0rbMv2PeGBbJCdtPSFQwgHwyBMUpX84HWFuRuqej1+sw+kL0oRX8Vjc1y0BXo2HMBlCK+nR5uv2KBM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106417; c=relaxed/simple; bh=L5vkGMHHPNKksYspTaVTpDf9h37kaRVD5IV72o6Zl+Y=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=H6AsZvj64TzcIYBMTyNk/FEfSa6ZUjSnFCJKt2j/W8RBfzsFPSvQyyAOTixNbw5DXQF7vY/IwhzM7JAeDZuZzN9OrHZt2tKw5/eUe9xGDuLZ9GoxuI0+Sb7ft96Y08FecGM9RHMB6R9pNKvsAvAnopwJ0++wSWqQiktP1WonQcw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=XTLYZDUB; arc=fail smtp.client-ip=52.101.56.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="XTLYZDUB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Oylgy9B5iKeA2HYeiy61Y8Eb7k8OoKgVpe/crX4gJ5KcvK5hdDIgdZ+R376eof0AIAQhHaKPy1zLfGTIke4z18zyqSRBB+4b+rb6VcnSXPeRSbFYCFIFuDa6tfy4XJQIKlvgCBZgZeGbRQ/Z2PcRJQstlzESWfpuRfif5f7UVSv5zY8IDAPSOfXoWl7nFITP2ysrtsw00YWWciyQaLEVyCWcxoFsDQoPsjhJi0/jTy1KiOaywo4QF/lGC8hcwIpUhmA18WNPE86quQRxLLQgVD+6ZixTe3XBdKlR3vlL55hJESo2YUbCBmqj2Ai4AT/2NwE/sguoaBHDcwM/mr6U/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KjQGDCSzf2Bu7JwIGWt6B97K83ritkwX3qFRyQw4Sqs=; b=GybXCK3NHiSMoITwYbfjAnrcFH30WDqpzANVTjlSFvH61XmtUw6UxRYptKL6k2YH1to3C/23nBjAZgDlEfES+Tjw+FjA+kN37eimQKhH+NGy9mj9DGCRiTKz2uFUFKC1oNmfSSP63LDCC4W6F5l7Q5uURarHC1/hNqlrp7vAVsTLvx0LcZ/5XpvZDMVHpTkmLTIYJN90Yk7aKrGLuttAtAZhbA5UsufjhpWF6FIgAmoas0rIxUU4zy86wz0sHB33wm2yO/sr6nEIy4wlEXZECuMuZK/+7BqbvgmxpG1Rx1aAyljPCtBhxk1CkiwuH0phsjRbj5UqJxVd1d9WBWIuSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KjQGDCSzf2Bu7JwIGWt6B97K83ritkwX3qFRyQw4Sqs=; b=XTLYZDUBy89tJayTrWD6WAGQt29QSC6NCgupq/3dgwvKeXWsWJ/wBHlmYojfjtunFn+KsPaix4apxltJF+O51cWg4pZ4otPxZ2QE++mKEhhm32H0AAb/LHkqWjgbVg8b34GQyGIGyEwbH6iRIhyGmDozloeT2ycKg5m05Ep1n8GQ+Ggux66Uw9AZGIYfgItlkQgda2nwD+G4u9WSpkR7xjHVKeTsVRJ5+1IHW/ieYUUpPwEh1k9Qtrq9gvA/XY4Qf+BkjG3HemTnO4VNYBuzbVG9kzMNMxfoz846ZkxtTWKmb0HtNhH5ZLOAzzdhf8HEjihU+atuussrR3/ipOFYQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB7112.namprd12.prod.outlook.com (2603:10b6:510:22c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.20; Thu, 26 Feb 2026 11:46:52 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.007; Thu, 26 Feb 2026 11:46:52 +0000 From: Eliot Courtney Date: Thu, 26 Feb 2026 20:45:35 +0900 Subject: [PATCH v3 3/9] rust: add EMSGSIZE error code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260226-cmdq-continuation-v3-3-572ab9916766@nvidia.com> References: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> In-Reply-To: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney , Zhi Wang X-Mailer: b4 0.14.3 X-ClientProxiedBy: SJ0P220CA0018.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::28) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB7112:EE_ X-MS-Office365-Filtering-Correlation-Id: 772cd3bc-94a4-4dc0-9b9d-08de752cbbef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: yhvCbRyr96xXPTq7fVE4QDOPTV83SAsbvpJPusdsHtMEgjtmUmlRGSwqQeHqQmPK6wKjkX43X7qPtSNpu2YrmTtvRS+87L148XVOMfJHjYYaASe7ZChbAAKm7PbI7cWOEa8DoajbmIIVKw+Ki/CQXHYrG9AZbn8AsUP7QE//RwElyMH0iUVngW2mocsB+2D+a6wauAM7vhwaarJ5EMMALjrdQvOD+CYDQK2aRaqUm7gvAlpEyJal5hdgAEeeisVdsopnfRUmcfFrcQ7CL2Qc1v/BmV+kngER2tG47eopj9JgMsvhZZfv/Cb5nErnwb6QYJd1vjTJA8VRoFskvCnp79js1FoRPir0/bYoh/CW/BaTZTGp6ukVh7o7rCE1Sk2WTy2WyhVVca+AK9568PdQqjrHJjFLNynpkvzoi68r/8cjxav9BhjMz6NXOynQNDquffIbkwrHKDPKiNXS+YunddF6T6SHvO5ZsSTVC+5jj7OyV1lqgeCL9pYb4Ul/Vg6MAXfPR0M25dvqCu4ssvvNsiXfEdiJ9wUhNad1imLMdthP7PmfwZRRQIdaTT/kBgAAwLB/Y61UmH2MLJFPpXP8nAMNopWKlaZlq/O3g+vN+o8o+QR4c6E0c2l+G8oZqb3OSJBddlZKeeJHiaYrv60pU3V2wb3BeM+z5KV3SJxLcioBQSIppNJsn5Q8VwYgADbZloXwyOEf5ktNllEpj6pckAK9eRSXNxp4I9ho1i8MaYpjETqbOW8OAXzd8Rg6Rj92AJx51Di75Kn4YaQ+Oea/HQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHFlVko1UjllV0d5MElQQmJUM2JjeCs1bk8wUEd1Z2h1U0Q5WUYrbTRVb1NM?= =?utf-8?B?Y1RjR1FFT0VMRk1xV0h1NnpROEMwdmgyNEhjT2VQK3QyVXFyVm9PbUs4VTVE?= =?utf-8?B?UG14NVhlY2RqSklTRDE1cWdvNWFkeGU5anViMWR3SDh0WGdzTVhObzcvQUdn?= =?utf-8?B?YWRsSzBmZkMwaDhFdXRKdFBndWtHSjBvRlIrSmtKRWJ1dnRtYWJqRW5yN25U?= =?utf-8?B?TlN0bkxJOEVwUmFKL3J3c0FEdktzckN6ZFlnR2FiN0JEdG9BOEwySElydkNT?= =?utf-8?B?dmxUT1B5YVhxM3l5Znl4RkR5SWdLNWtkS21rQ0hSODRWbFlHM0VTMVZUNUxp?= =?utf-8?B?ejY0MlVxUHdXMFFkTUNpVDNxcGlDYUFVb1ZhcElsUmUzekp2NUtvLzQyQ2hS?= =?utf-8?B?L2xPNWw1WC81RENsbUE4cCtTS21uc0NmTmpXbGNjaEJOQlE1d2JmVVZ1Rkt6?= =?utf-8?B?WGY0SFkreHFzSGdQb0dkYVErbEl3NkdzVGQ3TkRsZi9wNnRFV2YwcjUyR002?= =?utf-8?B?YXIxWUNuSXBiWGVjMlkrdFRpRVVaak5ZOUhtK0JYVEtsZE1Ea0RoY0ZHRURB?= =?utf-8?B?S05ObXBLMUVwVDJ3bXZyc1dJRVNickVmekRjM3V2Sm1Tei90YUVQbG1ya2p0?= =?utf-8?B?NEVuMFFid0t4bVJhVFkvb3ZpYjFkN0VkS0J6bVczaXI0WGF1MjN4MkMvM0VI?= =?utf-8?B?TlAyMUFhRTVkMERKYngvMDExV0V4WmtGVWp4RHVDVFI3QmduRVFrQnB1K1l3?= =?utf-8?B?YzhreXFma01Vdjl3bUFGMVcvcVpKNy9aRzlVai8zMkprM0FoVUlwZ0RTWDMz?= =?utf-8?B?TVhTdVdoM1ArZkc4cDZyeTg2U0YrQkxUTVp6d0JEaVRrNEZtNTFRNXNscFNE?= =?utf-8?B?bzZiZlJoMmRTS3RESE5JZjBLaHgyQldYTG84VGFtSVA4bTJJc3dMK09iRkJ3?= =?utf-8?B?K2dQMXpRUjJwK09qZXg5MmZidEhoV1dFZHlFK0xsWWhNSm0vS2JwOUlpMURT?= =?utf-8?B?UERnVlhFSTlzUnE4b1czTTRxR0VpWjVmanNvZXNQdHBUcEQvWjhxYTQrVXQ0?= =?utf-8?B?aTkrTzRwbkIzQk02Y0IxT3IyOTV0bURxM0pNcjBsMmtYaFdQSzZnakZJcGZO?= =?utf-8?B?MHFybUVwNE83eVRPMTBUQnZUL3VaTzhPRU51RFlhTjA0NkRhZ3Y4aGNzeEtn?= =?utf-8?B?cHFaME1sUjVFTy8xdHd1eldoK3hYMEFKdmR5cDF5WkpXK1BGVm9ZZmhMMXpT?= =?utf-8?B?MnA0VmtNRW9DL01sVjZZTlYzTlhZd2lJQjZYQi8wYnlzdjQ5KzUwYlVURm5W?= =?utf-8?B?UmpCVldkZG1hVWpJZ1ltK1kvL0xDMkZVSjFoL3VkMHpmN0lwRWNVOWFibk92?= =?utf-8?B?aG44aXM2ZUJMNjN3ZkYreUxxMXVaOFdYUWZFcHl0bVkvSnRZNHI3ZDB5QU9K?= =?utf-8?B?eVI5RFZLb1IxbUU1NXRDR0taVVg5NFRLQTBJcmhucVpucXpueGZTeDkvbmo4?= =?utf-8?B?disramdlMlBxMlBjMDgzbEVSZG1yMHhQbysxT0I1T1FMNUpYODRRempPSTNy?= =?utf-8?B?V0VwM1RBRUYrWWJlTURZVENPMkpNVjNzSVluSHgwalVzRGJERHo5ZWk4ZGVw?= =?utf-8?B?NU8xWnAzWWdNKzJxandLMHU2d2tzSEZUcGR1clFTbXNOaDVSU0lyNThHTVNN?= =?utf-8?B?L09wVGlVSkovR04zc3dDUS9adWJaa0VRNTV0ZUlOSDJhRWhEYmFCbVp6YzFu?= =?utf-8?B?ajVhT2NhYWZLdW1PUldJSUh5Qm8yY1VuREFIb3VEcVNoN0JWV3BoTXNldklH?= =?utf-8?B?UTc0N1ZIYk95QlJYRlNnUVlxZThJcC9kUVRLT3dHTFF4VS83NlczSkJ3aGMw?= =?utf-8?B?SHU5cHY0TXYvSUxFT3hEcjNnUkJPbXhwVTNuVWJvbzNFVnRBWnF3dzdsWWVO?= =?utf-8?B?eWtEd0VFckNyMWYxYVBFOGtENXB1WEkvT3EwWHd3TEMya1lKU1VtNlhudEpQ?= =?utf-8?B?dWlPUWFDTHNBWXRYNDFrKzFJajh6bGZLNkMxTzNFS3ZUaUdEMDlKTVlOREVG?= =?utf-8?B?TXpDUTl6NGxqTU9UWjFZRUg1R0FjUU9sdWNRdWFsSldxR3ptTVJNZzhZWmpL?= =?utf-8?B?KzhBZENFMWxJZHk0eDAyUE9QWEYwTEx2dFozOU13STVmY0hFSzBNSDhOczBX?= =?utf-8?B?MDhvSVJ6VUFyaUk4Ujd2ZCt0MXFSWXVmNTgwRTQrQ2VrbnpoWE9wQnV3TUN3?= =?utf-8?B?RnZBY3l4YkxnZGswMGdrQmM1L3RjdmFrY29LZVpLQU11bko5Yzh4b214OHlw?= =?utf-8?B?NVBlK2hxL1FqdUtkQ2tJeUZXbnJ5K0h0NFUyYnhwSzRkRyszSzI2VkV2YlFE?= =?utf-8?Q?BU+Mi8RLWmWulAH2ISoVcI1vWykLyGq4/YXsUXj4eYTPB?= X-MS-Exchange-AntiSpam-MessageData-1: n3CuYLlk0cj2OA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 772cd3bc-94a4-4dc0-9b9d-08de752cbbef X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2026 11:46:52.7264 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HyyfAMieOKcBHr/tpyvwv8hzDBQdFgTahysLzZLEI6S7K8XYtO+VSotR9Zl02q39C864ZI/0QKXzJ6GX9VqS1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7112 Add the EMSGSIZE error code, which indicates that a message is too long. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney Acked-by: Miguel Ojeda --- rust/kernel/error.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs index 258b12afdcba..10fcf1f0404d 100644 --- a/rust/kernel/error.rs +++ b/rust/kernel/error.rs @@ -67,6 +67,7 @@ macro_rules! declare_err { declare_err!(EDOM, "Math argument out of domain of func."); declare_err!(ERANGE, "Math result not representable."); declare_err!(EOVERFLOW, "Value too large for defined data type."); + declare_err!(EMSGSIZE, "Message too long."); declare_err!(ETIMEDOUT, "Connection timed out."); declare_err!(ERESTARTSYS, "Restart the system call."); declare_err!(ERESTARTNOINTR, "System call was interrupted by a signal = and will be restarted."); --=20 2.53.0 From nobody Tue Apr 7 15:27:24 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013006.outbound.protection.outlook.com [40.93.196.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C478637C10F; Thu, 26 Feb 2026 11:47:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106422; cv=fail; b=hFF1sHpbcqqI98ajtJoq5RkSmCejAALHGa8sv+04tUvutrQ6zN6hzQsSFZimn+kH4zdBt1LHu1yIIYMjUO6nPESM8veggj5Gw6GJbXSYft4OSlflglEX81UxyI6rSiWlykoG6nbR1VmDPwJPFKJA65ngsdlmTEXCdd5A03qDtfc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106422; c=relaxed/simple; bh=1+V/9J5J0c74hA4ikZHRnlIFsvGcHl4ZHe4Rc1PMAkQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ZMF3PYclwfX0wn4NY85LPhbt8m+UxqwM2n86Tu5yTzbjjCLbhbweNkdOCOaIZNeD9C0euJ+aWl5Vio6VOoDYDaUNdnAPZTJYrZBe/AkH3NZ5ile7ajv7F3vNptYlS9abUtSsb3Hkdz+0ZQgutUiZWh8wRwJZIn1iWfy32sc16FI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=rGz21nvy; arc=fail smtp.client-ip=40.93.196.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="rGz21nvy" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XVu+ce1MLTVZ3zX3GLQQ/oWtRzW1mGXNRm73vO7xzG2qJpGQS7VvzBoFOp6/YWYOx6ovVWaER3DryAlPELAWs8CEMEHsEZQIZc8bIz2/W4s1R9Ds54frgnquWhOK/KguNq2qkM3VN5wM3nd3duBSNGRKW7nFM0Wpx4TTXXrs4OHFQrM5VhnUrfGQDL0hcjRVU4GdTo0SzxoN3zUYD7sRVAesBeLWcfrSf/BWGr4WnkXmmY9+TdEYKEOravjV1IZZ2RmoH3UkFcTjOs0b0wMmZUBj6BRLAewKlw3Yp2O9RCZn8vJUMjxWafN7QxgJepFYWKRcEpCT7M9fdae4H6EWOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9VJnWXJm+yI8tbDkM2y/urrRT6WlSvBHufQjqJ8uwzA=; b=YxWC/oWySZ+RRP0Y+vke8SG71P8igJdmCDEQCVv62Jta/FVhgzI8ieDD2qh2n3ogFDdOzNkEx2xax94CS4I42+8xmn0DKyEUz+H92XG01ikSIHzveJbD3rw58/Ac4y7wCrXabAy5pAMsQ1kuRAdHMN59eRzZKfrDzJDnJWROVB+qb9Aprtceln5ctUoDzjDolOw+Py3C+dmWOQ54ADM01h1YG+8E4YfHIvVe4L4E3doLtf4Sze84zWUS4sBF4AVGuvnSNhPCd4BfpjU2MHvEkHKdN8zxRljVAkgK9vSMZXgOYiYLeswqwHcUgp+CnVedGKZ6Er/hDbKtgYym1r9Scw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9VJnWXJm+yI8tbDkM2y/urrRT6WlSvBHufQjqJ8uwzA=; b=rGz21nvyId453vnOck0rBSd8YDD/Yxm8F1AbfX2zoa/2yxreAY6kReLH2k/9yKDXoML0sQOfXZmTh7OsvEg3JJXzANUt3X5PrG5P8inihTMsn8vYZRMLdyRtZf0LtMGZKgtpUcVV4G2hXiKAYs6IRHDl2aFPMr8ChEu7kA9c2FgnoQomMlBm7w/QEz6LChJB8hTdSLEwXGefaB2aLjeOw7Xsw51OYLxH8ERDQnfmq3TmzSGsGWhEQxn8xZHWYOeauKG24lTLJBpBaRaAbY5Bv6H38OZdcsgzv5rYSm5rtikyPtPeBwwIkCJrrbSfRLDhT+sbFfaxA/VKpxwjfDwOwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB7112.namprd12.prod.outlook.com (2603:10b6:510:22c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.20; Thu, 26 Feb 2026 11:46:56 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.007; Thu, 26 Feb 2026 11:46:56 +0000 From: Eliot Courtney Date: Thu, 26 Feb 2026 20:45:36 +0900 Subject: [PATCH v3 4/9] gpu: nova-core: gsp: add checking oversized commands Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260226-cmdq-continuation-v3-4-572ab9916766@nvidia.com> References: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> In-Reply-To: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney , Zhi Wang X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P286CA0058.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:371::16) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB7112:EE_ X-MS-Office365-Filtering-Correlation-Id: c4b8eaaa-cf10-4ecf-1f5d-08de752cbe70 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: LSsFJL9TkQize6gP1KaZiqhbUG+p3z+T5G8Hb3y3Jytu3QackpjKzr5U41L6XLpRaybyQsIcUs85AOUEt4SS1TwEYXh1ZXJypSf9gTc06uZ9tn1Y99Juj4X9Bp0KkCoWDiUdp4qMS4ilJ0nh1dMeukvK6QszT9gU/HSUn3jd8WaxgeTys+AUS/yWmH8sJnppF8Y0OztEL8+4Dht/ej9ktXk8PyV8CdZMmmRspjRAjbWYW2M8+vZlYUA2RqUZSFDE7N4fXH/BspGxxvgYe+zIEQdeRL9GkZHNGK3C+WXjrA7dfcfEuuowG4XB1pQWegjDiy5TwwRK6BXA9ovTHLvILmLlkhAfTP/CAk4FiTPx4NSTC0Nd9IH8EhUjnu0tJlvH3ojBt8L6sFnnYOCUaui9wotaFAjNphjL320I0ZPWVuthXtzULizawiwJLwYs+62ph4oQPNQ3oDl8cCIWhPQC/UrLByFzVCf2NQ3oTd0UpoJnxC0snFeaVOcHj4EkeMyEU1lThSnlKMQoiy8tbTaylCP2JGwxcMjy1MQeRgeMddqF7Yp5K2uprj4bl1iY/UkaenagyWYusIkg4D6Ed3Gy6tuPwCghGxtlEkEjct/DDzJtFx4KlQlOjVn8l2eG21ixM9iZ4k0oDo8M9BD4l1tCCECa/0AYuXEXhkpitutmEYIfNvNL3Icz7vZsYotXM5T0GSaWtBh4czAKJ1atwgshYY5lxUxSceW9bHqjMwqEfL4bPisCgS4aYwkvFruvLbQbVpBV/3MQ/l8TR5ky1pAotQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aE5LTEpHdHhRQ01sR3pkR1ZBVHZNeG5jbTRTY1E5UWI0M1B5RkRLcE1RbWxY?= =?utf-8?B?S2ZpSW1qMXZJZGJRTGpvV0JZMzNnVk1lRlJpVGpEWkE5OXExb1JjeXZjMndI?= =?utf-8?B?Tzk1ZDh6Z3lUYjAyV3lESzQ1cUJJalJNWkMxM2FCQ1FyQjRqbjQ0bzhrbFBZ?= =?utf-8?B?dEpweThwVlZpak84RlhndDhHbmZlQ1o5MmJ0YTQvd29FMnNUSzFob3ZHSFdW?= =?utf-8?B?bGlVQVRuVlJiSG1TNXpkaXBzM3lqZ0JiUXpreVRNcERvM3UwTnFQaTFyU29C?= =?utf-8?B?WGtYclp1akRtZDE3NTh6QURUZHpwTVVHY0xVQkhOTFAvcU1aSlV3bnVSMC9J?= =?utf-8?B?ZHQ3cmRFcFRKN3pZb0E4c1J5V3hnbWRaZGhyOVFBaTBKaFFOYmpDRTIvdmZr?= =?utf-8?B?eVYvbHFNVEFja3g0ZUlFalROMk9HeCt3djJ1a3V3aFFmeTUzTFJwUnk2bHFj?= =?utf-8?B?S1VpYVo1bWNNb1BzRTlwNWcrMmdkVGZGc01yOU9qNStnMWpGS2JsT002Q2cy?= =?utf-8?B?UjB2UWZaeFhoK083K1pySFNvU0lLcFc5WTl2V0xYYTBmSjA2bkdYU1pDVlA4?= =?utf-8?B?QU8xeGJCNnpBNVh1cFdxOVhxZmk3NDVwUDhCQXVKejgxRjJ1M0tWaHhMOU9l?= =?utf-8?B?cnNYalZtK2Z0RmlEYUI0R29Rc0Y4d2V4UzRpTEVReU5vM2Y0M3pRcUpOMnJz?= =?utf-8?B?U2JaV2J3bW5rV2lQNzZ1MS9qaUMwVXpnem1JeTZINDZzRGV1TE01aHZpa2Zr?= =?utf-8?B?Nkp6UEZoMFF6NWczMnpLTXA4RFdueXBrcFdaU1l1a2JFWERBTkNTdEx2dlp5?= =?utf-8?B?WjNndkc0dTMwa1AreWpxMmxoVnFwS0EzYWxNUUp6VURzOXJrZWZnTmM4eW9F?= =?utf-8?B?a3hPL3FRVElManFvOThCaFdDRGVNWW9FelhXSklaNFQ4YWJxdWg0MDFYTEFm?= =?utf-8?B?T2tuOVByMSttbEJMMDFxdGJGWUJPRVpObzZRNnFnU0xMaTN2cmJCczgrcXVa?= =?utf-8?B?aFc3ZzY2MUJGclhvYWg0U3djVUY3SUIxK01jcUNZeFhlSWtqT20yTG9GUjRy?= =?utf-8?B?T1F2bGQ0MlorZFhXRzVwYWZ3S0NZTzZNeGZwYzZidWNYU0NyWURJTGk3RzBv?= =?utf-8?B?bjIybDFhQmFKVDNiSjVoZDRWS2M1UE1ER25ES1Zkck93SUVEdG1ua3A1Mzkv?= =?utf-8?B?am90ZVltbmZsTGpOTng1R0NqdG1naWdwYmlsNTRHMVNKSXI1aE00ckQ3d3gr?= =?utf-8?B?aXE5UHp1ZWNmMWRweGlKWGRCWnNPYkpYVjVtUHNWczR4YmhpeVY3Z1VGekI1?= =?utf-8?B?dStNVjZ6UTBjbTl6Zk1YYWxuTENKWWp4RWEycjl3aG5hUHZMbjU4c1IreUZn?= =?utf-8?B?U3lmcmJNU1NrWSt4bnArV0RLaVhQdk1scWJnV2UyMXgzckpCNFdncUdUdVhS?= =?utf-8?B?a0NFQS8xck1IVHdLME9pdDJCSWtKWFcyWUtDT2l0eWtudGNKdXVtMnZGcXV1?= =?utf-8?B?RVg4WWRiTU0vdEhDS3NZYlZ3MVhMMy80UnRpZ1F3N0IrOE1CNkRDTmtPQkl0?= =?utf-8?B?WlN0OHQ1bFNPQjViTkpuaGpQY0ZVVDhydit4MEljRmEveU5ubHlPZGZXZGFZ?= =?utf-8?B?TmRHVS9KL0ltWXdTOFVvVXB3Nk5mSEpOcERFdXRqK2lDSUdoSnpLejhuNGtz?= =?utf-8?B?WG9EZjQyMDJCUGlVZVFhOVNGb0dIVUFoZnZUbjlsY3ZNdXl6OXZkY1NQWDAv?= =?utf-8?B?eGxpVFpuV3puQmRRdDA2d21vNXlIdXNUYmVMVWo2djYrTU44VkNMYXZyVkhp?= =?utf-8?B?ZE9VZkFYTldnYndTc0x5N3FZemloaGw3L1AxNldFb25zaEd0aXlPckUySzdG?= =?utf-8?B?TUkyek9SQitvR1NERnR1OW0rbkV3dlozc2NXY09HWlptZHVGMlVEZ1cyODZL?= =?utf-8?B?TDhiMzNmU2ZydnFOOStQNml2QTFWd1QyckpDYVdqb2lwRk9NYytLSEN1R2ZJ?= =?utf-8?B?UjArWHRlQnAxWGl3QlFBYzZEZFluMUFsVkhRQ2ZFMGpjb00yYXJsaEdPTXYz?= =?utf-8?B?engxOXE3REdxa25GOUkweDhPeDA5dzBod0NEQkg4d0tMTkEwbWFVNGpRZWVS?= =?utf-8?B?dlNYZ3VKa1NpQmJpMWgwSVVHcnhLK0tlMTJHSzFidWI2bEdZcmhFcWM4SURD?= =?utf-8?B?TXdhbTN3N2QxS3FKZTR3R1A4RHlqWi82L0VuTzVaWEIwRDBXellMeXBoTHBM?= =?utf-8?B?dVRFcDN4VU8yZURTS0FpOHF1TTlSQWxOOHo4aTRkbngyeEdteVV3YUNHb3By?= =?utf-8?B?WUszL0pmMEJFc3NCbEZYYmY0R2M2QUw5SzdBdHpOcWFUS2QzSm8rdm9TQVFO?= =?utf-8?Q?zXglkBRTIcC3SeLYTxGry9A0ciTBM5n+x1kr8D4ngMSss?= X-MS-Exchange-AntiSpam-MessageData-1: uj6vhyXcqDh0ew== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4b8eaaa-cf10-4ecf-1f5d-08de752cbe70 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2026 11:46:56.8105 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6sWxA1XpODw4X8FHuRiKvGQq76DQ0CitvNJx3HrG8RYkGDg+JJi2luMUw+Lx/d6X10K+lnrWd0Vgm1R0fYCqzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7112 The limit is 16 pages for a single command sent to the GSP. Return an error if `allocate_command` is called with a too large size. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 7 ++++++- drivers/gpu/nova-core/gsp/fw.rs | 4 ++++ drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs | 1 + 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index efbbc89f4d8a..3c2652be74bf 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -32,7 +32,8 @@ GspMsgElement, MsgFunction, MsgqRxHeader, - MsgqTxHeader, // + MsgqTxHeader, + GSP_MSG_QUEUE_ELEMENT_SIZE_MAX, // }, PteArray, GSP_PAGE_SHIFT, @@ -300,9 +301,13 @@ fn driver_write_area_size(&self) -> usize { /// /// # Errors /// + /// - `EMSGSIZE` if the command is larger than [`GSP_MSG_QUEUE_ELEMENT= _SIZE_MAX`]. /// - `ETIMEDOUT` if space does not become available within the timeou= t. /// - `EIO` if the command header is not properly aligned. fn allocate_command(&mut self, size: usize, timeout: Delta) -> Result<= GspCommand<'_>> { + if size_of::() + size > GSP_MSG_QUEUE_ELEMENT_SIZE_= MAX { + return Err(EMSGSIZE); + } read_poll_timeout( || Ok(self.driver_write_area_size()), |available_bytes| *available_bytes >=3D size_of::() + size, diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index 4b998485360b..6005362450cb 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -39,6 +39,10 @@ }, }; =20 +/// Maximum size of a single GSP message queue element in bytes. +pub(crate) const GSP_MSG_QUEUE_ELEMENT_SIZE_MAX: usize =3D + num::u32_as_usize(bindings::GSP_MSG_QUEUE_ELEMENT_SIZE_MAX); + /// Empty type to group methods related to heap parameters for running the= GSP firmware. enum GspFwHeapParams {} =20 diff --git a/drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs b/drivers/gp= u/nova-core/gsp/fw/r570_144/bindings.rs index 6d25fe0bffa9..334e8be5fde8 100644 --- a/drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs +++ b/drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs @@ -43,6 +43,7 @@ fn fmt(&self, fmt: &mut ::core::fmt::Formatter<'_>) -> ::= core::fmt::Result { pub const GSP_FW_WPR_META_REVISION: u32 =3D 1; pub const GSP_FW_WPR_META_MAGIC: i64 =3D -2577556379034558285; pub const REGISTRY_TABLE_ENTRY_TYPE_DWORD: u32 =3D 1; +pub const GSP_MSG_QUEUE_ELEMENT_SIZE_MAX: u32 =3D 65536; pub type __u8 =3D ffi::c_uchar; pub type __u16 =3D ffi::c_ushort; pub type __u32 =3D ffi::c_uint; --=20 2.53.0 From nobody Tue Apr 7 15:27:24 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012019.outbound.protection.outlook.com [40.107.209.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91D6F37A481; Thu, 26 Feb 2026 11:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.19 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106425; cv=fail; b=QrALWqOlZVMYCVbk5VzXumUIgIsL9LwmZraF4a48upIO8MFuViP0Ge5JGXngNUKX/IGwGQ1FZRJ7ncXN+MKGnln0TKZnpw1lEUdntmcz0V/a0C+DdK/36UW1Z/LStUNwYLGqxxEn1Hi42nWVT0Rq1bbDto0bKPIdGwE7BeU/8vs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106425; c=relaxed/simple; bh=q0f0A5nkhgSfmu8DGoRi471ff8wm8rFHVuFwlAMkfoM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=FBUCf/ZUdpmz6bTIJriisFMZfVxwc+krXdVJkG6WNeoBQIKvjA0rWOSh70IYP1y2V9afbw1XTf6N+zWFl/0bhZzJVMBQZazPMkw+bzgXPHfv6+TFG3ALR8N9itMF3Zl8lLWD8ih0TN+DVi6uezvG0i1T0UpGloqznxs22ZgsWeQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=X4fNARNt; arc=fail smtp.client-ip=40.107.209.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="X4fNARNt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GEKVWR0VnwjLmrrYKCSAJUJn8Fkv6TOFUq7gUhWXyJIPKLPoOO4LF3XLK28mMlZ6aFzonvw4VKfrPgnQmPg5QNnyfNtl2G3puUzB3iucyInYHLWQTllwtumAG3UntR4lOQbjAcPXYNWgWVxnO8Ffx/dq3uhFcIgpe8QAdEDhjG86QG//wovoGAPFqGubLKO3sHm+rWJDJF5U2E2WSRC7pFqlnW9mfdW1OgMN+0qouUr4jqtXej9F8RIpNQu5RyJI5HST0TusiSO6XHvcbyFCHvNW4GpJDXdtsbCmAG6VHp/1XjfsciO/XGO1Ri+HB19DKCel6fDXave0v6BES8+69g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/xk0cB3ejg6x+g8QPLVKlfP5LVx9IUWJ+gsFaeJ3sRc=; b=qg2U/xazEujnmVKBIt5fMdabYAceYoS0V/QvfAPQ0+obl6bioIxJzj8cRa1LF6Frcu+tIwyVw+w6pGPFIJreIYs/WC5quOKZKZfQk/KFwGdoabcHPp5Rzq1m8evT58D011j8T52Va0DNZGjDyLAkHgk5N7qsVrtqUj2a4N66waAX2YFwIpG2z0cJq0rexKMiTl9OinUjRoHhnYt0Ge9chbALTfAUAZVSB8QGq669HyxQNFz4WGYZy0DHUS7bVkUs6DACw5eyiRHIQI/xxbBS7Pu0cl8efggUi1GnB/WUJpDsdyAHb4rtEFHCBuMAK5yb/nVm6y+5H0ooUR7b2b7VTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/xk0cB3ejg6x+g8QPLVKlfP5LVx9IUWJ+gsFaeJ3sRc=; b=X4fNARNt/ANCGgc7ALaU+7LhDebE5xVQDH1nGpmTqDVmZhIp5SRREm6O8U9OTmZ9vEFLlVqrCFvSwDX1ls8zYGKSGnvLa/fN9Gy9HznGssdbWAd4F1ts7ZsEOTp3x8bKzbXHu48LdfCb0kAra7lNiGCAe+1WlmxOOAd0kGfTuwcz75P5nK9Ky3zhMu3lUcVumjoGwxz851R5hlwIT4k/a9UbcTq3cCRFmZN2JcPrPDyZ3o42w8xbIH16G5SOzvSwIoBm6hcQCqD1h2U4NyI5Owy40jceOFIXINMR8rvp2oNh3cvDhyZtNkh8IL1/EiYkktRAM5liObcwhYzz0Ne9/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB7112.namprd12.prod.outlook.com (2603:10b6:510:22c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.20; Thu, 26 Feb 2026 11:47:00 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.007; Thu, 26 Feb 2026 11:47:00 +0000 From: Eliot Courtney Date: Thu, 26 Feb 2026 20:45:37 +0900 Subject: [PATCH v3 5/9] gpu: nova-core: gsp: clarify invariant on command queue Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260226-cmdq-continuation-v3-5-572ab9916766@nvidia.com> References: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> In-Reply-To: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney , Zhi Wang X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0281.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3c9::14) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB7112:EE_ X-MS-Office365-Filtering-Correlation-Id: cec7b3f8-2a4d-4fec-c61a-08de752cc0b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: E7ifM75NDmgpnsuFAErQKXUxW3w6bVfupHxbbOGEIOT0tfRoOViOM9i7ymgTaYVHBRDt/wVrDvzt+impURif1tsy8caTpjl7KZ+QyRWYpp+y3FYJzjRNOn/GT295I1wmsO8w3odekKYQtqA+6B4Pi1Oe76gukoaPi3B6L0WfGSBXdKCzync++J4AfxbfwQGK64ow+Q2dnf7bQUiVvFBAx/9pX5PZj4piL8X5MNpchsrUY9bUrpUitmsSkG/LSHYmzGR52EUrBpNbdjsA/ifyDcy3moWN3+Dts61C078ZM+5rC8u2dEvOKaiXyeCByvTEJuwGwK1qahbbHRx+2R1Mcr2kV49AlQ5R5eCaWWE9PEnqwZGHAshtTYDaYN2TZfONyiaLsfDGGnWpUMY2tA/hkTE3rP8pcK1KOMOZyLEJlwCbK1Wka0eeuk/HTXzXQyFe8rIsdclyHqNRMmtPstc6ZDfh8lV7+6T0XtX3d5Ur7bAF03wJnB2ZHBSZw47UgHAhY9iyNRrJqaroT9/mFc7qeNZ3Rf4aEoNFZpGYdqRL4DtrrVOK/DqwpOQECQtJm54AAQt4Yxw5O+Wc5OU8cmLs2cJ1sL7oyYT8ow0+2XFmNLfg5ybL1RQjTh+Revi7G+KxRMx9cYLTmQ6laAr0x3A8Auj1V+kMOQg01KfsZKnE3aQoHAZCLdMRkye9phkbDKT8qJpFc4q4khchSTLvZi6F5DNhOXqEfWgHXnjaiCf5op9LwuxtOKCDtYJkq8DzQQ0naYzaAkRhhjWUcunQAhT6qg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3dsL3luYy83ZmRnTkFsTjE2dXdqVnJQMjdZNC9Oc3VjeHFNdTlWSTVnU1Q4?= =?utf-8?B?ckYwZm1ESlJpSDVSR0ZzaCt5KzdLZm9wSVQ2Kzdab0phL0hiekRQM2RoNUhU?= =?utf-8?B?QVkwYXNmQkExRk1mU1VCQzVYSVhCZmtURWR1SnBuRGVOTklBdmJjRFpodEVB?= =?utf-8?B?aStEaVpaU3ZzclQ0VTNUeUN0VGVqTTF4NWxsUFd0Y0ZSWlpBc05LWldaTWhF?= =?utf-8?B?QkRsTkNVWm9jUVBrdktOZHU3dGs2NStwQXZpK2QwZUZyMVoxaGI3ditCR0d5?= =?utf-8?B?blh5RDhESFFVUE1ZazRKRmV2WlFYemlycC9nZ1J0QkVRY0haSkErY0NJaFJU?= =?utf-8?B?Y1NzYnJTY0VrT3lYK3RGQUZYYWh0eXFJQUVKL3BjdWE2V0RxNEMybUgwaHVs?= =?utf-8?B?K1ZJSENJQ0UrRytFejk1RFNPSGFYOWMreDhRYTFjcXRyWVZlQk5sVERSWHMr?= =?utf-8?B?UTRiUkJVaXBkN05WTkxRdWozR1lxRlg5MnY2NzZ4b0pDTlhOU3Q3NGlseXRJ?= =?utf-8?B?SlVJb01LWUFPQ2tpY296dHBTWEc3SExDcHNrMzhPdnIwMFV2Tit2ZDdYL21X?= =?utf-8?B?bk1HVDBiOWtoM2FXbUlQZWR0aEpqc3NqaTFFRGZYeEVPMTBDNVdUWUYyRUxC?= =?utf-8?B?ekhPQzhScjdxM0xZMzUrMHdKZGhDSWpUNUxsc2ZvdlZseUxhNWlRYUZiRW5B?= =?utf-8?B?UlFWUGcraG5ndUFjcU9iT1MwSjFiMW8vZW4yU3Fva0NKMkUrWVBQejVndURs?= =?utf-8?B?NUU4K0UrT0kzZU90REtrQ1NweFlnRDMvWlhwbXFmT2lCMWZSZUxEVm00dm9s?= =?utf-8?B?Qll4bUNoZHRZNlFZa0FBUGk0RFVHYXZpcktWS0pDR3cvUlR4ZHVhRUp4b1NF?= =?utf-8?B?SkFwNHBIaU5aYzhsb2hjVzNhYXZoaVBMZHV3L1ZrbDZ4L1B1WVJWa0w2dWg0?= =?utf-8?B?OUdkRzlwM1VvTXY2ZE1sRE1aZnJXSmRDVk1MUmlUZFVoYmFhTXBxQ0dBcmdn?= =?utf-8?B?aktVbzVwcElKdmg1UnlueFE1VXRTbytLSW4reTJ1OU9WYUNheGV6ak5meExr?= =?utf-8?B?UmlJUzc0TTZ5Z2wvNkl4Ym9PRzFwNW5iNEh3RzMvZUFMN2NTNjBvMkpFN0FX?= =?utf-8?B?djJvTVJ4MnczSUZFZ3N2SjQzMk5UY1g0bFlISDhBYzI2aDJLQU50QzNyamN3?= =?utf-8?B?bENBQUg3TlkwSWxJNDVTcS8vcHAyRmh4RjdRSHFXV0hGQWRUN2t4SktSekVM?= =?utf-8?B?UHBWVjZudnREMTdIaVYzRUNyUDBiN0taZExSb2JJRk1vWmdrRUhrVk01eW1U?= =?utf-8?B?a2tqNzNtNkdORitnN3l1cGNLWmNoQ1FPS3h1Ui8vd2EwaVlSeG5vRXFMa20r?= =?utf-8?B?cURaaXdlMmdPTzdaMDRRYjRLcGNwVFFwS2Q2OVdBNFdJRXhIYjVybkFwdEla?= =?utf-8?B?QzREQzNEeWJEOWNlS1g5RDl6and2cEh6aktNeE1jY3VLL3BuemhaRFgxT1Vq?= =?utf-8?B?TVFnR1pxWE4xYW5vSHUxcmVZTHZJOXFrNjcxM2lzQnFyYXlGaHgvcHp4Zzla?= =?utf-8?B?bDJaM2Z0bG1meW5pdmQ4RmhjL3VRam02WmlLaU5jMDlEQTZCTERScktzOWRS?= =?utf-8?B?MFFmbWxxZFpPVExKOFNkMW53REJNTGdxQU5VdCtSRXFYZ1ExWklaek8rK0Ft?= =?utf-8?B?Z0svVVlRUnh5aWV5V3U4NDVVMjdwOFVyc0kvNThGQ25xY2U3TkJBZE5Jb2dL?= =?utf-8?B?Q2RMVjQ0VlNFYUFGVS94cExlb2tXUEdtazBOYzFLc0dnaFBjV2g0OGY2bVNI?= =?utf-8?B?dG1EMjdxTzZPbG1uYTlYZGF4dXZkUkxkU3J0alZWNmV4alk5SitOYmZSRTBU?= =?utf-8?B?aVQyNHIrSDN4UXJybm11SXY1QTBZVzVkaUo4ZjU3ajhvQVJBV043a2ovYVVs?= =?utf-8?B?dHVYTUp1VVFnR0lkdE9XWVN0aElZY2xDbXB0N3VaeHArK3F1NzNmaTZMa0pl?= =?utf-8?B?RnB0WnY1VlJCaEd1ZXFhVldzdkQzM1JsdE9WazFLZXQyc3Q4dDVsbHdYQ0lo?= =?utf-8?B?anlveVZJRUs0SlpEempaWWhvVmRFWkc3WGEra2J4SGI1ZlNrc3RQNGdwOEhy?= =?utf-8?B?Q2h4SFNoRUpzcGl0L1JqVHZCemEzdEJWb1VXbjZNWmdnK2xwVHhHL2pDVkJP?= =?utf-8?B?WDVTcGRIczBuQ1FsOW9sN2RFd0RMdFgvamNqQUwvUVU4T0grSVFpYWhyRFV6?= =?utf-8?B?K2dHRkdjNmtwR2hIYXBUektSdlJ4ZTBoRHJrZ3RsZ3lMWkNGQzZ4TVo4Tlpv?= =?utf-8?B?SnlyVUNDM3FOeEk5RVkweHBieUxCMUJDNjdzTjF4a2hueE5BbGxtUWxCRFlk?= =?utf-8?Q?wpurxY/V2voVr3Ob/8V1k8ZgPWrnRr2+1KVIeDXBOmAFn?= X-MS-Exchange-AntiSpam-MessageData-1: VVDrCZLkFBxOag== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: cec7b3f8-2a4d-4fec-c61a-08de752cc0b3 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2026 11:47:00.6488 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: buBWyCUwBPC55P5YAq1Qcnm4zrUAuyF8zX6jUqPnqzk6RjPqWA9f428SUdcVIrdcxdFVDiTUTTCofLQJBxlaJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7112 Clarify why using only the first returned slice from allocate_command for the message headers is okay. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 3c2652be74bf..3653212efa7a 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -531,7 +531,9 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, co= mmand: M) -> Result .gsp_mem .allocate_command(command_size, Delta::from_secs(1))?; =20 - // Extract area for the command itself. + // Extract area for the command itself. The GSP message header and= the command header + // together are guaranteed to fit entirely into a single page, so = it's ok to only look + // at `dst.contents.0` here. let (cmd, payload_1) =3D M::Command::from_bytes_mut_prefix(dst.con= tents.0).ok_or(EIO)?; =20 // Fill the header and command in-place. --=20 2.53.0 From nobody Tue Apr 7 15:27:24 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011006.outbound.protection.outlook.com [40.107.208.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85CB236402D; Thu, 26 Feb 2026 11:47:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106429; cv=fail; b=O29wgaYbFpMQ9LIwLLSyHO9P1PPCCslBwwuqVzzl1EdtZOnUlnDk5t5NIOA2Hps4dVo/mWoD8Hwf18bNtptW9bR1cigqtvv6HqJo2nQV42c17PCUWgNZU0x6KRsqWLOyAH0ZvA268zdIeAN8prBzuwoMAdTmGC1mTYuV+e7NC08= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106429; c=relaxed/simple; bh=1vOs30wfq9ukEP4Ufvs2NNSGCn+5CDPUpMx2boNKqi0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=fQZMkccZ4bDAbfkJLy2Xu+Mil4qsbYSFsObIzxxVAKSzTm1e26ont+VmB4HHALWhuE+JmVikkn2gp66dqYB82VplIlEuJgbpbabEOlKvAPfPwvhamGJpRFaYRtlR2tWPtuMBAFLxPLaeZmZ6cdCP+y8TH9SDed+NsHAdmZz6o1w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Abf1EfLF; arc=fail smtp.client-ip=40.107.208.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Abf1EfLF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kxjazBS1kincg3wXhyU11T6ZI+5gISI4y6rHiWklTxa8Ewox/07UtnqRw9GYu/OYcNMi5AtLqPh71iyw+PwiCCqFw+4z2tbuJ9A4zQ7wmevM9g48IJ7zqoUWCIv30dPLStH+KRBHL2dIYV7iBQ0d7ZKf3mqWmZjKxQOr7rJMgDaKPRe4Iave30unzyhbGmby73jBtDytTURXzUgjHaPjQsjUur3j9a/HDnOpVdhW4/E1EH2XyfVmhrPjOoLJH64ZMbklJuBpEuKNXvL3Vk08Bl+tpdAJmX45HIFjNqgGMNHM98aEc+jr1510+K3yUY9KPkeUFv+1x4Nrcpl0d6j5eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wuzMRWR+jW/HgR/FN/Y1xTqf9vboNLEBI3fpc3rT3yU=; b=BlcnV6w4XT3Qny9OYgeB+suwNUuzdzkdEk+Z9V8VhX+o6mku0mgzQix9io3pSluKn56xNE/lgXJfBOk16cmS2UUDQWUnuVcc/9oIOAG8Kabzevm6yfh8WVpm62FdlXBwZI5Tw+l/nB5BK69fkPTn/1/doIvIvVBKrVOzqmZJIjP1fpktSj+9VCj0oOFWAVCemL5SwgETfJlDT0kiFXdqUKtILW+kwEyeRTzmtmj+PdjvKdzVgPr97sB485olLGQTQMwU57F+mHf7WKDLJEIn4xatjPxPhlaTgCyHJxfe7WjSvIEqJLwqH4NUA2V0Rkq8Xkh8tA7wft9Wk1BcdKdZlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wuzMRWR+jW/HgR/FN/Y1xTqf9vboNLEBI3fpc3rT3yU=; b=Abf1EfLFuMLyzHo5ZB5VFpn1pXLnnMxbUQ1xp+49CHyjAyAEZtyuvOsprfwV/AjdpRQI9RnCSR0Y4PVumpZo5jcHGoWEExI5mLEffr3yD5HyLmLMYvjMlnCERXye4NYMOOvHK8GudaT3ZmfhFaYt1/WorBP0FxOwK2z9X5WNFwnhrHBvp8gW6LTAUrWmQ58u0ofkYBrok8IAw7/H4/pdDhT3UkDq9uWOLqRybNTNkTiWTswVdh5eeGu1PkXGrZAVsKFSjKFiQfFqtPoW1UnJd9fMDz1b37zb43LORfmhiU+/a2O9gNZ2bcGPcGNlPem6cRj97G4xU82WTCCEMTINmA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB7112.namprd12.prod.outlook.com (2603:10b6:510:22c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.20; Thu, 26 Feb 2026 11:47:04 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.007; Thu, 26 Feb 2026 11:47:04 +0000 From: Eliot Courtney Date: Thu, 26 Feb 2026 20:45:38 +0900 Subject: [PATCH v3 6/9] gpu: nova-core: gsp: unconditionally call variable payload handling Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260226-cmdq-continuation-v3-6-572ab9916766@nvidia.com> References: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> In-Reply-To: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney , Zhi Wang X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P286CA0006.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:26d::7) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB7112:EE_ X-MS-Office365-Filtering-Correlation-Id: 178835b1-4584-4c1d-5a64-08de752cc317 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: 8fpGv0mB2q2HtcWay+gq4SQkLzRmVrqn8WW+4CrnTiEL+SzUAfm0YP4caMj7K5pr3F8ygRtlxTWO9Ht2HJrC32LnfYizQDo6fxJpNOO3Wo5/ShwoUiudurQT9DuBg+gNFp75td+jsokL30Hu5B44u6XxS0JLW7BLPb2dHnqNOsqQiN7Smo39ey00dtSPTOI5I4PqGrL1+vM0K9PBngxrsQ5SuE2rdeQXVGSEhRKaj4qIwYoZbeMcVqdmciW8WBUObOTbxJyZA16HcvXPkekYSRP+5QDShUHCDRgOQZP0Fh46/53nN14m+GL+CjKmwBhLeEC2UD8QnBIGDREIOBQiJXaFR1rvJNGk0lUkPMfvSP6NyKppmrmXQBCoUTBICPWspTdvVW6IpxWgPSIQ1vHn1wNxAhI/LNePK5UEvnwMLLSb41PNRybOSomlB+eNNdD02OXd/KEATChdhi3d1GJ0kntR8wSNGopvuhE00supVQBwcn1xi8Sra5WyEWUqANq7vnkLVb8XdJ4quMy9HdfQt11bjNDuszWniSvWysTa77qZ/coghWG5Z+JfpRXzAoXh+47cVlFlKV8UdMFkg/3J/2/xLo6KLh715/i/Unst7LgCR9zS65Em/s/EBnbNISFG6qrhBNdYU34OXWrTNx4QiXYTHzdEC9AwjwmkAtFfS5vOR5oTk4riY4UkhG9zDatpjjm2S9wPROxcdzROf0ya8ydy2HuWCBrQElujKO4thcnU3At10CUGuymOIwR57itXnLBlHniFpMZUY9HX4bVfPw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OCsyU25HbnFReFhSUjh4R2s3dzdzcWN2NkFwTC9qR2lERVg3dGxlR0h4UG5R?= =?utf-8?B?WGdocTVYRkZJekhpcjJqSUFqd21LeURyUDY3dVhVNGc4bERSVHdEc3QwZHhG?= =?utf-8?B?c3M2U0N1RFhoWDBZKzBSSW1LRHJOWkZlZ21qZHNWb2VWSjV1dDQ4eGZuYWds?= =?utf-8?B?djh2SDRMOEZYNFhNNkNBQyswdmZJYi95a2p5c3N0TzkvWUlwcm1GQkhFSzhB?= =?utf-8?B?RUZWZWV2bFpYVkJvYm5RUW1qV3J1K2pyWWpMN3BaWlFSQ2NvMGlUY01HZ1Ro?= =?utf-8?B?dnRVMDdDRlRFYlRNak40TVo5NnZuTURJOVNpNW9NcmlHNnNwQVlVV1dkbHV2?= =?utf-8?B?ZHdXbit1N2l1WkxPL29BamJKTHJZZzhKbXVwNzVJcmdwZkticFk4OWtHSWpD?= =?utf-8?B?V1Y0K3g3M0d0ZkJSZUdrQWpXODA5aWwrM0dvRWsyc01JbU5oVlB3NTVwTDcw?= =?utf-8?B?Vy91ajdOaFZlbDN4QWxXcU0xMy8rQzluMmxEUkdaMmN6aVpqT2FtOXg0UEdi?= =?utf-8?B?WXBlSHdzRVFWVGNoczJEQ0pIYVJlRkkrUVY3eUdid0szdXdrODJMSVRLYVNN?= =?utf-8?B?a1BzK2VBWTd3Y3BXME9ycFN0TEQwai9FeWM1Z1VmU0NSTmU3RVFsSlZuUlRh?= =?utf-8?B?NUVCRFkwbWhJem80d0JKc3V1d2l3S2k5MjczRkxhVzI2RHZ0UjdiNmxXQUpi?= =?utf-8?B?VlAwZmpBT2ZvUWVwUXJzcnFyV0VXMWoza2t6L2FON2U0MkE2bEJ3UUtNREJC?= =?utf-8?B?V1p6NFh0ZmtTZ20rVmNZanlKcjU0SmEwVFRseFkrOEFFcEk1Y3Awc1VhVVhL?= =?utf-8?B?QmpEdlNISnBTck5RdDYvM3dMSDRaR3Z5U1BuOFhsZW5EM2FaVHRCNXArYU1O?= =?utf-8?B?R0svMTdrVklOUTlQeGhtT21kdGxlWklhMUdIMkRHMkhqMjNwbjNBeml1MnBm?= =?utf-8?B?RDNKb2ZWR0UxbXMyeUt4K3NZYUVTN3JsWTNLa1B4K2VldUZEcUVDTm8xaHk5?= =?utf-8?B?eGhkL2hhQ2pGT2xQWU8vL3dGak55TmhENTgvL0VZQ2gvdWtUa0pTZ2VZUmJ2?= =?utf-8?B?UHkyUlJZdHhQQXhQdDl5RG51UmxDTHltWTcySHlYdWcxbUlRSHVwaE1VVmlt?= =?utf-8?B?cFBGNUVwSk9LNGF5bDdtVVFaNlJFMXR3NHZRTUE3WFpJaXFQSG56Z2Jzdnd6?= =?utf-8?B?WFpqL0lYSkJzNlhMZnZBSktWOHZ2dWNYNGVJdVZHZVdvaFhiWkRkMUsvYzZ2?= =?utf-8?B?T3hBclUySUpycHpCOWFRbnUrNHJldFJDSmI5MmdSazdrd0RHaGtZNTJmdVVY?= =?utf-8?B?a2pmM3pzSWVKeUxwc1N0dGdybllFREF6cUpibmwzc1dOS1c4QlNvaGNaUkJB?= =?utf-8?B?Nks2NnkvYU1PbG5yN1packlmczNLTzNxU1F2ZlVNcUpKd2xqWXpoeVpraEZ5?= =?utf-8?B?SGhEZzF3ZjJYemR5Tk10R3htY3REL0FldFNCS1hoQnIySHh1bjIzSDNlVXFW?= =?utf-8?B?eVdQQ0FCQzJZVWZZUEhBUVVaTlMzejJxQzFVZlRROUF0VFVqNUpVdGNHZVRN?= =?utf-8?B?c0xVbjQxVUdYb1Y1ZllIZENmR2J3ZlBWU1ltR3JkY1RGMERqY3RPTCtQS2Jm?= =?utf-8?B?V0V3dWNhMk5ETDNCdTkwUi9uSmxZZjhhcnZnS3h6b2t1ZmJ6dEZaY3FJSGNM?= =?utf-8?B?TlIxbVJGN3JmQkJGMEVFZlExZ1hIZThoQjBKc2VndlRFYVk0TnpXTzRkODQ4?= =?utf-8?B?dHBpa1g2YmVWa0hqVTNSTXU4WUtUNHBCNElLVjlCcFUvLzRETDZITzJaUFFt?= =?utf-8?B?d3ZkdkJhcEJpalZ0b3hFeXFqMXY4MmU3K005bWxHTlorRzhTRDB3VXFrWmRS?= =?utf-8?B?TVNselRPdDNLZ3oyeklUQ1c0V015Ymp5dXF6VktMSk9hTXhmNUNwYlRDM0tZ?= =?utf-8?B?Myt0TkVibGM5KzAzVU93YllxT0dKOWV1MktIUTlxaFRXMm1OWUdTcFhvQ1RG?= =?utf-8?B?ZFFCcHJrTWwybXBLT0c2Z0daTmdBSTEyTmlvelpoNzRLdHh1ZkZDRjE3UEJQ?= =?utf-8?B?a0JwejA5M21hZWwzWjF5djVhTGxjN1ozUzR3eVFHSHdDQUMxcWFPcmlneU90?= =?utf-8?B?eExhWGgzTTRkcE1LeWtEZGJBU0FmWmtLdllXMnFGbnE0ZzNmU2lXYnl3YXJn?= =?utf-8?B?dE1EaG1tcVhvSzBwNStVVmZnZUxzN3RxTmJTS0ZmNlVyNm16ZkZoYkxDSE9H?= =?utf-8?B?ZFpEVzdDWFVuQkMvSURPanMrQ0t6Z0djZ2RYVE8wUzBFbnpFdjk5NFVVRjdI?= =?utf-8?B?TUIxN294NWxyTXE0K2ZoYTNQOFA0SHVQRi9aTWk1RDJJNUFVZ1VCLzlCaVdS?= =?utf-8?Q?YcsdufYf5B8zWc0ycDypvuTjNc5/gVLsc5WhzN1JRxxjo?= X-MS-Exchange-AntiSpam-MessageData-1: lqgJ9KHRhuHAfA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 178835b1-4584-4c1d-5a64-08de752cc317 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2026 11:47:04.6556 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +oJZoGNaKynUD8NAtEw6bTIeRjoBvvJhuSXTQvneeMyCuUG1PSJS7IdC5VRP9mqDA5ms4WajBAyVjxVv74rmsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7112 Unconditionally call the variable length payload code, which is a no-op if there is no such payload but could defensively catch some coding errors by e.g. checking that the allocated size is completely filled. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 3653212efa7a..9f74f0898d90 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -545,16 +545,14 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, = command: M) -> Result command.init().__init(core::ptr::from_mut(cmd))?; } =20 - // Fill the variable-length payload. - if command_size > size_of::() { - let mut sbuffer =3D - SBufferIter::new_writer([&mut payload_1[..], &mut dst.cont= ents.1[..]]); - command.init_variable_payload(&mut sbuffer)?; + // Fill the variable-length payload, which may be empty. + let mut sbuffer =3D SBufferIter::new_writer([&mut payload_1[..], &= mut dst.contents.1[..]]); + command.init_variable_payload(&mut sbuffer)?; =20 - if !sbuffer.is_empty() { - return Err(EIO); - } + if !sbuffer.is_empty() { + return Err(EIO); } + drop(sbuffer); =20 // Compute checksum now that the whole message is ready. dst.header --=20 2.53.0 From nobody Tue Apr 7 15:27:24 2026 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012013.outbound.protection.outlook.com [52.101.48.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B58C83815E9; Thu, 26 Feb 2026 11:47:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.13 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106433; cv=fail; b=gX8QD3Xv6CCSquU1U7A69h7mGZZ1geS4358DSSsUYvUGvG04hh1d9H5JBYY8Qx5OEgG3VD2cAeix615qBpgQSqWswm4B+e2heeKawLDpbHrxSriJ9FtodJx39HvaZUOZ2nwJJzlpRS4Slrh5yhoVdZRnw5IP4nemJ0FSNB9mtbk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106433; c=relaxed/simple; bh=smEDmdlthUXHRfuED4WNCaHRf9woJLdfZAegYw2XLjk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=sU4/67MgSpxka7WdxBiIY4dfS82u64iL1fmlTOyw+vkDMNHCSkUqRhnXO1VxXO0ZUGaLMzWL6hdawnXjszPUgjM8CinkKWqYx1NL9S7aMibe2pVKJQ3pjcjtVfjMDoDJbpvSuW77YptJb+44Gp4PJklhDNnNJWbaoIsR/X541+4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=jTudqZoP; arc=fail smtp.client-ip=52.101.48.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="jTudqZoP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=INsZh8T+MwHsEsZ0D5CvfrC3T5cs41g1Ktd96ut6KxyEqnXoviwLjoK6iPmG3SIhlDRhrqdyDRDUJsuGYkrCfWWoMQjAaiMxnxzJXsAznaAov731HsG03QsCcB2RA4QhESr4KOEoILSn1QYahj8DjWKM4KbI5PGCpU0NxR0G2eU3hvr/6Y9LcvbbUefOe1P0+VAVhnQcs9hBGLp32ERZ3CbCUAZtOzvzZBH8Irrzy55n7MkvdhS9WUxWOGn7zPcIQ+wUrEAoVgqUn+NQ1BOgzeQG5BKx/7gTRAHpCHCaYJlWdf3xCugKFNE+18Yfaif2WA/YnBXWr+v2xpqbPYHXPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YHyYwFhSGalfP502Ba8nE94zzxFZO1J8n1P1B4869tc=; b=YiT+bFVJVGLyIRqxcTQVjuHLa5pqYGj5I9seZjvyANrbs+ffjeJsMGuJhSFJpR3Zzc0j2C7HU9wrQAHAkDn2E9mQg7mq7rtoGqOHO2HT525Kg/OrD3UHLA09cdWTs9xpczX+nFFWe77S5iJc9LucE5FBF+0o7muuP8Mn6EndedfbmMljrzYhTr5O3gn0buV5ESYyuBoC0nroNTdXgoyHSaYC/VxVIFAUu8x2B5NdkOA8Yj++f3b1eAxRI441qOTY64UkPBAnO3EWs3V1BR31F7VwbyqSEJeoFMGootoy1bpnoY19WRwTSx0BOLBsbx79FXJa0iiWrzGlucLoeeW/RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YHyYwFhSGalfP502Ba8nE94zzxFZO1J8n1P1B4869tc=; b=jTudqZoP+1pT4muv8Gly9LO6hFjcESAwW5ODyybrU8sIt6AAqbRb7AG7POWh+Uc39Dg2c1yoQEgcoaRBI0FhU2F1ZBPUt1Ay2SHjaHEzgmFjEJnduJW6tvk6PSahYfpEhaHUktpO5VDnJBz/NEj2xe6BbGj56/DGH9RaQsE9zAb+1Gec8AR621QjK+xTQJ/IF7816ikxKG/R/1FHcOWVv4QLUiLpVpYuCKvgBJkJhvzBUVhkhnedxXdcGcEw93kXg2QwpQU8Wav+rN4AMnhVvP+yZd1PNCJXHer3n+ZX2wE+nY43qDllfjwK8AUVcZGJB/Xm2YLqEHFsuG4lQEKj6g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB7112.namprd12.prod.outlook.com (2603:10b6:510:22c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.20; Thu, 26 Feb 2026 11:47:08 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.007; Thu, 26 Feb 2026 11:47:08 +0000 From: Eliot Courtney Date: Thu, 26 Feb 2026 20:45:39 +0900 Subject: [PATCH v3 7/9] gpu: nova-core: gsp: add command_size helper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260226-cmdq-continuation-v3-7-572ab9916766@nvidia.com> References: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> In-Reply-To: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney , Zhi Wang X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP301CA0001.JPNP301.PROD.OUTLOOK.COM (2603:1096:400:386::19) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB7112:EE_ X-MS-Office365-Filtering-Correlation-Id: 15969664-1bae-4a96-78c1-08de752cc554 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: VRajRYLyJWVrfTEEC8guCm/geh5DIoxArHLSKM7FVJuYfRTDemUoa2x9MIWG4UHGcUsaJpZkR3CSzMEvFCRgjqrQl3CuOuKpmai4WDeWBPu8oxDUGuYQrV2LYOevjJPT7QgnwYm4xZCLcJY7+9s3oy9qwEgGwl9MCQfDwgZOHlA+C2uvWpjRpJxpsm96Z0uhZRB+lAIy9F9Y9rilm6/I8oMt90iSln7sXXQK74q73cVrfC59LQzdtbO+z7mVzhXwDNFCv0ZFXN92NVzp99E0IFOhRew5fuYjvrQ2+wtD1jRbVOuMENhJ9gJy4AlkkgxHDkWBzlqIhoqqA1KXyF2l6Xq0Y18QHgkvduPtnZQR5bmDuOa8VVkKUkjceRtok4FBt+1lzxo89Ckk0NURHGKRp6OiDu88Zhm6YtajR+JjAARkkVpJR8+LYgGboWZ1EF7+4vWBkmuEZDOo+SEjgMac1QmUYOawY+9ESm9I2UXvnE5fDQtQPpFg8pFsmUYL1Oj4vGCS+jTjsONJ6TFXgxjrtguWTXaAltV4w+JQDAM1hktIhZjMb+I0chQ0uMKacpq1NjyCNPDaFl2w7Va2lHXncmrS7uCHoVdURr8r9X3fkl/gZBDGz2HzdPDPQ+T+zFxMXg6UufMc0B4wnyv48sv8R1avzTL+rvEtRgU5whJtEHrLe+e+/ePWOSaxqKO/r1fe4p7joMfFZ1eDOLLsbDkGXMoEoa6ue2jtU/q5vDtvpZFunjebanaSXLSTH56N9aWnJN9/cupDY4YxsFiEiosEvg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVk1TDhNVzJZWk42RlRYbEhoKytQT0wya1NUa2xlbFhvczIwUXByTVp4a1hj?= =?utf-8?B?VHF2K2RYNWhzS2oycXUvVjRvWWpTb1QvalUzaGFMd3VNTklVTzRMZHRIakxV?= =?utf-8?B?bFluam1IekhaSVl1dktzZVpiMjY3OWpXQTFjMERKTURwdERaN01mMjA1ZjNO?= =?utf-8?B?cncwbjNLK0tBdlVudjlOTkNhUmliWkkwSGJWMm91VTlOeEwvS0dndkJjZVdu?= =?utf-8?B?T2htRUFDUnBxWWpGWGc4N0ZEck5hNTlaRDN6REFSYmIvNi9DSmhTQXRKM29y?= =?utf-8?B?WGE1bUxFVm52MXliVGRVVzZJS2pzdDluWnNWSWNja1RlK2tjUHR5U01JdURs?= =?utf-8?B?dEYwWnVzWHd3aEx2OHpRaXpxQ2d5L3R0QkVmSUQva1M0M1VQcnMyN1Nnc2Fl?= =?utf-8?B?ZWVLV0s5dFd5Wm51QVNld2dtdGdWeFNSOUkxQU1zaHRZSndLbm9vcCtTQ1VX?= =?utf-8?B?cDU3VnNXdVVOeXlrTVBkMG5MZXZHSVZQN0ZtUFBZRElpazFDdVFBUENHWXJC?= =?utf-8?B?SW1kRFZJUTlNdFBONFR2cVhrbFZZb1F2YWNHVzhUdmVkL2IraGw2TlZhRHZy?= =?utf-8?B?bnNYdFpNQzg0M1l3c3lQMW9obkdqQ0xIOVc1cUo2b2Z2NEU4UEErUWI5SGFZ?= =?utf-8?B?ZGd4WjZXWFZiVytZZTU5QXpOU2QwQTl1dldZVzk3VGt3WlowQkpzNWNoNk5l?= =?utf-8?B?RUVBc1hmMzRNaDVmU2ZHZ3AzUTBEWXhRc2VDSkpkSHZ3WVBQQUlVcVhJaDl4?= =?utf-8?B?bWVuTXdOeWd6aWZnZnBhWlhMWUYyVHM3VUFvMlZMYzdrdHBnN0hGTFEvNlQw?= =?utf-8?B?cEpUbUh3dVNYSEI0QTROVWVZcXJVUVE3bXV5RmhMUEtIUE5vbGphU2JNc05l?= =?utf-8?B?d0hsWWlOaXJRKyt3SzY3V3lERDhQYVlUMG43bHdLM01nMEhHRjB0a1ErNmF1?= =?utf-8?B?cWliN2dxejhZL2RUYXJnNzI5OHBjZ3RqY291ZlFaYkZoRDQ4VmtINW9CUWsz?= =?utf-8?B?b1NrTjYwb3FoUEl3L3N4ZTZZTGJjb0ZuSVI3T2tkeEhjNkNMZ3BkVUVLQ3dT?= =?utf-8?B?czBKZ0ZtRnRoMDY1UkQ4U1FURDlUTEZTSUMvOU9vM0ZNV3pQMnRmS3RvdlhI?= =?utf-8?B?OWRPeDJMRW5zQUtmVzhvYVI3NG5HM3ZEUXdzb3d1bkMvVnFubnYvZ0g2MjZP?= =?utf-8?B?MmY1MGJqRVhWeEZtT28yR1R1bmNLTmFaVGNoK0FQR3RLSlNWZ0RpVnNLWEIz?= =?utf-8?B?V2F3TzZGQ1prL0s2eTF2am9YQ3dmUVd3TUJ5QjNsZ1VlVUp0eTJJb1QwUWEx?= =?utf-8?B?Y0JOVFdSQm8ySVkyWGNYZ083ekhkZGlUby9kWjR3akE0YkRjZ1YvOHNZQWZF?= =?utf-8?B?NGZ2a2FqNHl1YnNGbmdxTG11N2dsMklIejRqL1R2ZjVJc2hBdzQ4Y09yaE1q?= =?utf-8?B?VHlwY2V2cWpiTHpCUGRQTnFmUDlmR2h0YXFHKzAxRGpHUDRGTDk3QWU2dTBs?= =?utf-8?B?QmJOQkVwL2h2cDJGVnJYNGRMU3lPR2FmMndsejlmVDZEM2VzVFdRa0liZWEz?= =?utf-8?B?SzJLaXdWT3BzN1ZHWlhySjRpU0xDZS9vM0FsZHRIVXVRclp4ejN6cDk1K1p2?= =?utf-8?B?UjdRY0U1dGRBa0Fmdk16UUt5MkFKU0g1WTQ4OVJtZ015TExkWnlpSjFLVDVU?= =?utf-8?B?UXJqVGRiSEhIc3B3bVFJVjBwQ0x3b3JtZzRxWWtiM0p0MURzOWtUajVmSytR?= =?utf-8?B?VlhOU1BEZjZiZmE4QjJ4WUlWQU14U2VxcWhmY25JL2FKTFlXY0pNcHl0aFpK?= =?utf-8?B?RXFpYkVPdHRsZnNzd1NZWko5NHdITDg1dUQ4NjE2bjhvbmdGMktKTjVjNmVJ?= =?utf-8?B?OEtIYVlkV0VEeXFxSWNYZEtiT0EwSnpXOEMyUTNpSWhFejROVjZ2U3lnKzJm?= =?utf-8?B?dDFRcWpNbU4yMnNLTU1CVnBUdDIrZGdjWkZFbFR0bExhSGFZb1p6YzUzNFZR?= =?utf-8?B?Z21QY2VxQzJ0TytyTkpPU052bkp5L01CRFlKN2VZNmJ6NTlHd0U4WDYyWFZH?= =?utf-8?B?YVQvcDdKcjZhcFphMGVPMmhaRWVxYzA0RnBZTC92eXlra3lSSE51ZkF2dkJw?= =?utf-8?B?czdXOTNUUmJ2REx5QXFoMmN5a2VCdWNZKzhhazZoWlBYdGZWSWs0eUlhWmtX?= =?utf-8?B?WjZIZ1A3REJhbXZvaXhpSHdXKzgvM2dicmpDYWhMdnRsQnJPNURVODZVYjlY?= =?utf-8?B?L3BZZGFOQnRubU1BMlZVUk5oc2p1UUZIUkJ1NTQ5Zm5WNFBYN2Q5cmIwQThV?= =?utf-8?B?d1Vlc3lVa3NLMWVlOW5PQ2NySFNlbU1sZVM2WmZuV0gxenBJdjBVZk4rZThs?= =?utf-8?Q?OnqvYPDaMELhDIgPFztre56znAXXJPRN9yQ65jYu0lv/B?= X-MS-Exchange-AntiSpam-MessageData-1: V4Sd8ke1MajJbQ== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15969664-1bae-4a96-78c1-08de752cc554 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2026 11:47:08.3875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QXkEbOB5p+rXNIo7d9rBF3WUXgpasIZKFj5wmakUWC3XYeHpjudwoixmHQ3Ej2PJ20pmRRX43aDFwseS/2tB7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7112 Add a helper function which computes the size of a command. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 9f74f0898d90..4a663a5b3437 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -450,6 +450,15 @@ struct GspMessage<'a> { contents: (&'a [u8], &'a [u8]), } =20 +/// Computes the total size of the command (including its variable-length = payload) without the +/// [`GspMsgElement`] header. +fn command_size(command: &M) -> usize +where + M: CommandToGsp, +{ + size_of::() + command.variable_payload_len() +} + /// GSP command queue. /// /// Provides the ability to send commands and receive messages from the GS= P using a shared memory @@ -526,7 +535,7 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, co= mmand: M) -> Result // This allows all error types, including `Infallible`, to be used= for `M::InitError`. Error: From, { - let command_size =3D size_of::() + command.variable_pa= yload_len(); + let command_size =3D command_size(&command); let dst =3D self .gsp_mem .allocate_command(command_size, Delta::from_secs(1))?; --=20 2.53.0 From nobody Tue Apr 7 15:27:24 2026 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012007.outbound.protection.outlook.com [52.101.48.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BF483815EB; Thu, 26 Feb 2026 11:47:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.7 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106438; cv=fail; b=jaLUyBrISkjwCuP7L4J4I9/L2i6EG1udlYA+vnfiPynnLyHy/ahOfgFFYarmTL7pmIzZ3M2L+gfZYMfPUxB3nfgil499IgsKeEWZMXH/O6LA3Tnmsfco4DHc4uSSU4RZ39QfSXlSoPvk40xd22Frjv6K1XBXNAF4DFx/MW4Xqyg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106438; c=relaxed/simple; bh=7MAfeSqNTh0XA+Ad7WNFNRWBTUMI7B6wUYlSI2NOUOk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=PW7kwged66d+bwjD8jHIE95/C2huILhHKwJBmlm6lE63CAOmTP2kKk6rxhBTIatWXd49wmiGMCdGe5CkSds8qEmCrD/VIYCEF8LmKaflJqP+JV78kJAFCvNqwvdob0LLiglWnyMi1HnMiR7Ex37VXBhaysq6hxrfBkAEAs0yCgw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=cONv0/ls; arc=fail smtp.client-ip=52.101.48.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="cONv0/ls" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ONEHh54Cifcu7kTM2j1WaGhqC1hAzEANMeegQVG01kMwSvOX2m3XOwUiR9PotBpCvmeCNfEOYucmTgpl++8j13wqt8KvXlg5SV35UK7ak/TSeJ/cRu8O0U2E3fpFAabvA4uShieiZcdWrJ8DCi0irb+E3NZE4TIopAQRL89Du+FXubH5e9oKdt4GGXNO85X2aZE7IBPY6isXvUDlNsk6ciTYTTYjEb8jz/eITBdTI684KEidjXKn8f1DGXRFsmQ6YVfVgxNM9uc2KH5hJ/vbyHd/r/fGnrKfBI+1kQok09DCQQAy/0Ex3EKWd1hz+XOW18YHL3QB6hQOKVWBNNxuwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NqqMof2duYqqHENJt6n289KYKJ+n1ZwiwKXxOsdEXd8=; b=AArRVj2HvGJbQSzJSpvUe3qCoZzGJe+jf+PZ0DXCUjnRwfczJrhcbvuLfbkRgerN8+Zixu/F3CcCZ7l2fQxFjCdHFi/xZuV1iFL+auyLPdRH0EA8gxNukt1vbNMntwuQXVowgZ1Y9ABtCGl2Itgezj9v4Dj8ZxzSyPhNGKDeqd3CVOyOqobXMdPLi4rci8OE6TaweiN0n5Hlaj5LMFZnBemXNFwDk+LTNuzFcPn8ymtYHHnJIZCuwc6GLS6cbABJEMovjEZAsFjry1C3WBRAwnrGna+Wc2pBaZ4MrOuJSpbUwxFwTK0I5GQgIKhBV7Zg5WLuTMfgvVed23FKlORHaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NqqMof2duYqqHENJt6n289KYKJ+n1ZwiwKXxOsdEXd8=; b=cONv0/lsKYqXWc22PhOfdMcwOci8sl9pvqkh2Tq+ZyKizPhA7+GYuyc5bwc7GwogSX5RxzkBHLzcuv3WrsakLRFD12Neg+rRTodyVsb2Q3YYJLC+rvVxu2cnoi1G9kv4N4G3FCvAWMziqvndnBfejP0hNJunvjAeispRi4xfk3Ub63tvgjRq/7SW0rxzLp70iGhextbMJFWmg11vqIQ61fEWgaWzFL2dPdWWzs2r30S4y8b+ENaJuPsG6IDTFfKn84ISOGRjGwMVW1341IoKIdADlttev22yevJZ27EihaMWPmPBkHRHNV7+yYEU9mjvMnhhjYXdq2fhmMjSk/v3hA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB7112.namprd12.prod.outlook.com (2603:10b6:510:22c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.20; Thu, 26 Feb 2026 11:47:13 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.007; Thu, 26 Feb 2026 11:47:13 +0000 From: Eliot Courtney Date: Thu, 26 Feb 2026 20:45:40 +0900 Subject: [PATCH v3 8/9] gpu: nova-core: gsp: support large RPCs via continuation record Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260226-cmdq-continuation-v3-8-572ab9916766@nvidia.com> References: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> In-Reply-To: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney , Zhi Wang X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYWP286CA0015.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:178::13) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB7112:EE_ X-MS-Office365-Filtering-Correlation-Id: 8dade729-5f34-4549-c659-08de752cc822 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: UOrjHZ/vx7sX4KVyuGo8dLFzHmpicRn9YxUGJMDKJnucWM5jqJKcioQIxuRGaWRC8Q6XnnEJ3UJ2znIwqadOgNcZ2MQHflWaXNNFgyJPWzVK+YCZH3pA5k/oB8I/W1FBVX+SayemoxY0tjxjm07XzFxBDjpdK2TIDd60ztYW32JdUWefvUK5CCZ+uxebLL3gupMy1v7LQtHuOeZHS3HMvBeILoxFh1yGSs422/nYzr/O/8V3Fkrtq0/2g2whKEvPy5+nvd8BVOMWsOuzLiv8IP14+uIrOLF6Xzdh1ISg81UQTZaXRYlCbcm1dFukFQN+oyol8x26kRxDk3ta9zVcoHvjWa/pgoTER5plJDJovYVLFcUzBDWylsna8vgNUjpQ4nWFCQOxwtnCyQH+0To6IDJe4SIY2CuBLsq6NiNoIDXpiZtKas7cbcmfUJ/tm2jVGpbU3xXod7lRdP7MNxoSD8c9gnoRcWBVANynx0K5E0DlZc3FYkdllDmdc21+BUdyWvfpFuFvaS9Wom+29IkeL5tA7YUtXJT68UxpihPruMKzzikYbjez1oiP90qYu4E4bwZzC3oC7ctqX+ThkFGD6nlrgWhXAggp18IR6S5/MBXj5rKV7icqJDs5S3umJkktqKejMjKdvuKHBSMPiN1GsiMKxgwym6NCBfoJah8Xr7hGqw3DLrtDDau4yUJfMz4T0RqsPj8ixk+s1uOQ/ab6ssEdyVv5TNVzXjJJ83+RdCAW62KIYe8aF3TegZiwhz2cSHGEpU/MInfskOtxkj/LnA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1BhUW1EOEpUS1lNSGZOUW52TnNoRkg4OS9ORmsyaGJkYzF2NE5JclAzWXp4?= =?utf-8?B?MmhEckdWZnZKS1JJWXlXUEY4K05ZY3diMnVSNlRKOUZuRVo3eVNOR2wvSlhV?= =?utf-8?B?QnRWVzZLbHZCZWlwSEN3RjdVaUp6Nm41VE0zRlk3RGQvbWEzUmxFaGhHSTVR?= =?utf-8?B?RDQxUGFuT2QvSkNsOWhyMU5ta0J1dkcvN21RUUtKOTRwbHVSaXBENGRJS1RQ?= =?utf-8?B?dWdzdUU2dkZYcFptWHFkMm5OTFlPYjVYcjhjNTNMYnl3Q3phM3RqWXRaZVBi?= =?utf-8?B?Z0VnekZ3cHowNFhCZmpHc3NsN0s2cDI0cW5xU0xVU0dKYUFwQ3liWUZReUZv?= =?utf-8?B?ZTFiREo0cXZNM3hxZzNOK041U0U5VXRvazBrcTNiTVMrM0NqNXlMd1RiY09C?= =?utf-8?B?WVNwOEVpOFRrNWt0M3VvekN4N3QzdnVlcDlLTGR0cXYwMHlLME5CamZwTFlK?= =?utf-8?B?S0Z6MDlyUmN2QlJoTTl3TElRQkFnY0FkTlVUajk3WE9pMTVIanRLY0VmRXBi?= =?utf-8?B?eDFNdTZsZlVHUUZPenVBb050QTRwbDhKUlBOQUpydkJYbVV5dGZ6dUx5Y0pQ?= =?utf-8?B?OEdrVWM2dXNHcE4xcTR6TnlwbWVQQW8xNWpGV3cxcFZsb2dpZEoxQ1d1UmpS?= =?utf-8?B?ODBpa0lEcFVOQnAzcHIxZVN4STJKbEhjT1ZZTXBBVkVaYmJEK1p6RFNML29K?= =?utf-8?B?QXk0TkJ1Rk1mMjc4TVFtUnA5S1VOcHdESzZWcnNyL0tPK2t4ZEFjSG9KQ0Q1?= =?utf-8?B?VU9GUXRmTHpwR0VvVC8vRmZvNlF1dDZUM3BneVZXOW9nYkp5dlpGYTA3bklr?= =?utf-8?B?Y1JXaVdEVVF6VjRJVjExbitiUVZZSURRdTgvb2xYN0xGbDBmZU1YMEx2WDFh?= =?utf-8?B?NHk0dERoNHptSmNHNHI4cFFEOVhCNmh6ZWZYRXNtWk9HaDFsRmRETzFaOW4v?= =?utf-8?B?Y25pN3doMFRjTGpQMThOTTZnaFBXRS9mV2RDcXhuQ0pXT1pQNFRtVzhFSnZv?= =?utf-8?B?b2UzL1V5VXIrWmQ1aWQxcTFRYkE4SzZRc1QrV1NTaTAvK0NjQ3dNZkdSdGY1?= =?utf-8?B?SVJtSklXWGhGVzlCRU5IeXE1VzZRK0trMFZVbmFpVTdPalFuakd6ejhWT3cv?= =?utf-8?B?aXA5OXJtMXBVMmRORHBvb2lJZG9VZWZRcnpnYTV4Sk5zZFgrbHllSlNIbDUz?= =?utf-8?B?dENxTDBFSXN0L0prc2JVZW11cHBhK3FocG1FdzUrWHRRM1JPbmM0Ym5hUWtr?= =?utf-8?B?cUFwbHo3SEJLSUtrMkRCN05QSGJab3ROVmsyMEV6eXp2eEhUUjFDSG5qMHpJ?= =?utf-8?B?N2t0WEMwKzd1TTVhVENqNzFKdEVJbmsxUkh0UkN4QThxTmxCUThpaFdLS3hX?= =?utf-8?B?dmtrTkF4VzA3T1RhZEZhQ0U4cVNGZkhuQmhtVE5wWC82VThOUzR1dDRzQVpO?= =?utf-8?B?TXA1di94dGtwbHB0T3M1eGpveUtMcEQvUkxXYXpUcEhQa3FucUJxY0xaajg5?= =?utf-8?B?QUFtdVJYTTdsYVNhM0RKV3ZQU2dVa013VndIWDZGem9iM0RacEJtMHY3eHNE?= =?utf-8?B?TkhxdVFWWnBWNzBhVUJ4WmdrMjErM1hSZUxybjFrV1N4SXdPazVWc2xZV1RY?= =?utf-8?B?WlFLSEloM3pVSjVsVFhsRStXL1VBbU1nTHRDem44YlRkYUZLSjBkWTBXbHk4?= =?utf-8?B?bzYybmFJQllkMHJNRTU2eDlySWRtbWUxZ2ZmWEtNTnlES0x4cGNjcHIvY1p1?= =?utf-8?B?UG9XWXdTYXdSZ2ZyYS9nQnNWUTQ5ZnBwNWVCVlBEMFo3WThlem1kNUtZYUVM?= =?utf-8?B?U2VxN1p6Vit5eUp2RmJRNFhKd3I0M0RrWjM1Z1lyMmgwTG1QZ1cyL2ZlZWlU?= =?utf-8?B?SmJSWWVhd1VMVVNJQzBIQ1pJeDgrNlB4dWYzdFBoZ2pwQTBjd29BaW9PMkkw?= =?utf-8?B?UjYzamV3allya0xBTURHOVgvTlFJL3B0Wk5RWWJUZUpKcnp5UVRHM3dDRzBn?= =?utf-8?B?OGVoNS9kR1BWR091NzhxK004N0hld3FWS01PYzl0R3l5ZlY2dVJFcW5NcDhq?= =?utf-8?B?bnI5azY4KzBqY0VxUUJZbElDaDZCTXJQN0NBdjF6NmpyaUtPMkNIVzNZVFZr?= =?utf-8?B?K3pNL2VJSzJiTGVQL1E2clUrQUVUYzF6M0FyTWxWOElYNHRYeGVWK0NjT3ZD?= =?utf-8?B?ZldRdXIrejNHMjNyQm55YUJUZTR4VTB6ZXNzRlI2Z2pZOHU0UlpNTlI4OG5V?= =?utf-8?B?KzJ6dGV4RE5hbzB2OVVvd0p1OWZMcmQ2WGpNTThVWWlwci9QNHdhZEdjLzFC?= =?utf-8?B?SlBJU1lITTFKMTZpTmlaRHFVN2I1ajRQVDV2V3Y3TXM1NHhwRjVqR0hmd3hY?= =?utf-8?Q?fcndBckQQC0li67z++SjqVvWYvH4X+ItPMIoDypOV4Uvb?= X-MS-Exchange-AntiSpam-MessageData-1: gYYSb/7v3jhu7Q== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8dade729-5f34-4549-c659-08de752cc822 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2026 11:47:13.1934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CzxWu3zJxXjgLhR6a/oW1Pbqi1NVCf1F7hZNcKc1MrupRb7qnlKABQ4qXFlJArPPFpt2HOtWoR1AmpPRuQp1RA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7112 Splits large RPCs if necessary and sends the remaining parts using continuation records. RPCs that do not need continuation records continue to write directly into the command buffer. Ones that do write into a staging buffer first, so there is one copy. Continuation record for receive is not necessary to support at the moment because those replies do not need to be read and are currently drained by retrying `receive_msg` on ERANGE. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 43 +++++++++- drivers/gpu/nova-core/gsp/commands.rs | 144 ++++++++++++++++++++++++++++++= +++- drivers/gpu/nova-core/gsp/fw.rs | 4 + 3 files changed, 187 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 4a663a5b3437..d68b93ddf7cc 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -28,6 +28,10 @@ use crate::{ driver::Bar0, gsp::{ + commands::{ + ContinuationRecord, + SplitState, // + }, fw::{ GspMsgElement, MsgFunction, @@ -452,7 +456,7 @@ struct GspMessage<'a> { =20 /// Computes the total size of the command (including its variable-length = payload) without the /// [`GspMsgElement`] header. -fn command_size(command: &M) -> usize +pub(crate) fn command_size(command: &M) -> usize where M: CommandToGsp, { @@ -520,7 +524,7 @@ fn notify_gsp(bar: &Bar0) { .write(bar); } =20 - /// Sends `command` to the GSP. + /// Sends `command` to the GSP, without splitting it. /// /// # Errors /// @@ -529,7 +533,7 @@ fn notify_gsp(bar: &Bar0) { /// written to by its [`CommandToGsp::init_variable_payload`] method. /// /// Error codes returned by the command initializers are propagated as= -is. - pub(crate) fn send_command(&mut self, bar: &Bar0, command: M) -> Re= sult + fn send_single_command(&mut self, bar: &Bar0, command: M) -> Result where M: CommandToGsp, // This allows all error types, including `Infallible`, to be used= for `M::InitError`. @@ -588,6 +592,39 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, c= ommand: M) -> Result Ok(()) } =20 + /// Sends `command` to the GSP. + /// + /// The command may be split into multiple messages if it is large. + /// + /// # Errors + /// + /// - `ETIMEDOUT` if space does not become available within the timeou= t. + /// - `EIO` if the variable payload requested by the command has not b= een entirely + /// written to by its [`CommandToGsp::init_variable_payload`] method. + /// + /// Error codes returned by the command initializers are propagated as= -is. + pub(crate) fn send_command(&mut self, bar: &Bar0, command: M) -> Re= sult + where + M: CommandToGsp, + Error: From, + { + let mut state =3D SplitState::new(&command)?; + + self.send_single_command(bar, state.command(command))?; + + while let Some(continuation) =3D state.next_continuation_record() { + dev_dbg!( + &self.dev, + "GSP RPC: send continuation: size=3D0x{:x}\n", + command_size(&continuation), + ); + // Turbofish needed because the compiler cannot infer M here. + self.send_single_command::>(bar, contin= uation)?; + } + + Ok(()) + } + /// Wait for a message to become available on the message queue. /// /// This works purely at the transport layer and does not interpret or= validate the message diff --git a/drivers/gpu/nova-core/gsp/commands.rs b/drivers/gpu/nova-core/= gsp/commands.rs index 8f270eca33be..6ffd0b9cbf05 100644 --- a/drivers/gpu/nova-core/gsp/commands.rs +++ b/drivers/gpu/nova-core/gsp/commands.rs @@ -4,6 +4,7 @@ array, convert::Infallible, ffi::FromBytesUntilNulError, + marker::PhantomData, str::Utf8Error, // }; =20 @@ -22,13 +23,16 @@ driver::Bar0, gsp::{ cmdq::{ + command_size, Cmdq, CommandToGsp, MessageFromGsp, // }, fw::{ commands::*, - MsgFunction, // + GspMsgElement, + MsgFunction, + GSP_MSG_QUEUE_ELEMENT_SIZE_MAX, // }, }, sbuffer::SBufferIter, @@ -242,3 +246,141 @@ pub(crate) fn get_gsp_info(cmdq: &mut Cmdq, bar: &Bar= 0) -> Result { + data: &'a [u8], +} + +impl<'a> ContinuationRecord<'a> { + /// Creates a new `ContinuationRecord` command with the given data. + pub(crate) fn new(data: &'a [u8]) -> Self { + Self { data } + } +} + +impl<'a> CommandToGsp for ContinuationRecord<'a> { + const FUNCTION: MsgFunction =3D MsgFunction::ContinuationRecord; + type Command =3D (); + type InitError =3D Infallible; + + fn init(&self) -> impl Init { + <()>::init_zeroed() + } + + fn variable_payload_len(&self) -> usize { + self.data.len() + } + + fn init_variable_payload( + &self, + dst: &mut SBufferIter>, + ) -> Result { + dst.write_all(self.data) + } +} + +/// Wrapper that splits a command across continuation records if needed. +pub(crate) struct SplitState { + state: Option<(KVVec, usize)>, + _phantom: PhantomData, +} + +impl SplitState { + /// Maximum command size that fits in a single queue element. + const MAX_CMD_SIZE: usize =3D GSP_MSG_QUEUE_ELEMENT_SIZE_MAX - size_of= ::(); + + /// Maximum size of the variable payload that can be sent in the main = command. + const MAX_FIRST_PAYLOAD_SIZE: usize =3D Self::MAX_CMD_SIZE - size_of::= (); + + /// Creates a new `SplitState` for the given command. + /// + /// If the command is too large, it will be split into a main command = and some number of + /// continuation records. + pub(crate) fn new(inner: &C) -> Result { + if command_size(inner) > Self::MAX_CMD_SIZE { + let mut staging =3D + KVVec::::from_elem(0u8, inner.variable_payload_len(), = GFP_KERNEL)?; + let mut sbuffer =3D SBufferIter::new_writer([staging.as_mut_sl= ice(), &mut []]); + inner.init_variable_payload(&mut sbuffer)?; + if !sbuffer.is_empty() { + return Err(EIO); + } + drop(sbuffer); + + Ok(Self { + state: Some((staging, Self::MAX_FIRST_PAYLOAD_SIZE)), + _phantom: PhantomData, + }) + } else { + Ok(Self { + state: None, + _phantom: PhantomData, + }) + } + } + + /// Returns the main command. + pub(crate) fn command(&self, inner: C) -> SplitCommand<'_, C> { + if let Some((staging, _)) =3D &self.state { + SplitCommand::Split(inner, staging) + } else { + SplitCommand::Single(inner) + } + } + + /// Returns the next continuation record, or `None` if there are no mo= re. + pub(crate) fn next_continuation_record(&mut self) -> Option> { + let (staging, offset) =3D self.state.as_mut()?; + + let remaining =3D staging.len() - *offset; + if remaining > 0 { + let chunk_size =3D remaining.min(Self::MAX_CMD_SIZE); + let record =3D ContinuationRecord::new(&staging[*offset..(*off= set + chunk_size)]); + *offset +=3D chunk_size; + Some(record) + } else { + None + } + } +} + +/// Wrapper enum that represents either a single command or a split comman= d with its staging buffer. +pub(crate) enum SplitCommand<'a, C: CommandToGsp> { + /// A command that fits in a single queue element. + Single(C), + /// A command split across continuation records, with its full payload= in a staging buffer. + Split(C, &'a [u8]), +} + +impl<'a, C: CommandToGsp> CommandToGsp for SplitCommand<'a, C> { + const FUNCTION: MsgFunction =3D C::FUNCTION; + type Command =3D C::Command; + type InitError =3D C::InitError; + + fn init(&self) -> impl Init { + match self { + SplitCommand::Single(cmd) =3D> cmd.init(), + SplitCommand::Split(cmd, _) =3D> cmd.init(), + } + } + + fn variable_payload_len(&self) -> usize { + match self { + SplitCommand::Single(cmd) =3D> cmd.variable_payload_len(), + SplitCommand::Split(_, _) =3D> SplitState::::MAX_FIRST_PAYL= OAD_SIZE, + } + } + + fn init_variable_payload( + &self, + dst: &mut SBufferIter>, + ) -> Result { + match self { + SplitCommand::Single(cmd) =3D> cmd.init_variable_payload(dst), + SplitCommand::Split(_, staging) =3D> { + dst.write_all(&staging[..self.variable_payload_len()]) + } + } + } +} diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index 6005362450cb..25fca1f6db2c 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -202,6 +202,7 @@ pub(crate) enum MsgFunction { AllocObject =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_OBJECT, AllocRoot =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT, BindCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA, + ContinuationRecord =3D bindings::NV_VGPU_MSG_FUNCTION_CONTINUATION_REC= ORD, Free =3D bindings::NV_VGPU_MSG_FUNCTION_FREE, GetGspStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_GSP_STATIC_INF= O, GetStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO, @@ -239,6 +240,9 @@ fn try_from(value: u32) -> Result { bindings::NV_VGPU_MSG_FUNCTION_ALLOC_OBJECT =3D> Ok(MsgFunctio= n::AllocObject), bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT =3D> Ok(MsgFunction:= :AllocRoot), bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA =3D> Ok(MsgFunctio= n::BindCtxDma), + bindings::NV_VGPU_MSG_FUNCTION_CONTINUATION_RECORD =3D> { + Ok(MsgFunction::ContinuationRecord) + } bindings::NV_VGPU_MSG_FUNCTION_FREE =3D> Ok(MsgFunction::Free), bindings::NV_VGPU_MSG_FUNCTION_GET_GSP_STATIC_INFO =3D> Ok(Msg= Function::GetGspStaticInfo), bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO =3D> Ok(MsgFunc= tion::GetStaticInfo), --=20 2.53.0 From nobody Tue Apr 7 15:27:24 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010000.outbound.protection.outlook.com [52.101.56.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA92C392815; Thu, 26 Feb 2026 11:47:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106442; cv=fail; b=m6Oa2xhcergECWesqxp5nT7vkdih8sJ5l5pEF8pThz/kLqIAdsJ1/vAXe2b/a6jAFM17Bgbd62+qi4Z2FbsBiQ0Txm0O1byATRZ+12apYBVifABhgqxCHAqyt9GQd2NxWEMRjgXSn4xjFJbBvQAIs41gHrQ9S9VxTA5e7XcOSds= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772106442; c=relaxed/simple; bh=mePEQH3x1au3Fq85rhWxbiJte0pwLvvPBLcJ0lWsPq0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=o6LRuZrs3I9TYfa5iG5pdA2wF0IwxtjGLguPIGPB20kwJyTrC2kabzW8Xg9Ib+33PF75jxV72tD9flV8p+8SR1W/4CrjB7hHG77uCG5MSKjkdan8CuxIz8xlkPDDCLcNQtqKcs+QBojLN/MfAI4R/MbsVj6NNy/ujB3swyuK7sE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=DqByXa8v; arc=fail smtp.client-ip=52.101.56.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="DqByXa8v" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CZdmqJwYw4jdza8IRJfn3tVh3Xbd4Uwt1EI1pvqyOXmcaxxBqjfVoA6kW1+5Z9JkNNNbH0Odso6X5XskAMAIfJj3d1zAr2Fe29RNHFIBUpOy0cUgDgXUXXCzLJgLwuWmAw8lKvmX05+o6TQDXFiCR/uNRpQb7efcpX/bu08a0L4RYE/eWWBUDN0E+ybExcsgGU+sCVd7Gs7RnBJ3rYx1XoSw5nFtCVwLvNnQjrqDT3MIlelFl4d9bOApwGIex4rA/VtOweyZYQc+q4vL38ap5c+jZ5yTEqAk+GugvSv9ib+doJrooeF36h+/Whz8S/Ob7oByZgZyh+/DAI3/1+SHdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JVQ+AUSa2O8lPjC8zY2F0HyAKJMBLoSAHxI1phpLfM0=; b=EGRVEZGp2BphL1vit7SaL55brwPvkKt8xdWz8r2U0OnSauZro0vFnzF0NVXsQ46X/uQwQSwTYVQykrD4cT2SweTKxQc54dc2WVV9/HdNdVPVQe+lmFiOaLrIbocv8zhN65HmlfO3ZTRk6oxl4Bu7BpzDq1nHViQCP6+10rMDBI0AYNyd+6+lz4SFlvLhk9PdR+SZh+1pYSBSrzIFsN1yhsy/laV2AGn8ArgqD+oGfq+JLvKhJkJFjLsbrSntXhCwmUPK4drCEd3bcv9sy2eGSrwQOIp2efW8XyHYd7VCRTMMpwNGOEWbQ2H6WYaHBRN+/Et8KPFoZY2p/JHeWt2YcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JVQ+AUSa2O8lPjC8zY2F0HyAKJMBLoSAHxI1phpLfM0=; b=DqByXa8vG/DVQGcYD6Odmd+IgVxIiTcTx1C5bNkp24uWp5NWNjkWcwaP2ff3jUg5wpOpwJLT4H21mc/0l5bhQicDIGF+8aLvHrL8e20RiL50GWDL9PkegWl+RRNWHMpALvUBLk2lsjhnuSI9LZzaDFeRwuOcrarUtI/kt1im2uIT/UGzBwShahKCQ6QF+cLD8Fk/VaNrwLj7vmp9FHlh/Tfc1om2cNvVS0JtEadgiUe9Rs5+sheFHhW6dlBEDaiMySgOY2ni2vF2Es/32j4irPTfhWWye52FGy7E6CCRhdV3kV+btJLqJi2a6tDLpnn8ooO/vvzJOct4Zro4dzlmjA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB7112.namprd12.prod.outlook.com (2603:10b6:510:22c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.20; Thu, 26 Feb 2026 11:47:17 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9654.007; Thu, 26 Feb 2026 11:47:16 +0000 From: Eliot Courtney Date: Thu, 26 Feb 2026 20:45:41 +0900 Subject: [PATCH v3 9/9] gpu: nova-core: gsp: add tests for SplitState Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260226-cmdq-continuation-v3-9-572ab9916766@nvidia.com> References: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> In-Reply-To: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Eliot Courtney , Zhi Wang X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0334.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:38e::12) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB7112:EE_ X-MS-Office365-Filtering-Correlation-Id: 76da6bf0-a7cb-4f28-d162-08de752cca54 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: Y2SCgDlpn8SuEskmdJHmUR0fj3bQWCT5zaOySRn6ujM5IbWydyaGkg6IThYzPnw2PsAS4MdKkC65b0jKMP369yh3gZ6gZuku8ZN+rFs46bX/sD4FoN0KBSUTO4J/TLQ5ucRndcEmME3YSX5Y8fu0SA2y5mRBPD93FWOq7R/V+P4Kbkgo2mlRCkTkaXK5pq7oD+XYSMA/YJINQV8Q1wBIDziKNIGEtm1oely9HqzJcujFL5AWEOe59abG++ANkpUPR4Hv3djEk3kCHEo0Ni78IRPkZn8YTRmzavYp8au3kw5rZLFTPryWfoIstvwQJ9GW1G0Ihrd2z8dO6uYsklgRcj6dcVUMo9UsddK6yeH2J964sELAHysfe1GKYHQgYfkEAuq18sielZa8zhmimQvDqB0DhQcHxK9g7q8k8KNuPtWKtzEbT+wHQsO/qWk03KjClauk7meVB61bXTUiqNtbHiPvg4iumZLbS0TQFdE0aKrY0rBtSqaHJWmL46+ZDUN3fr4OTfEQXT/gYMdnA8dLuev9qzbwCKRvvTerxq6fQS/mP7zl9KfpzOikJeGDnLyyFZQ+GoefuIHfe1N1RSDYC3qKeWi8GcQ3qbnhHT9DlewFttUKedf7es+AtPAAF5oPzF/pE3WJHs+G0gmoR62VjiUg8p90QqdciHZ0Koq/w4uM/gInm1b8hjhIve/1p1zef97x+P5xj4FpVooKaLz/zhjagU8n3fXSxmNY21cZHno0kanHZwcGORWwTmARsRTEzU9wsdOpGubLwsxt5DiJSQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFUwc2ErU0hKdHRoV2orbjl4c203Rlhvd3BraXFzYUZsMncrZFUxMk15eCtN?= =?utf-8?B?SnFOYmZidDUrQ3ZtSEFhZllJVWdlanAvTE1pSmdScVU1Ti9HMCtCdjRqREw4?= =?utf-8?B?T1BtWWphNkdPclNiWW5VZERVL0ZLazhoN0pCQWFWOW9UZWxqbUFoNGR4UDVT?= =?utf-8?B?VUZlNmhNNU9GOVdQWCtoT2xyOHJGeUVXcEJFRVpYV3JtN2FKME4vME04bW5U?= =?utf-8?B?VWYyL3k5eS9ON2tLWjd1Zjk3c1gvSENmM1BwNFFROUVJVSs2OCtyNFZ1SXMy?= =?utf-8?B?R25yM0pVTUtXT3NMOTl5TU9PMTFEWXBpZDlUK0NaVHB3Ujh4WmJGM2pMSmd3?= =?utf-8?B?cmE2R0Y3K0tlQzlZYjI2Y2ExYTR1VlJsLyszcEZBeGFJQmZUNEgxaEVZNldF?= =?utf-8?B?eXUrcXFiMDVnNllvQjVhV2xGVnJzcUZ5VllQSzcvN1U4ZXArSHhhWEdvSGxL?= =?utf-8?B?eTBFblIreGJ3dWtvU2xaMWVCZlhGVjJFekU2UGkvaWN2Q0pKS2dVazlOblps?= =?utf-8?B?M25pbU4vaFZrR2R0alZ0Mk5sa2NuSWVoZFJUNDJhSERjVDZJSTNoaFVNUDht?= =?utf-8?B?dWdGZUhaMURvK3RZLytKTW5aTEpFaERzT1FUek9tYlo5U0hvUktSMTRIRjdS?= =?utf-8?B?dENxMmNEeG4wazJwSmZET0NpcGFkcDcyZnRmcXVOU2RiR0JOVjhjTUZZU1RR?= =?utf-8?B?cFdSRnNQTmsrdFNSeUxOV2VHRE52NEw4V2pPUTBHK1BER3AzY1EraTZ4ZWha?= =?utf-8?B?MFloNUxiRGlielhtMVJualdiRHhPV0lXTXFBa0wrYUpRRUdvbzRKbVp1SnBS?= =?utf-8?B?WmRrdTNLZ29pOUoyT2xjbEhxTmZUS2pwY05RcC91NmFmdm13b3lZZzZHcmE1?= =?utf-8?B?U2ZCTVlZOW5tbUpIamNJNk5vcUtTWFdETFQ5UmovSy9nNlZkSXN2NFBpc3l1?= =?utf-8?B?TTRhVEY3RGtPaHhjVVY1a2s4SWdtKzJJRDdFWFdsQVV0S2tUWW5wSlZGYm40?= =?utf-8?B?STk1R0xmbUNXdXY1SUFtU1Yrc3hJRUs1VWk1NzcySWtOcFZiRnZiZ1l5R01Y?= =?utf-8?B?dlZrcmVGR2lYbU5RUHh1OEZjTVFKSW9tQW5rWlVnY1lseEpDMm5SK0ZYWlVk?= =?utf-8?B?NFBBbU4ra2FsWExKcEhGbmpFeE40SVRWcmlTSDR5UllWZFFYUFJ6dnJGTUhX?= =?utf-8?B?Rld1Y2ZGRHNuK1prMHBPTXMrcEZUSHJzS25Zc2gxMzZwcjZNQVJMR3dMSCtX?= =?utf-8?B?Zi9FVUZrcGZUV3dsUjhmZ1YybFR0SkpvSWtjQThsajVvemxOTDR0M2RCM2F4?= =?utf-8?B?bnczZ3RGZmdrMnd1YlIxcGhwYllVK1FXMXF5QlgveGtNelgrNGowRHBQbkxJ?= =?utf-8?B?eXNuNEd3QUVJTGp4ZkJyamFwSWRPVWExWlNtby9kMWJtVUkxd3RJbkkvY050?= =?utf-8?B?YzF2Y0NZaFR0bE40ay8yYzFhcnpSVGJTeXFlUnY3RmdWTHF4V1lmMW5DYnhS?= =?utf-8?B?M3NjSFhINHRQRlJYQ3FDV01SMzkyVm9jd29ZNXNBbkE0TmNhRUd3T0V0c0k5?= =?utf-8?B?ZGxWbUJ3eDJMQkcyelcxdXhpNlB4UGlLc1FBeC82UktDbDcyR2NyY1RoM291?= =?utf-8?B?cUo0ZHZCN1MrUFBHcHA3azIwRkl2Q1ovaGxlMC8yVjFXcWoxTUlrK0dIYWUy?= =?utf-8?B?WkFiUU0waEt4eWM1YlVydkg0TkZBRmgrc3J0T0hBVG82MkMyb0lhOThxZTZq?= =?utf-8?B?MjJFU2NmWjBkZ0dsdG4ycXBuUVFvcWlEWUhzOStRa3l3ZEhPYlZTcG8yYnRj?= =?utf-8?B?NUJ6bmc5SThqbTZTNzdhWUQ5RzZUbThZZmRSVEh1UHl6eUdpMEtTNUlOSnds?= =?utf-8?B?RnA5M1l0b0s2R0U2MUZMMDJHdGl5cndjK2dSdXdiWklmMlVhNnlCa0RvWDVJ?= =?utf-8?B?aDhnVWF3RWFPTXdIQ21sclJtVmVJVnVlbkRkdmlMSlk1MHd6VnVKWjVsaURE?= =?utf-8?B?cXhvb0dEMk1aMGprSlhEYTkzNE5uM1lLZ3dHUVYyNkM0eVVQZ3RsUVJVM2Vv?= =?utf-8?B?ODQvblVnd3FabWNydkhSVHU1M042U1RCYUZ2K0l4djlBbmhSaFJSb01VZjRE?= =?utf-8?B?RkFmOHdRN2lhWVZnNkpRM2FOR0dCSUN1OFFQRE16RUFJbldTOVEyT0Z3QXU2?= =?utf-8?B?aHNUeG0zVTZzSEVpQURBM0R0V2lUOFJrV2N4NXJxc0pxWjFlOWlKaUo4eGZq?= =?utf-8?B?NisySFU2TTRja0ZsK1AzbmVOSFZnZnMzUWhMQkdmM3NGYWRINWVIOVY5eXJr?= =?utf-8?B?dFdlZjRTSWUwQTU2a3JOL2ZsVHY5WGQ3dVV3R3NydlUycFFYZkNlR0I2TUhn?= =?utf-8?Q?Lc+m2TdxAQkKWRP4yktqDs18cFBe9fMGsxOFSNUrVMv3l?= X-MS-Exchange-AntiSpam-MessageData-1: kHAScp5Y5R+aYw== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76da6bf0-a7cb-4f28-d162-08de752cca54 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2026 11:47:16.9203 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6TNF7u57JvLzGATr7Qc5NZsFxXNVQulAuW1ehdLxhjfFCIP4hzUD40WyASEBSlhgd8M6UO6EBNsDxD4HnOK7Ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7112 Add tests for SplitState. They cover boundary conditions at the split points to make sure the right number of continuation records are made. They also check that the data concatenated is correct. Tested-by: Zhi Wang Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/commands.rs | 114 ++++++++++++++++++++++++++++++= ++++ 1 file changed, 114 insertions(+) diff --git a/drivers/gpu/nova-core/gsp/commands.rs b/drivers/gpu/nova-core/= gsp/commands.rs index 6ffd0b9cbf05..74f875755e53 100644 --- a/drivers/gpu/nova-core/gsp/commands.rs +++ b/drivers/gpu/nova-core/gsp/commands.rs @@ -384,3 +384,117 @@ fn init_variable_payload( } } } + +#[kunit_tests(nova_core_gsp_commands)] +mod tests { + use super::*; + + struct TestPayload { + data: KVVec, + } + + impl TestPayload { + fn generate_pattern(len: usize) -> Result> { + let mut data =3D KVVec::with_capacity(len, GFP_KERNEL)?; + for i in 0..len { + data.push(i as u8, GFP_KERNEL)?; + } + Ok(data) + } + + fn new(len: usize) -> Result { + Ok(Self { + data: Self::generate_pattern(len)?, + }) + } + } + + impl CommandToGsp for TestPayload { + const FUNCTION: MsgFunction =3D MsgFunction::Nop; + type Command =3D (); + type InitError =3D Infallible; + + fn init(&self) -> impl Init { + <()>::init_zeroed() + } + + fn variable_payload_len(&self) -> usize { + self.data.len() + } + + fn init_variable_payload( + &self, + dst: &mut SBufferIter>, + ) -> Result { + dst.write_all(self.data.as_slice()) + } + } + + const MAX_CMD_SIZE: usize =3D SplitState::::MAX_CMD_SIZE; + + fn read_payload(cmd: &impl CommandToGsp) -> Result> { + let len =3D cmd.variable_payload_len(); + let mut buf =3D KVVec::from_elem(0u8, len, GFP_KERNEL)?; + let mut sbuf =3D SBufferIter::new_writer([buf.as_mut_slice(), &mut= []]); + cmd.init_variable_payload(&mut sbuf)?; + drop(sbuf); + Ok(buf) + } + + struct SplitTest { + payload_size: usize, + num_continuations: usize, + } + + fn check_split(t: SplitTest) -> Result { + let payload =3D TestPayload::new(t.payload_size)?; + let mut state =3D SplitState::new(&payload)?; + + let mut buf =3D read_payload(&state.command(payload))?; + assert!(buf.len() <=3D MAX_CMD_SIZE); + + let mut num_continuations =3D 0; + while let Some(cont) =3D state.next_continuation_record() { + let payload =3D read_payload(&cont)?; + assert!(payload.len() <=3D MAX_CMD_SIZE); + buf.extend_from_slice(&payload, GFP_KERNEL)?; + num_continuations +=3D 1; + } + + assert_eq!(num_continuations, t.num_continuations); + assert_eq!( + buf.as_slice(), + TestPayload::generate_pattern(t.payload_size)?.as_slice() + ); + Ok(()) + } + + #[test] + fn split_command() -> Result { + check_split(SplitTest { + payload_size: 0, + num_continuations: 0, + })?; + check_split(SplitTest { + payload_size: MAX_CMD_SIZE, + num_continuations: 0, + })?; + check_split(SplitTest { + payload_size: MAX_CMD_SIZE + 1, + num_continuations: 1, + })?; + check_split(SplitTest { + payload_size: MAX_CMD_SIZE * 2, + num_continuations: 1, + })?; + check_split(SplitTest { + payload_size: MAX_CMD_SIZE * 2 + 1, + num_continuations: 2, + })?; + check_split(SplitTest { + payload_size: MAX_CMD_SIZE * 3 + MAX_CMD_SIZE / 2, + num_continuations: 3, + })?; + Ok(()) + } +} --=20 2.53.0