From nobody Tue Apr 7 18:48:29 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A94EC38A72A for ; Thu, 26 Feb 2026 18:17:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772129869; cv=none; b=TzwIsacxMUBKWdJ6L35ZpHraW5A0mx9Q+QZm/2jGxNqwfaU1QdE+JgUa+DrCi7yywDjqtKQ9bf48edLF33QpAIBs37cXvpNwqdfFDKmKsnfG65buKPZtmsFuHRFlDLYqxDAwA/+C6JlkF9NsQ8bzCV+iZZVa4Uo/al2DML4J0gE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772129869; c=relaxed/simple; bh=Xv/Yn0DsACY4tPbVThHFi4E542QG5tcnAnMJGGRhnJY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tCH/FpOwApI29sRzzaPwCIcMpNCdR7jG60R0BLtOAHczu/SCyqReCHKAw/ZcHBKn/CffgkElYhWDrHoQ6OR45s0HvlVsYS1kc/gpeGxH26DiIiAqyf8wrEgaJTl+CuPPYSdMaggl0MqD2UUCZar9eYpUNGHOgyGDbkXgwvSuAn0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=J6YftRwZ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=VlRlL93h; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="J6YftRwZ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="VlRlL93h" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772129866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jTyzt/WEM+gv/OJ+PPQ8O+8T255/lfffemaw2ikqAT8=; b=J6YftRwZ+UulCXQTs7P0G7vfxlqSHihomRlFPD3Yzhfw+BMjOsVmcbTYHV7tDeXzgwKy6S DPWDe2Avi5ThqUk6Bx0fr9StauSEb5DCyCvZ+5IMgR57rK12YcKt4CiI50T9gKodCiGwTR cv1wnSWuP9c4UGNzlWAiCAVXDAfU57I= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-119-8hv1VzLjNDCWB9c-BUqypA-1; Thu, 26 Feb 2026 13:17:45 -0500 X-MC-Unique: 8hv1VzLjNDCWB9c-BUqypA-1 X-Mimecast-MFC-AGG-ID: 8hv1VzLjNDCWB9c-BUqypA_1772129865 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-89502dfd7b4so110266216d6.1 for ; Thu, 26 Feb 2026 10:17:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772129865; x=1772734665; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jTyzt/WEM+gv/OJ+PPQ8O+8T255/lfffemaw2ikqAT8=; b=VlRlL93hrZj1dYZfjTBaWm+z1JLada8eWPFqv03OVsMgZcYgM+QZfr+uefkCU1o7YK /xiHbjiFx6aR1kzkftWYKNGEiYJ44NQAriTLfHiUGykGsOUfRo1mt0zdJFgFAh/O01wf fjbVRi1EQHPHvcuLHr5ry4Zk9UoUHnRsjOaX5L8Js2uJVXlZot3i59w/t2KzlZb+Gt8N orH+SiJhsw0ALMNIkRAki4xwIZ51wNmrC3X+Ywxya4cUcmgHicqdy0GxSB1u5p0MCYqq O9lwu5+kdQ8ctbWO/OoF38l3oY3L6etI6sqmuA2dfoUr3vFKGtCad7fN++WBxbnj8eLP NiOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772129865; x=1772734665; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jTyzt/WEM+gv/OJ+PPQ8O+8T255/lfffemaw2ikqAT8=; b=hEUk7dzZ5ZOPXD9Ri+Lty8GzvGGZgcVuJ8U/RdRKX555Smz8RtHu3HbnwOaVgbA7GE /4Xua03GbjJjGPwX/sdHiDS6EbLC/swNWHyizhr1OO8cpsDoHg/lSV5wUVZwexrlW78d EPjej8Y3bnf5xAdyaQ3qWHcrpEHK4h6nH3TfLuOt2z4a720JSNoSdTZsuJ1IPglpOLFS kj2U3l3Lr/PixIqr/rDI2bgCnG6uMgVJvxT9QKvKkZo+d6BhK1Qj8IYeaMRgYKpaQoWP 3oc55wI79WcW+ncC/zSCp6f+kyukInVsb3jUk7znpOd2NAf7LJCibM898HDPiyFbvVxb 843w== X-Forwarded-Encrypted: i=1; AJvYcCXQBPPP69E21a6iHYj0Z4U/VNZtoiAFAjMswXx1wstpS4qOZBV4xw8ueU5dUM/5bTfxNPjSKkWXNdQ7pmo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7l3zXIXtHGZE/xNzhNcVk1YqIxfefBbfdU3Ksql2mNCPOZ8iz TbfqAayAmqaEMaVIOo7z9+IjN2yZF7jOhNR+pApkn6RBVG0U6YaM1gwBK6O/TGIUCjy3ohKFaKc 8Fie9s5ZlxpfjOe+QkbJG3mz3Kam0xlkP9C/dBCAS+38D5LLFNxasf4jT7maJwbzCvg== X-Gm-Gg: ATEYQzw7oXCNKHc6kXodHsHbJyEyRysHCNaIYHMoSW3yN1TARs4hHR5fq3gzOPf16nc VK06POP0JcMmBvvGoCu5Y8PnyX2cMz4HO+gVudvvqeLw1VNmMYU1eEkp32KQKME1QWEz/0qMcL+ UAw9Qc5TYdau+rQYdEIa2XkFHp3yTLk13C8clEplkD9gn0DwppH+fH5N7csJ1Iwb9U/Cf7LeStx ukZUnKwfYiF2YxBuokRWhxdL/OI++P9Y6kMCYAbIJu8AKnALZ92lVeDiISU2VuxAOeYifQwPXyi RZxKuWbv/sIGAfJl8ZOmO0MyGeQmOH5V9MTioY8Zf4NLwjK4Jmt1MIU6q08f+bO0Vr5FmykMnP4 KxDcmhSfrtYT2wd/T/YxMlA38jKUZyCi5DzZFaL6EzMGA+7XQ6olgjAx5pFF9 X-Received: by 2002:a05:620a:3192:b0:8cb:3870:5c1f with SMTP id af79cd13be357-8cbc112b3f0mr376956185a.27.1772129864793; Thu, 26 Feb 2026 10:17:44 -0800 (PST) X-Received: by 2002:a05:620a:3192:b0:8cb:3870:5c1f with SMTP id af79cd13be357-8cbc112b3f0mr376953185a.27.1772129864349; Thu, 26 Feb 2026 10:17:44 -0800 (PST) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf717f2bsm247046685a.35.2026.02.26.10.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 10:17:42 -0800 (PST) From: Brian Masney Date: Thu, 26 Feb 2026 13:16:46 -0500 Subject: [PATCH 02/13] clk: test: add test suite for CLK_ROUNDING_FW_MANAGED flag Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260226-clk-det-rate-fw-managed-v1-2-4421dd2f6dc6@redhat.com> References: <20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com> In-Reply-To: <20260226-clk-det-rate-fw-managed-v1-0-4421dd2f6dc6@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3637; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=Xv/Yn0DsACY4tPbVThHFi4E542QG5tcnAnMJGGRhnJY=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIX9OmotiloOvscfXSnkXtJtmCyxnyLuwlHd1dscFCfM GthzvKYjlIWBjEuBlkxRZYluUYFEamrbO/d0WSBmcPKBDKEgYtTACby35nhr/zUY+r3Zpz6xBpT OZdnHa9P+bYTB4LOWWpWXPqieSVq0w6GPzw2L4wl4mxMq2xUz6okl9xT89teyjF73Ymebztkgq5 KcAIA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 Add two new clk tests related to the CLK_ROUNDING_FW_MANAGED flag: - Test that clk_hw_register() fails when determine_rate is not set. - Test that clk_hw_register() succeeds when determine_rate is not set, and CLK_ROUNDING_FW_MANAGED is set. clk_set_rate() works, and clk_round_rate() returns the requested rate. Signed-off-by: Brian Masney --- To: Michael Turquette To: Stephen Boyd Cc: linux-clk@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/clk/clk_test.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 85 insertions(+) diff --git a/drivers/clk/clk_test.c b/drivers/clk/clk_test.c index b1961daac5e22fb84f493f04feab1ff94a975d90..d7037eadc0a0ddf755915106877= 5a9d11429c02e 100644 --- a/drivers/clk/clk_test.c +++ b/drivers/clk/clk_test.c @@ -3541,9 +3541,94 @@ static struct kunit_suite clk_hw_get_dev_of_node_tes= t_suite =3D { .test_cases =3D clk_hw_get_dev_of_node_test_cases, }; =20 +static const struct clk_ops clk_no_determine_rate_ops =3D { + .recalc_rate =3D clk_dummy_recalc_rate, + .set_rate =3D clk_dummy_set_rate, +}; + +/* + * Test that clk_hw_register() fails when determine_rate is not set. + */ +static void clk_test_no_determine_rate_fails(struct kunit *test) +{ + struct clk_init_data init =3D { }; + struct clk_dummy_context *ctx; + int ret; + + ctx =3D kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); + + ctx->rate =3D DUMMY_CLOCK_INIT_RATE; + + init.name =3D "test_no_determine_rate"; + init.ops =3D &clk_no_determine_rate_ops; + ctx->hw.init =3D &init; + + ret =3D clk_hw_register(NULL, &ctx->hw); + KUNIT_EXPECT_EQ(test, ret, -EINVAL); +} + +/* + * Test that clk_hw_register() succeeds when determine_rate is not set, + * and CLK_ROUNDING_FW_MANAGED is set. clk_set_rate() works, and + * clk_round_rate() returns the requested rate. + */ +static void clk_test_fw_managed_round_rate(struct kunit *test) +{ + struct clk_init_data init =3D { }; + struct clk_dummy_context *ctx; + long rate, rounded_rate; + struct clk *clk; + int ret; + + ctx =3D kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx); + + ctx->rate =3D DUMMY_CLOCK_INIT_RATE; + + init.name =3D "test_fw_managed"; + init.ops =3D &clk_no_determine_rate_ops; + init.flags =3D CLK_ROUNDING_FW_MANAGED; + ctx->hw.init =3D &init; + + ret =3D clk_hw_register(NULL, &ctx->hw); + KUNIT_ASSERT_EQ(test, ret, 0); + + clk =3D clk_hw_get_clk(&ctx->hw, NULL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, clk); + + /* Test that clk_round_rate() returns the requested rate */ + rounded_rate =3D clk_round_rate(clk, DUMMY_CLOCK_RATE_1); + KUNIT_EXPECT_EQ(test, rounded_rate, DUMMY_CLOCK_RATE_1); + + /* Set a rate and verify it works */ + ret =3D clk_set_rate(clk, DUMMY_CLOCK_RATE_1); + KUNIT_ASSERT_EQ(test, ret, 0); + + rate =3D clk_get_rate(clk); + KUNIT_EXPECT_EQ(test, rate, DUMMY_CLOCK_RATE_1); + + clk_put(clk); + clk_hw_unregister(&ctx->hw); +} + +static struct kunit_case clk_fw_managed_test_cases[] =3D { + KUNIT_CASE(clk_test_no_determine_rate_fails), + KUNIT_CASE(clk_test_fw_managed_round_rate), + {} +}; + +/* + * Test suite for CLK_ROUNDING_FW_MANAGED flag. + */ +static struct kunit_suite clk_fw_managed_test_suite =3D { + .name =3D "clk_fw_managed_test", + .test_cases =3D clk_fw_managed_test_cases, +}; =20 kunit_test_suites( &clk_assigned_rates_suite, + &clk_fw_managed_test_suite, &clk_hw_get_dev_of_node_test_suite, &clk_leaf_mux_set_rate_parent_test_suite, &clk_test_suite, --=20 2.53.0