From nobody Tue Apr 7 14:03:40 2026 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB6102E2679 for ; Wed, 25 Feb 2026 22:25:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772058315; cv=none; b=uluQSmIDC0MjDOUP5JqSVtZ6PyfXcFaKvxdzQYK+9QER9nicx03BcPxfnCiJwa8SKCtv0BwC5rnaoFah/VEn8Z0aKL1fVJeGoTBDm4JxSECtO7g3h+4k36NV70XNJ85dVSK9uYBm021AoqOUgJb+Ek65QEr7ENky2XS64b8EzXs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772058315; c=relaxed/simple; bh=SDcDYk56vSzLpnVonbCSc5DsGoX55CWSFB0SpTZnEAU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EmJefE/8Q90VyRSWszd4ZLqLtpZ+jWSlQkUM6bq62wRDtd9DSVTgB/mL+ZvpwfDIg5mD4yCZ48rfk/OB+fKDYMlhTAQDwRvwARDZeUObTLt+qh9dZgG07J7PinF4p0CHaGRxH/5h1RVQfyRGVUoet5t+e1GWaI1V8Db/hN++6jE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jjhj+aem; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jjhj+aem" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-7987531082aso1971707b3.3 for ; Wed, 25 Feb 2026 14:25:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772058313; x=1772663113; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YvvULsvPu1X90l0TH4lOXBcqCmc3q2PIWwDNbIUTe30=; b=Jjhj+aem+9oG0ScvtxMw1OFlfTpB2QGT6H9ZbpyrrPWMYpZWjVDF2ay8uBYHchCB/9 RXDaLqgGn+VBUIwIbKdtSKW+yqYn2FfS1ele4PwSQDNwpnIigqLFNWvQb/cJwwRg53Y6 ZjpzaNj/KJxJoPZofT5OcL2Tnh+VdYhJTg3S7GeenoDaAHlT+/Z0bfIGgKLm1fHiHcNg NsiS//F7NuHMwKI+TVQ4JMBZLmlwHjYdwm+Ezx7aLbjTs3CE4jT+idsHcPFxXIjUNoEi pLvcT9EKLRgp6WriGugJ0mDh4RpMN5llVlY880sGQA8E6RzEb5MXoy6K9jPY5zK3V5jz xvYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772058313; x=1772663113; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YvvULsvPu1X90l0TH4lOXBcqCmc3q2PIWwDNbIUTe30=; b=FoqwttFQoJB+Ud5jrVcaM5xQWnQO7DnhKFXgEIYGYwygSjNMATuoMH1BXPmAYAyeWA Lth0N6nkeM0xoFXf25FXxKq4GbqIqfwdxtok6Wi8Mp0eEq1DVn84ogqdWOST2Exn06k6 ajs/ClxlidoUblbl2rzSrF87813AvHKJct/vtgWgxy+GVg8I0h7iSZNnrjENGkgdqSfi OXZgepIR3ezUQYcQsJHM8S1hdLUdYc9UDe5Sh1VWpycSQTX3ZD6OpEleqmRlx3MHJUYP aUygd70jTueND4EEyCwGvVIIMTDuf662RI7/Hegs9G0NeD1zOFBe+pGbxUQk8tzLlvo4 DB0g== X-Forwarded-Encrypted: i=1; AJvYcCXbk3f32GVm7LiUkYVYlBHbRqyTjPNaqKZ4tKGjKqlQSnN2bpD7XrhDb2vYRdf8QxmW1vEvgoZ8u94UFR4=@vger.kernel.org X-Gm-Message-State: AOJu0YxrsyImSaNpouy37jNOQ23hNLjoeJuCb5gYyONP8JFQmVNwxKk0 sXWJhTjfarF9jxEYYW4nsJDtFJwz80Ao2gTcvt32bs9YiKCOsxoCL2Hn X-Gm-Gg: ATEYQzzflU2XRW8SklM91inGPXVkJoBgN03Jto8PRFKRJtUT5wDgz1Vz1o8n5QrHEkR Bxti0fsNRNqVEDVfibHpBUkA4R1inKhEd/7K6ITWJ502XwGtJPGTwjmPQVkLh1AwKzhDiRl19ZR yEfmuAQQ0qNYvT4R6gjgtKqeUHXnJ8sV8SCBSarlJwXhv8xL/+xDrjz4s2U4CH7BgzZ9Kid3bXG KuWb9mlEhbmYo+u19IdiFdpbdEdfEMvlsUBvXvyeDGSGAFJJUxgoVxOiH1nbEbaSO4SwW0HGSMC t7x++UyjipR3XcxzOioFpmq9/dc6LaXjEVDdAmAmVMGnKPWag/qgZpBTP0/Je4WF2ioAAFEA1N3 jUjT3cLpvsI+JK07DDrYvqv5k/kfe1ZXxOQcpE/3wa8Ws1AUzHUzS5Ug/sTIDaWeSHymM2+I77n fkUkkLopTj4gh++ZvkO1el4XUUuXbbFA59oHtpNCEa1Y+cFdXjzk6fZMYOGV1FPVZMD/aqpHjHi mRo347YyRrMRUvheECvwSzG X-Received: by 2002:a05:690c:386:b0:798:6a6b:5ad7 with SMTP id 00721157ae682-79876c82b04mr1771977b3.29.1772058312756; Wed, 25 Feb 2026 14:25:12 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876c992b9sm771817b3.50.2026.02.25.14.25.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 14:25:12 -0800 (PST) From: Ethan Tidmore To: Namjae Jeon , Hyunchul Lee Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] ntfs: Fix null pointer dereference Date: Wed, 25 Feb 2026 16:24:53 -0600 Message-ID: <20260225222453.1962678-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable ctx can be null and once confirmed to be null in its error path goes to label err_out. Once there it can be immediately dereferenced by the function ntfs_attr_put_search_ctx() which has no null pointer check. Detected by Smatch: fs/ntfs/ea.c:687 ntfs_new_attr_flags() error:=20 we previously assumed 'ctx' could be null (see line 577) Add null pointer check before running ntfs_attr_put_search_ctx() in=20 error path. Fixes: fc053f05ca282 ("ntfs: add reparse and ea operations") Signed-off-by: Ethan Tidmore Reviewed-by: Hyunchul Lee --- fs/ntfs/ea.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ntfs/ea.c b/fs/ntfs/ea.c index 82ad9b61ec64..b2b0a9a043a9 100644 --- a/fs/ntfs/ea.c +++ b/fs/ntfs/ea.c @@ -684,7 +684,8 @@ static int ntfs_new_attr_flags(struct ntfs_inode *ni, _= _le32 fattr) a->flags =3D new_aflags; mark_mft_record_dirty(ctx->ntfs_ino); err_out: - ntfs_attr_put_search_ctx(ctx); + if (ctx) + ntfs_attr_put_search_ctx(ctx); unmap_mft_record(ni); return err; } --=20 2.53.0