From nobody Tue Apr 7 14:02:48 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E26C9314A95 for ; Wed, 25 Feb 2026 21:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772055000; cv=none; b=u3vn8JauAHkT/bGJQTiku+TrkT0gBZhTSEF4tmUY16bwm0VCcNtcwAWaWw9kD4rBREiRMZqqTYJwoAhnXfK1mbe35w3GC4Ne8bDwqHqmxAQL2zq7m2uHGFbgg0VW4LbMnMCn2lkne7Ub3eQpAjDpqU5P7hOD7D31tUH3JuOXDNk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772055000; c=relaxed/simple; bh=mCLPrGOtRUwtqUXdKMvvjI+qHjopx10aB2jzC/sdhn4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=g48EggspJVf4j3n7Mo07k4l16MPKcL4b8NnCiavctYJ18fK3UJEln8BCY6o9cfq3KWoWlvpQF/eDrAuz94j8KlCxPjQYVHWVjnABzehi9JY16HEjB1Om3l+xqne35GeHzUcOQ/uU/oTXvvUGo5mhHy3/W0vrg7DTzOmHD0giykM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lwbdRvSx; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lwbdRvSx" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-43991064db8so162887f8f.2 for ; Wed, 25 Feb 2026 13:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772054997; x=1772659797; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vL2gQfXBf12veR/aTVeOj+fmUJCvNz6gPc20+jAbMl0=; b=lwbdRvSxtkHIVJAOU7GrJw1SCsxkHDtF2ifzdN//wbLxbU/BR41GAJANf8dfTv9Xqm 4Fjzwc/+HSG+w2hoAaAdWETTauEXeVLqSg3+q5l0s5fOXDyYhY1Fnjc7wwMNkuYvzIbq PXMEXkl0U8S6oNkmEySIrbtYQoOGyJnidGCrAhM8vEwAGTmI3ZZv7x7yGVDkT80m+Dd+ sQatFRcayfahKmeD1OHb7gEEyAc5f7nKZlYNOQlEY5tVphcsL3SSsLRlw0gbI5husqnO 6dppZXZl3hcWgLWbcwGV33Uj4MubIawrj8fHQUsexh48GjHBeEeqblCd0IqLHrbWv3HJ DU8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772054997; x=1772659797; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vL2gQfXBf12veR/aTVeOj+fmUJCvNz6gPc20+jAbMl0=; b=Z96YZwHUEHsKp38hYFOgJp+99oNf6HoYzTmNSl75tbpk7bx9v2o9tljIDpdYsy2xzk 8N6iO9EDLoJtbuMCn2THRhhfQWzASU7IhHwQS1b6AXzodqNPtDa8gNiD9LIe2DvHhDR0 /Bu6z15yLFXtAqocF2X6Lr2dJU4S9uebYhiaDfTxovM2rl9knb4TQOekNxqi2ei/lJdC QkhbFJDuusjwbaOv5yJS/JoGuZTeTgtICrRea2mlP2Ky4aWr4ibSjOqDe5GgkNwKF1Ng YgWdTzdCZW1qwYRtwpxNtB0jeqq3ddRL9QeLQpTp8Ktn5OAtCQC2rnUL7d9j31DXQ9eE 8frA== X-Forwarded-Encrypted: i=1; AJvYcCW51XbFp16dysJScuSQ8zTFkJS0cIgrC5ktgifMvq+7OecPIZGxO5g7oxJ+fF0upUd6G691HwEUeXErEyQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyBmn3/gZUjoAmrbeuqYUu00Ncqge3DN3xCxvlusVZeVeCO4vbv 7EDeN4kYK4uStn/BcNVyAPrM9EdAmivYxaXK9yNDylWqWrk1RNKrlA16 X-Gm-Gg: ATEYQzwQScncpx2VFLLqeMXocVByk7WcLMVqbTvx4jMeRhHMw8WeFv1UlOU+L9mFTgc 1NA+J4UUSeICaSLvT7DQiS2QhtHE24RraK7DVCVhP6UKW4n1AiFZCv5EO3i8uduVH3JcvRKGnzb 9pcwgTErGGcGxmiU6cXAdxqT/fZKHu4AXMpmmZSc1c17A0Ss11xL9Ia0iWOQSkSRYQaG6OwKzEA 65T5Rc3Q/5zoQ9XA0Wy8ngkx/WZAZRRFWfGofQokVUK2wmwSBOqlHKg7/iFitJ8viitbF4TCkhr Ann1E1e0o2BIkihQlejXrQkcwffACcBSamj2APR4RiqzUMbZO35Kes8+etVzqJ6t16lS2noO+o4 M2rDLhbVCnlD+S2+0WPDvWIk56BPXNP9iyTjoy8T7adaBz1gzD4iI/3z6cj0iD1FXHiRI+IVnHQ == X-Received: by 2002:a5d:5d84:0:b0:437:7177:8f04 with SMTP id ffacd0b85a97d-4396f15b248mr34788029f8f.14.1772054997083; Wed, 25 Feb 2026 13:29:57 -0800 (PST) Received: from kimsufi.. ([2001:41d0:303:6f54::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43995056115sm2452561f8f.14.2026.02.25.13.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 13:29:56 -0800 (PST) From: Ruslan Valiyev To: Vaibhav Hiremath , Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ruslan Valiyev Subject: [PATCH] staging: greybus: arche: use sysfs_emit() instead of sprintf() Date: Wed, 25 Feb 2026 21:29:55 +0000 Message-ID: <20260225212955.57102-1-linuxoid@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace sprintf() with sysfs_emit() in state_show() sysfs attribute callbacks in arche-platform.c and arche-apb-ctrl.c. sysfs_emit() is preferred over sprintf() in sysfs show functions because it is aware of the PAGE_SIZE buffer limit, preventing potential buffer overflows. This addresses checkpatch warnings about the use of sprintf() in sysfs show callbacks. Signed-off-by: Ruslan Valiyev --- drivers/staging/greybus/arche-apb-ctrl.c | 10 +++++----- drivers/staging/greybus/arche-platform.c | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/gre= ybus/arche-apb-ctrl.c index 33f26a65f..19a6e59b6 100644 --- a/drivers/staging/greybus/arche-apb-ctrl.c +++ b/drivers/staging/greybus/arche-apb-ctrl.c @@ -300,16 +300,16 @@ static ssize_t state_show(struct device *dev, =20 switch (apb->state) { case ARCHE_PLATFORM_STATE_OFF: - return sprintf(buf, "off%s\n", + return sysfs_emit(buf, "off%s\n", apb->init_disabled ? ",disabled" : ""); case ARCHE_PLATFORM_STATE_ACTIVE: - return sprintf(buf, "active\n"); + return sysfs_emit(buf, "active\n"); case ARCHE_PLATFORM_STATE_STANDBY: - return sprintf(buf, "standby\n"); + return sysfs_emit(buf, "standby\n"); case ARCHE_PLATFORM_STATE_FW_FLASHING: - return sprintf(buf, "fw_flashing\n"); + return sysfs_emit(buf, "fw_flashing\n"); default: - return sprintf(buf, "unknown state\n"); + return sysfs_emit(buf, "unknown state\n"); } } =20 diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/gre= ybus/arche-platform.c index f669a7e2e..de5de59ea 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -374,15 +374,15 @@ static ssize_t state_show(struct device *dev, =20 switch (arche_pdata->state) { case ARCHE_PLATFORM_STATE_OFF: - return sprintf(buf, "off\n"); + return sysfs_emit(buf, "off\n"); case ARCHE_PLATFORM_STATE_ACTIVE: - return sprintf(buf, "active\n"); + return sysfs_emit(buf, "active\n"); case ARCHE_PLATFORM_STATE_STANDBY: - return sprintf(buf, "standby\n"); + return sysfs_emit(buf, "standby\n"); case ARCHE_PLATFORM_STATE_FW_FLASHING: - return sprintf(buf, "fw_flashing\n"); + return sysfs_emit(buf, "fw_flashing\n"); default: - return sprintf(buf, "unknown state\n"); + return sysfs_emit(buf, "unknown state\n"); } } =20 --=20 2.43.0