From nobody Tue Apr 7 14:03:40 2026 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F2C536F40A for ; Wed, 25 Feb 2026 23:05:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772060752; cv=none; b=A9I8CGlhfVgJM3a/eu832GDREj7LQawlvpB/xev6KGqBKd8M/ssRxc8E3eUmG/0zllQvSBqoV6V8iESSatG3N+HTwlYZA1ZR2F4I1FSkD9GRP6tNbtCQhEhqjZL4Q+m9MK6SBo0qEx9alKJfg2SvKHm5goy2tJWP8AxYzSTUPj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772060752; c=relaxed/simple; bh=HTmy5488v9hXkqPVTkzElOlRjdj2HmgiEo6MMvs9nlY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=OqQe0baH5PVhGrYnjhXeN4r/PPRdfZkYJHOxbMZImYShHkhBKlJw6HVwqKKuB617D7bOSn1k+Zr2x+LcmjDuDFvt4kpMb5ohtEDL8MHu8uePd7bxIccJS/R0Zg7N+NZQ+JXJFjUVA75NpZIJblzeXyb3mxhdcbA73S7YWaEywW8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bToZpqB6; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bToZpqB6" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-506a747448dso2090851cf.0 for ; Wed, 25 Feb 2026 15:05:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772060750; x=1772665550; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+DIYJmA1zfgahLdi3SX9E/gtSF322FOGG+oNFk3Qenw=; b=bToZpqB6BE4qsLPwDqqPfK3+LmUUX8BLkspKgEaFUqrvx/lRQBbQuc9JXS2YrfMQiM tYcvpQKr7Ei74XvBhcodFJhXcbGzR4PZFdKAgsfq5kSqaVAU0pYWghs7ZGRaKVRK5FXZ BSFKZWzidWYHfWlXUFCikqXYvNvbYJBZ+WzWTAfuo7Tdo8Pat26J0h6k7nkof2ZPveSI Go1GgmifbdQ6Z8BKNCIk4ZDzloT4mYCGsrGgRDfQp2XnlhAArizUeLFsmj2Per9dls3m bkW/boOhZ3Vv+0bgAyfqyfK9hejc7Vn466DXXtmqJt7O9kqyzF8iEtjEPCEHWbCcWDrY vsCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772060750; x=1772665550; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+DIYJmA1zfgahLdi3SX9E/gtSF322FOGG+oNFk3Qenw=; b=PpJd/hO8cwU6iWu/TCLKb4DvBDO5Fe4AVfv8H5lblVAdIKcboWiykER3ePj3CbkTTr jKYZzclkIburBoAC5QHzhJv24pfuFw3x0RVBtVZqI7w4ZRWipWwueUqvenzblk16/y4P aFRbHXopYCqL521sgZBvPCHsj/xyeEECCXr290b5e9Nxx4jjrjgp/j6qH7pc2d+3X5ic 7NA8bJBx3QE+kD6oCuakaM5XQlKYqIKLSw1qO3bjSBxY7tU/d8BZVOaHTCv4v1ZN7OtG C3/PYwU+ACCpaAU+dWu5Yki0+2lDMjuDu7ig7mA0SA5nY+xuiVffxuyQbOhgDcYndCpj F/Pw== X-Gm-Message-State: AOJu0YyuZEWQaS6FK924x1jnltPL0m9MdJLcvIudyW6FoH6INuBLZaYg 68HXoZ00RoVlGsMOdkpbXqXl2e+WQ25Nr4WKu3xXCB5simYXttO1H6WwIONXRg== X-Gm-Gg: ATEYQzyUcWtNZRxXDIjqKkKeeoS+TTpE420j9akuh64f0ZO7zfzyn+erc8VRAKGwWQM wU+yp4xLhE1w9Kk7a6CrtoD6xs/0/34KCwwkIEeuktYgcQLGtJ7UMiQvwTIA24w2kFatTYKOOcD C5bTzMnrijoE+qcLFXkA5DItQ1gj4X0u4/lx7OjnOOcBXbpnhBlvyxNQYByowcDDMGP/X7JGgzO lmBJFaraI/iRn6NcxIWmAJqpmD7CJIlFfxiR3jgHwgOEW6xlpEsHSve6Q5bc+lNEtfcTrjy7OWy r0O6QrHb0ztlo2lhfT8wMXNVyXGHYNPCKZGAqzIZGmqjQsgB+XZfQSAyvk7GqORCdmeN3WdvSs4 8r96sbbXAMrYhjd0+8fONuJfw7v4qm13T50z9CqFxJ7/KK1L+oNKpqbhdOSSTpU28I0w+IrFnB7 HgzhOidJnxwgN7a7Zb1VNKO0ZkNh/aosuQDwSD X-Received: by 2002:a17:902:d2d2:b0:2a0:c1ca:20f7 with SMTP id d9443c01a7336-2ade99bd62bmr19648135ad.15.1772054816193; Wed, 25 Feb 2026 13:26:56 -0800 (PST) Received: from Barrys-MBP.hub ([47.72.129.29]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb6c87a9sm1455865ad.71.2026.02.25.13.26.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 25 Feb 2026 13:26:55 -0800 (PST) From: Barry Song <21cnbao@gmail.com> To: akpm@linux-foundation.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Barry Song , wangzicheng , Suren Baghdasaryan , Lei Liu , Matthew Wilcox , Axel Rasmussen , Yuanchu Xie , Wei Xu , Kairui Song , Tangquan Zheng Subject: [PATCH RFC] mm/mglru: lazily activate folios while folios are really mapped Date: Thu, 26 Feb 2026 05:26:42 +0800 Message-Id: <20260225212642.15219-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Barry Song MGLRU activates folios when a new folio is added and lru_gen_in_fault() returns true. The problem is that when a page fault occurs at address N, readahead may bring in many folios around N, and those folios are also activated even though many of them may never be accessed. A previous attempt by Lei Liu proposed introducing a separate LRU for readahead[1], but that approach is likely over-designed. This patch instead activates folios lazily, only when they are actually mapped, so that unused folios do not occupy higher- priority positions in the LRU and become harder to reclaim. A similar optimization could also be applied to swapin readahead, but this RFC limits the change to file-backed folios for now. Based on Tangquan's observations, this can significantly reduce file refaults on Android devices when using MGLRU. BTW, it seems somewhat odd that all LRU APIs are defined in swap.c and swap.h. [1] https://lore.kernel.org/linux-mm/20250916072226.220426-1-liulei.rjpt@vi= vo.com/ Cc: wangzicheng Cc: Suren Baghdasaryan Cc: Lei Liu Cc: Matthew Wilcox (Oracle) Cc: Axel Rasmussen Cc: Yuanchu Xie Cc: Wei Xu Cc: Kairui Song Cc: Tangquan Zheng Signed-off-by: Barry Song --- include/linux/swap.h | 1 + mm/filemap.c | 2 ++ mm/swap.c | 17 ++++++++++++++++- 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/include/linux/swap.h b/include/linux/swap.h index 62fc7499b408..ce88ec560527 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h @@ -335,6 +335,7 @@ void folio_add_lru(struct folio *); void folio_add_lru_vma(struct folio *, struct vm_area_struct *); void mark_page_accessed(struct page *); void folio_mark_accessed(struct folio *); +void folio_activate_on_mapped(struct folio *folio); =20 static inline bool folio_may_be_lru_cached(struct folio *folio) { diff --git a/mm/filemap.c b/mm/filemap.c index 6cd7974d4ada..0b8f383facdb 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -3567,6 +3567,7 @@ vm_fault_t filemap_fault(struct vm_fault *vmf) } } =20 + folio_activate_on_mapped(folio); if (!lock_folio_maybe_drop_mmap(vmf, folio, &fpin)) goto out_retry; =20 @@ -3926,6 +3927,7 @@ vm_fault_t filemap_map_pages(struct vm_fault *vmf, nr_pages, &rss, &mmap_miss, file_end); =20 folio_unlock(folio); + folio_activate_on_mapped(folio); } while ((folio =3D next_uptodate_folio(&xas, mapping, end_pgoff)) !=3D N= ULL); add_mm_counter(vma->vm_mm, folio_type, rss); pte_unmap_unlock(vmf->pte, vmf->ptl); diff --git a/mm/swap.c b/mm/swap.c index bb19ccbece46..1a991586c5af 100644 --- a/mm/swap.c +++ b/mm/swap.c @@ -488,6 +488,20 @@ void folio_mark_accessed(struct folio *folio) } EXPORT_SYMBOL(folio_mark_accessed); =20 +void folio_activate_on_mapped(struct folio *folio) +{ + if (lru_gen_enabled() && lru_gen_in_fault() && + !(current->flags & PF_MEMALLOC) && + !folio_test_active(folio) && + !folio_test_unevictable(folio)) { + if (folio_test_lru(folio)) + folio_activate(folio); + else /* still in lru cache */ + __lru_cache_activate_folio(folio); + } +} +EXPORT_SYMBOL(folio_activate_on_mapped); + /** * folio_add_lru - Add a folio to an LRU list. * @folio: The folio to be added to the LRU. @@ -506,7 +520,8 @@ void folio_add_lru(struct folio *folio) /* see the comment in lru_gen_folio_seq() */ if (lru_gen_enabled() && !folio_test_unevictable(folio) && lru_gen_in_fault() && !(current->flags & PF_MEMALLOC)) - folio_set_active(folio); + if (!folio_is_file_lru(folio)) + folio_set_active(folio); =20 folio_batch_add_and_move(folio, lru_add); } --=20 2.39.3 (Apple Git-146)